Subject: bug#19921: closed (Re: bug#19921: Support URL open for upcomming Mozilla Firefox 36)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 24 Feb 2015 23:06:02 +0000

Your bug report

#19921: Support URL open for upcomming Mozilla Firefox 36

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
19921: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19921
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#19921: Support URL open for upcomming Mozilla Firefox 36
From: Glenn Morris <[email-masked]>
To: [email-masked]
Date: Tue, 24 Feb 2015 18:05:25 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 24.5

I see that Firefox 36 is now released, so fixed in emacs-24.

(Someone really needs to take a sledgehammer to the plethora of options
and functions in browse-url.)

Subject: Support URL open for upcomming Mozilla Firefox 36
From: Ryo ONODERA <[email-masked]>
To: [email-masked]
Date: Sun, 22 Feb 2015 17:01:13 +0900 (JST)
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Firefox 36 or later has no "-remote" command line option anymore.
browse-url-firefox of Emacs uses this "-remote" option
to open URL as new window or new tab.
We should use "--new-tab URLString" or "--new-window URLString" instead.

See
https://developer.mozilla.org/en-US/docs/Mozilla/Command_Line_Options#-remote_remote_command
> This feature has been removed in Firefox 36.

Following patch uses --new-tab or --new-window command line option.
This works with Mozilla Firefox 36.0 build 10.

diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el
index 42fb954..6ad14a2 100644
--- a/lisp/net/browse-url.el
+++ b/lisp/net/browse-url.el
@@ -1137,15 +1137,12 @@ URL in a new window."
 		 (append
 		  browse-url-firefox-arguments
 		  (if use-remote
-		      (list "-remote"
-			    (concat
-			     "openURL("
-			     url
-			     (if (browse-url-maybe-new-window new-window)
-				 (if browse-url-firefox-new-window-is-tab
-				     ",new-tab"
-				   ",new-window"))
-			     ")"))
+		      (list
+		       (if (browse-url-maybe-new-window new-window)
+			   (if browse-url-firefox-new-window-is-tab
+			       "--new-tab"
+			     "--new-window"))
+		       url)
 		    (list url))))))
     ;; If we use -remote, the process exits with status code 2 if
     ;; Firefox is not already running.  The sentinel runs firefox

--
Ryo ONODERA // [email-masked]
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3