GNU bug report logs - #19915
25.0.50; defadvice for `org-store-link' makes code fail because of `org-called-interactively-p'

Previous Next

Full log

Message #13 received at 19915-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 19915-done <at> debbugs.gnu.org
Subject: Re: bug#19915: 25.0.50;
 defadvice for `org-store-link' makes code fail because of
 `org-called-interactively-p'
Date: Wed, 03 Jan 2018 18:09:55 +0100

Hello,

Drew Adams <drew.adams <at> oracle.com> writes:

> And yes, `advice-add' does not have the same problem.
>
> But it is a shame to limit users to recent Emacs versions
> just because Org uses `called-interactively' instead of
> adding an argument that indicates whether the command is
> called interactively (as Emacs recommends).

I removed call to `called-interactively-p' in `org-store-link' (in
development version).

Thank you.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.