GNU bug report logs - #19909
[PATCH] Error out if with-file-notification=w32 is specified on cygwin

Previous Next

Package: emacs;

Reported by: bug-gnu-emacs <at> gnu.org

Date: Fri, 20 Feb 2015 09:49:02 UTC

Severity: minor

Tags: patch

Done: Ken Brown <kbrown <at> cornell.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ken Brown <kbrown <at> cornell.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#19909: closed ([PATCH] Error out if with-file-notification=w32
 is specified on cygwin)
Date: Mon, 02 Mar 2015 14:06:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 02 Mar 2015 09:05:40 -0500
with message-id <54F46E34.1090502 <at> cornell.edu>
and subject line Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin
has caused the debbugs.gnu.org bug report #19909,
regarding [PATCH] Error out if with-file-notification=w32 is specified on cygwin
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
19909: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19909
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Robert Pluim <rpluim <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Error out if with-file-notification=w32 is specified on cygwin
Date: Fri, 20 Feb 2015 10:47:36 +0100
It's a combination that won't compile, so it's probably best to error
out during configure.

diff --git a/ChangeLog b/ChangeLog
index 4365668..dec9ce0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2015-02-20  rpluim  <rpluim <at> gmail.com>
+
+	* configure.ac: Error out if with-file-notification=w32 is
+	specified on cygwin.
+
 2015-02-13  Jan Djärv  <jan.h.d <at> swipnet.se>
 
 	* configure.ac: Set locallisppath to empty for NS self contained,
diff --git a/configure.ac b/configure.ac
index 0bcc55c..048168a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2659,6 +2659,10 @@ fi
 
 dnl MS Windows native file monitor is available for mingw32 only.
 case $with_file_notification,$opsys in
+  w32,cygwin)
+    AC_MSG_ERROR([`--with-file-notification=w32' was specified, but
+    this is only supported on MS-Windows native and MinGW32 builds])
+    ;;
   w32,* | yes,mingw32)
     AC_CHECK_HEADER(windows.h)
     if test "$ac_cv_header_windows_h" = yes ; then



[Message part 3 (message/rfc822, inline)]
From: Ken Brown <kbrown <at> cornell.edu>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 19909-done <at> debbugs.gnu.org
Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is
 specified on cygwin
Date: Mon, 02 Mar 2015 09:05:40 -0500
On 3/2/2015 4:35 AM, Robert Pluim wrote:
> I'd prefer "Robert Pluim" but it's not a big deal.

OK, I've pushed the change to the master branch and am closing the bug.

> It does show that
> there's a variable somewhere that I haven't set correctly though, since
> that ChangeLog entry should never have said "rpluim"

I think user-full-name is what you're looking for.

Ken



This bug report was last modified 10 years and 79 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.