From unknown Tue Jun 17 20:20:07 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19909 <19909@debbugs.gnu.org> To: bug#19909 <19909@debbugs.gnu.org> Subject: Status: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Reply-To: bug#19909 <19909@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:20:07 +0000 retitle 19909 [PATCH] Error out if with-file-notification=3Dw32 is specifie= d on cygwin reassign 19909 emacs submitter 19909 bug-gnu-emacs@gnu.org severity 19909 minor tag 19909 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 04:48:09 2015 Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 09:48:09 +0000 Received: from localhost ([127.0.0.1]:49113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOkBt-0003YL-2N for submit@debbugs.gnu.org; Fri, 20 Feb 2015 04:48:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51710) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOkBq-0003YC-KE for submit@debbugs.gnu.org; Fri, 20 Feb 2015 04:48:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOkBm-0001Vn-0m for submit@debbugs.gnu.org; Fri, 20 Feb 2015 04:48:06 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOkBl-0001Vj-UR for submit@debbugs.gnu.org; Fri, 20 Feb 2015 04:48:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOkBk-0003ym-U6 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 04:48:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOkBg-0001V3-CJ for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 04:48:00 -0500 Received: from plane.gmane.org ([80.91.229.3]:50940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOkBg-0001Uq-4z for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 04:47:56 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YOkBc-0007sE-ES for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:47:52 +0100 Received: from vav06-1-78-207-202-9.fbx.proxad.net ([78.207.202.9]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 10:47:52 +0100 Received: from rpluim by vav06-1-78-207-202-9.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 10:47:52 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org To: bug-gnu-emacs@gnu.org From: Robert Pluim Subject: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Fri, 20 Feb 2015 10:47:36 +0100 Organization: not if I can help it Lines: 31 Message-ID: <821tlkhq2v.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: vav06-1-78-207-202-9.fbx.proxad.net Mail-Copies-To: never X-Debbugs-No-Ack: yes User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (cygwin) Cancel-Lock: sha1:r+9jtvF41d9KNzqonapeNKfZxpQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bug-gnu-emacs@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) It's a combination that won't compile, so it's probably best to error out during configure. diff --git a/ChangeLog b/ChangeLog index 4365668..dec9ce0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2015-02-20 rpluim + + * configure.ac: Error out if with-file-notification=w32 is + specified on cygwin. + 2015-02-13 Jan Djärv * configure.ac: Set locallisppath to empty for NS self contained, diff --git a/configure.ac b/configure.ac index 0bcc55c..048168a 100644 --- a/configure.ac +++ b/configure.ac @@ -2659,6 +2659,10 @@ fi dnl MS Windows native file monitor is available for mingw32 only. case $with_file_notification,$opsys in + w32,cygwin) + AC_MSG_ERROR([`--with-file-notification=w32' was specified, but + this is only supported on MS-Windows native and MinGW32 builds]) + ;; w32,* | yes,mingw32) AC_CHECK_HEADER(windows.h) if test "$ac_cv_header_windows_h" = yes ; then From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 05:11:51 2015 Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 10:11:51 +0000 Received: from localhost ([127.0.0.1]:49149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOkYp-00047l-6I for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:11:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55467) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOkYn-00047e-KX for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:11:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOkYm-0000d3-L4 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:11:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOkYm-0000cz-IC for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:11:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOkYl-0001Rn-Ll for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:11:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOkYi-0000cB-F8 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:11:47 -0500 Received: from mtaout27.012.net.il ([80.179.55.183]:46165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOkYi-0000c0-7K for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:11:44 -0500 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NK200F00E3Y2Z00@mtaout27.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:01:10 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NK2005GAEHYDL90@mtaout27.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:01:10 +0200 (IST) Date: Fri, 20 Feb 2015 12:06:58 +0200 From: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin In-reply-to: <821tlkhq2v.fsf@gmail.com> X-012-Sender: halo1@inter.net.il To: bug-gnu-emacs@gnu.org Message-id: <83mw48lwvx.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Robert Pluim > Date: Fri, 20 Feb 2015 10:47:36 +0100 > > It's a combination that won't compile, so it's probably best to error > out during configure. Why doesn't it compile? Perhaps it's better to allow it to compile, than to error out. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 05:19:49 2015 Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 10:19:50 +0000 Received: from localhost ([127.0.0.1]:49153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOkgX-0004LM-BF for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:19:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56685) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOkgU-0004LD-Is for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:19:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOkgT-0002oP-9F for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:19:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOkgT-0002oL-5v for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:19:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOkgS-0003Bg-A7 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:19:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOkgK-0002mN-0D for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:19:44 -0500 Received: from plane.gmane.org ([80.91.229.3]:53093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOkgJ-0002mB-PK for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:19:35 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YOkgH-0005iv-Fl for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:19:33 +0100 Received: from vav06-1-78-207-202-9.fbx.proxad.net ([78.207.202.9]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 11:19:33 +0100 Received: from rpluim by vav06-1-78-207-202-9.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 11:19:33 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org To: bug-gnu-emacs@gnu.org From: Robert Pluim Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Fri, 20 Feb 2015 11:19:16 +0100 Organization: not if I can help it Lines: 28 Message-ID: <82wq3cga1n.fsf@gmail.com> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: vav06-1-78-207-202-9.fbx.proxad.net Mail-Copies-To: never X-Debbugs-No-Ack: yes User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (cygwin) Cancel-Lock: sha1:yWBtolEqqcnp4HqLYKyCAm9hzy0= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bug-gnu-emacs@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Eli Zaretskii writes: >> From: Robert Pluim >> Date: Fri, 20 Feb 2015 10:47:36 +0100 >> >> It's a combination that won't compile, so it's probably best to error >> out during configure. > > Why doesn't it compile? Perhaps it's better to allow it to compile, > than to error out. I guess whoever put the following in w32.h had his reasons: #ifdef CYGWIN #error "w32.h is not compatible with Cygwin" #endif In file included from w32notify.c:95:0: w32.h:23:2: error: #error "w32.h is not compatible with Cygwin" #error "w32.h is not compatible with Cygwin" ^ In file included from ../lib/sys/types.h:28:0, from ../lib/signal.h:49, from /usr/include/machine/setjmp.h:357, from /usr/include/setjmp.h:10, from lisp.h:24, from w32notify.c:92: From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 05:46:31 2015 Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 10:46:31 +0000 Received: from localhost ([127.0.0.1]:49174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOl6M-0004zB-T4 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:46:31 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33103) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOl6K-0004z3-Of for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:46:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOl6J-00043a-0O for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:46:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOl6I-00043O-Tc for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:46:26 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOl6H-0007Og-U6 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:46:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOl6E-0003z4-Mv for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:46:25 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:58925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOl6E-0003yg-Es for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:46:22 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NK200800GJSYG00@a-mtaout20.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:46:20 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NK2008A8GL8TA60@a-mtaout20.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:46:20 +0200 (IST) Date: Fri, 20 Feb 2015 12:46:36 +0200 From: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin In-reply-to: <82wq3cga1n.fsf@gmail.com> X-012-Sender: halo1@inter.net.il To: bug-gnu-emacs@gnu.org Message-id: <83ioewlv1v.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Robert Pluim > Date: Fri, 20 Feb 2015 11:19:16 +0100 > > Eli Zaretskii writes: > > >> From: Robert Pluim > >> Date: Fri, 20 Feb 2015 10:47:36 +0100 > >> > >> It's a combination that won't compile, so it's probably best to error > >> out during configure. > > > > Why doesn't it compile? Perhaps it's better to allow it to compile, > > than to error out. > > I guess whoever put the following in w32.h had his reasons: > > #ifdef CYGWIN > #error "w32.h is not compatible with Cygwin" > #endif According to the comment in w32notify.c, w32.h is included only for w32_strerror. Could you try commenting out the w32.h inclusion, and instead copy the w32_strerror prototype into w32notify.c? Does Emacs compile then as part of the Cygwin-w32 build, and do file notifications work? (I don't have Cygwin installed to try that, sorry.) If getting the prototype of w32_strerror is the only problem, then it's easy to solve in a way that will be compatible with the Cygwin-w32 build. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 09:17:28 2015 Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 14:17:28 +0000 Received: from localhost ([127.0.0.1]:49270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOoOV-0002pf-MC for submit@debbugs.gnu.org; Fri, 20 Feb 2015 09:17:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47997) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOoOS-0002pX-V9 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 09:17:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOoOO-0005GF-MJ for submit@debbugs.gnu.org; Fri, 20 Feb 2015 09:17:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOoOO-0005GB-KK for submit@debbugs.gnu.org; Fri, 20 Feb 2015 09:17:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOoON-0008Jy-K4 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 09:17:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOoOJ-0005Bo-C6 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 09:17:19 -0500 Received: from plane.gmane.org ([80.91.229.3]:42117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOoOJ-00059U-4o for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 09:17:15 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YOoOH-0007qC-Qc for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 15:17:13 +0100 Received: from vav06-1-78-207-202-9.fbx.proxad.net ([78.207.202.9]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 15:17:13 +0100 Received: from rpluim by vav06-1-78-207-202-9.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 15:17:13 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org To: bug-gnu-emacs@gnu.org From: Robert Pluim Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Fri, 20 Feb 2015 15:16:49 +0100 Organization: not if I can help it Lines: 39 Message-ID: <82sie0fz1q.fsf@gmail.com> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: vav06-1-78-207-202-9.fbx.proxad.net Mail-Copies-To: never X-Debbugs-No-Ack: yes User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (cygwin) Cancel-Lock: sha1:x07DeFH3K72AHL7WA9Ik0j4j2MA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bug-gnu-emacs@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Eli Zaretskii writes: >> From: Robert Pluim >> Date: Fri, 20 Feb 2015 11:19:16 +0100 >> >> Eli Zaretskii writes: >> >> >> From: Robert Pluim >> >> Date: Fri, 20 Feb 2015 10:47:36 +0100 >> >> >> >> It's a combination that won't compile, so it's probably best to error >> >> out during configure. >> > >> > Why doesn't it compile? Perhaps it's better to allow it to compile, >> > than to error out. >> >> I guess whoever put the following in w32.h had his reasons: >> >> #ifdef CYGWIN >> #error "w32.h is not compatible with Cygwin" >> #endif > > According to the comment in w32notify.c, w32.h is included only for > w32_strerror. Could you try commenting out the w32.h inclusion, and > instead copy the w32_strerror prototype into w32notify.c? Does Emacs > compile then as part of the Cygwin-w32 build, and do file > notifications work? (I don't have Cygwin installed to try that, > sorry.) > No, that doesn't compile. w32notify.c needs (at least) w32_unicode_filenames, filename_to_utf16(), filename_to_ansi() and w32_valid_pointer_p() from w32.c. I don't think adding w32.c into the build on cygwin is going to work. Regards Robert From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 10:10:43 2015 Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 15:10:43 +0000 Received: from localhost ([127.0.0.1]:49619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOpE1-00048G-F0 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:10:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58118) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOpDy-000486-KL for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:10:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOpDx-000649-BB for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:10:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpDx-000645-6n for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:10:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpDw-0007Pw-Dl for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:10:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOpDq-00063h-QW for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:10:36 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:49659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpDq-00063b-DL for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:10:30 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NK200A00SMDKN00@a-mtaout23.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 17:10:29 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NK200AGXSTG7ED0@a-mtaout23.012.net.il>; Fri, 20 Feb 2015 17:10:29 +0200 (IST) Date: Fri, 20 Feb 2015 17:10:45 +0200 From: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin In-reply-to: <82sie0fz1q.fsf@gmail.com> X-012-Sender: halo1@inter.net.il To: Ken Brown Message-id: <838ufslitm.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Robert Pluim > Date: Fri, 20 Feb 2015 15:16:49 +0100 > > > According to the comment in w32notify.c, w32.h is included only for > > w32_strerror. Could you try commenting out the w32.h inclusion, and > > instead copy the w32_strerror prototype into w32notify.c? Does Emacs > > compile then as part of the Cygwin-w32 build, and do file > > notifications work? (I don't have Cygwin installed to try that, > > sorry.) > > > > No, that doesn't compile. w32notify.c needs (at least) > w32_unicode_filenames, filename_to_utf16(), filename_to_ansi() and > w32_valid_pointer_p() from w32.c. Right. But those problems are quite simple to solve. Ken, would you like to try to solve them? I could suggest a patch, but it would be 100% untested. > I don't think adding w32.c into the build on cygwin is going to work. Because of the above, or because of something else? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 10:47:34 2015 Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 15:47:34 +0000 Received: from localhost ([127.0.0.1]:49626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOpnh-0004xu-DR for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:47:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37943) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOpnf-0004xm-1P for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:47:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOpnd-0001h7-Gb for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:47:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpnd-0001h1-Dp for submit@debbugs.gnu.org; Fri, 20 Feb 2015 10:47:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpnc-0005zz-E3 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:47:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOpnZ-0001gG-4H for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:47:28 -0500 Received: from plane.gmane.org ([80.91.229.3]:48964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOpnY-0001g9-Tc for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 10:47:25 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YOpnU-0000HV-JZ for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 16:47:20 +0100 Received: from vav06-1-78-207-202-9.fbx.proxad.net ([78.207.202.9]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 16:47:20 +0100 Received: from rpluim by vav06-1-78-207-202-9.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 16:47:20 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org To: bug-gnu-emacs@gnu.org From: Robert Pluim Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Fri, 20 Feb 2015 16:46:48 +0100 Organization: not if I can help it Lines: 35 Message-ID: <82oaoofuvr.fsf@gmail.com> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: vav06-1-78-207-202-9.fbx.proxad.net Mail-Copies-To: never X-Debbugs-No-Ack: yes User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (cygwin) Cancel-Lock: sha1:PfoV7m2SQEXEMR0jRyDTcRvqCTI= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit Cc: 19909@debbugs.gnu.org, Ken Brown X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bug-gnu-emacs@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Eli Zaretskii writes: >> From: Robert Pluim >> Date: Fri, 20 Feb 2015 15:16:49 +0100 >> >> > According to the comment in w32notify.c, w32.h is included only for >> > w32_strerror. Could you try commenting out the w32.h inclusion, and >> > instead copy the w32_strerror prototype into w32notify.c? Does Emacs >> > compile then as part of the Cygwin-w32 build, and do file >> > notifications work? (I don't have Cygwin installed to try that, >> > sorry.) >> > >> >> No, that doesn't compile. w32notify.c needs (at least) >> w32_unicode_filenames, filename_to_utf16(), filename_to_ansi() and >> w32_valid_pointer_p() from w32.c. > > Right. But those problems are quite simple to solve. > > Ken, would you like to try to solve them? I could suggest a patch, > but it would be 100% untested. > >> I don't think adding w32.c into the build on cygwin is going to work. > > Because of the above, or because of something else? Because (perhaps mistakenly) I think that calling emacs code that assumes it's running under Windows native will not interact well with emacs code that's running under cygwin. Having said that, I'm willing to test any patches over the next week or so (after that I'm going to be without a cygwin environment for a couple of weeks). Robert From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 11:15:24 2015 Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 16:15:24 +0000 Received: from localhost ([127.0.0.1]:49636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOqEd-00060L-Lt for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:15:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43746) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOqEb-0005xK-72 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:15:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOqEU-0001ns-3K for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:15:20 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqEU-0001nj-0w for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:15:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqET-0004sP-1U for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:15:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOqEM-0001gD-Pm for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:15:12 -0500 Received: from limerock01.mail.cornell.edu ([128.84.13.241]:44716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqEM-0001W1-Mk; Fri, 20 Feb 2015 11:15:06 -0500 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t1KGExiP001421; Fri, 20 Feb 2015 11:14:59 -0500 Received: from [192.168.1.3] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t1KGEw3G013429 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 20 Feb 2015 11:14:59 -0500 Message-ID: <54E75D96.70601@cornell.edu> Date: Fri, 20 Feb 2015 11:15:18 -0500 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> In-Reply-To: <838ufslitm.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) On 2/20/2015 10:10 AM, Eli Zaretskii wrote: >> From: Robert Pluim >> Date: Fri, 20 Feb 2015 15:16:49 +0100 >> >>> According to the comment in w32notify.c, w32.h is included only for >>> w32_strerror. Could you try commenting out the w32.h inclusion, and >>> instead copy the w32_strerror prototype into w32notify.c? Does Emacs >>> compile then as part of the Cygwin-w32 build, and do file >>> notifications work? (I don't have Cygwin installed to try that, >>> sorry.) >>> >> >> No, that doesn't compile. w32notify.c needs (at least) >> w32_unicode_filenames, filename_to_utf16(), filename_to_ansi() and >> w32_valid_pointer_p() from w32.c. > > Right. But those problems are quite simple to solve. > > Ken, would you like to try to solve them? I could suggest a patch, > but it would be 100% untested. I'm busy with other things at the moment and can't get to it right away. If it's easy for you to suggest a patch, why don't you go ahead, and Robert can test it. Or you can wait a couple weeks until I can look at it. BTW, file-notification=gfile works fine in the Cygwin-w32 build, so I'm not sure there's any need to put a lot of effort into this. Ken From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 11:17:31 2015 Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 16:17:31 +0000 Received: from localhost ([127.0.0.1]:49640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOqGg-00072d-G4 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:17:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44179) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOqGe-00072V-Em for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:17:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOqGd-0002e4-JK for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:17:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqGd-0002dy-GM for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:17:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqGc-0002RL-Ki for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:17:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOqGX-0002cT-MA for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:17:26 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:46205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqGX-0002c5-Ex for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:17:21 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NK200B00VQI3X00@a-mtaout20.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 18:17:19 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NK200AK4VWVZ290@a-mtaout20.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 18:17:19 +0200 (IST) Date: Fri, 20 Feb 2015 18:17:36 +0200 From: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin In-reply-to: <82oaoofuvr.fsf@gmail.com> X-012-Sender: halo1@inter.net.il To: bug-gnu-emacs@gnu.org Message-id: <83wq3cd0bj.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <82oaoofuvr.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Robert Pluim > Date: Fri, 20 Feb 2015 16:46:48 +0100 > > >> I don't think adding w32.c into the build on cygwin is going to work. > > > > Because of the above, or because of something else? > > Because (perhaps mistakenly) I think that calling emacs code that > assumes it's running under Windows native will not interact well with > emacs code that's running under cygwin. Sorry, maybe I'm confused, but isn't your Cygwin build configured "--with-w32"? If so, it already uses some of the Windows native code. > Having said that, I'm willing to test any patches over the next week or > so Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 11:45:07 2015 Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 16:45:07 +0000 Received: from localhost ([127.0.0.1]:49646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOqhP-0007hm-9R for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:45:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55638) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOqhM-0007hc-MA for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:45:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOqhJ-0005h7-1A for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:45:04 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqhI-0005h3-UP for submit@debbugs.gnu.org; Fri, 20 Feb 2015 11:45:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqhC-0006AK-UW for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:45:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOqh7-0005g9-0Z for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:44:54 -0500 Received: from plane.gmane.org ([80.91.229.3]:55141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqh6-0005g3-Pf for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 11:44:48 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YOqh5-0007Xg-Ox for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 17:44:47 +0100 Received: from vav06-1-78-207-202-9.fbx.proxad.net ([78.207.202.9]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 17:44:47 +0100 Received: from rpluim by vav06-1-78-207-202-9.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Feb 2015 17:44:47 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org To: bug-gnu-emacs@gnu.org From: Robert Pluim Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Fri, 20 Feb 2015 17:44:30 +0100 Organization: not if I can help it Lines: 19 Message-ID: <821tlkfs7l.fsf@gmail.com> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <82oaoofuvr.fsf@gmail.com> <83wq3cd0bj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: vav06-1-78-207-202-9.fbx.proxad.net Mail-Copies-To: never X-Debbugs-No-Ack: yes User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (cygwin) Cancel-Lock: sha1:yPp5ApiNyVsXCBR5hXOkpMxdnVs= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: bug-gnu-emacs@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Eli Zaretskii writes: >> From: Robert Pluim >> Date: Fri, 20 Feb 2015 16:46:48 +0100 >> >> >> I don't think adding w32.c into the build on cygwin is going to work. >> > >> > Because of the above, or because of something else? >> >> Because (perhaps mistakenly) I think that calling emacs code that >> assumes it's running under Windows native will not interact well with >> emacs code that's running under cygwin. > > Sorry, maybe I'm confused, but isn't your Cygwin build configured > "--with-w32"? If so, it already uses some of the Windows native code. > Yes, but only the bits relevant to the GUI. I don't know what the rest of it does :) From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 12:06:37 2015 Received: (at 19909) by debbugs.gnu.org; 20 Feb 2015 17:06:38 +0000 Received: from localhost ([127.0.0.1]:49657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOr2D-0008EX-00 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 12:06:37 -0500 Received: from mail-wi0-f169.google.com ([209.85.212.169]:46456) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOr2A-0008EO-4q for 19909@debbugs.gnu.org; Fri, 20 Feb 2015 12:06:34 -0500 Received: by mail-wi0-f169.google.com with SMTP id em10so7735104wid.0 for <19909@debbugs.gnu.org>; Fri, 20 Feb 2015 09:06:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=Kjb21/kNdxfqMbL8536d2RRHm3wxyD6FJj1iV3zpMSQ=; b=BhcMHrIcoYTkwcAOMmEmf7T0EwBn4slrP+41F//WsRG9KvqvyvJKUllMp3q2YwrtBN qU9tx6HeCJ/Jmm1KT7CGg6wpYuDPRIRrcsCB/4X0viGhn2cGaZWtyHNi3dvbB5xHUOAy eq5i5pKu3mqRKVSh5lKkWDVKlwI5rgfvZWr8AohbtIMPzzvaeq1ElEuT01AG0ACvr+O+ XJMYTtrWC458FlDKXSEzIpFB7DzFWk/LIbH8ftge+Qt1esrDFF+9aqFtnzYxHcGvpvZ5 Q6lGM17+QzOUGZHIEuWDNK4osmgQ3M+lvVqUYPqKI2PsFxbj5uHJ3WYQDBseOsqiQasr 67uQ== X-Received: by 10.180.108.239 with SMTP id hn15mr21596096wib.38.1424451993567; Fri, 20 Feb 2015 09:06:33 -0800 (PST) Received: from RPLUIM (vav06-1-78-207-202-9.fbx.proxad.net. [78.207.202.9]) by mx.google.com with ESMTPSA id dm6sm3168386wib.22.2015.02.20.09.06.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 09:06:33 -0800 (PST) From: Robert Pluim To: Ken Brown Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> X-Debbugs-No-Ack: yes Gmane-Reply-To-List: yes Date: Fri, 20 Feb 2015 18:06:21 +0100 In-Reply-To: <54E75D96.70601@cornell.edu> (Ken Brown's message of "Fri, 20 Feb 2015 11:15:18 -0500") Message-ID: <82lhjsecmq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (cygwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19909 Cc: 19909@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ken Brown writes: > On 2/20/2015 10:10 AM, Eli Zaretskii wrote: >>> From: Robert Pluim >>> Date: Fri, 20 Feb 2015 15:16:49 +0100 >>> >>>> According to the comment in w32notify.c, w32.h is included only for >>>> w32_strerror. Could you try commenting out the w32.h inclusion, and >>>> instead copy the w32_strerror prototype into w32notify.c? Does Emacs >>>> compile then as part of the Cygwin-w32 build, and do file >>>> notifications work? (I don't have Cygwin installed to try that, >>>> sorry.) >>>> >>> >>> No, that doesn't compile. w32notify.c needs (at least) >>> w32_unicode_filenames, filename_to_utf16(), filename_to_ansi() and >>> w32_valid_pointer_p() from w32.c. >> >> Right. But those problems are quite simple to solve. >> >> Ken, would you like to try to solve them? I could suggest a patch, >> but it would be 100% untested. > > I'm busy with other things at the moment and can't get to it right > away. If it's easy for you to suggest a patch, why don't you go ahead, > and Robert can test it. Or you can wait a couple weeks until I can > look at it. > > BTW, file-notification=3Dgfile works fine in the Cygwin-w32 build, so > I'm not sure there's any need to put a lot of effort into this. I didn't know that. I'll give it a go. Perhaps the following slight modification to my original patch? diff --git a/ChangeLog b/ChangeLog index 4365668..dec9ce0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2015-02-20 rpluim + + * configure.ac: Error out if with-file-notification=3Dw32 is + specified on cygwin. + 2015-02-13 Jan Dj=C3=A4rv =20 * configure.ac: Set locallisppath to empty for NS self contained, diff --git a/configure.ac b/configure.ac index 0bcc55c..19d9c20 100644 --- a/configure.ac +++ b/configure.ac @@ -2659,6 +2659,11 @@ fi =20 dnl MS Windows native file monitor is available for mingw32 only. case $with_file_notification,$opsys in + w32,cygwin) + AC_MSG_ERROR([`--with-file-notification=3Dw32' was specified, but + this is only supported on MS-Windows native and MinGW32 builds. + Consider using gfile instead.]) + ;; w32,* | yes,mingw32) AC_CHECK_HEADER(windows.h) if test "$ac_cv_header_windows_h" =3D yes ; then From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 12:16:34 2015 Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 17:16:34 +0000 Received: from localhost ([127.0.0.1]:49669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOrBq-0008T1-EC for submit@debbugs.gnu.org; Fri, 20 Feb 2015 12:16:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36700) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOrBo-0008Ss-Mk for submit@debbugs.gnu.org; Fri, 20 Feb 2015 12:16:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOrBn-00033E-Lp for submit@debbugs.gnu.org; Fri, 20 Feb 2015 12:16:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOrBn-00033A-Bn for submit@debbugs.gnu.org; Fri, 20 Feb 2015 12:16:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOrBi-00045t-7R for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:16:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOrBe-00030q-3u for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:16:26 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:57818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOrBd-00030N-TA for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:16:22 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NK200A00YHZ6L00@a-mtaout21.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 19:16:20 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NK200ASKYN85M30@a-mtaout21.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 19:16:20 +0200 (IST) Date: Fri, 20 Feb 2015 19:16:37 +0200 From: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin In-reply-to: <821tlkfs7l.fsf@gmail.com> X-012-Sender: halo1@inter.net.il To: bug-gnu-emacs@gnu.org Message-id: <83vbiwcxl6.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <82oaoofuvr.fsf@gmail.com> <83wq3cd0bj.fsf@gnu.org> <821tlkfs7l.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Robert Pluim > Date: Fri, 20 Feb 2015 17:44:30 +0100 > > Eli Zaretskii writes: > > >> From: Robert Pluim > >> Date: Fri, 20 Feb 2015 16:46:48 +0100 > >> > >> >> I don't think adding w32.c into the build on cygwin is going to work. > >> > > >> > Because of the above, or because of something else? > >> > >> Because (perhaps mistakenly) I think that calling emacs code that > >> assumes it's running under Windows native will not interact well with > >> emacs code that's running under cygwin. > > > > Sorry, maybe I'm confused, but isn't your Cygwin build configured > > "--with-w32"? If so, it already uses some of the Windows native code. > > Yes, but only the bits relevant to the GUI. I don't know what the rest > of it does :) Most of native Windows code in Emacs is related to GUI. That includes drawing GUI frames and accepting input from the Windows message queue; both are used by the Cygwin build --with-w32. The rest is emulation of Posix functions, which Cygwin doesn't need. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 20 12:18:18 2015 Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 17:18:18 +0000 Received: from localhost ([127.0.0.1]:49673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOrDV-0008Vi-RY for submit@debbugs.gnu.org; Fri, 20 Feb 2015 12:18:18 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37084) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOrDU-0008Va-13 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 12:18:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOrDO-0003ou-HY for submit@debbugs.gnu.org; Fri, 20 Feb 2015 12:18:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOrDO-0003oq-EA for submit@debbugs.gnu.org; Fri, 20 Feb 2015 12:18:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOrDI-0004qz-Rd for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:18:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOrDE-0003nN-Of for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:18:04 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:57874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOrDE-0003nH-Gn for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:18:00 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NK200A00YHZ6L00@a-mtaout21.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 19:17:59 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NK200ACCYPZ5M40@a-mtaout21.012.net.il>; Fri, 20 Feb 2015 19:17:59 +0200 (IST) Date: Fri, 20 Feb 2015 19:18:16 +0200 From: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin In-reply-to: <54E75D96.70601@cornell.edu> X-012-Sender: halo1@inter.net.il To: Ken Brown Message-id: <83twygcxif.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Fri, 20 Feb 2015 11:15:18 -0500 > From: Ken Brown > CC: bug-gnu-emacs@gnu.org, Robert Pluim > > I'm busy with other things at the moment and can't get to it right away. > If it's easy for you to suggest a patch, why don't you go ahead, and > Robert can test it. Or you can wait a couple weeks until I can look at it. OK, I will try to find time. > BTW, file-notification=gfile works fine in the Cygwin-w32 build, so I'm > not sure there's any need to put a lot of effort into this. If it turns out to need a lot of effort, I'll agree with you. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 27 17:26:01 2015 Received: (at submit) by debbugs.gnu.org; 27 Feb 2015 22:26:01 +0000 Received: from localhost ([127.0.0.1]:60266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRTM8-0006sN-Ar for submit@debbugs.gnu.org; Fri, 27 Feb 2015 17:26:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55730) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRTM6-0006s9-CB for submit@debbugs.gnu.org; Fri, 27 Feb 2015 17:25:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRTLz-0006ud-Qj for submit@debbugs.gnu.org; Fri, 27 Feb 2015 17:25:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRTLz-0006uZ-NV for submit@debbugs.gnu.org; Fri, 27 Feb 2015 17:25:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRTLy-0008DJ-AB for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 17:25:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRTLv-0006sx-39 for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 17:25:50 -0500 Received: from limerock03.mail.cornell.edu ([128.84.13.243]:34305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRTLu-0006sq-U4; Fri, 27 Feb 2015 17:25:46 -0500 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t1RMPi6F020128; Fri, 27 Feb 2015 17:25:44 -0500 Received: from [192.168.1.3] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t1RMPhID009054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 27 Feb 2015 17:25:43 -0500 Message-ID: <54F0EEF2.1030908@cornell.edu> Date: Fri, 27 Feb 2015 17:25:54 -0500 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> In-Reply-To: <83twygcxif.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------030000060002070602010600" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) This is a multi-part message in MIME format. --------------030000060002070602010600 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 2/20/2015 12:18 PM, Eli Zaretskii wrote: >> Date: Fri, 20 Feb 2015 11:15:18 -0500 >> From: Ken Brown >> CC: bug-gnu-emacs@gnu.org, Robert Pluim >> >> I'm busy with other things at the moment and can't get to it right away. >> If it's easy for you to suggest a patch, why don't you go ahead, and >> Robert can test it. Or you can wait a couple weeks until I can look at it. > > OK, I will try to find time. > >> BTW, file-notification=gfile works fine in the Cygwin-w32 build, so I'm >> not sure there's any need to put a lot of effort into this. > > If it turns out to need a lot of effort, I'll agree with you. It looks like it might not take much effort. What I did for now, just for testing purposes, is to copy into w32notify.c whatever was necessary to make the Cygwin-w32 build compile with w32 file notification. I tested it briefly and it seems to work. Obviously it needs much more testing to make sure this doesn't break anything else, and then we can worry about how to do this right. Robert, please test when you get a chance (patch attached). Ken --------------030000060002070602010600 Content-Type: text/plain; charset=windows-1252; name="cygw32_notify.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="cygw32_notify.patch" diff --git a/src/w32notify.c b/src/w32notify.c index ab6cd12..71ee1a3 100644 --- a/src/w32notify.c +++ b/src/w32notify.c @@ -92,12 +92,216 @@ along with GNU Emacs. If not, see . */ #include "lisp.h" #include "w32term.h" /* for enter_crit/leave_crit and WM_EMACS_FILENOTIFY */ #include "w32common.h" /* for OS version data */ -#include "w32.h" /* for w32_strerror */ #include "coding.h" #include "keyboard.h" #include "frame.h" /* needed by termhooks.h */ #include "termhooks.h" /* for FILE_NOTIFY_EVENT */ +/* Experimental code for Cygwin-w32 build */ + +extern char * w32_strerror (int error_no); + +int (WINAPI *pMultiByteToWideChar)(UINT,DWORD,LPCSTR,int,LPWSTR,int); +int (WINAPI *pWideCharToMultiByte)(UINT,DWORD,LPCWSTR,int,LPSTR,int,LPCSTR,LPBOOL); + +#define MAXPATHLEN MAX_PATH +#define MAX_UTF8_PATH (MAXPATHLEN * 4) + +static int file_name_codepage; + +static int +codepage_for_filenames (CPINFO *cp_info) +{ + /* A simple cache to avoid calling GetCPInfo every time we need to + encode/decode a file name. The file-name encoding is not + supposed to be changed too frequently, if ever. */ + static Lisp_Object last_file_name_encoding; + static CPINFO cp; + Lisp_Object current_encoding; + + current_encoding = Vfile_name_coding_system; + if (NILP (current_encoding)) + current_encoding = Vdefault_file_name_coding_system; + + if (!EQ (last_file_name_encoding, current_encoding)) + { + /* Default to the current ANSI codepage. */ + file_name_codepage = w32_ansi_code_page; + + if (NILP (current_encoding)) + { + char *cpname = SDATA (SYMBOL_NAME (current_encoding)); + char *cp = NULL, *end; + int cpnum; + + if (strncmp (cpname, "cp", 2) == 0) + cp = cpname + 2; + else if (strncmp (cpname, "windows-", 8) == 0) + cp = cpname + 8; + + if (cp) + { + end = cp; + cpnum = strtol (cp, &end, 10); + if (cpnum && *end == '\0' && end - cp >= 2) + file_name_codepage = cpnum; + } + } + + if (!file_name_codepage) + file_name_codepage = CP_ACP; /* CP_ACP = 0, but let's not assume that */ + + if (!GetCPInfo (file_name_codepage, &cp)) + { + file_name_codepage = CP_ACP; + if (!GetCPInfo (file_name_codepage, &cp)) + emacs_abort (); + } + } + if (cp_info) + *cp_info = cp; + + return file_name_codepage; +} + +int +filename_to_utf16 (const char *fn_in, wchar_t *fn_out) +{ + int result = pMultiByteToWideChar (CP_UTF8, MB_ERR_INVALID_CHARS, fn_in, -1, + fn_out, MAX_PATH); + + if (!result) + { + DWORD err = GetLastError (); + + switch (err) + { + case ERROR_INVALID_FLAGS: + case ERROR_INVALID_PARAMETER: + errno = EINVAL; + break; + case ERROR_INSUFFICIENT_BUFFER: + case ERROR_NO_UNICODE_TRANSLATION: + default: + errno = ENOENT; + break; + } + return -1; + } + return 0; +} + +int +filename_from_utf16 (const wchar_t *fn_in, char *fn_out) +{ + int result = pWideCharToMultiByte (CP_UTF8, 0, fn_in, -1, + fn_out, MAX_UTF8_PATH, NULL, NULL); + + if (!result) + { + DWORD err = GetLastError (); + + switch (err) + { + case ERROR_INVALID_FLAGS: + case ERROR_INVALID_PARAMETER: + errno = EINVAL; + break; + case ERROR_INSUFFICIENT_BUFFER: + case ERROR_NO_UNICODE_TRANSLATION: + default: + errno = ENOENT; + break; + } + return -1; + } + return 0; +} + +int +filename_to_ansi (const char *fn_in, char *fn_out) +{ + wchar_t fn_utf16[MAX_PATH]; + + if (filename_to_utf16 (fn_in, fn_utf16) == 0) + { + int result; + int codepage = codepage_for_filenames (NULL); + + result = pWideCharToMultiByte (codepage, 0, fn_utf16, -1, + fn_out, MAX_PATH, NULL, NULL); + if (!result) + { + DWORD err = GetLastError (); + + switch (err) + { + case ERROR_INVALID_FLAGS: + case ERROR_INVALID_PARAMETER: + errno = EINVAL; + break; + case ERROR_INSUFFICIENT_BUFFER: + case ERROR_NO_UNICODE_TRANSLATION: + default: + errno = ENOENT; + break; + } + return -1; + } + return 0; + } + return -1; +} + +int +filename_from_ansi (const char *fn_in, char *fn_out) +{ + wchar_t fn_utf16[MAX_PATH]; + int codepage = codepage_for_filenames (NULL); + int result = pMultiByteToWideChar (codepage, MB_ERR_INVALID_CHARS, fn_in, -1, + fn_utf16, MAX_PATH); + + if (!result) + { + DWORD err = GetLastError (); + + switch (err) + { + case ERROR_INVALID_FLAGS: + case ERROR_INVALID_PARAMETER: + errno = EINVAL; + break; + case ERROR_INSUFFICIENT_BUFFER: + case ERROR_NO_UNICODE_TRANSLATION: + default: + errno = ENOENT; + break; + } + return -1; + } + return filename_from_utf16 (fn_utf16, fn_out); +} + +int +w32_valid_pointer_p (void *p, int size) +{ + SIZE_T done; + HANDLE h = OpenProcess (PROCESS_VM_READ, FALSE, GetCurrentProcessId ()); + + if (h) + { + unsigned char *buf = alloca (size); + int retval = ReadProcessMemory (h, p, buf, size, &done); + + CloseHandle (h); + return retval; + } + else + return -1; +} + +/* End experimental code for Cygwin-w32 build */ + #define DIRWATCH_SIGNATURE 0x01233210 struct notification { diff --git a/src/w32term.c b/src/w32term.c index d415b13..061c9c3 100644 --- a/src/w32term.c +++ b/src/w32term.c @@ -3195,7 +3195,6 @@ lispy_file_action (DWORD action) return retval; } -#ifdef WINDOWSNT /* Put file notifications into the Emacs input event queue. This function runs when the WM_EMACS_FILENOTIFY message arrives from a watcher thread. */ @@ -3271,7 +3270,6 @@ queue_notifications (struct input_event *event, W32Msg *msg, struct frame *f, /* We've stuffed all the events ourselves, so w32_read_socket shouldn't. */ event->kind = NO_EVENT; } -#endif /* WINDOWSNT */ #endif /* HAVE_W32NOTIFY */ --------------030000060002070602010600-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 28 02:59:42 2015 Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 07:59:42 +0000 Received: from localhost ([127.0.0.1]:60340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRcJJ-0005FX-G2 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 02:59:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58793) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRcJH-0005FF-K5 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 02:59:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRcJB-0005hj-GR for submit@debbugs.gnu.org; Sat, 28 Feb 2015 02:59:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRcJB-0005hc-Cr for submit@debbugs.gnu.org; Sat, 28 Feb 2015 02:59:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRcJA-00006T-50 for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 02:59:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRcJ5-0005fh-7P for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 02:59:32 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:38212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRcJ4-0005fM-V1 for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 02:59:27 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NKH00E001XTIY00@a-mtaout20.012.net.il> for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 09:59:25 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKH00ESE270I020@a-mtaout20.012.net.il>; Sat, 28 Feb 2015 09:59:25 +0200 (IST) Date: Sat, 28 Feb 2015 09:59:45 +0200 From: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin In-reply-to: <54F0EEF2.1030908@cornell.edu> X-012-Sender: halo1@inter.net.il To: Ken Brown Message-id: <83sidq4gb2.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Fri, 27 Feb 2015 17:25:54 -0500 > From: Ken Brown > CC: bug-gnu-emacs@gnu.org, rpluim@gmail.com > > It looks like it might not take much effort. What I did for now, just > for testing purposes, is to copy into w32notify.c whatever was necessary > to make the Cygwin-w32 build compile with w32 file notification. I > tested it briefly and it seems to work. Obviously it needs much more > testing to make sure this doesn't break anything else, and then we can > worry about how to do this right. Thanks. A few comments: . Cygwin doesn't need to call MultiByteToWideChar and WideCharToMultiByte via function pointers, it can call them directly. . I think there shouldn't be a need to call filename_to_utf16 and its ilk, but instead use the to_unicode etc., like the rest of Cygwin-w32 code does. E.g., just use GUI_ENCODE_FILE defined on w32term.h. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 28 11:32:37 2015 Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 16:32:37 +0000 Received: from localhost ([127.0.0.1]:60806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRkJh-00027U-3f for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:32:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41396) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRkJe-00027F-47 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:32:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRkJX-0005Mz-Nm for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:32:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRkJX-0005Mq-LX for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:32:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRkJW-0001aH-IJ for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 11:32:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRkJT-0005L7-Rx for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 11:32:26 -0500 Received: from limerock02.mail.cornell.edu ([128.84.13.242]:41406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRkJT-0005Kv-OK; Sat, 28 Feb 2015 11:32:23 -0500 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t1SGWHq3024384; Sat, 28 Feb 2015 11:32:18 -0500 Received: from [192.168.1.3] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t1SGWG8d008520 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 28 Feb 2015 11:32:17 -0500 Message-ID: <54F1ED9D.9040303@cornell.edu> Date: Sat, 28 Feb 2015 11:32:29 -0500 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> In-Reply-To: <83sidq4gb2.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) On 2/28/2015 2:59 AM, Eli Zaretskii wrote: >> Date: Fri, 27 Feb 2015 17:25:54 -0500 >> From: Ken Brown >> CC: bug-gnu-emacs@gnu.org, rpluim@gmail.com >> >> It looks like it might not take much effort. What I did for now, just >> for testing purposes, is to copy into w32notify.c whatever was necessary >> to make the Cygwin-w32 build compile with w32 file notification. I >> tested it briefly and it seems to work. Obviously it needs much more >> testing to make sure this doesn't break anything else, and then we can >> worry about how to do this right. > > Thanks. A few comments: > > . Cygwin doesn't need to call MultiByteToWideChar and > WideCharToMultiByte via function pointers, it can call them > directly. > > . I think there shouldn't be a need to call filename_to_utf16 and > its ilk, but instead use the to_unicode etc., like the rest of > Cygwin-w32 code does. E.g., just use GUI_ENCODE_FILE defined on > w32term.h. It turns out that filename_to_utf16 wasn't even being called in the Cygwin-w32 build, because w32_unicode_filenames == 0. It also turns out that when I "tested" the build, which I did via M-x auto-revert-tail-mode, I wasn't actually testing w32notify, because I forgot to do this: diff --git a/src/emacs.c b/src/emacs.c index ca5633d..342d0fe 100644 --- a/src/emacs.c +++ b/src/emacs.c @@ -1334,11 +1334,12 @@ Using an Emacs configured with --with-x-toolkit=lucid does not have this problem globals_of_gfilenotify (); #endif -#ifdef WINDOWSNT - globals_of_w32 (); #ifdef HAVE_W32NOTIFY globals_of_w32notify (); #endif + +#ifdef WINDOWSNT + globals_of_w32 (); /* Initialize environment from registry settings. */ init_environment (argv); init_ntproc (dumping); /* must precede init_editfns. */ @@ -1512,11 +1513,12 @@ Using an Emacs configured with --with-x-toolkit=lucid does not have this problem syms_of_dbusbind (); #endif /* HAVE_DBUS */ -#ifdef WINDOWSNT - syms_of_ntterm (); #ifdef HAVE_W32NOTIFY syms_of_w32notify (); -#endif /* HAVE_W32NOTIFY */ +#endif + +#ifdef WINDOWSNT + syms_of_ntterm (); #endif /* WINDOWSNT */ syms_of_profiler (); When I add that patch, auto-revert-tail-mode no longer works; there's no error message, but the buffer doesn't get auto-reverted when something is appended. I think I have again lost motivation to pursue this further, since gfile works fine. And glib is required for the default Cygwin-w32 build anyway, because ImageMagick brings it in, so why not just use it? Ken From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 28 11:41:33 2015 Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 16:41:33 +0000 Received: from localhost ([127.0.0.1]:60810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRkSL-0002KS-CG for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:41:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42622) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRkSJ-0002KF-I5 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:41:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRkSD-00087x-FR for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:41:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRkSD-00087t-B6 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:41:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRkSC-0000AB-Gf for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 11:41:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRkS7-000857-5u for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 11:41:24 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:50993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRkS6-00084p-OI for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 11:41:19 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NKH00H00Q83RM00@a-mtaout20.012.net.il> for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 18:41:17 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKH00H8SQCTP820@a-mtaout20.012.net.il>; Sat, 28 Feb 2015 18:41:17 +0200 (IST) Date: Sat, 28 Feb 2015 18:41:10 +0200 From: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin In-reply-to: <54F1ED9D.9040303@cornell.edu> X-012-Sender: halo1@inter.net.il To: Ken Brown Message-id: <83zj7yrntl.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sat, 28 Feb 2015 11:32:29 -0500 > From: Ken Brown > CC: bug-gnu-emacs@gnu.org, rpluim@gmail.com > > I think I have again lost motivation to pursue this further, since gfile > works fine. And glib is required for the default Cygwin-w32 build > anyway, because ImageMagick brings it in, so why not just use it? Perhaps the OP could explain why he wanted that. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 28 11:53:54 2015 Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 16:53:54 +0000 Received: from localhost ([127.0.0.1]:60814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRkeH-0002cg-OY for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:53:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43918) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRkeF-0002cS-Kl for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:53:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRke5-00049A-Hd for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:53:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRke5-000492-FK for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:53:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRke4-0007Hh-Id for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 11:53:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRke3-000479-Hh for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 11:53:40 -0500 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:39983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRke3-000464-AO; Sat, 28 Feb 2015 11:53:39 -0500 Received: by wiwl15 with SMTP id l15so6404760wiw.5; Sat, 28 Feb 2015 08:53:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=kHF+7LAdWnhFHf1EMcE1knKrsFaukV+kvAT/tXm+vFI=; b=lX4E93R7XYMXN3nk3IYio38RZgNxAmI9W7GKxsJ7qVoW1MyuwFYhelBX+1+0CkyDCN bSZdOmqm0cMphCXzwhuWDD3vxdglc7DbJDmATfY0czWpuFPrEQScaddvV8IyBR6er5eA +tpdMrPK3MXP15fTztRv5Cm8AwFEKhBqIlLc/7sQn5LLynQTsoZ+htOEsJ2iUlflr6nK neRyG44cXl3iQX09i7xPkyvWUJ1y2siYYAichVpRPxdg64gqHDdeaEpea5TqFsiDvfay LljpTZ1A6Ht3r68esPVQlPyK85eHkat8ytwogBBCwcsCCVg2gTAGaGb3wPUvxtCfy8Df 2y6g== MIME-Version: 1.0 X-Received: by 10.194.118.198 with SMTP id ko6mr39259547wjb.47.1425142418097; Sat, 28 Feb 2015 08:53:38 -0800 (PST) Received: by 10.27.198.198 with HTTP; Sat, 28 Feb 2015 08:53:38 -0800 (PST) In-Reply-To: <83zj7yrntl.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> <83zj7yrntl.fsf@gnu.org> Date: Sat, 28 Feb 2015 17:53:38 +0100 Message-ID: Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin From: Robert Pluim To: Eli Zaretskii Content-Type: multipart/alternative; boundary=089e01176ba395cc31051028d330 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Ken Brown X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --089e01176ba395cc31051028d330 Content-Type: text/plain; charset=UTF-8 On Sat, Feb 28, 2015 at 5:41 PM, Eli Zaretskii wrote: > > Date: Sat, 28 Feb 2015 11:32:29 -0500 > > From: Ken Brown > > CC: bug-gnu-emacs@gnu.org, rpluim@gmail.com > > > > I think I have again lost motivation to pursue this further, since gfile > > works fine. And glib is required for the default Cygwin-w32 build > > anyway, because ImageMagick brings it in, so why not just use it? > > Perhaps the OP could explain why he wanted that. > --089e01176ba395cc31051028d330 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Sat, Feb 28, 2015 at 5:41 PM, Eli Zaretskii = <eliz@gnu.org><= /span> wrote:
> Date: Sat, 28 Feb 2015= 11:32:29 -0500
> From: Ken Brown <kbrown@cornell.edu>
> CC: bug-gnu-emacs@gnu.org= , rpluim@gmail.com
>
> I think I have again lost motivation to pursue= this further, since gfile
> works fine.=C2=A0 And glib is required for the default Cygwin-w32 buil= d
> anyway, because ImageMagick brings it in, so why not just use it?

Perhaps the OP could explain why he wanted that.

--089e01176ba395cc31051028d330-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 28 11:56:40 2015 Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 16:56:40 +0000 Received: from localhost ([127.0.0.1]:60819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRkgy-0002gh-9y for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:56:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44330) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRkgw-0002gV-05 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:56:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRkgq-0005XS-0C for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:56:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:38278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRkgp-0005XM-Ts for submit@debbugs.gnu.org; Sat, 28 Feb 2015 11:56:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRkgp-00018g-03 for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 11:56:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRkgn-0005Wy-QN for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 11:56:30 -0500 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:44721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRkgn-0005Wu-KH; Sat, 28 Feb 2015 11:56:29 -0500 Received: by wesk11 with SMTP id k11so25754224wes.11; Sat, 28 Feb 2015 08:56:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7EGhHwC6xYFOsR3MRE5MOQflKq12bNePGVUeNpLRMD8=; b=a4fIYhfLMiACNnzTWzyVfL8ty5XR0DbrQTYBpZjMGepynXTheBWssLS4KrMtFZkdAV ZkM9WjQh+EPjZdrmJueCsVgohB295qyZs22UB8LbDkeloyJF2xR0s9vSTKbG90O/ezIa xJ+szzqTB/AOjSaO85xFjbSS271djXxIMqyzpE/ZmTXrOnIB4vg2GqodNzLdgjxbRC4W rJLe/eu0liaHzyPMcMsjfVG2DYYk3T0r9ykzfbZowuc7S2KMnj2H8zLWAhs+iuRmbCf4 DjR+UQzRC2q7cGKfqVXljovEhvUogDD9kqMeRZnNMadq27BhawPd7i1Fe0jQuAHM3B5F dxKg== MIME-Version: 1.0 X-Received: by 10.194.158.39 with SMTP id wr7mr40819926wjb.118.1425142588942; Sat, 28 Feb 2015 08:56:28 -0800 (PST) Received: by 10.27.198.198 with HTTP; Sat, 28 Feb 2015 08:56:28 -0800 (PST) In-Reply-To: <83zj7yrntl.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> <83zj7yrntl.fsf@gnu.org> Date: Sat, 28 Feb 2015 17:56:28 +0100 Message-ID: Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin From: Robert Pluim To: Eli Zaretskii Content-Type: multipart/alternative; boundary=089e01160576c4afdd051028dd6e X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Ken Brown X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --089e01160576c4afdd051028dd6e Content-Type: text/plain; charset=UTF-8 @#$ web interface, sorry about the duplicate On Sat, Feb 28, 2015 at 5:41 PM, Eli Zaretskii wrote: > > Date: Sat, 28 Feb 2015 11:32:29 -0500 > > From: Ken Brown > > CC: bug-gnu-emacs@gnu.org, rpluim@gmail.com > > > > I think I have again lost motivation to pursue this further, since gfile > > works fine. And glib is required for the default Cygwin-w32 build > > anyway, because ImageMagick brings it in, so why not just use it? > > Perhaps the OP could explain why he wanted that. > If you're referring to me, my motivation was to prevent a compilation error for an incorrect configure combination. I believe you started us all down the path of trying to get w32 notifying to work. I have no problem with using glib. Robert --089e01160576c4afdd051028dd6e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
@#$ web interface, sorry about the duplicate

On Sat, Feb 28, 2015 at 5:4= 1 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> Date: Sat, 28 Feb 2015 11:32:29 -0500
> From: Ken Brown <kbrown@cornell.edu>
> CC: bug-gnu-emacs@gnu.org= , rpluim@gmail.com
>
> I think I have again lost motivation to pursue= this further, since gfile
> works fine.=C2=A0 And glib is required for the default Cygwin-w32 buil= d
> anyway, because ImageMagick brings it in, so why not just use it?

Perhaps the OP could explain why he wanted that.

If you're referring to me, my motivation was to preven= t a compilation error for an incorrect configure combination. I believe you= started us all down the path of trying to get w32 notifying to work. I hav= e no problem with using glib.

Robert=C2=A0

--089e01160576c4afdd051028dd6e-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 28 12:57:25 2015 Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 17:57:25 +0000 Received: from localhost ([127.0.0.1]:60833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRldl-00047j-53 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 12:57:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54435) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRldj-00047W-Jz for submit@debbugs.gnu.org; Sat, 28 Feb 2015 12:57:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRldd-0001KD-EK for submit@debbugs.gnu.org; Sat, 28 Feb 2015 12:57:18 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRldd-0001Js-CE for submit@debbugs.gnu.org; Sat, 28 Feb 2015 12:57:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRldc-0006xr-H3 for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 12:57:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRldY-0001HL-2t for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 12:57:16 -0500 Received: from mtaout28.012.net.il ([80.179.55.184]:57042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRldX-0001Gg-RZ for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 12:57:12 -0500 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NKH00H00TNCSU00@mtaout28.012.net.il> for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 19:55:40 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKH00I78TSRIN00@mtaout28.012.net.il>; Sat, 28 Feb 2015 19:55:40 +0200 (IST) Date: Sat, 28 Feb 2015 19:57:01 +0200 From: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin In-reply-to: X-012-Sender: halo1@inter.net.il To: Robert Pluim Message-id: <83wq31syvm.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> <83zj7yrntl.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, kbrown@cornell.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sat, 28 Feb 2015 17:56:28 +0100 > From: Robert Pluim > Cc: Ken Brown , bug-gnu-emacs@gnu.org > > Perhaps the OP could explain why he wanted that. > > If you're referring to me, my motivation was to prevent a compilation error for > an incorrect configure combination. I believe you started us all down the path > of trying to get w32 notifying to work. I have no problem with using glib. No, I meant your reasons for specifying --with-file-notification=w32. You could only bump into this issue if you specified it, AFAIU. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 28 13:44:43 2015 Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 18:44:43 +0000 Received: from localhost ([127.0.0.1]:60837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRmNX-0005IC-Ag for submit@debbugs.gnu.org; Sat, 28 Feb 2015 13:44:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60154) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRmNV-0005I0-5z for submit@debbugs.gnu.org; Sat, 28 Feb 2015 13:44:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRmNO-0001oO-Pf for submit@debbugs.gnu.org; Sat, 28 Feb 2015 13:44:35 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmNO-0001oK-N3 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 13:44:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmNN-0004L1-HW for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 13:44:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRmNI-0001nc-IK for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 13:44:33 -0500 Received: from limerock04.mail.cornell.edu ([128.84.13.244]:34049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmNI-0001nY-De; Sat, 28 Feb 2015 13:44:28 -0500 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t1SIiQm7015752; Sat, 28 Feb 2015 13:44:26 -0500 Received: from [192.168.1.3] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t1SIiPPT007791 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 28 Feb 2015 13:44:26 -0500 Message-ID: <54F20C96.4020507@cornell.edu> Date: Sat, 28 Feb 2015 13:44:38 -0500 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eli Zaretskii , Robert Pluim Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> <83zj7yrntl.fsf@gnu.org> <83wq31syvm.fsf@gnu.org> In-Reply-To: <83wq31syvm.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) On 2/28/2015 12:57 PM, Eli Zaretskii wrote: >> Date: Sat, 28 Feb 2015 17:56:28 +0100 >> From: Robert Pluim >> Cc: Ken Brown , bug-gnu-emacs@gnu.org >> >> Perhaps the OP could explain why he wanted that. >> >> If you're referring to me, my motivation was to prevent a compilation error for >> an incorrect configure combination. I believe you started us all down the path >> of trying to get w32 notifying to work. I have no problem with using glib. > > No, I meant your reasons for specifying --with-file-notification=w32. > You could only bump into this issue if you specified it, AFAIU. Based on http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19909#36, I think he specified --with-file-notification=w32 because he wanted file notification and didn't know he could use gfile. Robert, please correct me if I'm misinterpreting what you wrote. I'm inclined to go ahead with the revised patch he submitted in the above URL. I'll commit it (with Robert as author and with the change marked as a "tiny change") if that's OK with you, Eli. Two questions: 1. Shouldn't the name in the ChangeLog be "Robert Pluim" instead of "rpluim" to match all the other entries? 2. I tested making a git commit with --author="Robert Pluim (tiny change)" but git stripped away the "(tiny change)" part. What should I do to get "tiny change" into the git history? Maybe it's not so important now, because I can put it into the ChangeLog, but I'm thinking about the future, when ChangeLogs are automatically generated. Ken From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 28 14:14:31 2015 Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 19:14:31 +0000 Received: from localhost ([127.0.0.1]:60845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRmqN-0005zs-5k for submit@debbugs.gnu.org; Sat, 28 Feb 2015 14:14:31 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34908) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRmqK-0005ze-Gm for submit@debbugs.gnu.org; Sat, 28 Feb 2015 14:14:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRmqD-0001zW-QY for submit@debbugs.gnu.org; Sat, 28 Feb 2015 14:14:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmqD-0001zP-NV for submit@debbugs.gnu.org; Sat, 28 Feb 2015 14:14:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmqC-00027K-Ml for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 14:14:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRmq9-0001yz-EE for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 14:14:20 -0500 Received: from mtaout25.012.net.il ([80.179.55.181]:35073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmq9-0001yt-6N for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 14:14:17 -0500 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NKH00600WTWWR00@mtaout25.012.net.il> for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 21:08:55 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKH004TSX6V0M40@mtaout25.012.net.il>; Sat, 28 Feb 2015 21:08:55 +0200 (IST) Date: Sat, 28 Feb 2015 21:14:06 +0200 From: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin In-reply-to: <54F20C96.4020507@cornell.edu> X-012-Sender: halo1@inter.net.il To: Ken Brown Message-id: <83vbilsvb5.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> <83zj7yrntl.fsf@gnu.org> <83wq31syvm.fsf@gnu.org> <54F20C96.4020507@cornell.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: rpluim@gmail.com, bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sat, 28 Feb 2015 13:44:38 -0500 > From: Ken Brown > CC: bug-gnu-emacs@gnu.org > > > No, I meant your reasons for specifying --with-file-notification=w32. > > You could only bump into this issue if you specified it, AFAIU. > > Based on http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19909#36, I think > he specified --with-file-notification=w32 because he wanted file > notification and didn't know he could use gfile. Isn't gfile the default for Cygwin? > I'm inclined to go ahead with the revised patch he submitted in the > above URL. I'll commit it (with Robert as author and with the change > marked as a "tiny change") if that's OK with you, Eli. If that's what Cygwin users want, fine with me. > 1. Shouldn't the name in the ChangeLog be "Robert Pluim" instead of > "rpluim" to match all the other entries? I don't think it matters when there's no assignment on file. > 2. I tested making a git commit with > > --author="Robert Pluim (tiny change)" > > but git stripped away the "(tiny change)" part. What should I do to get > "tiny change" into the git history? Maybe it's not so important now, > because I can put it into the ChangeLog, but I'm thinking about the > future, when ChangeLogs are automatically generated. The projects I know of use Copyright-paperwork-exempt: yes on a separate line in the log message. You will see that I already used that in Emacs, at least once. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 28 15:14:56 2015 Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 20:14:57 +0000 Received: from localhost ([127.0.0.1]:60870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRnmq-0007RA-91 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 15:14:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40581) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRnmo-0007Qw-AJ for submit@debbugs.gnu.org; Sat, 28 Feb 2015 15:14:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRnmf-00021a-A2 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 15:14:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRnmf-00021V-6j for submit@debbugs.gnu.org; Sat, 28 Feb 2015 15:14:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRnmd-0003xT-Uc for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 15:14:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRnmY-00020J-VA for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 15:14:43 -0500 Received: from limerock03.mail.cornell.edu ([128.84.13.243]:42721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRnmY-00020F-Q2; Sat, 28 Feb 2015 15:14:38 -0500 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t1SKEbPN030381; Sat, 28 Feb 2015 15:14:37 -0500 Received: from [192.168.1.3] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t1SKEaxV016966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 28 Feb 2015 15:14:36 -0500 Message-ID: <54F221B8.4050909@cornell.edu> Date: Sat, 28 Feb 2015 15:14:48 -0500 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> <83zj7yrntl.fsf@gnu.org> <83wq31syvm.fsf@gnu.org> <54F20C96.4020507@cornell.edu> <83vbilsvb5.fsf@gnu.org> In-Reply-To: <83vbilsvb5.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit Cc: rpluim@gmail.com, bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) On 2/28/2015 2:14 PM, Eli Zaretskii wrote: >> Date: Sat, 28 Feb 2015 13:44:38 -0500 >> From: Ken Brown >> CC: bug-gnu-emacs@gnu.org >> >>> No, I meant your reasons for specifying --with-file-notification=w32. >>> You could only bump into this issue if you specified it, AFAIU. >> >> Based on http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19909#36, I think >> he specified --with-file-notification=w32 because he wanted file >> notification and didn't know he could use gfile. > > Isn't gfile the default for Cygwin? Yes. (Of course, the builder has to have the appropriate glib development package installed, or else file notification won't actually be used.) >> I'm inclined to go ahead with the revised patch he submitted in the >> above URL. I'll commit it (with Robert as author and with the change >> marked as a "tiny change") if that's OK with you, Eli. > > If that's what Cygwin users want, fine with me. I personally don't care, but Robert requested it, and I don't see any harm in it. So I'll go ahead as soon as I hear back from him as to how he wants his name shown. >> 1. Shouldn't the name in the ChangeLog be "Robert Pluim" instead of >> "rpluim" to match all the other entries? > > I don't think it matters when there's no assignment on file. > >> 2. I tested making a git commit with >> >> --author="Robert Pluim (tiny change)" >> >> but git stripped away the "(tiny change)" part. What should I do to get >> "tiny change" into the git history? Maybe it's not so important now, >> because I can put it into the ChangeLog, but I'm thinking about the >> future, when ChangeLogs are automatically generated. > > The projects I know of use > > Copyright-paperwork-exempt: yes > > on a separate line in the log message. You will see that I already > used that in Emacs, at least once. Thanks. Ken From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 04:36:04 2015 Received: (at submit) by debbugs.gnu.org; 2 Mar 2015 09:36:04 +0000 Received: from localhost ([127.0.0.1]:33809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSMlf-0001pj-By for submit@debbugs.gnu.org; Mon, 02 Mar 2015 04:36:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52201) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSMld-0001pD-FW for submit@debbugs.gnu.org; Mon, 02 Mar 2015 04:36:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSMlW-0005aI-KH for submit@debbugs.gnu.org; Mon, 02 Mar 2015 04:35:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMlW-0005aC-Gg for submit@debbugs.gnu.org; Mon, 02 Mar 2015 04:35:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMlV-0003Qu-5o for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2015 04:35:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSMlT-0005Z4-KB for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2015 04:35:53 -0500 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:42111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMlT-0005Yi-9i; Mon, 02 Mar 2015 04:35:51 -0500 Received: by wiwh11 with SMTP id h11so13247522wiw.1; Mon, 02 Mar 2015 01:35:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=orR7ZPuyr+egBlT4qXjklqyTCqGIAq4QnJL5Xh6/Fck=; b=DclHV9qJ29IAeLxvA2uAi/Z9H0O6/Ve2pJfa1/x34o7BhYPkezGzIb6KmYV0mRIj+/ NpffVA8vJCFIuq0tIDzS9666gpLPLQjgTN89VOzd2eWtmxuhJEhmzz0tM3x4t4aoBxBR XZe38SRQQQuFTAf1DpL9UPngx3sw7OdF6tUi5K0LCvUhkQtibWN7BH0djW2h6RxEcD20 OqUP8LrVqwOFpKiOk8npd48P/d5v02eQCuHR7fFeqsknqReSzAnKypmDP7I7VIdWrFL1 4yMQU/qFBNipWdphriav2MgTN7yYF0ZAYgx0WhJ3yeGxi7wUdUBIRW/cpXitxCDLuPPg Vm2w== MIME-Version: 1.0 X-Received: by 10.194.90.210 with SMTP id by18mr55137182wjb.80.1425288950078; Mon, 02 Mar 2015 01:35:50 -0800 (PST) Received: by 10.27.198.198 with HTTP; Mon, 2 Mar 2015 01:35:50 -0800 (PST) In-Reply-To: <54F221B8.4050909@cornell.edu> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> <83zj7yrntl.fsf@gnu.org> <83wq31syvm.fsf@gnu.org> <54F20C96.4020507@cornell.edu> <83vbilsvb5.fsf@gnu.org> <54F221B8.4050909@cornell.edu> Date: Mon, 2 Mar 2015 10:35:50 +0100 Message-ID: Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin From: Robert Pluim To: Ken Brown Content-Type: multipart/alternative; boundary=047d7bfcf66292635605104af195 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Eli Zaretskii , bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --047d7bfcf66292635605104af195 Content-Type: text/plain; charset=UTF-8 On Sat, Feb 28, 2015 at 9:14 PM, Ken Brown wrote: > On 2/28/2015 2:14 PM, Eli Zaretskii wrote: > >> Date: Sat, 28 Feb 2015 13:44:38 -0500 >>> From: Ken Brown >>> CC: bug-gnu-emacs@gnu.org >>> >>> No, I meant your reasons for specifying --with-file-notification=w32. >>>> You could only bump into this issue if you specified it, AFAIU. >>>> >>> >>> Based on http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19909#36, I think >>> he specified --with-file-notification=w32 because he wanted file >>> notification and didn't know he could use gfile. >>> >> >> Exactly > Isn't gfile the default for Cygwin? >> > > Yes. (Of course, the builder has to have the appropriate glib development > package installed, or else file notification won't actually be used.) > > I'm inclined to go ahead with the revised patch he submitted in the >>> above URL. I'll commit it (with Robert as author and with the change >>> marked as a "tiny change") if that's OK with you, Eli. >>> >> >> If that's what Cygwin users want, fine with me. >> > > I personally don't care, but Robert requested it, and I don't see any harm > in it. So I'll go ahead as soon as I hear back from him as to how he wants > his name shown. > > 1. Shouldn't the name in the ChangeLog be "Robert Pluim" instead of >>> "rpluim" to match all the other entries? >>> >> >> I don't think it matters when there's no assignment on file. >> > I'd prefer "Robert Pluim" but it's not a big deal. It does show that there's a variable somewhere that I haven't set correctly though, since that ChangeLog entry should never have said "rpluim" > >> 2. I tested making a git commit with >>> >>> --author="Robert Pluim (tiny change)" >>> >>> but git stripped away the "(tiny change)" part. What should I do to get >>> "tiny change" into the git history? Maybe it's not so important now, >>> because I can put it into the ChangeLog, but I'm thinking about the >>> future, when ChangeLogs are automatically generated. >>> >> >> The projects I know of use >> >> Copyright-paperwork-exempt: yes >> >> on a separate line in the log message. You will see that I already >> used that in Emacs, at least once. >> > I'll test the waters with my future employers as to copyright assignment, and this discussion will hopefully not have to happen again :) Regards Robert --047d7bfcf66292635605104af195 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On S= at, Feb 28, 2015 at 9:14 PM, Ken Brown <kbrown@cornell.edu>= wrote:
On 2/28/2015 2:1= 4 PM, Eli Zaretskii wrote:
Date: Sat, 28 Feb 2015 13:44:38 -0500
From: Ken Brown <kbrown@cornell.edu>
CC: bug-gnu-emac= s@gnu.org

No, I meant your reasons for specifying --with-file-notification=3Dw32.
You could only bump into this issue if you specified it, AFAIU.

Based on http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D1= 9909#36, I think
he specified --with-file-notification=3Dw32 because he wanted file
notification and didn't know he could use gfile.


Exactly
= =C2=A0
Isn't gfile the default for Cygwin?

 Yes.=C2=A0 (Of course, the builder has to have the appropriate glib develop= ment package installed, or else file notification won't actually be use= d.)

I'm inclined to go ahead with the revised patch he submitted in the
above URL.=C2=A0 I'll commit it (with Robert as author and with the cha= nge
marked as a "tiny change") if that's OK with you, Eli.

If that's what Cygwin users want, fine with me.

 I personally don't care, but Robert requested it, and I don't see a= ny harm in it.=C2=A0 So I'll go ahead as soon as I hear back from him a= s to how he wants his name shown.

1. Shouldn't the name in the ChangeLog be "Robert Pluim" inst= ead of
"rpluim" to match all the other entries?

I don't think it matters when there's no assignment on file.

I'd prefer "Robe= rt Pluim" but it's not a big deal. It does show that there's a= variable somewhere that I haven't set correctly though, since that Cha= ngeLog entry should never have said "rpluim"
=C2=A0

2. I tested making a git commit with

=C2=A0 =C2=A0 --author=3D"Robert Pluim <rpluim@gmail.com>=C2=A0 (tiny change)&quo= t;

but git stripped away the "(tiny change)" part.=C2=A0 What should= I do to get
"tiny change" into the git history?=C2=A0 Maybe it's not so i= mportant now,
because I can put it into the ChangeLog, but I'm thinking about the
future, when ChangeLogs are automatically generated.

The projects I know of use

=C2=A0 =C2=A0Copyright-paperwork-exempt: yes

on a separate line in the log message.=C2=A0 You will see that I already used that in Emacs, at least once.

I'll tes= t the waters with my future employers as to copyright assignment, and this = discussion will hopefully not have to happen again :)

Regards

Robert
--047d7bfcf66292635605104af195-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 02 09:05:34 2015 Received: (at 19909-done) by debbugs.gnu.org; 2 Mar 2015 14:05:35 +0000 Received: from localhost ([127.0.0.1]:33936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSQyU-0002nL-M7 for submit@debbugs.gnu.org; Mon, 02 Mar 2015 09:05:34 -0500 Received: from limerock02.mail.cornell.edu ([128.84.13.242]:57397) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YSQyT-0002n6-E6 for 19909-done@debbugs.gnu.org; Mon, 02 Mar 2015 09:05:33 -0500 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t22E5RID019276; Mon, 2 Mar 2015 09:05:27 -0500 Received: from [192.168.1.3] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t22E5Q5r027592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 2 Mar 2015 09:05:27 -0500 Message-ID: <54F46E34.1090502@cornell.edu> Date: Mon, 02 Mar 2015 09:05:40 -0500 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Robert Pluim Subject: Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> <83zj7yrntl.fsf@gnu.org> <83wq31syvm.fsf@gnu.org> <54F20C96.4020507@cornell.edu> <83vbilsvb5.fsf@gnu.org> <54F221B8.4050909@cornell.edu> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19909-done Cc: Eli Zaretskii , 19909-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 3/2/2015 4:35 AM, Robert Pluim wrote: > I'd prefer "Robert Pluim" but it's not a big deal. OK, I've pushed the change to the master branch and am closing the bug. > It does show that > there's a variable somewhere that I haven't set correctly though, since > that ChangeLog entry should never have said "rpluim" I think user-full-name is what you're looking for. Ken From unknown Tue Jun 17 20:20:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 31 Mar 2015 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator