GNU bug report logs - #19895
24.4; battery.el does not support /sys/class/power_supply/BATX

Previous Next

Full log

Message #8 received at 19895 <at> debbugs.gnu.org (full text, mbox):

From: Marcin Borkowski <mbork <at> mbork.pl>
To: Greg Farough <gregf <at> riseup.net>
Cc: 19895 <at> debbugs.gnu.org
Subject: Re: bug#19895: 24.4;
 battery.el does not support /sys/class/power_supply/BATX
Date: Mon, 21 Mar 2016 06:44:46 +0100

On 2015-02-18, at 09:53, Greg Farough <gregf <at> riseup.net> wrote:

> It seems that battery-linux-sysfs does not support certain laptop
> batteries which are not classified as BAT0, but by BATX instead. I had
> to add this to my .emacs to get display-battery-mode working properly:
>
> (eval-after-load 'battery
>   '(progn
>      (setq battery--linux-sysfs-regexp "[bB][aA][tT][xX]$")
>      (setq battery-status-function 'battery-linux-sysfs
>       battery-echo-area-format "Power %L, battery %B (%p%% charged, remaining time %t)"
>       battery-mode-line-format " [%p%%] ")))
> (display-battery-mode 1)
>
> Hope this helps, and thanks for all your hard work.
> -g

Hi,

thanks for your report.  IMHO, this suggests a simple patch, replacing

(defconst battery--linux-sysfs-regexp "[bB][aA][tT][0-9]?$")

with e.g.

(defconst battery--linux-sysfs-regexp "[bB][aA][tT][0-9X]?$")

in battery.el.  Could someone more knowledgeable about what sits in
/sys/class/power_supply/ confirm that this shouldn't break anything?
(On my laptop, the right directory is called BAT0, btw.)

Best,

-- 
Marcin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.