From unknown Sat Jun 21 03:26:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19890: [PATCH] Use after free in dld_link on error path Resent-From: Tobias Stoeckmann Original-Sender: "Debbugs-submit" Resent-CC: bug-libtool@gnu.org Resent-Date: Tue, 17 Feb 2015 21:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19890 X-GNU-PR-Package: libtool X-GNU-PR-Keywords: patch To: 19890@debbugs.gnu.org X-Debbugs-Original-To: bug-libtool@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14242093834254 (code B ref -1); Tue, 17 Feb 2015 21:44:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Feb 2015 21:43:03 +0000 Received: from localhost ([127.0.0.1]:46658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNpv4-00016Y-Pc for submit@debbugs.gnu.org; Tue, 17 Feb 2015 16:43:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58700) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNpv2-000162-TA for submit@debbugs.gnu.org; Tue, 17 Feb 2015 16:43:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNpuw-0002YC-PJ for submit@debbugs.gnu.org; Tue, 17 Feb 2015 16:42:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNpuw-0002Xy-ML for submit@debbugs.gnu.org; Tue, 17 Feb 2015 16:42:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNpuv-0001Gx-FT for bug-libtool@gnu.org; Tue, 17 Feb 2015 16:42:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNpur-0002Mk-Bx for bug-libtool@gnu.org; Tue, 17 Feb 2015 16:42:53 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:62374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNpur-0002IY-2H for bug-libtool@gnu.org; Tue, 17 Feb 2015 16:42:49 -0500 Received: from localhost ([79.227.31.112]) by mrelayeu.kundenserver.de (mreue001) with ESMTPSA (Nemesis) id 0MMb9i-1YUyW82xcE-008FzZ for ; Tue, 17 Feb 2015 22:42:46 +0100 Date: Tue, 17 Feb 2015 22:42:45 +0100 From: Tobias Stoeckmann Message-ID: <20150217214245.GA4684@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Provags-ID: V03:K0:z6sYvXoy8NZEKSfiLE5vgmsyILNBSLrcdiupHGWyZ4MNxpd/fF9 5yp6zNGWpriQSEA/wtkqfLJjyhOguztD83IrolgEq0H9Hk4D+2QsaCU7eyf0UyXLSmmIEl+ KPpQ1lwOkwscoYWiYxpAwiXlVNhCMSaNrF3PfJv5RC4CKTXBqgmiSvLevgKqx81rp2UPkKn L+vkehNjQOc7Q/ureUYCQ== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) When dld_link fails, the allocated memory for module (strdup) is freed, but still returned by vm_open. vm_open is called in ltdr.c line 444, which checks the error flag only if result is NULL. Therefore, the error condition of vm_open is ignored and the memory pointed to by module is used later on. While fixing this, also set error condition and return NULL if strdup is unable to allocate memory. --- libltdl/loaders/dld_link.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libltdl/loaders/dld_link.c b/libltdl/loaders/dld_link.c index a73880f..e95d5e4 100644 --- a/libltdl/loaders/dld_link.c +++ b/libltdl/loaders/dld_link.c @@ -111,11 +111,15 @@ vm_open (lt_user_data loader_data LT__UNUSED, const char *filename, lt_dladvise advise LT__UNUSED) { lt_module module = lt__strdup (filename); - - if (dld_link (filename) != 0) + if (module == NULL) + { + LT__SETERROR (NO_MEMORY); + } + else if (dld_link (filename) != 0) { LT__SETERROR (CANNOT_OPEN); FREE (module); + module = NULL; } return module; -- 2.3.0 From unknown Sat Jun 21 03:26:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19890: [PATCH] Check for strdup NULL return value References: <20150217214245.GA4684@localhost> In-Reply-To: <20150217214245.GA4684@localhost> Resent-From: Tobias Stoeckmann Original-Sender: "Debbugs-submit" Resent-CC: bug-libtool@gnu.org Resent-Date: Tue, 17 Feb 2015 22:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19890 X-GNU-PR-Package: libtool X-GNU-PR-Keywords: patch To: 19890@debbugs.gnu.org Received: via spool by 19890-submit@debbugs.gnu.org id=B19890.14242104095842 (code B ref 19890); Tue, 17 Feb 2015 22:01:01 +0000 Received: (at 19890) by debbugs.gnu.org; 17 Feb 2015 22:00:09 +0000 Received: from localhost ([127.0.0.1]:46672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNqBd-0001Vt-Am for submit@debbugs.gnu.org; Tue, 17 Feb 2015 17:00:09 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:53579) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNqBZ-0001Ut-JS for 19890@debbugs.gnu.org; Tue, 17 Feb 2015 17:00:06 -0500 Received: from localhost ([79.227.31.112]) by mrelayeu.kundenserver.de (mreue001) with ESMTPSA (Nemesis) id 0MU9x3-1XxCUm0MXB-00QneS for <19890@debbugs.gnu.org>; Tue, 17 Feb 2015 22:59:57 +0100 Date: Tue, 17 Feb 2015 22:59:55 +0100 From: Tobias Stoeckmann Message-ID: <20150217215955.GA7009@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Provags-ID: V03:K0:1WxeGFR87YePjWp3BL9pfuzUPdRTIrPrk8PaI/CwfZMzZDC/wzy cSdVpWjksXlZg8SA2e6NxlED7MbVaf1geNo2+ETIoBXOUdo6nKcGhZZNmF37dqIkuYZVdoE Imhjyr/Rui9tz2luUWv3dx4NTQZi//Ok0MiH7M/1K9KN6TYhwKVMPy5NLwbvQ0a29N4hBHa sWbeoPXfykS7ZAYnnReDQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) In contrast to previous mail, only check for strdup NULL value. The FREE macro properly sets module to NULL, therefore this one is the only issue left. --- Sorry for the previous noise. --- libltdl/loaders/dld_link.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libltdl/loaders/dld_link.c b/libltdl/loaders/dld_link.c index a73880f..54053ee 100644 --- a/libltdl/loaders/dld_link.c +++ b/libltdl/loaders/dld_link.c @@ -112,7 +112,11 @@ vm_open (lt_user_data loader_data LT__UNUSED, const char *filename, { lt_module module = lt__strdup (filename); - if (dld_link (filename) != 0) + if (module == NULL) + { + LT__SETERROR (NO_MEMORY); + } + else if (dld_link (filename) != 0) { LT__SETERROR (CANNOT_OPEN); FREE (module); -- 2.3.0 From unknown Sat Jun 21 03:26:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19890: [PATCH] Check for strdup NULL return value Resent-From: Pavel Raiskup Original-Sender: "Debbugs-submit" Resent-CC: bug-libtool@gnu.org Resent-Date: Fri, 12 Feb 2016 15:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19890 X-GNU-PR-Package: libtool X-GNU-PR-Keywords: patch To: 19890@debbugs.gnu.org Cc: tobias@stoeckmann.org X-Debbugs-Original-To: bug-libtool@gnu.org X-Debbugs-Original-Cc: Tobias Stoeckmann , 19890@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14552899979359 (code B ref -1); Fri, 12 Feb 2016 15:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Feb 2016 15:13:17 +0000 Received: from localhost ([127.0.0.1]:38094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aUFPJ-0002Qt-1v for submit@debbugs.gnu.org; Fri, 12 Feb 2016 10:13:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54965) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aUFPG-0002Qd-Ka for submit@debbugs.gnu.org; Fri, 12 Feb 2016 10:13:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUFPA-0002bQ-Oc for submit@debbugs.gnu.org; Fri, 12 Feb 2016 10:13:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUFPA-0002bL-MM for submit@debbugs.gnu.org; Fri, 12 Feb 2016 10:13:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUFP6-0007G9-Mg for bug-libtool@gnu.org; Fri, 12 Feb 2016 10:13:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUFP3-0002aL-G6 for bug-libtool@gnu.org; Fri, 12 Feb 2016 10:13:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUFP3-0002a5-A4 for bug-libtool@gnu.org; Fri, 12 Feb 2016 10:13:01 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 1302380504; Fri, 12 Feb 2016 15:13:00 +0000 (UTC) Received: from nb.usersys.redhat.com (ovpn-200-24.brq.redhat.com [10.40.200.24]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1CFCvdi013112 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 12 Feb 2016 10:12:59 -0500 From: Pavel Raiskup Date: Fri, 12 Feb 2016 16:12:57 +0100 Message-ID: <4911267.eoThH2gNvm@nb.usersys.redhat.com> User-Agent: KMail/4.14.10 (Linux/4.3.5-300.fc23.x86_64; KDE/4.14.16; x86_64; ; ) In-Reply-To: <20150217215955.GA7009@localhost> References: <20150217214245.GA4684@localhost> <20150217215955.GA7009@localhost> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Thanks for the report, Tobias. On Tuesday 17 of February 2015 22:59:55 Tobias Stoeckmann wrote: > - if (dld_link (filename) != 0) > + if (module == NULL) > + { > + LT__SETERROR (NO_MEMORY); > + } There is 'lt__alloc_die = lt__alloc_die_callback;' in ltdl.c (properly setting the lasterror). Can you verify that this patch is good enough? | libltdl: handle ENOMEM sooner | | * libltdl/loaders/dld_link.c (vm_open): Do not even try dld_link() | in case of ENOMEM. | | diff --git a/libltdl/loaders/dld_link.c b/libltdl/loaders/dld_link.c | index a73880f..0edf0df 100644 | --- a/libltdl/loaders/dld_link.c | +++ b/libltdl/loaders/dld_link.c | @@ -112,7 +112,7 @@ vm_open (lt_user_data loader_data LT__UNUSED, const char *filename, | { | lt_module module = lt__strdup (filename); | | - if (dld_link (filename) != 0) | + if (module && dld_link (filename) != 0) | { | LT__SETERROR (CANNOT_OPEN); | FREE (module); Pavel From unknown Sat Jun 21 03:26:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19890: [PATCH] Check for strdup NULL return value Resent-From: Tobias Stoeckmann Original-Sender: "Debbugs-submit" Resent-CC: bug-libtool@gnu.org Resent-Date: Fri, 12 Feb 2016 20:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19890 X-GNU-PR-Package: libtool X-GNU-PR-Keywords: patch To: Pavel Raiskup Cc: 19890@debbugs.gnu.org X-Debbugs-Original-Cc: bug-libtool@gnu.org, 19890@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.145530724621406 (code B ref -1); Fri, 12 Feb 2016 20:01:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Feb 2016 20:00:46 +0000 Received: from localhost ([127.0.0.1]:38256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aUJtW-0005ZB-7R for submit@debbugs.gnu.org; Fri, 12 Feb 2016 15:00:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48809) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aUJtU-0005Yz-3d for submit@debbugs.gnu.org; Fri, 12 Feb 2016 15:00:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUJtN-0007nK-TH for submit@debbugs.gnu.org; Fri, 12 Feb 2016 15:00:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41352) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUJtN-0007n0-Ml for submit@debbugs.gnu.org; Fri, 12 Feb 2016 15:00:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUJtM-0004Dl-Et for bug-libtool@gnu.org; Fri, 12 Feb 2016 15:00:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUJtJ-0007kq-7C for bug-libtool@gnu.org; Fri, 12 Feb 2016 15:00:36 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:60856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUJtI-0007kI-UJ for bug-libtool@gnu.org; Fri, 12 Feb 2016 15:00:33 -0500 Received: from localhost ([79.227.30.190]) by mrelayeu.kundenserver.de (mreue005) with ESMTPSA (Nemesis) id 0LiqBl-1ZsEFV3xyn-00cvrZ; Fri, 12 Feb 2016 21:00:21 +0100 Date: Fri, 12 Feb 2016 21:00:18 +0100 From: Tobias Stoeckmann Message-ID: <20160212200018.GA20905@pepper.home.stoeckmann.org> References: <20150217214245.GA4684@localhost> <20150217215955.GA7009@localhost> <4911267.eoThH2gNvm@nb.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4911267.eoThH2gNvm@nb.usersys.redhat.com> X-Provags-ID: V03:K0:mEpDaEb7Jt5uk3AEX1ReO5mJQ1IY2sGJD+snSNipZv/eo5GWSIr du1blboEETNy+lASFGfQ6rGdRwg6fQ1eKNu8xKFgegEYe4KqWgjj3wDpDzl9wUYavVE1cp+ /mAOGv2qwwkuhIAkQG+OpyqiCx3BP4SVnJlV0F4xWuJnNBeHokymQNXIKlMJogLhimeJBHN pUI3vW7noHfY3BFm8C1LQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Mdl9oCUKAog=:0OoikRAZ5KBSeyRXlFKFwT KQlby1Iop1ba+Iqqxs3pkUyIgKUE2UboCrkHb1vvlpOwze7b3ddESMcBTIVP2MQO+5aDil70n gIZSUgFxZ3E416Sdktyw11msi1aA6BLQXrnU23yz1NVUysSXejkq0xfHcHvFrEU0msOgc0mYK q9aeqV3s/BhfNeUPzT3X4z1u/CzwFweMknQ7cDz2nupqCtS+kr/keu1a7+oKJNAJf65gRQSCF wcV5OJz0YpwpLG6E4CLO7bQXSkyOQdMrVrs0CBHBSgAm2KgsJ6boYxQIxK971eoDyDTiFsJyN LcA/kjsl9ZgJ/BygueG7FBVt8F6F8akt1u794/L5G3Ehl+vB32nc4rhjRkrw6TH+ZJGZ995Gv HJe8eF19XQtB+qgf94itvOIu/FhAbHUMcziMzXkfH2w4N3SzqrGZptOwQsoH1b2e95SfbJv8f QCk1b0MzJ7gUQZkKD3vTjyvDjU8nwJOgFaxHFs+FuaJ3eGBkERhRLSgzoa9Se0w8e1L10JONh RXgdbxtZ1nczUwGESL9ImuHd2cB0i5AaFgl506FvZVv7g35adXPm9RLKZF+jiMGCalT+RN6nK V9aJfa093PjBbihlcG865VNiaef0nTu/2lyK/6ax9wWocLHTAFImPdFnjVw6c5pW02XFcWzAm n7B+xg4dos7IUp8wcpVYSCHjRTxHer3g0lI0aeYrST04xmqdv7pARdUlxSjdWlch05o8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On Fri, Feb 12, 2016 at 04:12:57PM +0100, Pavel Raiskup wrote: > There is 'lt__alloc_die = lt__alloc_die_callback;' in ltdl.c (properly > setting the lasterror). Can you verify that this patch is good enough? Yes, that looks reasonable to me. Thanks for pointing that out! Tobias From unknown Sat Jun 21 03:26:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19890: [PATCH] Check for strdup NULL return value Resent-From: Pavel Raiskup Original-Sender: "Debbugs-submit" Resent-CC: bug-libtool@gnu.org Resent-Date: Mon, 15 Feb 2016 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19890 X-GNU-PR-Package: libtool X-GNU-PR-Keywords: patch To: 19890@debbugs.gnu.org Cc: control@debbugs.gnu.org, tobias@stoeckmann.org X-Debbugs-Original-To: bug-libtool@gnu.org X-Debbugs-Original-Cc: control@debbugs.gnu.org, Tobias Stoeckmann , 19890@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.145554663327780 (code B ref -1); Mon, 15 Feb 2016 14:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Feb 2016 14:30:33 +0000 Received: from localhost ([127.0.0.1]:39545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVKAa-0007E0-Ps for submit@debbugs.gnu.org; Mon, 15 Feb 2016 09:30:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42386) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVKAY-0007DO-1V for submit@debbugs.gnu.org; Mon, 15 Feb 2016 09:30:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVKAS-0005r6-3O for submit@debbugs.gnu.org; Mon, 15 Feb 2016 09:30:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVKAS-0005r2-0F for submit@debbugs.gnu.org; Mon, 15 Feb 2016 09:30:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVKAR-0006bi-33 for bug-libtool@gnu.org; Mon, 15 Feb 2016 09:30:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVKAN-0005qE-US for bug-libtool@gnu.org; Mon, 15 Feb 2016 09:30:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVKAN-0005q9-On for bug-libtool@gnu.org; Mon, 15 Feb 2016 09:30:19 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 27C4AC0C2363; Mon, 15 Feb 2016 14:30:19 +0000 (UTC) Received: from nb.usersys.redhat.com (unused-4-210.brq.redhat.com [10.34.4.210]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1FEUHgd020814 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 15 Feb 2016 09:30:18 -0500 From: Pavel Raiskup Date: Mon, 15 Feb 2016 15:30:17 +0100 Message-ID: <4855559.G82F5mHScn@nb.usersys.redhat.com> User-Agent: KMail/4.14.10 (Linux/4.3.5-300.fc23.x86_64; KDE/4.14.16; x86_64; ; ) In-Reply-To: <20160212200018.GA20905@pepper.home.stoeckmann.org> References: <20150217214245.GA4684@localhost> <4911267.eoThH2gNvm@nb.usersys.redhat.com> <20160212200018.GA20905@pepper.home.stoeckmann.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) close 19890 libtool-2.4.6.25 thanks On Friday 12 of February 2016 21:00:18 Tobias Stoeckmann wrote: > On Fri, Feb 12, 2016 at 04:12:57PM +0100, Pavel Raiskup wrote: > > There is 'lt__alloc_die = lt__alloc_die_callback;' in ltdl.c (properly > > setting the lasterror). Can you verify that this patch is good enough? > > Yes, that looks reasonable to me. Thanks for pointing that out! Pushed as b5d44b844703. Pavel From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 15 09:33:58 2016 Received: (at control) by debbugs.gnu.org; 15 Feb 2016 14:33:58 +0000 Received: from localhost ([127.0.0.1]:39555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVKDu-0007JX-9a for submit@debbugs.gnu.org; Mon, 15 Feb 2016 09:33:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53359) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVKDt-0007JN-6r for control@debbugs.gnu.org; Mon, 15 Feb 2016 09:33:57 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id C5E76804EC for ; Mon, 15 Feb 2016 14:33:56 +0000 (UTC) Received: from nb.usersys.redhat.com (unused-4-210.brq.redhat.com [10.34.4.210]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1FEXtJX023405 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 15 Feb 2016 09:33:56 -0500 From: Pavel Raiskup To: control@debbugs.gnu.org Subject: Re: bug#19890: [PATCH] Check for strdup NULL return value Date: Mon, 15 Feb 2016 15:33:54 +0100 Message-ID: <2584493.FWJLnufBNV@nb.usersys.redhat.com> User-Agent: KMail/4.14.10 (Linux/4.3.5-300.fc23.x86_64; KDE/4.14.16; x86_64; ; ) In-Reply-To: <20160212200018.GA20905@pepper.home.stoeckmann.org> References: <20150217214245.GA4684@localhost> <4911267.eoThH2gNvm@nb.usersys.redhat.com> <20160212200018.GA20905@pepper.home.stoeckmann.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) close 19890 2.4.6.25 thanks On Friday 12 of February 2016 21:00:18 Tobias Stoeckmann wrote: > On Fri, Feb 12, 2016 at 04:12:57PM +0100, Pavel Raiskup wrote: > > There is 'lt__alloc_die = lt__alloc_die_callback;' in ltdl.c (properly > > setting the lasterror). Can you verify that this patch is good enough? > > Yes, that looks reasonable to me. Thanks for pointing that out! Pushed as b5d44b844703. Pavel