GNU bug report logs - #19883
Smob's mark_smob has become unreliable in Guile 2.x

Previous Next

Full log

Message #74 received at 19883 <at> debbugs.gnu.org (full text, mbox):

From: Artyom Poptsov <poptsov.artyom <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 19883 <at> debbugs.gnu.org, guile-devel <guile-devel <at> gnu.org>
Subject: Re: The “finalized” SMOB type
Date: Sun, 09 Oct 2016 10:51:25 +0300

[Message part 1 (text/plain, inline)]

Hello Ludovic,

thanks for pointing that out.  IIRC, I saw this kind of errors during
testing but I thought I fixed them.  What Guile-SSH version do you use?

Here's 'free_session' procedure from Guile-SSH version 0.10.0:

--8<---------------cut here---------------start------------->8---
size_t
free_session (SCM session_smob)
{
  if (! SCM_SMOB_PREDICATE (session_tag, session_smob))
    {
      _ssh_log (SSH_LOG_FUNCTIONS, "free_session", "%s", "already freed");
      return 0;
    }
  struct session_data *data = _scm_to_session_data (session_smob);

  [...]

  return 0;
}
--8<---------------cut here---------------end--------------->8---

As you can see, there's additional smob check before accessing the
smob's data.

Please let me know if the problem manifest itself in the latest
Guile-SSH version.

Thanks!

- Artyom

-- 
Artyom V. Poptsov <poptsov.artyom <at> gmail.com>;  GPG Key: 0898A02F
Home page: http://poptsov-artyom.narod.ru/

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.