GNU bug report logs - #19875
25.0.50; Setting an input-method-function breaks prefix show on the echo area

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19875 in the body.
You can then email your comments to 19875 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: oscarfv <at> telefonica.net (Óscar Fuentes)
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50;
 Setting an input-method-function breaks prefix show on the echo area
Date: Sun, 15 Feb 2015 18:04:16 +0100

emacs -Q
M-x set-input-method ENTER spanish-prefix ENTER

Now let's suppose that we want to execute a command with a numeric
prefix (say 42). Let's press C-u and wait until it is displayed on the
echo area, then press `4' and wait, then press `2' and wait until it
is displayed too. The echo area shows:

C-u C-u 4 C-u 4 2

The problem is not limited to `set-input-method'. I discovered it with
key-chord-mode. I also have echo-keystrokes set to a low value, which
makes the problem more jarring.



In GNU Emacs 25.0.50.5 (x86_64-unknown-linux-gnu, X toolkit)
 of 2015-01-03 on qcore
Repository revision: 11ee7d8bf16b8ee4fcb3659e4b09686ed8b10590
Windowing system distributor `The X.Org Foundation', version 11.0.11600000
System Description:	Ubuntu 14.10

Configured using:
 `configure --without-toolkit-scroll-bars --with-x-toolkit=lucid'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY LIBXML2 FREETYPE XFT
ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Message #8 received at 19875 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: oscarfv <at> telefonica.net (Óscar Fuentes)
Cc: 19875 <at> debbugs.gnu.org
Subject: Re: bug#19875: 25.0.50;
 Setting an input-method-function breaks prefix show on the echo area
Date: Sun, 15 Feb 2015 19:30:45 +0200

> From: oscarfv <at> telefonica.net (Óscar Fuentes)
> Date: Sun, 15 Feb 2015 18:04:16 +0100
> 
> 
> emacs -Q
> M-x set-input-method ENTER spanish-prefix ENTER
> 
> Now let's suppose that we want to execute a command with a numeric
> prefix (say 42). Let's press C-u and wait until it is displayed on the
> echo area, then press `4' and wait, then press `2' and wait until it
> is displayed too. The echo area shows:
> 
> C-u C-u 4 C-u 4 2

This happens on the release branch, and in Emacs 24.4 as well.

Message #11 received at 19875 <at> debbugs.gnu.org (full text, mbox):

From: oscarfv <at> telefonica.net (Óscar Fuentes)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 19875 <at> debbugs.gnu.org
Subject: Re: bug#19875: 25.0.50;
 Setting an input-method-function breaks prefix show on the echo area
Date: Sun, 15 Feb 2015 19:03:56 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> This happens on the release branch, and in Emacs 24.4 as well.

The relevant area of code in keyboard.c is very old. The bug probably
has more than 15 years.

Semi-blind fix attempt:

diff --git a/src/keyboard.c b/src/keyboard.c
index bcb51cf..8b65f0e 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -3095,7 +3095,15 @@ read_char (int commandflag, Lisp_Object map,
 
       cancel_echoing ();
       ok_to_echo_at_next_pause = saved_ok_to_echo;
-      kset_echo_string (current_kboard, saved_echo_string);
+      /* Do not restore the echo area string if the user is
+         introducing a prefix argument. Otherwise we end with
+         repetitions of the partially introduced prefix
+         argument. (bug#19875) */
+      Lisp_Object pa = intern ("prefix-arg");
+      if (NILP(pa))
+        {
+          kset_echo_string (current_kboard, saved_echo_string);
+        }
       current_kboard->echo_after_prompt = saved_echo_after_prompt;
       if (saved_immediate_echo)
 	echo_now ();

Message #16 received at 19875-done <at> debbugs.gnu.org (full text, mbox):

From: oscarfv <at> telefonica.net (Óscar Fuentes)
To: 19875-done <at> debbugs.gnu.org
Subject: Re: bug#19875: 25.0.50;
 Setting an input-method-function breaks prefix show on the echo area
Date: Wed, 18 Feb 2015 05:16:28 +0100

Fixed on 81d89d88aef5de720e7fbeecbfb295d6eaf6fd37

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.