GNU bug report logs - #19865
tar-untar-buffer: should honor default-directory

Previous Next

Package: emacs;

Reported by: Ivan Shmakov <ivan <at> siamics.net>

Date: Sat, 14 Feb 2015 11:32:01 UTC

Severity: minor

Tags: fixed, patch

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Ivan Shmakov <ivan <at> siamics.net>
To: 19865 <at> debbugs.gnu.org
Subject: bug#19865: tar-untar-buffer: should honor default-directory 
Date: Mon, 16 Feb 2015 08:55:14 +0000

>>>>> Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

 >> PS.  Should the pending objections be resolved by sometime around
 >> 18:00 UTC today, I’d happily push the change to ‘master’.

 > Most of the change (tho not the removal of set-buffer-multibyte)
 > probably belongs in emacs-24 rather than in master.

	I certainly could push it to the stable branch, but as for
	actually /testing/ it there – that’d double the work for me
	(as I do not currently follow emacs-24 development.)

 >> +    (with-current-buffer data-buf
 >> +      (cl-assert (not enable-multibyte-characters)))

 > Why not move this further down where you already do the
 > "(with-current-buffer data-buf"?

	My only concern is that that latter with-current-buffer happens
	within a loop, and I don’t seem to see a reason for checking
	this condition for every archive member extracted.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A
This bug report was last modified 5 years and 331 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.