GNU bug report logs - #19865
tar-untar-buffer: should honor default-directory

Previous Next

Full log

Message #14 received at 19865 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 19865 <at> debbugs.gnu.org
Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory
Date: Sat, 14 Feb 2015 14:40:44 +0200

> From: Ivan Shmakov <ivan <at> siamics.net>
> Date: Sat, 14 Feb 2015 12:27:45 +0000
> 
> >>>>> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> […]
> 
>  > The doc string of tar-untar-buffer says:
> 
>  >   "Extract all archive members in the tar-file into the current
>  > directory."
> 
>  > which seems to match what it does.  Why isn't default-directory of
>  > tar-data-buffer the right choice for doing that?
> 
> 	Because the default-directory of the tar-mode buffer may be
> 	changed by the user (with M-x cd or otherwise) with the intent
> 	of directing tar-untar-buffer to extract the archive members
> 	into an arbitrary directory, per its docstring.

Sounds like an obscure possibility to me.  If we want to give the user
an option to extract to a specific directory, why not make that
directory an argument of tar-untar-buffer, and prompt for it when the
function is called with a prefix argument?  That's how we usually let
the user change such defaults.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.