GNU bug report logs - #19865
tar-untar-buffer: should honor default-directory

Previous Next

Full log

View this message in rfc822 format

From: Ivan Shmakov <ivan <at> siamics.net>
To: 19865 <at> debbugs.gnu.org
Subject: bug#19865: tar-untar-buffer: should honor default-directory 
Date: Sat, 14 Feb 2015 12:27:45 +0000

>>>>> Eli Zaretskii <eliz <at> gnu.org> writes:

[…]

 > The doc string of tar-untar-buffer says:

 >   "Extract all archive members in the tar-file into the current
 > directory."

 > which seems to match what it does.  Why isn't default-directory of
 > tar-data-buffer the right choice for doing that?

	Because the default-directory of the tar-mode buffer may be
	changed by the user (with M-x cd or otherwise) with the intent
	of directing tar-untar-buffer to extract the archive members
	into an arbitrary directory, per its docstring.

	Which fails, as the tar-data-buffer’s value for that same
	variable doesn’t get changed at that point.

	Another solution is to wrap with-current-buffer just around
	write-region, so that the rest of the code will still be
	evaluated with the tar-mode buffer being current.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.