From unknown Fri Jun 20 07:14:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19865 <19865@debbugs.gnu.org> To: bug#19865 <19865@debbugs.gnu.org> Subject: Status: tar-untar-buffer: should honor default-directory Reply-To: bug#19865 <19865@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:14:45 +0000 retitle 19865 tar-untar-buffer: should honor default-directory=20 reassign 19865 emacs submitter 19865 Ivan Shmakov severity 19865 minor tag 19865 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 06:31:23 2015 Received: (at submit) by debbugs.gnu.org; 14 Feb 2015 11:31:23 +0000 Received: from localhost ([127.0.0.1]:42736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMawV-0003G8-9m for submit@debbugs.gnu.org; Sat, 14 Feb 2015 06:31:23 -0500 Received: from fely.am-1.org ([78.47.74.50]:43729) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMawT-0003G1-QB for submit@debbugs.gnu.org; Sat, 14 Feb 2015 06:31:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=59TCgIvZhqPxelFmp/TSFH/Yn4Zt039eVW+V4TF5c4c=; b=QDDbAZZxjRBeJ3Jmo7SVpfZDpRcR2MxxHZVnfDHQV+eNh910HRXFQX3FjSs8wYX+y3xtH7Dq6tTCK0L60L9t7i5WzcX0munxaSqQDEPo211RBN9G8EfuldI8YUomtKnuvtpy8Px9SJtIJEvUb5E68UDSWA6Y1tmuDdVligIMMmI=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMawR-0001Hc-KB for submit@debbugs.gnu.org; Sat, 14 Feb 2015 11:31:19 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMawL-0001eh-0T for submit@debbugs.gnu.org; Sat, 14 Feb 2015 18:31:13 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: tar-untar-buffer: should honor default-directory Date: Sat, 14 Feb 2015 11:31:12 +0000 Message-ID: <87a90gd91b.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Severity: minor Tags: patch As currently implemented (tested on 7eb2077f9dd1, 2015-02-06 15:01:12 UTC), tar-untar-buffer uses the default-directory value for the =E2=80=9Cdata=E2=80=9D buffer (see tar-data-buffer), instead of the (arguably much less obscure) one for the tar-mode buffer itself (which could easily be changed by the user via M-x cd.) A possible fix is to remember the default-directory value in the same =E2=80=98let=E2=80=99 form used to do so for tar-parse-info, along the lines of the patch MIMEd. --=20 FSF associate member #7257 np. A World Behind the World =E2=80=94 Jami Sie= ber --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/tar-mode.el +++ b/lisp/tar-mode.el @@ -531,6 +542,7 @@ defun tar-untar-buffer () (interactive) ;; FIXME: make it work even if we're not in tar-mode. - (let ((descriptors tar-parse-info)) ;Read the var in its buffer. + (let ((descriptors tar-parse-info) ; Read the var in its buffer. + (dest-dir default-directory)) (with-current-buffer (if (tar-data-swapped-p) tar-data-buffer (current-buffer)) (set-buffer-multibyte nil) ;Hopefully, a no-op. @@ -544,5 +564,6 @@ defun tar-untar-buffer () (dir (if (eq (tar-header-link-type descriptor) 5) name (file-name-directory name))) + (default-directory dest-dir) (start (tar-header-data-start descriptor)) (end (+ start (tar-header-size descriptor)))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 07:16:11 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 12:16:11 +0000 Received: from localhost ([127.0.0.1]:42758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMbdq-0004Iq-Sk for submit@debbugs.gnu.org; Sat, 14 Feb 2015 07:16:11 -0500 Received: from mtaout28.012.net.il ([80.179.55.184]:46327) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMbdp-0004Ic-4H for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 07:16:10 -0500 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NJR00O00GBW5000@mtaout28.012.net.il> for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 14:14:22 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJR00NBJGNYV410@mtaout28.012.net.il>; Sat, 14 Feb 2015 14:14:22 +0200 (IST) Date: Sat, 14 Feb 2015 14:16:03 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: <87a90gd91b.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <834mqoy9h8.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <87a90gd91b.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Sat, 14 Feb 2015 11:31:12 +0000 > > As currently implemented (tested on 7eb2077f9dd1, 2015-02-06 > 15:01:12 UTC), tar-untar-buffer uses the default-directory value > for the “data” buffer (see tar-data-buffer), instead of the > (arguably much less obscure) one for the tar-mode buffer itself > (which could easily be changed by the user via M-x cd.) Sorry, I don't understand the implications of the change, or even the problem. Could you elaborate? The doc string of tar-untar-buffer says: "Extract all archive members in the tar-file into the current directory." which seems to match what it does. Why isn't default-directory of tar-data-buffer the right choice for doing that? From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 07:27:57 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 12:27:57 +0000 Received: from localhost ([127.0.0.1]:42762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMbpF-0004Z6-1I for submit@debbugs.gnu.org; Sat, 14 Feb 2015 07:27:57 -0500 Received: from fely.am-1.org ([78.47.74.50]:43751) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMbpC-0004Yw-O5 for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 07:27:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=4LWkKcBj+rLOkYMH2dx2Pqa+adQUYoX7kLqB7d1S4ho=; b=OwSjFlbU0PHPO8vsRMwwp35l+7c91YT7s6xj3afvEptqJ1dinGOrjiUxAyqKl71HDztyy4dR3mrvNUvnyBORSR21sc4OOHudstLdEn2qtqEGs1F3jp3gHVHPPOj95LIsxeJYt0RC5ikLgGLp7marMLIJXO0N3NTFQ7+IIZm5OvU=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMbpA-0001hI-G2 for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 12:27:52 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMbp3-0001m3-Sj for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 19:27:45 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <834mqoy9h8.fsf@gnu.org> Mail-Followup-To: 19865@debbugs.gnu.org Date: Sat, 14 Feb 2015 12:27:45 +0000 In-Reply-To: <834mqoy9h8.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Feb 2015 14:16:03 +0200") Message-ID: <8761b4d6f2.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: [=E2=80=A6] > The doc string of tar-untar-buffer says: > "Extract all archive members in the tar-file into the current > directory." > which seems to match what it does. Why isn't default-directory of > tar-data-buffer the right choice for doing that? Because the default-directory of the tar-mode buffer may be changed by the user (with M-x cd or otherwise) with the intent of directing tar-untar-buffer to extract the archive members into an arbitrary directory, per its docstring. Which fails, as the tar-data-buffer=E2=80=99s value for that same variable doesn=E2=80=99t get changed at that point. Another solution is to wrap with-current-buffer just around write-region, so that the rest of the code will still be evaluated with the tar-mode buffer being current. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 07:41:01 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 12:41:01 +0000 Received: from localhost ([127.0.0.1]:42771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMc1s-0006Fb-EI for submit@debbugs.gnu.org; Sat, 14 Feb 2015 07:41:00 -0500 Received: from mtaout27.012.net.il ([80.179.55.183]:54143) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMc1q-0006FO-41 for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 07:40:59 -0500 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NJR00C00HK63900@mtaout27.012.net.il> for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 14:35:01 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJR00B9XHMDYF00@mtaout27.012.net.il>; Sat, 14 Feb 2015 14:35:01 +0200 (IST) Date: Sat, 14 Feb 2015 14:40:44 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: <8761b4d6f2.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <831tlsy8c3.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <87a90gd91b.fsf@violet.siamics.net> <834mqoy9h8.fsf@gnu.org> <8761b4d6f2.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Sat, 14 Feb 2015 12:27:45 +0000 > > >>>>> Eli Zaretskii writes: > > […] > > > The doc string of tar-untar-buffer says: > > > "Extract all archive members in the tar-file into the current > > directory." > > > which seems to match what it does. Why isn't default-directory of > > tar-data-buffer the right choice for doing that? > > Because the default-directory of the tar-mode buffer may be > changed by the user (with M-x cd or otherwise) with the intent > of directing tar-untar-buffer to extract the archive members > into an arbitrary directory, per its docstring. Sounds like an obscure possibility to me. If we want to give the user an option to extract to a specific directory, why not make that directory an argument of tar-untar-buffer, and prompt for it when the function is called with a prefix argument? That's how we usually let the user change such defaults. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 07:48:00 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 12:48:00 +0000 Received: from localhost ([127.0.0.1]:42775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMc8d-0006PV-GQ for submit@debbugs.gnu.org; Sat, 14 Feb 2015 07:47:59 -0500 Received: from fely.am-1.org ([78.47.74.50]:43755) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMc8a-0006PM-RK for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 07:47:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=ViR+bXngh61fcpsuIkIzwmT93hTIWRE6PkGqckWUjjs=; b=b8wHaGd87fbc3n2pm7LQBKmCRxygmXeMrhXXNaUtj2yJnxYaFuas1di2TkJVGqmTIVQDf90IWcNnL7Vmi08XBXWgAH3JYLS9Si58AZOLqM5wI9OM7in3r0bnwnPg1PSbXCz3wH0J0GTZ3y8UCXRAYTe6KKI1vbHJ5Qv433FSxNc=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMc8a-0001qh-1r for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 12:47:56 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMc8T-0001qR-Bl for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 19:47:49 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <834mqoy9h8.fsf@gnu.org> <8761b4d6f2.fsf@violet.siamics.net> <831tlsy8c3.fsf@gnu.org> Mail-Followup-To: 19865@debbugs.gnu.org Date: Sat, 14 Feb 2015 12:47:48 +0000 In-Reply-To: <831tlsy8c3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Feb 2015 14:40:44 +0200") Message-ID: <871tlsd5hn.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Sat, 14 Feb 2015 12:27:45 +0000 >>>>> Eli Zaretskii writes: [=E2=80=A6] >>> "Extract all archive members in the tar-file into the current >>> directory." >>> which seems to match what it does. Why isn't default-directory of >>> tar-data-buffer the right choice for doing that? >> Because the default-directory of the tar-mode buffer may be changed >> by the user (with M-x cd or otherwise) with the intent of directing >> tar-untar-buffer to extract the archive members into an arbitrary >> directory, per its docstring. > Sounds like an obscure possibility to me. If we want to give the > user an option to extract to a specific directory, why not make that > directory an argument of tar-untar-buffer, and prompt for it when the > function is called with a prefix argument? That's how we usually let > the user change such defaults. No objection against such a new feature on my part. Still, the docstring mentions =E2=80=9Ccurrent directory=E2=80=9D, and it= =E2=80=99s exactly the thing default-directory references and M-x cd sets. Thus the current behavior doesn=E2=80=99t match the documentation, so at least one of the two=E2=80=99s in the need for a fix. --=20 FSF associate member #7257 np. El Dorado =E2=80=94 Iron Maiden =E2=80=A6 3= 013 B6A0 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 08:22:31 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 13:22:31 +0000 Received: from localhost ([127.0.0.1]:42806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMcg2-0007Cb-T5 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 08:22:31 -0500 Received: from mtaout28.012.net.il ([80.179.55.184]:44719) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMcg1-0007CL-4K for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 08:22:30 -0500 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NJR00D00JNQKQ00@mtaout28.012.net.il> for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 15:20:42 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJR00CBDJQI8710@mtaout28.012.net.il>; Sat, 14 Feb 2015 15:20:42 +0200 (IST) Date: Sat, 14 Feb 2015 15:22:23 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: <871tlsd5hn.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <83y4o0wru8.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <87a90gd91b.fsf@violet.siamics.net> <834mqoy9h8.fsf@gnu.org> <8761b4d6f2.fsf@violet.siamics.net> <831tlsy8c3.fsf@gnu.org> <871tlsd5hn.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Sat, 14 Feb 2015 12:47:48 +0000 > > Still, the docstring mentions “current directory”, and it’s > exactly the thing default-directory references and M-x cd sets. > Thus the current behavior doesn’t match the documentation It does if you don't use "M-x cd". From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 08:34:36 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 13:34:36 +0000 Received: from localhost ([127.0.0.1]:42814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMcrj-0007Tw-Hu for submit@debbugs.gnu.org; Sat, 14 Feb 2015 08:34:35 -0500 Received: from fely.am-1.org ([78.47.74.50]:43771) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMcrh-0007Tn-37 for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 08:34:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=Ci8GwPm+RdXcVqoX5XlSDasYxpsveDVLnLfYbkD6PM8=; b=IViy9trktESwIXO3LMsPIz+vHVPssFXTbusC/xXzdrdUEEr9BNw3Pg+Orx1w65aIMpAWPywQJIAkS7wf2KyL/czBW8vOodRQU60HrA1pnAlJ9i3S24sguezv3FuR1ggPxUArZi2VJ0FO5/zjU7LLYYTq1nO/K1HWPNQDeYiM/2E=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMcre-0002Cs-RA for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 13:34:30 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMcrV-00023z-T8 for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 20:34:21 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <834mqoy9h8.fsf@gnu.org> <8761b4d6f2.fsf@violet.siamics.net> <831tlsy8c3.fsf@gnu.org> <871tlsd5hn.fsf@violet.siamics.net> <83y4o0wru8.fsf@gnu.org> Mail-Followup-To: 19865@debbugs.gnu.org Date: Sat, 14 Feb 2015 13:34:21 +0000 In-Reply-To: <83y4o0wru8.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Feb 2015 15:22:23 +0200") Message-ID: <87wq3kborm.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Sat, 14 Feb 2015 12:47:48 +0000 >> Still, the docstring mentions =E2=80=9Ccurrent directory=E2=80=9D, and = it=E2=80=99s exactly >> the thing default-directory references and M-x cd sets. Thus the >> current behavior doesn=E2=80=99t match the documentation > It does if you don't use "M-x cd". It doesn=E2=80=99t if you C-x C-w into a file in a different directory. Or is your point that tar-mode buffer=E2=80=99s default-directory should /not/ be honored, unless under some specific circumstances (as in: for a just loaded .tar file)? --=20 FSF associate member #7257 np. Starblind =E2=80=94 Iron Maiden =E2=80=A6 3= 013 B6A0 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 09:50:05 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 14:50:05 +0000 Received: from localhost ([127.0.0.1]:42827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMe2n-0000hN-20 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 09:50:05 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:34986) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMe2j-0000gs-3m for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 09:50:02 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t1EEnuSx002918; Sat, 14 Feb 2015 09:49:56 -0500 Received: by pastel.home (Postfix, from userid 20848) id 03BDF1179; Sat, 14 Feb 2015 09:49:50 -0500 (EST) From: Stefan Monnier To: Ivan Shmakov Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory Message-ID: References: <87a90gd91b.fsf@violet.siamics.net> Date: Sat, 14 Feb 2015 09:49:50 -0500 In-Reply-To: <87a90gd91b.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 14 Feb 2015 11:31:12 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5217=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5217> : inlines <2181> : streams <1390144> : uri <1855189> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > As currently implemented (tested on 7eb2077f9dd1, 2015-02-06 > 15:01:12 UTC), tar-untar-buffer uses the default-directory value > for the =E2=80=9Cdata=E2=80=9D buffer (see tar-data-buffer), instead of = the > (arguably much less obscure) one for the tar-mode buffer itself > (which could easily be changed by the user via M-x cd.) I agre with Eli that it's a somewhat obscure corner case, but as someone who does `M-x cd' fairly often for similar purposes, I think the patch is right. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 09:56:37 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 14:56:37 +0000 Received: from localhost ([127.0.0.1]:43912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMe97-00016R-6Y for submit@debbugs.gnu.org; Sat, 14 Feb 2015 09:56:37 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:53526) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMe92-00016L-TV for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 09:56:34 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NJR00M00O2K7200@a-mtaout22.012.net.il> for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 16:56:26 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJR00M5LO603240@a-mtaout22.012.net.il>; Sat, 14 Feb 2015 16:56:26 +0200 (IST) Date: Sat, 14 Feb 2015 16:56:25 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: <87wq3kborm.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <83vbj4wnhi.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <87a90gd91b.fsf@violet.siamics.net> <834mqoy9h8.fsf@gnu.org> <8761b4d6f2.fsf@violet.siamics.net> <831tlsy8c3.fsf@gnu.org> <871tlsd5hn.fsf@violet.siamics.net> <83y4o0wru8.fsf@gnu.org> <87wq3kborm.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Sat, 14 Feb 2015 13:34:21 +0000 > > >>>>> Eli Zaretskii writes: > >>>>> From: Ivan Shmakov Date: Sat, 14 Feb 2015 12:47:48 +0000 > > >> Still, the docstring mentions “current directory”, and it’s exactly > >> the thing default-directory references and M-x cd sets. Thus the > >> current behavior doesn’t match the documentation > > > It does if you don't use "M-x cd". > > It doesn’t if you C-x C-w into a file in a different directory. > > Or is your point that tar-mode buffer’s default-directory should > /not/ be honored, unless under some specific circumstances > (as in: for a just loaded .tar file)? My point is that there is no reason to cater to such user behavior. I agree that there should be a way for the user to extract into a directory of her choice, but the way to give that capability is to let the user explicitly request a non-default directory. Once we have that capability, any user who complains about the issue you wanted to fix can be told "just invoke the function with an argument". From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 10:01:46 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 15:01:46 +0000 Received: from localhost ([127.0.0.1]:43920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMeE5-0001EH-IH for submit@debbugs.gnu.org; Sat, 14 Feb 2015 10:01:45 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:54378) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMeE2-0001E0-FR for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 10:01:43 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NJR00M00O2K7200@a-mtaout22.012.net.il> for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 17:01:36 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJR00MGZOEJ3250@a-mtaout22.012.net.il>; Sat, 14 Feb 2015 17:01:32 +0200 (IST) Date: Sat, 14 Feb 2015 17:01:32 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83sie8wn8z.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <87a90gd91b.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org, ivan@siamics.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Date: Sat, 14 Feb 2015 09:49:50 -0500 > Cc: 19865@debbugs.gnu.org > > > As currently implemented (tested on 7eb2077f9dd1, 2015-02-06 > > 15:01:12 UTC), tar-untar-buffer uses the default-directory value > > for the “data” buffer (see tar-data-buffer), instead of the > > (arguably much less obscure) one for the tar-mode buffer itself > > (which could easily be changed by the user via M-x cd.) > > I agre with Eli that it's a somewhat obscure corner case, but as someone > who does `M-x cd' fairly often for similar purposes, I think the patch > is right. So we now need someone third to resolve the tie. Any opinions out there? From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 10:07:23 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 15:07:23 +0000 Received: from localhost ([127.0.0.1]:43924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMeJX-0001M4-03 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 10:07:23 -0500 Received: from fely.am-1.org ([78.47.74.50]:43801) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMeJU-0001Lv-N0 for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 10:07:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=1a2dyXcY3upv+8CXsqryXFu0CTO5M6rNtI+bC848ps8=; b=VWqafdXStkFAWPqH0P5a4Yo5Rj7FP4RJKGQFiHw6yQryWLpGllipwDeIrZPJ3OzimEVLKyk40+D6KKKLmU2+vDethS7fRn3ZMrP/VPcqcNWm+GlQaubKD2sD/UHW9aC5DwGTN0QUzzjXwU9+2rVGL9xtZlZTWFPiMr6ft95pyLQ=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMeJT-0002wy-CN for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 15:07:19 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMeJM-0002Ik-Kp for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 22:07:12 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> Mail-Followup-To: 19865@debbugs.gnu.org Date: Sat, 14 Feb 2015 15:07:12 +0000 In-Reply-To: (Stefan Monnier's message of "Sat, 14 Feb 2015 09:49:50 -0500") Message-ID: <87oaowbkgv.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Stefan Monnier writes: >> As currently implemented (tested on 7eb2077f9dd1, 2015-02-06 >> 15:01:12 UTC), tar-untar-buffer uses the default-directory value for >> the =E2=80=9Cdata=E2=80=9D buffer (see tar-data-buffer), instead of the= (arguably >> much less obscure) one for the tar-mode buffer itself (which could >> easily be changed by the user via M-x cd.) > I agree with Eli that it's a somewhat obscure corner case, (Which makes me wonder if using write-file on a tar-mode buffer a similarly obscure corner case?) > but as someone who does `M-x cd' fairly often for similar purposes, I > think the patch is right. Avoiding switching buffers until around the actual write-region call may still be a better alternative (as that should make mistakes of this kind hardier to introduce), but results in a lengthier patch. Any opinion on which way I should go there? Unless there be objections, I hope to push a fix for this issue within the next two days. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 10:16:12 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 15:16:12 +0000 Received: from localhost ([127.0.0.1]:43941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMeS4-0001Yg-10 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 10:16:12 -0500 Received: from fely.am-1.org ([78.47.74.50]:43806) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMeS1-0001YQ-8V for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 10:16:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=Vx6WGic/DAaAF408LSSOyC3h47fPZLrsro+mOxJNkOs=; b=WdMAcVayRgrRdUJpdFV0H+fKsdnN1gdB/HmSkISIjCNu8wF1GVDhJeF+VUdwcCml0CxP1/vb+BIWdcTc/2yFbEXLlywigj05eYsYpiPyfAqwtjdkbvSg8cPcRGywLoZ73/6nKvAhuJ5+fw86Ghk9F55P70NFpcaJQijZXO2EuZc=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMeS0-000315-HN for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 15:16:08 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMeRt-0002Kc-R9 for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 22:16:01 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <834mqoy9h8.fsf@gnu.org> <8761b4d6f2.fsf@violet.siamics.net> <831tlsy8c3.fsf@gnu.org> <871tlsd5hn.fsf@violet.siamics.net> <83y4o0wru8.fsf@gnu.org> <87wq3kborm.fsf@violet.siamics.net> <83vbj4wnhi.fsf@gnu.org> Mail-Followup-To: 19865@debbugs.gnu.org Date: Sat, 14 Feb 2015 15:16:01 +0000 In-Reply-To: <83vbj4wnhi.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Feb 2015 16:56:25 +0200") Message-ID: <87k2zkbk26.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Sat, 14 Feb 2015 13:34:21 +0000 [=E2=80=A6] >> It doesn=E2=80=99t if you C-x C-w into a file in a different directory. >> Or is your point that tar-mode buffer=E2=80=99s default-directory should >> /not/ be honored, unless under some specific circumstances (as in: >> for a just loaded .tar file)? > My point is that there is no reason to cater to such user behavior. That is: to the possible use of C-x C-w to save the (possibly modified) Tar archive to a new file in some arbitrary directory? Also to note is that thanks to the tar-new-entry command, it=E2=80=99s possible to create .tar archives entirely in Emacs. Consider: C-x b *new* RET M-x tar-mode RET C-x C-q I newfile RET RET Hello, world! C-x C-s C-x b *new* RET C-x C-w /where/my/tar/files/are.tar RET Now, where do you think M-x tar-untar-buffer RET would unpack this newly created archive? [=E2=80=A6] --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 10:57:49 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 15:57:49 +0000 Received: from localhost ([127.0.0.1]:43964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMf6K-0002V5-R5 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 10:57:49 -0500 Received: from fely.am-1.org ([78.47.74.50]:43808) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMf6H-0002Uv-Pz for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 10:57:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=UOgg57V0i8LmpUTNWiCDSjVBnuN+1AY7AvpYWZP/JiY=; b=SdfJafWYCUl6MmW9cFAiYLghI53J4on4T+OLUPrm9gmiuGXMCAF7QICyNPzk8q2WuIL7tJUkU0tKAAXt8OSK2IpVaJQ/Igcq6A31H2pK5NduQOXscvPyaD1HgNIY0L0QWbFv0mR73k8UJutTOnijkauV2FnqofW5JDEPLMvy9fM=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMf6G-0003KD-Rs for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 15:57:44 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMf69-0002Sj-8i for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 22:57:37 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> Mail-Followup-To: 19865@debbugs.gnu.org Date: Sat, 14 Feb 2015 15:57:36 +0000 In-Reply-To: <87a90gd91b.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 14 Feb 2015 11:31:12 +0000") Message-ID: <87fva8bi4v.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Well, let=E2=80=99s see if I can reword the report. As currently implemented (tested on 7eb2077f9dd1, 2015-02-06 15:01:12 UTC), the *user* tar-untar-buffer command uses the value of the default-directory *user* variable, as set for the *internal* (tar-data-buffer) buffer =E2=80=93 in place of the value that same variable has in the buffer /the command is invoked from./ To stress it out: this report is /not/ intended to be a request for a feature for unpacking Tar archives into arbitrary directories, but is rather meant to point out that as currently implemented, the tar-untar-buffer behavior is *ill-defined*; especially if used after write-file (C-x C-w), save-buffer (C-x C-s; when a Tar archive is created from scratch), or M-x cd RET. (As all these commands /may/ change the value of default-directory for the user interaction buffer, but do /not/ do the same for the *internal* tar-data-buffer one.) I believe that using the values the *user* variables posses in *internal* buffers, when the command in question is invoked from a buffer dedicated to the *user* interaction and implemented by that same facility, is generally a wrong thing to do, and has a potential for confusion of users and developers alike. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 11:27:41 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 16:27:41 +0000 Received: from localhost ([127.0.0.1]:43973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMfZE-0003BA-Qv for submit@debbugs.gnu.org; Sat, 14 Feb 2015 11:27:41 -0500 Received: from fely.am-1.org ([78.47.74.50]:43811) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMfZC-0003B2-S9 for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 11:27:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=k8UBoqFw+61BwC/s4G1xCFpOu3LupfRpaAlrFtSwuAY=; b=UhBzM/5fgyBDsPw7mX4r8I1CLeBRhn22ObsuiLL/0YGl/r0gfVqkG/YN0AVlWysLYIV98epavITWjZAdEc2OAeKkXsDOIoB2UGfttAOb/QgOof606GPVKmC4mOdkHB3Y8BVuGiFmOwUBdOVLvJaKJ/JtZZ9kykJgw+hSTGgNmTk=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMfZB-0003XJ-8v for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 16:27:37 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMfZ4-0002ar-Fp for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 23:27:30 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <87oaowbkgv.fsf@violet.siamics.net> Mail-Followup-To: 19865@debbugs.gnu.org Date: Sat, 14 Feb 2015 16:27:29 +0000 In-Reply-To: <87oaowbkgv.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 14 Feb 2015 15:07:12 +0000") Message-ID: <87bnkwbgr2.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> Ivan Shmakov writes: [=E2=80=A6] > Avoiding switching buffers until around the actual write-region call > may still be a better alternative (as that should make mistakes of > this kind hardier to introduce), but results in a lengthier patch. > Any opinion on which way I should go there? Per my reading of the code, with-current-buffer is generally used in tar-mode.el around the smallest fragments possible. Please thus consider the revised patch MIMEd, which I=E2=80=99ve tried to make consistent with such an approach. Also to note is that the awareness of the general =E2=80=9Cdata buffer default-directory=E2=80=9D issue dates back to 2001 at the least (considering the excerpt below, for instance), so I don=E2=80=99t seem to understand how making tar-untar-buffer consistent with the rest of the tar-mode.el code could ever be harmful? TIA. commit e8421604cdd386af0c32fb7cf698882ec6b74015 Author: Gerd Moellmann Date: 2001-08-07 13:36:14 +0000 (tar-extract): Avoid generating a new buffer for each file visited. From Markus Rost . $ git archive --format=3Dtar e8421604cdd3 -- tar-mode.el | tar -xO | nl -b= a=20 =E2=80=A6 749 ;; Set the default-directory to the dir of the 750 ;; superior buffer.=20 751 (setq default-directory 752 (save-excursion 753 (set-buffer tar-buffer) 754 default-directory)) =E2=80=A6 $=20 --=20 FSF associate member #7257 np. Meditation =E2=80=94 David Modica 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline diff --git a/lisp/tar-mode.el b/lisp/tar-mode.el index 6c7f755..c6eef01 100644 --- a/lisp/tar-mode.el +++ b/lisp/tar-mode.el @@ -531,25 +531,28 @@ defun tar-untar-buffer () "Extract all archive members in the tar-file into the current directory." (interactive) ;; FIXME: make it work even if we're not in tar-mode. - (let ((descriptors tar-parse-info)) ;Read the var in its buffer. - (with-current-buffer - (if (tar-data-swapped-p) tar-data-buffer (current-buffer)) - (set-buffer-multibyte nil) ;Hopefully, a no-op. - (dolist (descriptor descriptors) - (let* ((name (tar-header-name descriptor)) - (dir (if (eq (tar-header-link-type descriptor) 5) - name - (file-name-directory name))) - (start (tar-header-data-start descriptor)) - (end (+ start (tar-header-size descriptor)))) - (unless (file-directory-p name) - (message "Extracting %s" name) - (if (and dir (not (file-exists-p dir))) - (make-directory dir t)) - (unless (file-directory-p name) - (let ((coding-system-for-write 'no-conversion)) - (write-region start end name))) - (set-file-modes name (tar-header-mode descriptor)))))))) + (let ((data-buf (if (tar-data-swapped-p) tar-data-buffer (current-buffer)))) + (with-current-buffer data-buf + (set-buffer-multibyte nil)) ; Hopefully, a no-op. + (dolist (descriptor tar-parse-info) + (let* ((name (tar-header-name descriptor)) + (dir (if (eq (tar-header-link-type descriptor) 5) + name + (file-name-directory name))) + (start (tar-header-data-start descriptor)) + (end (+ start (tar-header-size descriptor)))) + (unless (file-directory-p name) + (message "Extracting %s" name) + (if (and dir (not (file-exists-p dir))) + (make-directory dir t)) + (unless (file-directory-p name) + (let ((coding-system-for-write 'no-conversion) + ;; Note that default-directory may have a different + ;; value in the data buffer. + (name (expand-file-name name default-directory))) + (with-current-buffer data-buf + (write-region start end name)))) + (set-file-modes name (tar-header-mode descriptor))))))) (defun tar-summarize-buffer () "Parse the contents of the tar file in the current buffer." --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 11:56:37 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 16:56:37 +0000 Received: from localhost ([127.0.0.1]:44032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMg1E-0003rF-B2 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 11:56:36 -0500 Received: from mtaout26.012.net.il ([80.179.55.182]:60722) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMg1B-0003qv-GX for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 11:56:34 -0500 Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NJR00H00TMHSU00@mtaout26.012.net.il> for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 18:56:39 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJR00GBETQFNB10@mtaout26.012.net.il>; Sat, 14 Feb 2015 18:56:39 +0200 (IST) Date: Sat, 14 Feb 2015 18:56:26 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: <87fva8bi4v.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <83h9uowhxh.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <87a90gd91b.fsf@violet.siamics.net> <87fva8bi4v.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Sat, 14 Feb 2015 15:57:36 +0000 > > Well, let’s see if I can reword the report. If all you want is for me to stop bothering you with comments, all you need is just ask. There's no need to have the bug reports reworded around my comments. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 12:33:12 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 17:33:12 +0000 Received: from localhost ([127.0.0.1]:44092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMgae-0004iZ-1t for submit@debbugs.gnu.org; Sat, 14 Feb 2015 12:33:12 -0500 Received: from fely.am-1.org ([78.47.74.50]:43832) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMgaa-0004iP-IP for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 12:33:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=5a+nwQEOCwoV5Bthe2NCBbHPdEtz/Kih0+Su/hBaDwQ=; b=azLtCOOwzGztKY5vbYZJb9BrAYuXgG/5NFNtkUdG+Tp5Qn9YRGMmnbAsAAgZD8qKqTEUEYZ/xufqnJynRze5ydGd4PVPkfc2JI4a1ITb20aG7UxmDzaW2qxYZqCwj8A6xzV0fSwUJfTraDLxWi3M5Agom2V+oNclWF/nI6afBRA=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMgaZ-00041Q-AE for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 17:33:07 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMgaS-0002jG-D8 for 19865@debbugs.gnu.org; Sun, 15 Feb 2015 00:33:00 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <87fva8bi4v.fsf@violet.siamics.net> <83h9uowhxh.fsf@gnu.org> Mail-Followup-To: 19865@debbugs.gnu.org Date: Sat, 14 Feb 2015 17:32:59 +0000 In-Reply-To: <83h9uowhxh.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Feb 2015 18:56:26 +0200") Message-ID: <877fvkbdpw.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Sat, 14 Feb 2015 15:57:36 +0000 >> Well, let=E2=80=99s see if I can reword the report. > If all you want is for me to stop bothering you with comments, all > you need is just ask. There's no need to have the bug reports > reworded around my comments. All I want is to get the issue (that is: the misbehavior of tar-untar-buffer with respect to the tar-mode buffer value of default-directory) fixed. From where I stand, the shortest way there seems to get either of my two patches approved (that is: at least a single OK and no NAKs), so that I can safely push it. If there=E2=80=99s any other way I should be aware of =E2=80=93 I=E2=80=99d like to hear about it. My understanding is that the Stefan=E2=80=99s comment is an OK (for a former patch), while your request for =E2=80=9Csomeone third to resolve the tie=E2=80=9D is a NAK (please correct me if it=E2=80=99s not.) I appreciate the comments regarding the possible new =E2=80=9Cexplicit destination directory=E2=80=9D feature, and I guess I can work on a possible implementation once /this/ issue =E2=80=93 and also #19481 =E2=80= =93 are fixed. However, I believe that such a new feature is no substitute for a proper fix to this bug. Thanks again for your participation in this discussion. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 12:44:32 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 17:44:32 +0000 Received: from localhost ([127.0.0.1]:44100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMglb-0004ya-O5 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 12:44:31 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:47618) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMglZ-0004yN-Kr for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 12:44:30 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NJR00000VXC4N00@a-mtaout22.012.net.il> for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 19:44:22 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJR00MY5VXXZ880@a-mtaout22.012.net.il>; Sat, 14 Feb 2015 19:44:22 +0200 (IST) Date: Sat, 14 Feb 2015 19:44:22 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: <877fvkbdpw.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <83a90gwfpl.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <87a90gd91b.fsf@violet.siamics.net> <87fva8bi4v.fsf@violet.siamics.net> <83h9uowhxh.fsf@gnu.org> <877fvkbdpw.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Sat, 14 Feb 2015 17:32:59 +0000 > > >>>>> Eli Zaretskii writes: > >>>>> From: Ivan Shmakov Date: Sat, 14 Feb 2015 15:57:36 +0000 > > >> Well, let’s see if I can reword the report. > > > If all you want is for me to stop bothering you with comments, all > > you need is just ask. There's no need to have the bug reports > > reworded around my comments. > > All I want is to get the issue (that is: the misbehavior of > tar-untar-buffer with respect to the tar-mode buffer value of > default-directory) fixed. > > From where I stand, the shortest way there seems to get either > of my two patches approved (that is: at least a single OK and no > NAKs), so that I can safely push it. If there’s any other way I > should be aware of – I’d like to hear about it. > > My understanding is that the Stefan’s comment is an OK (for a > former patch), while your request for “someone third to resolve > the tie” is a NAK (please correct me if it’s not.) It is only a NAK if it's respected. I cannot force anyone here to do anything, I don;t have that power. > I appreciate the comments regarding the possible new “explicit > destination directory” feature, and I guess I can work on a > possible implementation once /this/ issue – and also #19481 – > are fixed. However, I believe that such a new feature is no > substitute for a proper fix to this bug. I obviously disagree, but whatever. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 13:13:00 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 18:13:00 +0000 Received: from localhost ([127.0.0.1]:44120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMhD9-0005cO-N3 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 13:13:00 -0500 Received: from fely.am-1.org ([78.47.74.50]:43839) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMhD7-0005cH-Cn for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 13:12:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=zm2T50luTNB31W+qoPrHrityUduQOB7GwhTTcnpu2iw=; b=VemKjpNFUMOlsgly+j31wfr5EJHgA6OFM8MUu/lGQBjtoAesduz2rH7ppTLd4mngq9IZeKZ2exzjb58KBg0Z/bfXpmsDYsllZpY3E6kIr4rwSLtEDZT4U+ywbs+1y/SVUIcni3FTUFHUanW4htROh70rDOxkuOlzmyNbVb/qYts=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMhD6-0004JR-Lt for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 18:12:56 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMhCx-0002nS-M6 for 19865@debbugs.gnu.org; Sun, 15 Feb 2015 01:12:47 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <87fva8bi4v.fsf@violet.siamics.net> <83h9uowhxh.fsf@gnu.org> <877fvkbdpw.fsf@violet.siamics.net> <83a90gwfpl.fsf@gnu.org> Mail-Followup-To: 19865@debbugs.gnu.org Date: Sat, 14 Feb 2015 18:12:47 +0000 In-Reply-To: <83a90gwfpl.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Feb 2015 19:44:22 +0200") Message-ID: <873868bbvk.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Sat, 14 Feb 2015 17:32:59 +0000 [=E2=80=A6] >> My understanding is that the Stefan=E2=80=99s comment is an OK (for a f= ormer >> patch), while your request for =E2=80=9Csomeone third to resolve the ti= e=E2=80=9D is >> a NAK (please correct me if it=E2=80=99s not.) > It is only a NAK if it's respected. I will surely respect any NAKs from those in charge of the given package, or Emacs as a whole (as per the Savannah project page.) > I cannot force anyone here to do anything, I don=E2=80=99t have that pow= er. We=E2=80=99re all volunteers here, yes. But you can =E2=80=93 and, I=E2= =80=99d argue, should =E2=80=93 /prevent/ the use of the Emacs community resources for the purposes contrary to the advancement of the project itself. (FWIW, it=E2=80=99s just the thing I do at Russian Wikibooks.) And as long as there=E2=80=99s a NAK from you, I will consider my change more or less a matter of my taste, not something valuable to the Emacs community at large. Similarly, as long as there=E2=80=99re any objections from Lars regarding my SHR- or EWW-related suggestions, I=E2=80=99d rather start my own fork than push a single change. >> I appreciate the comments regarding the possible new =E2=80=9Cexplicit >> destination directory=E2=80=9D feature, and I guess I can work on a pos= sible >> implementation once /this/ issue =E2=80=93 and also #19481 =E2=80=93 ar= e fixed. >> However, I believe that such a new feature is no substitute for a >> proper fix to this bug. > I obviously disagree, but whatever. And I=E2=80=99d still like to hear why you think that tar-untar-buffer /must/ use the value of default-directory local to a buffer /other/ than the one the user called this command from. TIA. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 13:38:03 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 18:38:03 +0000 Received: from localhost ([127.0.0.1]:44152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMhbP-0006EO-87 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 13:38:03 -0500 Received: from mtaout25.012.net.il ([80.179.55.181]:43861) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMhbM-0006Dr-7S for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 13:38:01 -0500 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NJR00O00Y2O8W00@mtaout25.012.net.il> for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 20:32:40 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJR00D0PY6FILA0@mtaout25.012.net.il>; Sat, 14 Feb 2015 20:32:40 +0200 (IST) Date: Sat, 14 Feb 2015 20:37:54 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: <873868bbvk.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <8361b4wd8d.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <87a90gd91b.fsf@violet.siamics.net> <87fva8bi4v.fsf@violet.siamics.net> <83h9uowhxh.fsf@gnu.org> <877fvkbdpw.fsf@violet.siamics.net> <83a90gwfpl.fsf@gnu.org> <873868bbvk.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Sat, 14 Feb 2015 18:12:47 +0000 > > >>>>> Eli Zaretskii writes: > >>>>> From: Ivan Shmakov Date: Sat, 14 Feb 2015 17:32:59 +0000 > > […] > > >> My understanding is that the Stefan’s comment is an OK (for a former > >> patch), while your request for “someone third to resolve the tie” is > >> a NAK (please correct me if it’s not.) > > > It is only a NAK if it's respected. > > I will surely respect any NAKs from those in charge of the given > package, or Emacs as a whole (as per the Savannah project page.) The file says emacs-devel is in charge, so I'm not sure who you mean here. > > I cannot force anyone here to do anything, I don’t have that power. > > We’re all volunteers here, yes. But you can – and, I’d argue, > should – /prevent/ the use of the Emacs community resources for > the purposes contrary to the advancement of the project itself. I don't know what that means in practice. I have my opinions and views, but who is to say whether they are or aren't contrary to the advancement? > >> I appreciate the comments regarding the possible new “explicit > >> destination directory” feature, and I guess I can work on a possible > >> implementation once /this/ issue – and also #19481 – are fixed. > >> However, I believe that such a new feature is no substitute for a > >> proper fix to this bug. > > > I obviously disagree, but whatever. > > And I’d still like to hear why you think that tar-untar-buffer > /must/ use the value of default-directory local to a buffer > /other/ than the one the user called this command from. Because it's simpler, and makes the code easier to follow. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 14:12:21 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 19:12:21 +0000 Received: from localhost ([127.0.0.1]:44169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMi8b-0006zH-3M for submit@debbugs.gnu.org; Sat, 14 Feb 2015 14:12:21 -0500 Received: from fely.am-1.org ([78.47.74.50]:43846) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMi8Y-0006z6-O3 for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 14:12:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=8HGTf1L3KgzNmUPRT4As1gbTJ+w+Jh/BdZeyos57ip0=; b=KKjyVwJD6sgvw40KtFVBMkQ9CoPD0wxAfHmf4DnvOtuiNVVBD9cjJ/545Gd35bpsZwA3by3klu9HaiNnKS8n2R9mpNO1ZmLMT57aDS7/kd3LEdrLJtzC2BCu2IT24J1DZAF2/pE6u+z4J7p3yDoHnkT0QZffWveXtXzN7FHh6IQ=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMi8W-0004la-Hm for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 19:12:16 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMi8L-0002vm-Bl for 19865@debbugs.gnu.org; Sun, 15 Feb 2015 02:12:05 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <87fva8bi4v.fsf@violet.siamics.net> <83h9uowhxh.fsf@gnu.org> <877fvkbdpw.fsf@violet.siamics.net> <83a90gwfpl.fsf@gnu.org> <873868bbvk.fsf@violet.siamics.net> <8361b4wd8d.fsf@gnu.org> Mail-Followup-To: 19865@debbugs.gnu.org Date: Sat, 14 Feb 2015 19:12:04 +0000 In-Reply-To: <8361b4wd8d.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Feb 2015 20:37:54 +0200") Message-ID: <87y4o09ukb.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Sat, 14 Feb 2015 18:12:47 +0000 >>>>> Eli Zaretskii writes: [=E2=80=A6] >> I will surely respect any NAKs from those in charge of the given >> package, or Emacs as a whole (as per the Savannah project page.) > The file says emacs-devel is in charge, so I'm not sure who you mean > here. --cut: https://savannah.gnu.org/projects/emacs/ -- Project Admins: - Stefan Monnier - Eli Zaretskii - Richard M. Stallman - Miles Bader - Francesco Potort=C3=AC - Kim F. Storm --cut: https://savannah.gnu.org/projects/emacs/ -- >>> I cannot force anyone here to do anything, I don=E2=80=99t have that p= ower. >> We=E2=80=99re all volunteers here, yes. But you can =E2=80=93 and, I= =E2=80=99d argue, >> should =E2=80=93 /prevent/ the use of the Emacs community resources for= the >> purposes contrary to the advancement of the project itself. > I don't know what that means in practice. In practice, that means that those who keep interfering with the community efforts risk losing their commit access. (Or =E2=80=9Cposting access=E2=80=9D to the mailing list, just like it happened to one of the bug-hurd@ participants something like a decade back. Etc.) > I have my opinions and views, but who is to say whether they are or > aren't contrary to the advancement? It=E2=80=99s up to those who=E2=80=99re in charge to decide. I can unders= tand the lack of interest in holding such a responsibility, but the problem is: I don=E2=80=99t want it, either. Still, I have no means to /force/ you to review my submissions. But once you did =E2=80=93 I won=E2=80=99t use community resources against= your /objections./ (As opposed to, say, lack of appreciation =E2=80=93 I can accept that perfectly well.) (In short: the golden rule of volunteer-driven projects is that the leaders tell us not what we /do,/ but what we /do not./) [=E2=80=A6] >> And I=E2=80=99d still like to hear why you think that tar-untar-buffer >> /must/ use the value of default-directory local to a buffer /other/ >> than the one the user called this command from. > Because it's simpler, and makes the code easier to follow. My former patch expands the code by a single line; my latter one adds two more for a comment (while removing one level of nesting from a fair chunk of the code at the same time.) How is that making it any harder to follow? Besides, as I=E2=80=99ve already noted, it does make tar-untar-buffer more consistent with both the rest of tar-mode.el, /and/ the rest of Emacs. I thus believe that a single extra LoC is fully justified here. --=20 FSF associate member #7257 np. Cherry Blossom =E2=80=94 David Modica B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 14:29:00 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 19:29:00 +0000 Received: from localhost ([127.0.0.1]:44177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMiOh-0007Lz-NW for submit@debbugs.gnu.org; Sat, 14 Feb 2015 14:29:00 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:64913) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMiOe-0007Lk-R6 for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 14:28:58 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NJS000000JZT200@a-mtaout22.012.net.il> for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 21:28:50 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJS000F20S1IJA0@a-mtaout22.012.net.il>; Sat, 14 Feb 2015 21:28:50 +0200 (IST) Date: Sat, 14 Feb 2015 21:28:51 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: <87y4o09ukb.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <831tlswavg.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <87a90gd91b.fsf@violet.siamics.net> <87fva8bi4v.fsf@violet.siamics.net> <83h9uowhxh.fsf@gnu.org> <877fvkbdpw.fsf@violet.siamics.net> <83a90gwfpl.fsf@gnu.org> <873868bbvk.fsf@violet.siamics.net> <8361b4wd8d.fsf@gnu.org> <87y4o09ukb.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Sat, 14 Feb 2015 19:12:04 +0000 > > >> And I’d still like to hear why you think that tar-untar-buffer > >> /must/ use the value of default-directory local to a buffer /other/ > >> than the one the user called this command from. > > > Because it's simpler, and makes the code easier to follow. > > My former patch expands the code by a single line; my latter one > adds two more for a comment (while removing one level of nesting > from a fair chunk of the code at the same time.) How is that > making it any harder to follow? Length of code is only one factor, insignificant in this case. Subtle dependencies between different parts of the code, as well as overriding the default-directory value, is what complicates things in this case. > Besides, as I’ve already noted, it does make tar-untar-buffer > more consistent with both the rest of tar-mode.el, /and/ the > rest of Emacs. I thus believe that a single extra LoC is fully > justified here. Once again, we disagree, there's no doubt about that. There's no need to reiterate things you already wrote, as they have been duly noted. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 14:42:53 2015 Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 19:42:53 +0000 Received: from localhost ([127.0.0.1]:44190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMic8-0007gj-JY for submit@debbugs.gnu.org; Sat, 14 Feb 2015 14:42:53 -0500 Received: from fely.am-1.org ([78.47.74.50]:43855) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMic6-0007gb-MO for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 14:42:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=5m35+2o6k7qdpn+4cLdnFszeZ82Dnu9lBh0kU1MUWI0=; b=XvV81gD70AkwFyOX79TkPbAgvUbi9brDGmxxvFVymR9JSKsS2doOvJT2OQq1rmBzQQCoOxZgmIleWbP6hxD53hQmjKv5y2lxD6oSMQDjO4KxrRYXjX7IbMnAEmYXXdRK3BYgRF3AUyacVS2M4MMhpnezFo+0/gasX3JPQ0+LahQ=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMic5-00053C-VY for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 19:42:50 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMiby-0002za-KW for 19865@debbugs.gnu.org; Sun, 15 Feb 2015 02:42:42 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <87fva8bi4v.fsf@violet.siamics.net> <83h9uowhxh.fsf@gnu.org> <877fvkbdpw.fsf@violet.siamics.net> <83a90gwfpl.fsf@gnu.org> <873868bbvk.fsf@violet.siamics.net> <8361b4wd8d.fsf@gnu.org> <87y4o09ukb.fsf@violet.siamics.net> <831tlswavg.fsf@gnu.org> Mail-Followup-To: 19865@debbugs.gnu.org Date: Sat, 14 Feb 2015 19:42:42 +0000 In-Reply-To: <831tlswavg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Feb 2015 21:28:51 +0200") Message-ID: <87twyo9t59.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Sat, 14 Feb 2015 19:12:04 +0000 >>>> And I=E2=80=99d still like to hear why you think that tar-untar-buffer >>>> /must/ use the value of default-directory local to a buffer >>>> /other/ than the one the user called this command from. >>> Because it's simpler, and makes the code easier to follow. >> My former patch expands the code by a single line; my latter one >> adds two more for a comment (while removing one level of nesting >> from a fair chunk of the code at the same time.) How is that making >> it any harder to follow? > Length of code is only one factor, insignificant in this case. > Subtle dependencies between different parts of the code, as well as > overriding the default-directory value, is what complicates things in > this case. My second patch [1] doesn=E2=80=99t change the value of default-directory (instead, it uses expand-file-name explicitly at the write-region time.) As for the subtle dependencies, could you point at anything specific? TIA. [1] http://debbugs.gnu.org/19865#msg44 [=E2=80=A6] --=20 FSF associate member #7257 np. Povus esti simple =E2=80=94 Persone =E2=80= =A6 B6A0 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 15 20:43:35 2015 Received: (at 19865) by debbugs.gnu.org; 16 Feb 2015 01:43:35 +0000 Received: from localhost ([127.0.0.1]:45032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNAil-0007sH-2r for submit@debbugs.gnu.org; Sun, 15 Feb 2015 20:43:35 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:52810) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNAii-0007s6-H7 for 19865@debbugs.gnu.org; Sun, 15 Feb 2015 20:43:33 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t1G1hRBf003774; Sun, 15 Feb 2015 20:43:27 -0500 Received: by pastel.home (Postfix, from userid 20848) id 11E4F1648; Sun, 15 Feb 2015 20:43:17 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory Message-ID: References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> Date: Sun, 15 Feb 2015 20:43:17 -0500 In-Reply-To: <83sie8wn8z.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Feb 2015 17:01:32 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5218=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5218> : inlines <2184> : streams <1390937> : uri <1856217> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org, ivan@siamics.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > So we now need someone third to resolve the tie. I don't see why you object: the command is executed by the user in one buffer, and it just so happens that its implementation switches to some internal auxiliary buffer. The value of `default-directory' that should be used is the one that the user knows about, not the one kept by the hidden buffer, over which the user has no control. This behavior is an unintended result of my change in tar-mode where we now have 2 buffers (rather than keeping all the raw tar data in the same buffer as the pretty list, hidden via narrowing). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 15 20:48:53 2015 Received: (at 19865) by debbugs.gnu.org; 16 Feb 2015 01:48:53 +0000 Received: from localhost ([127.0.0.1]:45036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNAns-0007zv-VI for submit@debbugs.gnu.org; Sun, 15 Feb 2015 20:48:53 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:54646) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNAnr-0007zn-67 for 19865@debbugs.gnu.org; Sun, 15 Feb 2015 20:48:51 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t1G1mnhD014749; Sun, 15 Feb 2015 20:48:50 -0500 Received: by pastel.home (Postfix, from userid 20848) id A4F761648; Sun, 15 Feb 2015 20:48:39 -0500 (EST) From: Stefan Monnier To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory Message-ID: References: <87a90gd91b.fsf@violet.siamics.net> <87oaowbkgv.fsf@violet.siamics.net> <87bnkwbgr2.fsf@violet.siamics.net> Date: Sun, 15 Feb 2015 20:48:39 -0500 In-Reply-To: <87bnkwbgr2.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 14 Feb 2015 16:27:29 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5218=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5218> : inlines <2184> : streams <1390939> : uri <1856220> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > Per my reading of the code, with-current-buffer is generally > used in tar-mode.el around the smallest fragments possible. Indeed. > Please thus consider the revised patch MIMEd, which I=E2=80=99ve tried > to make consistent with such an approach. I think it's better, indeed. BTW, the (set-buffer-multibyte nil) should probably just be remove (or replaced by a cl-assert) Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 16 00:24:58 2015 Received: (at 19865) by debbugs.gnu.org; 16 Feb 2015 05:24:58 +0000 Received: from localhost ([127.0.0.1]:45079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNEAz-0004Uo-VL for submit@debbugs.gnu.org; Mon, 16 Feb 2015 00:24:58 -0500 Received: from fely.am-1.org ([78.47.74.50]:44029) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNEAw-0004Uf-Va for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 00:24:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=O2eoS12DkOJ0eqU3aYi/CDP+Ld+ACTMd1NQy+bOKyvQ=; b=jgq/TvZXdLuknCUT1ooez9Z/l+HNE8nsJBKb0l9bRQsz8BbaTrd9cTWIt6pXgzAo8FR3uW6bQ5ihIX1zURH6tFGf0Vi8R+1K1sVK2cA/R+FIGqAMw6GDsFhaJdRpbR6lp1xBb5OElqOEYWTUVuMaHIxpyU83+XGHOEx424rvLqA=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YNEAu-0006bR-UI for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 05:24:53 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YNEAn-00074t-6Y for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 12:24:45 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <87oaowbkgv.fsf@violet.siamics.net> <87bnkwbgr2.fsf@violet.siamics.net> Mail-Followup-To: 19865@debbugs.gnu.org Date: Mon, 16 Feb 2015 05:24:44 +0000 In-Reply-To: (Stefan Monnier's message of "Sun, 15 Feb 2015 20:48:39 -0500") Message-ID: <878ufya0o3.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> Stefan Monnier writes: [=E2=80=A6] >> Please thus consider the revised patch MIMEd, which I=E2=80=99ve tried = to >> make consistent with such an approach. > I think it's better, indeed. I=E2=80=99ve revised the change to apply default-directory just once and use the result consistently throughout the function. > BTW, the (set-buffer-multibyte nil) should probably just be remove > (or replaced by a cl-assert) Done. Fix default-directory handling in tar-untar-buffer. * lisp/tar-mode.el (tar-untar-buffer): Fixed: use the value of default-directory local to the tar-mode buffer (was: tar-data-buffer); clean-up. =20=20=20=20 Fixes: debbugs:19865 PS. Should the pending objections be resolved by sometime around 18:00=C2=A0UTC today, I=E2=80=99d happily push the change to =E2=80=98mast= er=E2=80=99. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/tar-mode.el +++ b/lisp/tar-mode.el @@ -533,27 +533,32 @@ (defun tar-untar-buffer () "Extract all archive members in the tar-file into the current directory." (interactive) ;; FIXME: make it work even if we're not in tar-mode. - (let ((descriptors tar-parse-info)) ;Read the var in its buffer. - (with-current-buffer - (if (tar-data-swapped-p) tar-data-buffer (current-buffer)) - (set-buffer-multibyte nil) ;Hopefully, a no-op. - (dolist (descriptor descriptors) - (let* ((name (tar-header-name descriptor)) - (dir (if (eq (tar-header-link-type descriptor) 5) - name - (file-name-directory name))) - (start (tar-header-data-start descriptor)) - (end (+ start (tar-header-size descriptor)))) - (unless (file-directory-p name) - (message "Extracting %s" name) - (if (and dir (not (file-exists-p dir))) - (make-directory dir t)) - (unless (file-directory-p name) + (let ((data-buf (if (tar-data-swapped-p) tar-data-buffer + (current-buffer)))) + (with-current-buffer data-buf + (cl-assert (not enable-multibyte-characters))) + (dolist (descriptor tar-parse-info) + (let* ((orig (tar-header-name descriptor)) + ;; Note that default-directory may have different values + ;; in the tar-mode and data buffers, so we stick to the + ;; absolute file name from now on. + (name (expand-file-name orig)) + (dir (if (eq (tar-header-link-type descriptor) 5) + name + (file-name-directory name))) + (start (tar-header-data-start descriptor)) + (end (+ start (tar-header-size descriptor)))) + (unless (file-directory-p name) + (message "Extracting %s" orig) + (if (and dir (not (file-exists-p dir))) + (make-directory dir t)) + (unless (file-directory-p name) + (with-current-buffer data-buf (let ((coding-system-for-write 'no-conversion)) - (write-region start end name))) - (set-file-modes name (tar-header-mode descriptor)))))))) + (write-region start end name)))) + (set-file-modes name (tar-header-mode descriptor))))))) (defun tar-summarize-buffer () "Parse the contents of the tar file in the current buffer." --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 16 02:45:33 2015 Received: (at 19865) by debbugs.gnu.org; 16 Feb 2015 07:45:33 +0000 Received: from localhost ([127.0.0.1]:45116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNGN1-0007mw-GW for submit@debbugs.gnu.org; Mon, 16 Feb 2015 02:45:31 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:56099) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNGMz-0007mn-Ew for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 02:45:30 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t1G7jQ4f001485; Mon, 16 Feb 2015 02:45:27 -0500 Received: by pastel.home (Postfix, from userid 20848) id C91812818; Mon, 16 Feb 2015 02:45:15 -0500 (EST) From: Stefan Monnier To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory Message-ID: References: <87a90gd91b.fsf@violet.siamics.net> <87oaowbkgv.fsf@violet.siamics.net> <87bnkwbgr2.fsf@violet.siamics.net> <878ufya0o3.fsf@violet.siamics.net> Date: Mon, 16 Feb 2015 02:45:15 -0500 In-Reply-To: <878ufya0o3.fsf@violet.siamics.net> (Ivan Shmakov's message of "Mon, 16 Feb 2015 05:24:44 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5218=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5218> : inlines <2184> : streams <1391075> : uri <1856405> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > PS. Should the pending objections be resolved by sometime around > 18:00=C2=A0UTC today, I=E2=80=99d happily push the change to =E2=80=98ma= ster=E2=80=99. Most of the change (tho not the removal of set-buffer-multibyte) probably belongs in emacs-24 rather than in master. > + (with-current-buffer data-buf > + (cl-assert (not enable-multibyte-characters))) Why not move this further down where you already do the "(with-current-buffer data-buf"? Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 16 03:55:30 2015 Received: (at 19865) by debbugs.gnu.org; 16 Feb 2015 08:55:30 +0000 Received: from localhost ([127.0.0.1]:45149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNHSi-00010a-O8 for submit@debbugs.gnu.org; Mon, 16 Feb 2015 03:55:29 -0500 Received: from fely.am-1.org ([78.47.74.50]:44047) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNHSe-00010P-RN for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 03:55:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=9IqsnO+YO1hCbBiSXoIXU4EBFAtRc5ZmjDV4P1MKdRE=; b=r2dg3GH2y9CEUFO18bP06qnL5UZd7bPMWtJQOVyLvycbFJjPnTEUlDVpeUMUxLPdjJJyhPJR7oHrV+6A26/H+Qb1cJVTi+BdyHPIznyK6uqV2s1UGuSP8p7NQHJ5fI6LIfA6Jt42NM5qq5rqEByUJjggFkrjaocNZlW1aLir6hI=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YNHSc-0000HX-67 for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 08:55:22 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YNHSV-0007PR-9d for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 15:55:15 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <87oaowbkgv.fsf@violet.siamics.net> <87bnkwbgr2.fsf@violet.siamics.net> <878ufya0o3.fsf@violet.siamics.net> Mail-Followup-To: 19865@debbugs.gnu.org Date: Mon, 16 Feb 2015 08:55:14 +0000 In-Reply-To: (Stefan Monnier's message of "Mon, 16 Feb 2015 02:45:15 -0500") Message-ID: <874mqm9qx9.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Stefan Monnier writes: >> PS. Should the pending objections be resolved by sometime around >> 18:00=C2=A0UTC today, I=E2=80=99d happily push the change to =E2=80=98m= aster=E2=80=99. > Most of the change (tho not the removal of set-buffer-multibyte) > probably belongs in emacs-24 rather than in master. I certainly could push it to the stable branch, but as for actually /testing/ it there =E2=80=93 that=E2=80=99d double the work for me (as I do not currently follow emacs-24 development.) >> + (with-current-buffer data-buf >> + (cl-assert (not enable-multibyte-characters))) > Why not move this further down where you already do the > "(with-current-buffer data-buf"? My only concern is that that latter with-current-buffer happens within a loop, and I don=E2=80=99t seem to see a reason for checking this condition for every archive member extracted. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 16 09:58:46 2015 Received: (at 19865) by debbugs.gnu.org; 16 Feb 2015 14:58:46 +0000 Received: from localhost ([127.0.0.1]:45506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNN8H-0002Ca-UR for submit@debbugs.gnu.org; Mon, 16 Feb 2015 09:58:46 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:46312) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNN8E-0002CR-6F for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 09:58:44 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t1GEweat030506; Mon, 16 Feb 2015 09:58:40 -0500 Received: by pastel.home (Postfix, from userid 20848) id 01BB12818; Mon, 16 Feb 2015 09:58:27 -0500 (EST) From: Stefan Monnier To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory Message-ID: References: <87a90gd91b.fsf@violet.siamics.net> <87oaowbkgv.fsf@violet.siamics.net> <87bnkwbgr2.fsf@violet.siamics.net> <878ufya0o3.fsf@violet.siamics.net> <874mqm9qx9.fsf@violet.siamics.net> Date: Mon, 16 Feb 2015 09:58:27 -0500 In-Reply-To: <874mqm9qx9.fsf@violet.siamics.net> (Ivan Shmakov's message of "Mon, 16 Feb 2015 08:55:14 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5219=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5219> : inlines <2188> : streams <1391240> : uri <1856653> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > I certainly could push it to the stable branch, but as for > actually /testing/ it there =E2=80=93 that=E2=80=99d double the work for= me > (as I do not currently follow emacs-24 development.) OK, your call. >>> + (with-current-buffer data-buf >>> + (cl-assert (not enable-multibyte-characters))) >> Why not move this further down where you already do the >> "(with-current-buffer data-buf"? > My only concern is that that latter with-current-buffer happens > within a loop, and I don=E2=80=99t seem to see a reason for checking > this condition for every archive member extracted. This assertion should soon be removed altogether anyway, so let's not waste too much time with it: either way is fine. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 16 10:44:02 2015 Received: (at 19865) by debbugs.gnu.org; 16 Feb 2015 15:44:02 +0000 Received: from localhost ([127.0.0.1]:45510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNNq5-0003Er-QY for submit@debbugs.gnu.org; Mon, 16 Feb 2015 10:44:02 -0500 Received: from mtaout24.012.net.il ([80.179.55.180]:60412) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNNq2-0003EJ-OL for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 10:44:00 -0500 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NJV00800F2B3800@mtaout24.012.net.il> for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 17:35:33 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJV00OVLFB94Q80@mtaout24.012.net.il>; Mon, 16 Feb 2015 17:35:33 +0200 (IST) Date: Mon, 16 Feb 2015 17:43:58 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <831tlpvp35.fsf@gnu.org> References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org, ivan@siamics.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: ivan@siamics.net, 19865@debbugs.gnu.org > Date: Sun, 15 Feb 2015 20:43:17 -0500 > > I don't see why you object I can only re-iterate what I already said: we shouldn't cater to marginal use cases like that with code that is "tricky" (a.k.a. "maintenance headache"). People who change directories of their buffers should (and do) know what they are doing. If doing that causes them annoyances, they will know better next time. > the command is executed by the user in one > buffer, and it just so happens that its implementation switches > to some internal auxiliary buffer. The value of `default-directory' > that should be used is the one that the user knows about, not the one > kept by the hidden buffer, over which the user has no control. Are we still talking about the situation where a user did "M-x cd"? Or is this another use case? If the latter, please describe it in its entirety. If the former, then is there still a problem if the user refrains from "M-x cd"? > This behavior is an unintended result of my change in tar-mode where we > now have 2 buffers (rather than keeping all the raw tar data in the same > buffer as the pretty list, hidden via narrowing). Understood, but unintended results do not necessarily need fixes, just because they are unintended. The important question is: what, if any, real problems are caused as unintended results? We are discussing those problems, so the fact that they are unintended results doesn't seem important to me. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 16 14:34:23 2015 Received: (at 19865) by debbugs.gnu.org; 16 Feb 2015 19:34:24 +0000 Received: from localhost ([127.0.0.1]:45628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNRR1-0003Aj-7o for submit@debbugs.gnu.org; Mon, 16 Feb 2015 14:34:23 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:44776) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNRQy-0003Aa-4u for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 14:34:21 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t1GJYEnj021896; Mon, 16 Feb 2015 14:34:14 -0500 Received: by pastel.home (Postfix, from userid 20848) id 73289F86; Mon, 16 Feb 2015 14:34:02 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory Message-ID: References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> <831tlpvp35.fsf@gnu.org> Date: Mon, 16 Feb 2015 14:34:02 -0500 In-Reply-To: <831tlpvp35.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Feb 2015 17:43:58 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5219=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5219> : inlines <2191> : streams <1391347> : uri <1856840> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org, ivan@siamics.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > I can only re-iterate what I already said: we shouldn't cater to > marginal use cases like that with code that is "tricky" (a.k.a. > "maintenance headache"). People who change directories of their > buffers should (and do) know what they are doing. If doing that > causes them annoyances, they will know better next time. Hmm... so you're considering `M-x cd' as harmful? I'm surprised, it looks like a perfectly normal command to me. If we don't want normal users to use, we should at least `disable-command' and/or rename it to something more verbose and less attractive. >> the command is executed by the user in one buffer, and it just so >> happens that its implementation switches to some internal auxiliary >> buffer. The value of `default-directory' that should be used is the >> one that the user knows about, not the one kept by the hidden buffer, >> over which the user has no control. > Are we still talking about the situation where a user did "M-x cd"? Actually, no, I'm talking about how the code *should* behave from a simple semantic correctness point of view. This then appears in cases such as `M-x cd' indeed, but it might appear in other cases I haven't thought about. > If the former, then is there still a problem if the user refrains from > "M-x cd"? Until we decide to deprecate `M-x cd' I think this question is not really relevant. > Understood, but unintended results do not necessarily need fixes, just > because they are unintended. The important question is: what, if any, > real problems are caused as unintended results? We are discussing > those problems, so the fact that they are unintended results doesn't > seem important to me. The patch he provides fixes the immediate problem, which in my book is a plain bug (maybe for a "corner case", but still a plain bug), but in terms of "disagrees with the docstring" and "disagrees with my mental model of what is right". Also the fix doesn't make the code more obscure or more complex. Hence I still fail to see why you're opposing it. I agree that having to be careful in which buffer we are when we read a given variable because it might be buffer-local is a source of maintenance headaches, but we have that all over the place in Elisp, and we don't really have any "better solution". Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 16 14:49:19 2015 Received: (at 19865) by debbugs.gnu.org; 16 Feb 2015 19:49:19 +0000 Received: from localhost ([127.0.0.1]:45633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNRfT-0003VA-0R for submit@debbugs.gnu.org; Mon, 16 Feb 2015 14:49:19 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:54507) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNRfP-0003Us-7Y for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 14:49:17 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NJV00I00R0RJY00@a-mtaout21.012.net.il> for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 21:49:08 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJV00I9NR1VI230@a-mtaout21.012.net.il>; Mon, 16 Feb 2015 21:49:08 +0200 (IST) Date: Mon, 16 Feb 2015 21:49:14 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83twyltz5x.fsf@gnu.org> References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> <831tlpvp35.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org, ivan@siamics.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: ivan@siamics.net, 19865@debbugs.gnu.org > Date: Mon, 16 Feb 2015 14:34:02 -0500 > > > I can only re-iterate what I already said: we shouldn't cater to > > marginal use cases like that with code that is "tricky" (a.k.a. > > "maintenance headache"). People who change directories of their > > buffers should (and do) know what they are doing. If doing that > > causes them annoyances, they will know better next time. > > Hmm... so you're considering `M-x cd' as harmful? Not harmful, potentially dangerous, especially in buffers that have associated files, or where default-directory plays some other significant role. People who do that should "M-x cd" back before they invoke functions that use the value. It's the same as working in the shell: if you changed a directory, you need to go back before you operate on files, or risk operate on wrong files. > I agree that having to be careful in which buffer we are when we read > a given variable because it might be buffer-local is a source of > maintenance headaches, but we have that all over the place in Elisp, > and we don't really have any "better solution". I don't really see a problem here that needs a solution. A year from now no one will remember or understand why we use with-current-buffer in that place. Doing so for such a weak reason is unwise, and no amount of cruft we have elsewhere can justify adding to that. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 16 18:41:08 2015 Received: (at 19865) by debbugs.gnu.org; 16 Feb 2015 23:41:08 +0000 Received: from localhost ([127.0.0.1]:45725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNVHn-0005rH-U4 for submit@debbugs.gnu.org; Mon, 16 Feb 2015 18:41:08 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:37410) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNVHm-0005r7-1g for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 18:41:07 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t1GNf3dL024407; Mon, 16 Feb 2015 18:41:03 -0500 Received: by pastel.home (Postfix, from userid 20848) id 0DDFBF86; Mon, 16 Feb 2015 18:40:51 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory Message-ID: References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> <831tlpvp35.fsf@gnu.org> <83twyltz5x.fsf@gnu.org> Date: Mon, 16 Feb 2015 18:40:51 -0500 In-Reply-To: <83twyltz5x.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Feb 2015 21:49:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5219=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5219> : inlines <2192> : streams <1391442> : uri <1856984> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org, ivan@siamics.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > It's the same as working in the shell: That's also my impression. > if you changed a directory, you need to go back before you operate on > files, or risk operate on wrong files. No: I changed directory specifically because I wanted to operate on other files. And I often don't go back. >> I agree that having to be careful in which buffer we are when we read >> a given variable because it might be buffer-local is a source of >> maintenance headaches, but we have that all over the place in Elisp, >> and we don't really have any "better solution". > I don't really see a problem here that needs a solution. A year from > now no one will remember or understand why we use with-current-buffer > in that place. The comment explains why and the comment will still be there a year from now. The code takes a file name from one buffer and uses it in another buffer: every time we do it, we have to be extra careful to make sure the file name is absolute, and that's what the patch does. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 16 22:37:27 2015 Received: (at 19865) by debbugs.gnu.org; 17 Feb 2015 03:37:27 +0000 Received: from localhost ([127.0.0.1]:45749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNYyT-0003ko-KI for submit@debbugs.gnu.org; Mon, 16 Feb 2015 22:37:26 -0500 Received: from mtaout29.012.net.il ([80.179.55.185]:46045) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNYyQ-0003kW-7U for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 22:37:23 -0500 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NJW00700CE9W100@mtaout29.012.net.il> for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 05:33:15 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJW005DMCJEH120@mtaout29.012.net.il>; Tue, 17 Feb 2015 05:33:15 +0200 (IST) Date: Tue, 17 Feb 2015 05:37:23 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83sie5tdho.fsf@gnu.org> References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> <831tlpvp35.fsf@gnu.org> <83twyltz5x.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org, ivan@siamics.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: ivan@siamics.net, 19865@debbugs.gnu.org > Date: Mon, 16 Feb 2015 18:40:51 -0500 > > > if you changed a directory, you need to go back before you operate on > > files, or risk operate on wrong files. > > No: I changed directory specifically because I wanted to operate on > other files. And I often don't go back. Then your next delete command will probably delete wrong files. > > I don't really see a problem here that needs a solution. A year from > > now no one will remember or understand why we use with-current-buffer > > in that place. > > The comment explains why and the comment will still be there a year > from now. Comments cannot be a replacement for clear, self-explanatory code that has no hidden dependencies. > The code takes a file name from one buffer and uses it in another > buffer: every time we do it, we have to be extra careful to make sure > the file name is absolute, and that's what the patch does. If both buffers has the same default-directory, as they should, there's no need to do anything special. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 17 00:26:00 2015 Received: (at 19865) by debbugs.gnu.org; 17 Feb 2015 05:26:00 +0000 Received: from localhost ([127.0.0.1]:45794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNafX-0006AV-R4 for submit@debbugs.gnu.org; Tue, 17 Feb 2015 00:26:00 -0500 Received: from fely.am-1.org ([78.47.74.50]:44214) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNafV-0006AM-6x for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 00:25:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=ioL5a4YCp4yOQAmrQUTR2TSdUS5wjtFwhA93xmUbhsc=; b=RY6BdY6ON3AfmBBMeKyO+hkR99PhKT8v8VjYEnA9ikoXr/LsJa2xhGo7NcuRmP5xHTKMeL+GsSdhjjLcfbqZaPCejEwYRhBe28Pp567OfHzEONBkfzTPUpjIknDHaacBzVEfhSo5epNnf42cfUsqM+Od74r+82HJzIqVmHR79o0=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YNafT-0003p6-VB for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 05:25:56 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YNafM-00052v-Od for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 12:25:48 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> <831tlpvp35.fsf@gnu.org> <83twyltz5x.fsf@gnu.org> Mail-Followup-To: 19865@debbugs.gnu.org Date: Tue, 17 Feb 2015 05:25:47 +0000 In-Reply-To: <83twyltz5x.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Feb 2015 21:49:14 +0200") Message-ID: <87sie585yc.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Stefan Monnier Date: Mon, 16 Feb 2015 14:34:02 -0500 [=E2=80=A6] >> I agree that having to be careful in which buffer we are when we >> read a given variable because it might be buffer-local is a source >> of maintenance headaches, but we have that all over the place in >> Elisp, and we don't really have any "better solution". > I don't really see a problem here that needs a solution. Yet at least two other Emacs users do. > A year from now no one will remember or understand why we use > with-current-buffer in that place. Doing so for such a weak reason > is unwise, and no amount of cruft we have elsewhere can justify > adding to that. We=E2=80=99re using with-current-buffer there for the sole reason that write-region operates strictly on the current buffer. It is so without this change, and it remains so with it; the change maintains this status quo just perfectly. And as long as such use /is/ acceptable in the current code, I fail to see why it wouldn=E2=80=99t be in the replacement being discussed. What /is/ changed is that with-current-buffer will now go immediately before write-region: (with-current-buffer data-buffer (write-region =E2=80=A6)) Cf. the former: (with-current-buffer data-buffer =E2=80=A6 lots of code to make sure the reader=E2=80=99s lost=E2=80=A6 (write-region =E2=80=A6)) And at the same time: (let ((name (expand-file-name (the-name-of-the-archive-member)))) =E2=80=A6) Versus the current: (let ((name (the-name-of-the-archive-member))) =E2=80=A6) Please also note that the use of expand-file-name will still be necessary if we decide to add an extra optional target-directory argument to the function later, =E2=80=93 and the /new/ code could easily be changed to that effect, like: (unless target-directory (setq target-directory default-directory)) (let ((name (expand-file-name (the-name-of-the-archive-member) target-directory))) =E2=80=A6) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 17 10:46:18 2015 Received: (at 19865) by debbugs.gnu.org; 17 Feb 2015 15:46:18 +0000 Received: from localhost ([127.0.0.1]:46441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNkLp-0004kk-Eb for submit@debbugs.gnu.org; Tue, 17 Feb 2015 10:46:17 -0500 Received: from mtaout28.012.net.il ([80.179.55.184]:58804) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNkLm-0004kM-60 for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 10:46:15 -0500 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NJX00K00A571A00@mtaout28.012.net.il> for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 17:44:29 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJX00BRKAE5J690@mtaout28.012.net.il>; Tue, 17 Feb 2015 17:44:29 +0200 (IST) Date: Tue, 17 Feb 2015 17:46:16 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: <87sie585yc.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il To: Ivan Shmakov Message-id: <83egpo7d87.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> <831tlpvp35.fsf@gnu.org> <83twyltz5x.fsf@gnu.org> <87sie585yc.fsf@violet.siamics.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ivan Shmakov > Date: Tue, 17 Feb 2015 05:25:47 +0000 > > >> I agree that having to be careful in which buffer we are when we > >> read a given variable because it might be buffer-local is a source > >> of maintenance headaches, but we have that all over the place in > >> Elisp, and we don't really have any "better solution". > > > I don't really see a problem here that needs a solution. > > Yet at least two other Emacs users do. That doesn't make the use case any less marginal, IMO. You are both power users who can easily get yourself out of this trouble. Emacs maintenance shouldn't pay a price for marginal use cases for which simple workarounds (like "M-x cd BACK") are available. > > A year from now no one will remember or understand why we use > > with-current-buffer in that place. Doing so for such a weak reason > > is unwise, and no amount of cruft we have elsewhere can justify > > adding to that. > > We’re using with-current-buffer there for the sole reason that > write-region operates strictly on the current buffer. It is so > without this change, and it remains so with it; the change > maintains this status quo just perfectly. And as long as such > use /is/ acceptable in the current code, I fail to see why it > wouldn’t be in the replacement being discussed. I already explained that, more than once: the change is obscure, and is made for the sake of a marginal use case, where the user should have returned to the original directory from which she cd'ed, to avoid the problem. > What /is/ changed is that with-current-buffer will now go > immediately before write-region: > > (with-current-buffer data-buffer > (write-region …)) > > Cf. the former: > > (with-current-buffer data-buffer > … lots of code to make sure the reader’s lost… > (write-region …)) > > And at the same time: > > (let ((name (expand-file-name (the-name-of-the-archive-member)))) > …) > > Versus the current: > > (let ((name (the-name-of-the-archive-member))) > …) Now put yourself in the shoes of someone who needs to review this change many moons from now, and try to imagine how "easy" it will be for them to understand what the heck was that all about. > Please also note that the use of expand-file-name will still be > necessary if we decide to add an extra optional target-directory > argument to the function later, – and the /new/ code could > easily be changed to that effect, like: > > (unless target-directory > (setq target-directory default-directory)) > (let ((name (expand-file-name (the-name-of-the-archive-member) > target-directory))) > …) When we have an explicit directory as an argument, expanding a file name against that directory is something that is crystal-clear and doesn't require any explanations. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 17 12:06:28 2015 Received: (at 19865) by debbugs.gnu.org; 17 Feb 2015 17:06:28 +0000 Received: from localhost ([127.0.0.1]:46507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNlbQ-0006sd-7J for submit@debbugs.gnu.org; Tue, 17 Feb 2015 12:06:28 -0500 Received: from b2bfep15.mx.upcmail.net ([62.179.121.60]:33481) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNlbN-0006sP-Oh for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 12:06:26 -0500 Received: from edge12.upcmail.net ([192.168.13.82]) by b2bfep15.mx.upcmail.net (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP id <20150217170619.FVBL27307.b2bfep15-int.chello.at@edge12.upcmail.net> for <19865@debbugs.gnu.org>; Tue, 17 Feb 2015 18:06:19 +0100 Received: from iznogoud.viz ([91.119.101.156]) by edge12.upcmail.net with edge id tV6F1p0063NTfpn0CV6F5x; Tue, 17 Feb 2015 18:06:19 +0100 X-SourceIP: 91.119.101.156 Received: from wolfgang by iznogoud.viz with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1YNlbC-000OAP-P0; Tue, 17 Feb 2015 18:06:14 +0100 From: Wolfgang Jenkner To: Stefan Monnier Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory Date: Tue, 17 Feb 2015 18:03:26 +0100 References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> <831tlpvp35.fsf@gnu.org> <83twyltz5x.fsf@gnu.org> Message-ID: <85y4nwii2h.fsf@iznogoud.viz> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19865 Cc: Eli Zaretskii , 19865@debbugs.gnu.org, ivan@siamics.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Mon, Feb 16 2015, Stefan Monnier wrote: > [Eli wrote:] >> It's the same as working in the shell: > > That's also my impression. The shell analogy might be a bit misleading and is perhaps the reason why you seem to be talking past each other: Personally, at the shell command line, I don't change to the directory holding the tarball, instead I change to the directory where I want to extract it, like this $ cd ~/src; tar xvf ~/Downloads/foo.tar.gz This is quite different from the situation in emacs where C-x C-f ~/Downloads/foo.tar.gz results in buffers whose default-directory is ~/Downloads, hence the reason why doing M-x cd ~/src in the non-hidden buffer should have the effect as in the proposed patch. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 17 13:02:31 2015 Received: (at 19865) by debbugs.gnu.org; 17 Feb 2015 18:02:32 +0000 Received: from localhost ([127.0.0.1]:46531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNmTf-00089M-7v for submit@debbugs.gnu.org; Tue, 17 Feb 2015 13:02:31 -0500 Received: from mtaout26.012.net.il ([80.179.55.182]:44879) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNmTb-000895-UH for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 13:02:29 -0500 Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NJX00B00GEEHS00@mtaout26.012.net.il> for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 20:02:36 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJX001H4GSB30B0@mtaout26.012.net.il>; Tue, 17 Feb 2015 20:02:36 +0200 (IST) Date: Tue, 17 Feb 2015 20:02:29 +0200 From: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory In-reply-to: <85y4nwii2h.fsf@iznogoud.viz> X-012-Sender: halo1@inter.net.il To: Wolfgang Jenkner Message-id: <83pp985scq.fsf@gnu.org> References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> <831tlpvp35.fsf@gnu.org> <83twyltz5x.fsf@gnu.org> <85y4nwii2h.fsf@iznogoud.viz> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org, monnier@IRO.UMontreal.CA, ivan@siamics.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Wolfgang Jenkner > Cc: Eli Zaretskii , ivan@siamics.net, 19865@debbugs.gnu.org > Date: Tue, 17 Feb 2015 18:03:26 +0100 > > The shell analogy might be a bit misleading and is perhaps the reason > why you seem to be talking past each other: Personally, at the shell > command line, I don't change to the directory holding the tarball, > instead I change to the directory where I want to extract it, like this > > $ cd ~/src; tar xvf ~/Downloads/foo.tar.gz > > This is quite different from the situation in emacs where > > C-x C-f ~/Downloads/foo.tar.gz > > results in buffers whose default-directory is ~/Downloads, hence the > reason why doing M-x cd ~/src in the non-hidden buffer should have the > effect as in the proposed patch. To solve this problem, I proposed, in the beginning of this thread, to allow the user to specify a directory where to extract the tarball, by invoking the command with a prefix argument. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 17 13:06:01 2015 Received: (at 19865) by debbugs.gnu.org; 17 Feb 2015 18:06:01 +0000 Received: from localhost ([127.0.0.1]:46535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNmX3-0008EM-6N for submit@debbugs.gnu.org; Tue, 17 Feb 2015 13:06:01 -0500 Received: from fely.am-1.org ([78.47.74.50]:44303) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNmX1-0008EE-CW for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 13:06:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=k3t/Rd4rXdJw4wyqtQ5l5l9zef3wE+KzfP5IW5j7GZQ=; b=Ts1Jc5i0X2NAOXjJEoHo0Bz+W0MTHRsaud+He2/wYiXPTTG/jzbfcUg/S/bqm9T2JRBRVngjK4ELCr2TI50hmjWJiLiBhkswhjjAE+0Yp2CJU81trdU6AUTd2bbVQTacZ1jrAJMn+36K2sCGXznvoy/3lX+DIuJTahKYgn98jMU=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YNmWz-0003pr-UM for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 18:05:58 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YNmWs-0006Eh-Fo for 19865@debbugs.gnu.org; Wed, 18 Feb 2015 01:05:50 +0700 From: Ivan Shmakov To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> <831tlpvp35.fsf@gnu.org> <83twyltz5x.fsf@gnu.org> <87sie585yc.fsf@violet.siamics.net> <83egpo7d87.fsf@gnu.org> Mail-Followup-To: 19865@debbugs.gnu.org Date: Tue, 17 Feb 2015 18:05:49 +0000 In-Reply-To: <83egpo7d87.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Feb 2015 17:46:16 +0200") Message-ID: <87oaos8lc2.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Tue, 17 Feb 2015 05:25:47 +0000 [=E2=80=A6] > Emacs maintenance shouldn't pay a price for marginal use cases for > which simple workarounds (like "M-x cd BACK") are available. It is not a workaround for the problem in question. [=E2=80=A6] >> We=E2=80=99re using with-current-buffer there for the sole reason that >> write-region operates strictly on the current buffer. It is so >> without this change, and it remains so with it; the change maintains >> this status quo just perfectly. And as long as such use /is/ >> acceptable in the current code, I fail to see why it wouldn=E2=80=99t b= e in >> the replacement being discussed. > I already explained that, more than once: And I=E2=80=99ve already provided an example where default-directory is changed by Emacs behind the back of the user. > the change is obscure, Yet it makes the code /less/ obscure that it currently is. > and is made for the sake of a marginal use case, It is made for the sake of consistency with the rest of the tar-mode.el code. And sure: it fixes that marginal use case at the same time, too. > where the user should have returned to the original directory from > which she cd'ed, to avoid the problem. The use of M-x cd on a buffer does not influence the behavior of tar-untar-buffer for that same buffer in any way. When it thinks =E2=80=93 for whatever reason =E2=80=93 that it should use /that/directory as its target, =E2=80=93 it=E2=80=99s stuck that way, and = no sensible user action is going to change its twisted mind. (Incidentally, this is the very description of this bug.) There=E2=80=99s simply /no/ problem which the user could solve by changing the value of default-directory =E2=80=93 whether back, forth, or sideways. >> What /is/ changed is that with-current-buffer will now go >> immediately before write-region: >> (with-current-buffer data-buffer (write-region =E2=80=A6)) >> Cf. the former: >> (with-current-buffer data-buffer =E2=80=A6 lots of code to make sure the >> reader=E2=80=99s lost=E2=80=A6 (write-region =E2=80=A6)) [=E2=80=A6] > Now put yourself in the shoes of someone who needs to review this > change many moons from now, and try to imagine how "easy" it will be > for them to understand what the heck was that all about. Whose shoes do you think I was in while I=E2=80=99ve investigated this issue? My first thought: why on Earth does with-current-buffer wraps some 18=C2=A0LoC while it=E2=80=99s needed for exactly a single one? As for the =E2=80=9Cmany moons=E2=80=9D part, I think I=E2=80=99d request = a re-review after a few. Hopefully someone=E2=80=99d provide some more convincing arguments by then, since I=E2=80=99m pretty much out of ink right now. (And TIA to that party, sure.) [=E2=80=A6] --=20 FSF associate member #7257 tar-mode.el does nasty things 3013 B6A0 230E 33= 4A From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 17 22:38:30 2015 Received: (at 19865) by debbugs.gnu.org; 18 Feb 2015 03:38:30 +0000 Received: from localhost ([127.0.0.1]:46825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNvT4-0003bf-9d for submit@debbugs.gnu.org; Tue, 17 Feb 2015 22:38:30 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:52755) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNvT0-0003bV-MC for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 22:38:27 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t1I3cNti018522; Tue, 17 Feb 2015 22:38:23 -0500 Received: by pastel.home (Postfix, from userid 20848) id B2AF11E3C; Tue, 17 Feb 2015 22:38:05 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory Message-ID: References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> <831tlpvp35.fsf@gnu.org> <83twyltz5x.fsf@gnu.org> <83sie5tdho.fsf@gnu.org> Date: Tue, 17 Feb 2015 22:38:05 -0500 In-Reply-To: <83sie5tdho.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Feb 2015 05:37:23 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5220=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5220> : inlines <2217> : streams <1392082> : uri <1858021> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19865 Cc: 19865@debbugs.gnu.org, ivan@siamics.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >> No: I changed directory specifically because I wanted to operate on >> other files. And I often don't go back. > Then your next delete command will probably delete wrong files. No: it would delete the wrong file if I had *not* changed directory. > Comments cannot be a replacement for clear, self-explanatory code that > has no hidden dependencies. Of course, but in the case under discussion there is such a dependency, and we're just considering two different versions of the code, both of which have the exact same hidden dependency. IOW this situation sucks, but the patch is not the cause of it and doesn't make it worse (it makes it marginally better by adding a comment and by making the behavior right). >> The code takes a file name from one buffer and uses it in another >> buffer: every time we do it, we have to be extra careful to make sure >> the file name is absolute, and that's what the patch does. > If both buffers has the same default-directory, as they should, > there's no need to do anything special. Right: *as they should*. But there's no mechanism to keep them in sync. So the next best thing is to make sure we only use the default-directory from the proper buffer. > To solve this problem, I proposed, in the beginning of this thread, to > allow the user to specify a directory where to extract the tarball, by > invoking the command with a prefix argument. Your proposal is fine, but is orthogonal to the patch proposed by Ivan. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 06:05:27 2016 Received: (at 19865) by debbugs.gnu.org; 23 Feb 2016 11:05:27 +0000 Received: from localhost ([127.0.0.1]:39294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYAmV-0001FS-GX for submit@debbugs.gnu.org; Tue, 23 Feb 2016 06:05:27 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:40210) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYAmU-0001FL-R3 for 19865@debbugs.gnu.org; Tue, 23 Feb 2016 06:05:27 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYAm1-00041H-SH for 19865@debbugs.gnu.org; Tue, 23 Feb 2016 12:04:58 +0100 From: Lars Ingebrigtsen To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <87oaowbkgv.fsf@violet.siamics.net> <87bnkwbgr2.fsf@violet.siamics.net> <878ufya0o3.fsf@violet.siamics.net> Date: Tue, 23 Feb 2016 22:04:52 +1100 In-Reply-To: <878ufya0o3.fsf@violet.siamics.net> (Ivan Shmakov's message of "Mon, 16 Feb 2015 05:24:44 +0000") Message-ID: <874mczsn57.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-MailScanner-ID: 1aYAm1-00041H-SH X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456830298.6297@6OodZ6FwVyBtCDnb31qErw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Ivan Shmakov writes: > Fix default-directory handling in tar-untar-buffer. > > * lisp/tar-mode.el (tar-untar-buffer): Fixed: use the value of > default-directory local to the tar-mode buffer (was: > tar-data-buffer); clean-up. > > Fixes: debbugs:19865 > > PS. Should the pending objections be resolved by sometime around > 18:00=A0UTC today, I=92d happily push the change to =91master=92. As far as I can tell, the patch was never applied? It looks like a correct change to me... --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 13:56:16 2019 Received: (at 19865) by debbugs.gnu.org; 25 Jun 2019 17:56:16 +0000 Received: from localhost ([127.0.0.1]:33498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfpfv-0002Ht-QR for submit@debbugs.gnu.org; Tue, 25 Jun 2019 13:56:16 -0400 Received: from quimby.gnus.org ([80.91.231.51]:53572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfpfp-0002HQ-Fz for 19865@debbugs.gnu.org; Tue, 25 Jun 2019 13:56:10 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfpfj-0002dI-PP for 19865@debbugs.gnu.org; Tue, 25 Jun 2019 19:56:03 +0200 From: Lars Ingebrigtsen To: 19865@debbugs.gnu.org Subject: Re: bug#19865: tar-untar-buffer: should honor default-directory References: <87a90gd91b.fsf@violet.siamics.net> <87oaowbkgv.fsf@violet.siamics.net> <87bnkwbgr2.fsf@violet.siamics.net> <878ufya0o3.fsf@violet.siamics.net> <874mczsn57.fsf@gnus.org> Date: Tue, 25 Jun 2019 19:55:59 +0200 In-Reply-To: <874mczsn57.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 23 Feb 2016 22:04:52 +1100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Ivan Shmakov writes: > >> Fix default-directory handling in tar-untar-buffer. >> >> * lisp/tar-mode.el (tar-untar-buffer): Fixed: use the value of >> default-directory local to th [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19865 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Ivan Shmakov writes: > >> Fix default-directory handling in tar-untar-buffer. >> >> * lisp/tar-mode.el (tar-untar-buffer): Fixed: use the value of >> default-directory local to the tar-mode buffer (was: >> tar-data-buffer); clean-up. >> >> Fixes: debbugs:19865 >> >> PS. Should the pending objections be resolved by sometime around >> 18:00=C2=A0UTC today, I=E2=80=99d happily push the change to =E2=80=98m= aster=E2=80=99. > > As far as I can tell, the patch was never applied? It looks like a > correct change to me... That was three years ago, and now the patch didn't apply any more. But I respun the change that Ivan had done and I've now applied it to tar-mode. I've tested that it now untars to the current directory (even after M-x cd). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 13:56:16 2019 Received: (at control) by debbugs.gnu.org; 25 Jun 2019 17:56:16 +0000 Received: from localhost ([127.0.0.1]:33500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfpg0-0002I5-46 for submit@debbugs.gnu.org; Tue, 25 Jun 2019 13:56:16 -0400 Received: from quimby.gnus.org ([80.91.231.51]:53584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfpfu-0002Hj-I4 for control@debbugs.gnu.org; Tue, 25 Jun 2019 13:56:10 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfpfr-0002dU-Up for control@debbugs.gnu.org; Tue, 25 Jun 2019 19:56:09 +0200 Date: Tue, 25 Jun 2019 19:56:07 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #19865 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 19865 fixed close 19865 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 19865 fixed close 19865 27.1 quit From unknown Fri Jun 20 07:14:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 24 Jul 2019 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator