GNU bug report logs - #19851
25.0.50; package-install-{file,from-buffer} broken

Previous Next

Full log

Message #43 received at control <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: control <at> debbugs.gnu.org
Subject: Re: bug#19851: 25.0.50; package-install-{file,from-buffer} broken
Date: Sun, 21 Aug 2016 12:26:04 -0400

tags 19851 fixed
close 19851 25.2
quit

npostavs <at> users.sourceforge.net writes:

>>> I wonder why are you trying yo install a package from the empty directory?
>>
>> Just trying to break things is all.
>
> So we just need a better error message here?  Something like this:
>
>>From dabd1cb2ffe3aed39f11d89f5ab1acab5b1d0426 Mon Sep 17 00:00:00 2001
> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Sat, 25 Jun 2016 15:57:39 -0400
> Subject: [PATCH v1] Improve error when installing non-package dirs
>
> * lisp/emacs-lisp/package.el (package-dir-info): Throw meaningful error
> when no file with package info is found (Bug #19851).
> ---
>  lisp/emacs-lisp/package.el | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> index e721b55..f669c31 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -1081,6 +1081,8 @@ package-dir-info
>                (setq files nil)
>                ;; set the 'dir kind,
>                (setf (package-desc-kind info) 'dir))))
> +        (unless info
> +          (error "No .el files with package headers in `%s'" default-directory))
>          ;; and return the info.
>          info))))

Pushed as 14a86f83.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.