GNU bug report logs - #19850
25.0.50; [PATCH] configure.ac: Fix site-lisp paths with NS self-contained apps.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Jan D." <jan.h.d <at> swipnet.se>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#19850: closed (25.0.50; [PATCH] configure.ac: Fix site-lisp
 paths with NS self-contained apps.)
Date: Fri, 13 Feb 2015 16:47:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 13 Feb 2015 17:46:02 +0100
with message-id <ABF63548-2815-4BE5-95AF-01A2F72A46FF <at> swipnet.se>
and subject line Re: bug#19850: 25.0.50; [PATCH] configure.ac: Fix site-lisp paths with NS self-contained apps.
has caused the debbugs.gnu.org bug report #19850,
regarding 25.0.50; [PATCH] configure.ac: Fix site-lisp paths with NS self-contained apps.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
19850: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19850
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: David Caldwell <david <at> porkrind.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; [PATCH] configure.ac: Fix site-lisp paths with NS
 self-contained apps.
Date: Thu, 12 Feb 2015 13:51:28 -0800

[Message part 3 (text/plain, inline)]

When building a self contained Mac OS X app, the site-lisp dir that gets
inserted into `load-path` is not very useful, since it points to the
Emacs.app in `nextstep/` where emacs was compiled. For example:

"/Users/build/workspace/Emacs-Multi-Build/label/mavericks/emacs-source/nextstep/Emacs.app/Contents/Resources/share/emacs/24.4/site-lisp"

I think the site lisp path should be in `/Library/emacs` instead. Here
is a patch to do just that (created with `git format-patch`, is that
convenient? I don't know what works best in these cases).

I patched the trunk, but on reflection, it seems like this should go in
the 24 branch, too.

-David

From c20e8816f3905fa3ec6f82a7f566f7ce32dc178b Mon Sep 17 00:00:00 2001
From: David Caldwell <david <at> porkrind.org>
Date: Thu, 12 Feb 2015 13:31:36 -0800
Subject: [PATCH] configure.ac: Fix site-lisp paths with NS self-contained
 apps.

* configure.ac (HAVE_NS): When self-contained, set datarootdir to
/Library so PATH_SITELOADSEARCH path points there instead of inside
the Emacs.app build dir.
---
 configure.ac | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configure.ac b/configure.ac
index 68291b8..3e44a93 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1872,6 +1872,8 @@ if test "${HAVE_NS}" = yes; then
      mandir="\${ns_appresdir}/man"
      lispdir="\${ns_appresdir}/lisp"
      INSTALL_ARCH_INDEP_EXTRA=
+     # This is so PATH_SITELOADSEARCH gets set to /Library/emacs/...
+     datarootdir=/Library
   fi

   NS_OBJC_OBJ="nsterm.o nsfns.o nsmenu.o nsselect.o nsimage.o $ns_fontfile"
--
2.2.2

[mac-site-lisp-path.patch (text/plain, attachment)]

[smime.p7s (application/pkcs7-signature, attachment)]

[Message part 6 (message/rfc822, inline)]

From: "Jan D." <jan.h.d <at> swipnet.se>
To: David Caldwell <david <at> porkrind.org>
Cc: 19850-done <at> debbugs.gnu.org
Subject: Re: bug#19850: 25.0.50;
 [PATCH] configure.ac: Fix site-lisp paths with NS self-contained apps.
Date: Fri, 13 Feb 2015 17:46:02 +0100

I have fixed in trunk so that directories pointing to the build dir is not in loadpath.

	Jan D.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.