GNU bug report logs - #19848
Minibuffer completion does not work with ECB package?

Previous Next

Package: emacs;

Reported by: Angelo Graziosi <angelo.graziosi <at> alice.it>

Date: Thu, 12 Feb 2015 20:20:01 UTC

Severity: normal

Tags: moreinfo

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19848 in the body.
You can then email your comments to 19848 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#19848; Package emacs. (Thu, 12 Feb 2015 20:20:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Angelo Graziosi <angelo.graziosi <at> alice.it>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 12 Feb 2015 20:20:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Angelo Graziosi <angelo.graziosi <at> alice.it>
To: bug-gnu-emacs <at> gnu.org
Subject: Minibuffer completion does not work with ECB package?
Date: Thu, 12 Feb 2015 21:18:55 +0100
(Following Stefan's suggestion: 
http://lists.gnu.org/archive/html/emacs-devel/2015-02/msg00790.html)

It seems that minibuffer completion does not work properly if ECB
package is installed (from MELPA, with : Options | Manage Emacs 
Packages), and active.

For example, if I want to strip the trailing withe spaces (M-x
delete-trailing-whitespace), I try

  M-x del<TAB>

In the minibuffer I get

Click on a completion to select it.
In this buffer, type RET to select the completion near point.

Possible completions are:
delete-backward-char 	delete-blank-lines
[...]


but at this point, if I click on 'delete-trailing-whitespace', I get

  Minibuffer is not active for completion


If I try to exit with C-G, it print 'Quit', but does not exit. In short,
whatever I do I cannot exit minibuffer if not quitting Emacs.

In the above, if I change 'M-x del<TAB>' with

  M-x dele<TAB>

the completion works,

  M-x delete-

and with few other tabs I can complete the command.

I can reproduce this behavior with this minimal init.el file in ~/.emacs.d:

$ cat init.el
;;
;; ECB : Emacs Code browser setup
;;
(add-to-list 'load-path "~/.emacs.d/elpa/ecb-20140215.114")
(require 'ecb)

;; So that ECB is activated at Emacs startup
(setq ecb-auto-activate t)

;; This is suggested here:
;; http://www.patrickmin.com/linux/tip.php?name=emacs_ecb_startup
(setq ecb-tip-of-the-day nil)
(custom-set-variables '(ecb-options-version "2.40"))

Maybe the issue is in ECB, so I flagged this just for completeness.


TIA,
 Angelo.






Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19848; Package emacs. (Sun, 11 Dec 2016 23:47:01 GMT) Full text and rfc822 format available.

Message #8 received at 19848 <at> debbugs.gnu.org (full text, mbox):

From: Thorsten Bonow <thorsten.bonow <at> withouthat.org>
To: 19848 <at> debbugs.gnu.org
Subject: bug#19848: Minibuffer completion does not work with ECB package?
Date: Sun, 11 Dec 2016 22:57:51 +0100 (CET)
> It seems that minibuffer completion does not work properly if ECB
> package is installed (from MELPA, with : Options | Manage Emacs 
> Packages), and active.
 
> For example, if I want to strip the trailing withe spaces (M-x
> delete-trailing-whitespace), I try
 
>   M-x del<TAB>
 
> In the minibuffer I get
 
> Click on a completion to select it.
> In this buffer, type RET to select the completion near point.
 
> Possible completions are:
> delete-backward-char 	delete-blank-lines
> [...]
  
> but at this point, if I click on 'delete-trailing-whitespace', I get
 
>   Minibuffer is not active for completion
 
> If I try to exit with C-G, it print 'Quit', but does not exit. In short,
> whatever I do I cannot exit minibuffer if not quitting Emacs.

Hi,

I don't think it's an Emacs bug. I think ECB chokes on the Emacs 25
version of `minibuffer-completion-help' from "minibuffer.el".

Version 25 of `minibuffer-completion-help' now calls
`display-buffer-at-bottom' which appears not to be adapted to the ECB
layout. (ECB divides its frame into special ECB windows on the left or
right side of the frame and one main "edit-area". By advising the
window functions like `display-buffer', the ECB layout is left
undisturbed; window functions only act on the "edit-area". Since
`display-buffer-at-bottom' is not advised, this now fails with Emacs
25.)

As a workaround till this is fixed in ECB I wrote an advice for
`display-buffer-at-bottom', which overrides this defun in the ECB
frame and calls 'display-buffer-use-some-window' instead. A call to
`display-buffer-use-some-window' in other frames will call the
unmodified defun. The Completion buffer takes up the whole
"edit-area", but selecting a completion works for me now.

Toto

(defun display-buffer-at-bottom--display-buffer-at-bottom-around (orig-fun &rest args)
  "Bugfix for ECB: cannot use `display-buffer-at-bottom', call
`display-buffer-use-some-window' instead in ECB frame."
  (if (and ecb-minor-mode (equal (selected-frame) ecb-frame))
      (apply 'display-buffer-use-some-window args)
    (apply orig-fun args)))
(advice-add 'display-buffer-at-bottom :around #'display-buffer-at-bottom--display-buffer-at-bottom-around)





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19848; Package emacs. (Fri, 01 Nov 2019 23:36:02 GMT) Full text and rfc822 format available.

Message #11 received at 19848 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Thorsten Bonow <thorsten.bonow <at> withouthat.org>
Cc: 19848 <at> debbugs.gnu.org
Subject: Re: bug#19848: Minibuffer completion does not work with ECB package?
Date: Sat, 02 Nov 2019 00:35:38 +0100
Thorsten Bonow <thorsten.bonow <at> withouthat.org> writes:

>> It seems that minibuffer completion does not work properly if ECB
>> package is installed (from MELPA, with : Options | Manage Emacs 
>> Packages), and active.
>  
>> For example, if I want to strip the trailing withe spaces (M-x
>> delete-trailing-whitespace), I try
>  
>>   M-x del<TAB>
>  
>> In the minibuffer I get
>  
>> Click on a completion to select it.
>> In this buffer, type RET to select the completion near point.
>  
>> Possible completions are:
>> delete-backward-char 	delete-blank-lines
>> [...]
>   
>> but at this point, if I click on 'delete-trailing-whitespace', I get
>  
>>   Minibuffer is not active for completion
>  
>> If I try to exit with C-G, it print 'Quit', but does not exit. In short,
>> whatever I do I cannot exit minibuffer if not quitting Emacs.
>
> Hi,
>
> I don't think it's an Emacs bug. I think ECB chokes on the Emacs 25
> version of `minibuffer-completion-help' from "minibuffer.el".

The last message here suggests that this is not an Emacs bugs.  Does
anyone disagree with that?

Best regards,
Stefan Kangas




Added tag(s) moreinfo. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Thu, 21 Nov 2019 12:00:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19848; Package emacs. (Fri, 29 Nov 2019 13:10:02 GMT) Full text and rfc822 format available.

Message #16 received at 19848 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Thorsten Bonow <thorsten.bonow <at> withouthat.org>
Cc: 19848 <at> debbugs.gnu.org
Subject: Re: bug#19848: Minibuffer completion does not work with ECB package?
Date: Fri, 29 Nov 2019 14:09:19 +0100
Stefan Kangas <stefan <at> marxist.se> writes:

>> I don't think it's an Emacs bug. I think ECB chokes on the Emacs 25
>> version of `minibuffer-completion-help' from "minibuffer.el".
>
> The last message here suggests that this is not an Emacs bug.  Does
> anyone disagree with that?

More information was requested, but none was given within 4 weeks, so
I'm closing this bug.  If this is still an issue, please reply to this
email (use "Reply to all" in your email client) and we can reopen the
bug report.

Best regards,
Stefan Kangas




Reply sent to Stefan Kangas <stefan <at> marxist.se>:
You have taken responsibility. (Wed, 15 Jan 2020 05:35:02 GMT) Full text and rfc822 format available.

Notification sent to Angelo Graziosi <angelo.graziosi <at> alice.it>:
bug acknowledged by developer. (Wed, 15 Jan 2020 05:35:02 GMT) Full text and rfc822 format available.

Message #21 received at 19848-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Thorsten Bonow <thorsten.bonow <at> withouthat.org>
Cc: 19848-done <at> debbugs.gnu.org
Subject: Re: bug#19848: Minibuffer completion does not work with ECB package?
Date: Wed, 15 Jan 2020 06:34:27 +0100
Stefan Kangas <stefan <at> marxist.se> writes:

> Stefan Kangas <stefan <at> marxist.se> writes:
>
>>> I don't think it's an Emacs bug. I think ECB chokes on the Emacs 25
>>> version of `minibuffer-completion-help' from "minibuffer.el".
>>
>> The last message here suggests that this is not an Emacs bug.  Does
>> anyone disagree with that?
>
> More information was requested, but none was given within 4 weeks, so
> I'm closing this bug.  If this is still an issue, please reply to this
> email (use "Reply to all" in your email client) and we can reopen the
> bug report.

I missed to actually close this bug.  Closing it now.

Best regards,
Stefan Kangas




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19848; Package emacs. (Wed, 15 Jan 2020 05:57:01 GMT) Full text and rfc822 format available.

Message #24 received at 19848-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 19848-done <at> debbugs.gnu.org
Subject: Re: bug#19848: Minibuffer completion does not work with ECB package?
Date: Wed, 15 Jan 2020 06:56:51 +0100
Stefan Kangas <stefan <at> marxist.se> writes:

> Stefan Kangas <stefan <at> marxist.se> writes:
>
>>> I don't think it's an Emacs bug. I think ECB chokes on the Emacs 25
>>> version of `minibuffer-completion-help' from "minibuffer.el".
>>
>> The last message here suggests that this is not an Emacs bug.  Does
>> anyone disagree with that?
>
> More information was requested, but none was given within 4 weeks, so
> I'm closing this bug.  If this is still an issue, please reply to this
> email (use "Reply to all" in your email client) and we can reopen the
> bug report.

It seems this was left open for some reason; closing now.

Best regards,
Stefan Kangas




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 12 Feb 2020 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 125 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.