From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 11 22:40:50 2015 Received: (at submit) by debbugs.gnu.org; 12 Feb 2015 03:40:50 +0000 Received: from localhost ([127.0.0.1]:40468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YLkdx-0002iB-TT for submit@debbugs.gnu.org; Wed, 11 Feb 2015 22:40:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54377) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YLjVP-0000aH-AH for submit@debbugs.gnu.org; Wed, 11 Feb 2015 21:27:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLjVI-0007ku-OT for submit@debbugs.gnu.org; Wed, 11 Feb 2015 21:27:45 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: *** X-Spam-Status: No, score=3.3 required=5.0 tests=BAYES_50,HTML_MESSAGE, RECEIVED_FROM_WINDOWS_HOST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLjVI-0007kq-Ls for submit@debbugs.gnu.org; Wed, 11 Feb 2015 21:27:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLjVH-0001sa-D3 for bug-gnu-emacs@gnu.org; Wed, 11 Feb 2015 21:27:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLjVA-0007j7-I7 for bug-gnu-emacs@gnu.org; Wed, 11 Feb 2015 21:27:43 -0500 Received: from mail-bn1on0144.outbound.protection.outlook.com ([157.56.110.144]:30448 helo=na01-bn1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLjVA-0007iu-Bv for bug-gnu-emacs@gnu.org; Wed, 11 Feb 2015 21:27:36 -0500 Received: from [192.168.0.3] (75.166.160.171) by DM2PR0201MB0816.namprd02.prod.outlook.com (25.160.95.15) with Microsoft SMTP Server (TLS) id 15.1.81.19; Thu, 12 Feb 2015 01:53:25 +0000 Message-ID: <54DC078E.7030804@roguewave.com> Date: Wed, 11 Feb 2015 18:53:18 -0700 From: Jeff Gran User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Subject: comint-mode obliterates previous faces with `comint-highlight-prompt' Content-Type: multipart/alternative; boundary="------------020105090905010701090400" X-Originating-IP: [75.166.160.171] X-ClientProxiedBy: BY2PR02CA0035.namprd02.prod.outlook.com (10.141.216.25) To DM2PR0201MB0816.namprd02.prod.outlook.com (25.160.95.15) Authentication-Results: gnu.org; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:DM2PR0201MB0816; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004); SRVR:DM2PR0201MB0816; X-Forefront-PRVS: 0485417665 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6049001)(230783001)(50986999)(87266999)(19617315012)(40100003)(54356999)(65816999)(15975445007)(117156001)(65806001)(66066001)(450100001)(122386002)(84326002)(33656002)(65956001)(19580395003)(42186005)(77096005)(16236675004)(86362001)(110136001)(46102003)(229853001)(107886001)(2351001)(62966003)(77156002)(36756003)(87976001)(92566002)(512874002)(81973001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM2PR0201MB0816; H:[192.168.0.3]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:; SRVR:DM2PR0201MB0816; X-OriginatorOrg: roguewave.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2015 01:53:25.1445 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0201MB0816 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 11 Feb 2015 22:40:44 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --------------020105090905010701090400 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit I believe this is easy to reproduce. I'm happy to help with additional info if needed. In shell-mode, I have a PS1 that has ansi-color control codes in it. But it is obliterated by the `comint-highlight-prompt' face. In previous versions of emacs, the comint-highlight-prompt was an overlay, however this commit: https://github.com/emacs-mirror/emacs/commit/74c5d24c74e3167db6e3ee01831584c99905bb70 ...changed it to just apply the face instead of overlaying it. It mentions Bug#14744, but I'm not sure what that is. I preferred having it overlay. However, earlier than that there was a `defcustom' option that switched the comint-highlight-prompt on or off altogether, which is probably the best solution. Again, not sure why that was ever removed, except that maybe that author in 2002 decided that using an overlay that could be set to nil accomplishes the same goal, which is the option of having or not having a prompt highlight face applied. See https://github.com/emacs-mirror/emacs/commit/8b1d2946a2f9e6779c405ee81f0162470d2eb79b When I type "C-u C-x =" on the characters that should be colored in my prompt, I see that there is ansi-color-face property, but it is not visible because the face is applied on top of it: There are text properties here: ansi-color-face (foreground-color . "#3AaCbf") field output font-lock-face comint-highlight-prompt fontified t front-sticky (read-only) inhibit-line-move-field-capture t read-only t rear-nonsticky t I think the best solution is probably to put the boolean custom options back in so that the user can specify whether they want the font-face applied or not. -- Jeff Gran --------------020105090905010701090400 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit I believe this is easy to reproduce. I'm happy to help with additional info if needed.

In shell-mode, I have a PS1 that has ansi-color control codes in it. But it is obliterated by the `comint-highlight-prompt' face.

In previous versions of emacs, the comint-highlight-prompt was an overlay, however this commit:

https://github.com/emacs-mirror/emacs/commit/74c5d24c74e3167db6e3ee01831584c99905bb70

...changed it to just apply the face instead of overlaying it. It mentions Bug#14744, but I'm not sure what that is. I preferred having it overlay.

However, earlier than that there was a `defcustom' option that switched the comint-highlight-prompt on or off altogether, which is probably the best solution. Again, not sure why that was ever removed, except that maybe that author in 2002 decided that using an overlay that could be set to nil accomplishes the same goal, which is the option of having or not having a prompt highlight face applied.

See https://github.com/emacs-mirror/emacs/commit/8b1d2946a2f9e6779c405ee81f0162470d2eb79b

When I type "C-u C-x =" on the characters that should be colored in my prompt, I see that there is ansi-color-face property, but it is not visible because the face is applied on top of it:

There are text properties here:
  ansi-color-face      (foreground-color . "#3AaCbf")
  field                output
  font-lock-face       comint-highlight-prompt
  fontified            t
  front-sticky         (read-only)
  inhibit-line-move-field-capture t
  read-only            t
  rear-nonsticky       t


I think the best solution is probably to put the boolean custom options back in so that the user can specify whether they want the font-face applied or not.

 
-- 
Jeff Gran
--------------020105090905010701090400-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 26 01:27:32 2015 Received: (at control) by debbugs.gnu.org; 26 May 2015 05:27:32 +0000 Received: from localhost ([127.0.0.1]:56143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yx7Ol-0008MW-Rx for submit@debbugs.gnu.org; Tue, 26 May 2015 01:27:32 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:40422 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yx7Ok-0008MM-1z for control@debbugs.gnu.org; Tue, 26 May 2015 01:27:30 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Yx7Oj-00025S-7v for control@debbugs.gnu.org; Tue, 26 May 2015 01:27:29 -0400 Date: Tue, 26 May 2015 01:27:29 -0400 Message-Id: Subject: control message for bug 20658 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 19843 20658 From debbugs-submit-bounces@debbugs.gnu.org Tue May 26 01:32:46 2015 Received: (at control) by debbugs.gnu.org; 26 May 2015 05:32:46 +0000 Received: from localhost ([127.0.0.1]:56152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yx7Tp-0001Am-Lu for submit@debbugs.gnu.org; Tue, 26 May 2015 01:32:45 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:40688 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yx7Tn-00019b-W0 for control@debbugs.gnu.org; Tue, 26 May 2015 01:32:44 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Yx7Tn-0005Ed-AF for control@debbugs.gnu.org; Tue, 26 May 2015 01:32:43 -0400 Date: Tue, 26 May 2015 01:32:43 -0400 Message-Id: Subject: control message for bug 20658 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) unarchive 20084 fixed 20658 25.1 forcemerge 20084 20658 From unknown Sun Aug 10 16:46:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 23 Jun 2015 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator