GNU bug report logs - #19828
[PATCH] eval.c: couldn't make closures

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19828 in the body.
You can then email your comments to 19828 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 尾崎 成一 <mitararu <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] eval.c: couldn't make closures
Date: Tue, 10 Feb 2015 16:25:02 +0900

Hi.

The following code doesn't work because doesn't create any lexical
environment correctly in Emacs 24.4.1.


(defvar my-ticker nil)
;; => my-ticker

(let ((x 0))
  (setq my-ticker (lambda ()
            (setq x (1+ x)))))
;; => (lambda nil
;; =>   (setq x
;; =>     (1+ x)))

(funcall my-ticker)
;; error--> Symbol's value as variable is void: x


After fixing that, it works well.


(defvar my-ticker)
;; => my-ticker

(let ((x 0))
  (setq my-ticker (lambda ()
            (setq x (1+ x)))))
;; => (closure
;; =>  ((x . 0))
;; =>  nil
;; =>  (setq x
;; =>        (1+ x)))

(funcall my-ticker)
;; => 1
(funcall my-ticker)
;; => 2



Regard,
Shigekazu


=== modified file 'src/eval.c'
--- src/eval.c    2014-09-16 04:04:56 +0000
+++ src/eval.c    2015-02-10 06:48:29 +0000
@@ -875,7 +875,7 @@
       val = eval_sub (Fcar (Fcdr (elt)));
     }

-      if (!NILP (lexenv) && SYMBOLP (var)
+      if (SYMBOLP (var)
       && !XSYMBOL (var)->declared_special
       && NILP (Fmemq (var, Vinternal_interpreter_environment)))
     /* Lexically bind VAR by adding it to the interpreter's binding
@@ -953,7 +953,7 @@
       var = SYMBOLP (elt) ? elt : Fcar (elt);
       tem = temps[argnum++];

-      if (!NILP (lexenv) && SYMBOLP (var)
+      if (SYMBOLP (var)
       && !XSYMBOL (var)->declared_special
       && NILP (Fmemq (var, Vinternal_interpreter_environment)))
     /* Lexically bind VAR by adding it to the lexenv alist.  */

Message #8 received at 19828 <at> debbugs.gnu.org (full text, mbox):

From: Shigekazu Ozaki <mitararu <at> gmail.com>
To: 19828 <at> debbugs.gnu.org
Subject: Re: bug#19828: [PATCH] eval.c: couldn't make closures
Date: Tue, 10 Feb 2015 19:18:43 +0900

Sorry everyone, if you attach this patch, Info-menu command won't work.

Message #11 received at 19828 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>
To: 尾崎 成一 <mitararu <at> gmail.com>
Cc: 19828 <at> debbugs.gnu.org
Subject: Re: bug#19828: [PATCH] eval.c: couldn't make closures
Date: Tue, 10 Feb 2015 12:17:39 +0100

Hello,

尾崎 成一 <mitararu <at> gmail.com> writes:
> The following code doesn't work because doesn't create any lexical
> environment correctly in Emacs 24.4.1.

I think this is not a bug. In order for emacs to create closures, you
need to enable lexical-binding (usually done via a file local variable
at the top of the file, e.g. using add-file-local-variable-prop-line).

See (info "(elisp) Closures").

HTH,

-- 
Nicolas Richard

Message #14 received at 19828 <at> debbugs.gnu.org (full text, mbox):

From: Shigekazu Ozaki <mitararu <at> gmail.com>
To: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>
Cc: 19828 <at> debbugs.gnu.org
Subject: Re: bug#19828: [PATCH] eval.c: couldn't make closures
Date: Tue, 10 Feb 2015 21:06:06 +0900

>> The following code doesn't work because doesn't create any lexical
>> environment correctly in Emacs 24.4.1.
>
> I think this is not a bug. In order for emacs to create closures, you
> need to enable lexical-binding (usually done via a file local variable
> at the top of the file, e.g. using add-file-local-variable-prop-
> line).
>
> See (info "(elisp) Closures").

I see. I've misunderstood about the lexical bindings. Thank you. It's
very kind of you.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.