GNU bug report logs - #19826
25.0.50; wrong binding for 'comment-line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19826 in the body.
You can then email your comments to 19826 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mark Oteiza <mvoteiza <at> udel.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; wrong binding for 'comment-line
Date: Tue, 10 Feb 2015 01:09:33 -0500

Hi,

(define-key ctl-x-map "C-;" 'comment-line)

is missing the backslash, and should be

(define-key ctl-x-map "\C-;" 'comment-line)

Message #10 received at 19826 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 19826 <at> debbugs.gnu.org
Cc: Mark Oteiza <mvoteiza <at> udel.edu>,
 Artur Malabarba <bruce.connor.am <at> gmail.com>
Subject: Re: 25.0.50; wrong binding for 'comment-line
Date: Sat, 21 Feb 2015 13:00:02 -0800

Artur installed Mark's proposed patch, but that broke 'make bootstrap', as there 
is no 'C-;' character.  I don't know what binding Artur had in mind, so I 
guessed 'M-;' was intended and installed that as commit 
1cb34285463d2b9050a031a7f9a53d376de5b489, so as to fix 'make bootstrap'.  Please 
feel free to improve on the binding.

Message #15 received at 19826-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: bruce.connor.am <at> gmail.com, Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 19826-done <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There
 is no 'C-; '.
Date: Sun, 22 Feb 2015 22:04:49 -0800

[Message part 1 (text/plain, inline)]

Artur Malabarba wrote:
> The actual binding was supposed to be C-x C-;. The problem with bootstrap
> surprises me, but I guess it must be something in the order that files are
> loaded.

It's because if you try to evaluate the string "\C-;", Emacs throws (error 
"Invalid modifier in string").  I installed the attached patch to use the 
keybinding that you wanted.  This should fix the bug, so I'm closing the bug report.

[0001-Fix-the-desired-binding-for-comment-line.patch (text/x-patch, attachment)]

Message #18 received at 19826-done <at> debbugs.gnu.org (full text, mbox):

From: Artur Malabarba <bruce.connor.am <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 19826-done <at> debbugs.gnu.org
Subject: Re: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is
 no 'C-; '.
Date: Mon, 23 Feb 2015 07:32:24 +0000

[Message part 1 (text/plain, inline)]

Yes, that looks fine. Thanks again.!
On Feb 23, 2015 3:04 AM, "Paul Eggert" <eggert <at> cs.ucla.edu> wrote:

> Artur Malabarba wrote:
>
>> The actual binding was supposed to be C-x C-;. The problem with bootstrap
>> surprises me, but I guess it must be something in the order that files are
>> loaded.
>>
>
> It's because if you try to evaluate the string "\C-;", Emacs throws (error
> "Invalid modifier in string").  I installed the attached patch to use the
> keybinding that you wanted.  This should fix the bug, so I'm closing the
> bug report.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.