GNU bug report logs - #19823
25.0.50; Inferior-python-mode buffer can't be killed if process is dead

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: fgallina <at> gnu.org (Fabián Ezequiel Gallina)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#19823: closed (25.0.50; Inferior-python-mode buffer can't be
 killed if process is dead)
Date: Thu, 12 Feb 2015 03:43:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 12 Feb 2015 00:42:11 -0300
with message-id <87y4o3eqy4.fsf <at> gnu.org>
and subject line 25.0.50; Inferior-python-mode buffer can't be killed if process is dead
has caused the debbugs.gnu.org bug report #19823,
regarding 25.0.50; Inferior-python-mode buffer can't be killed if process is dead
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
19823: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19823
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dima Kogan <dima <at> secretsauce.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50;
 Inferior-python-mode buffer can't be killed if process is dead
Date: Mon, 09 Feb 2015 12:05:09 -0800

Hi. Currently emacs requires the inferior python process to exist to be
able to kill that buffer. If the inferior process exits earlier for any
reason, it's impossible to kill the buffer. Recipe:

1. emacs -Q
2. M-x python
3. exit()       [ this exits the session, killing the inferior process ]
4. C-x k enter  [ Error! "No inferior Python process running" ]


This happens because a cleanup handler fails. It needs to explicitly
ignore this particular failure. Wrapping the contents of
python-shell-font-lock-kill-buffer() into (ignore-errors ....) is one
way to fix this:

(defun python-shell-font-lock-kill-buffer ()
  "Kill the font-lock buffer safely."
  (ignore-errors
    (python-shell-with-shell-buffer
      (when (and python-shell--font-lock-buffer
                 (buffer-live-p python-shell--font-lock-buffer))
        (kill-buffer python-shell--font-lock-buffer)
        (when (derived-mode-p 'inferior-python-mode)
          (setq python-shell--font-lock-buffer nil))))))

It should probably be more specific than a blanket ignore-errors, but
the maintainers should decide what they want here.

[Message part 3 (message/rfc822, inline)]

From: fgallina <at> gnu.org (Fabián Ezequiel Gallina)
To: 19823-done <at> debbugs.gnu.org
Subject: 25.0.50;
 Inferior-python-mode buffer can't be killed if process is dead
Date: Thu, 12 Feb 2015 00:42:11 -0300

Fixed at revno da726ad in the master branch.


Thanks,
Fabián.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.