GNU bug report logs - #19796
25.0.50; Regression: highlight-lines-matching-regexp can't re-highlight the same string

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#19796: closed (25.0.50; Regression: highlight-lines-matching-regexp
 can't re-highlight the same string)
Date: Wed, 11 Feb 2015 21:43:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 11 Feb 2015 16:41:41 -0500
with message-id <jwvvbj886xp.fsf-monnier+emacsbugs <at> gnu.org>
and subject line Re: bug#19796: 25.0.50; Regression: highlight-lines-matching-regexp can't re-highlight the same string
has caused the debbugs.gnu.org bug report #19796,
regarding 25.0.50; Regression: highlight-lines-matching-regexp can't re-highlight the same string
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
19796: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19796
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dima Kogan <dima <at> secretsauce.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50;
 Regression: highlight-lines-matching-regexp can't re-highlight the
 same string
Date: Fri, 06 Feb 2015 22:57:30 -0800

Hi.

The following commit broke some hi-lock functionality:

commit 6711a21f1125c0047c56eb266eb374c1ec90a967
Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
Date:   Wed May 28 23:45:29 2014 -0400

    ...
    * lisp/hi-lock.el (hi-lock-mode, hi-lock-unface-buffer)
    (hi-lock-set-pattern, hi-lock-set-file-patterns): Use font-lock-flush.
    ...


Recipe to reproduce:

1. seq 1000 > /tmp/dat
2. emacs -Q /tmp/dat
3. M-s h l 7       (highlight all lines matching "7")
4. M-s h u [enter] (un-highlight the default, "7" in this case)
5. M-s h l 7       (highlight all lines matching "7" again)

After that commit, nothing is highlighted anymore

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 19796-done <at> debbugs.gnu.org
Subject: Re: bug#19796: 25.0.50;
 Regression: highlight-lines-matching-regexp can't re-highlight the
 same string
Date: Wed, 11 Feb 2015 16:41:41 -0500

> 1. seq 1000 > /tmp/dat
> 2. emacs -Q /tmp/dat
> 3. M-s h l 7       (highlight all lines matching "7")
> 4. M-s h u [enter] (un-highlight the default, "7" in this case)
> 5. M-s h l 7       (highlight all lines matching "7" again)

> After that commit, nothing is highlighted anymore

Yuck, the old behavior looked right but was subtly wrong (the
highlighting at step 5 was done via font-lock whereas it was done with
overlays at step 3), and the recent change made the difference "more
visible" ;-)

The real problem is in font-lock, I think, but I don't have the courage
to fix it now, so I've installed a workaround that I hope will be sufficient.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.