GNU bug report logs - #19773
23.2; kill-rectangle documentation

Previous Next

Full log

Message #10 received at control <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: vincent douzal <vincent.douzal <at> teledetection.fr>
Cc: 19773 <at> debbugs.gnu.org
Subject: Re: bug#19773: 23.2; kill-rectangle documentation
Date: Sun, 03 Jul 2016 22:09:37 -0400

[Message part 1 (text/plain, inline)]

tags 19773 patch
quit

vincent douzal <vincent.douzal <at> teledetection.fr> writes:

> Hello,
>
> The documentation string for kill-rectangle erroneously speaks about the
> kill ring.  Rectangles of text are not copied to the kill ring, but in
> the variable kill-rectangle, which besides is not a ring.

Hmm yeah, looks like copy-pasto.  Should we mention the variable name
directly in the docstring (as in patch below) or is it better to just
say it's "saved"?

[v1-0001-kill-rectangle-should-mention-kill-rectangle.patch (text/x-diff, inline)]

From e2455dd16032f21884b39169a70386801a27392a Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs <at> gmail.com>
Date: Sun, 3 Jul 2016 21:40:26 -0400
Subject: [PATCH v1] kill-rectangle should mention kill-rectangle

* lisp/rect.el (kill-rectangle): Mention `killed-rectangle' in docstring
and warning message, rather than kill ring (Bug#19773).
---
 lisp/rect.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/rect.el b/lisp/rect.el
index 43621d9..8fedce2 100644
--- a/lisp/rect.el
+++ b/lisp/rect.el
@@ -284,7 +284,7 @@ kill-rectangle
 deleted.
 
 If the buffer is read-only, Emacs will beep and refrain from deleting
-the rectangle, but put it in the kill ring anyway.  This means that
+the rectangle, but put it in `killed-rectangle' anyway.  This means that
 you can use this command to copy text from a read-only buffer.
 \(If the variable `kill-read-only-ok' is non-nil, then this won't
 even beep.)"
@@ -295,7 +295,7 @@ kill-rectangle
      (setq deactivate-mark t)
      (setq killed-rectangle (extract-rectangle start end))
      (if kill-read-only-ok
-	 (progn (message "Read only text copied to kill ring") nil)
+	 (progn (message "Read only text copied to `killed-rectangle'") nil)
        (barf-if-buffer-read-only)
        (signal 'text-read-only (list (current-buffer)))))))
 
-- 
2.8.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.