From unknown Sun Jun 22 00:02:10 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19763 <19763@debbugs.gnu.org> To: bug#19763 <19763@debbugs.gnu.org> Subject: Status: 24.4; artist-mode: ellipse filled incorrectly Reply-To: bug#19763 <19763@debbugs.gnu.org> Date: Sun, 22 Jun 2025 07:02:10 +0000 retitle 19763 24.4; artist-mode: ellipse filled incorrectly reassign 19763 emacs submitter 19763 Andrea Rossetti severity 19763 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 03 19:42:48 2015 Received: (at submit) by debbugs.gnu.org; 4 Feb 2015 00:42:48 +0000 Received: from localhost ([127.0.0.1]:33268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YIo3L-0004bB-O9 for submit@debbugs.gnu.org; Tue, 03 Feb 2015 19:42:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51935) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YIo3J-0004ay-4V for submit@debbugs.gnu.org; Tue, 03 Feb 2015 19:42:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIo3D-0001u1-2e for submit@debbugs.gnu.org; Tue, 03 Feb 2015 19:42:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIo3C-0001tx-W1 for submit@debbugs.gnu.org; Tue, 03 Feb 2015 19:42:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIo3C-0003pv-2l for bug-gnu-emacs@gnu.org; Tue, 03 Feb 2015 19:42:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIo37-0001tJ-N1 for bug-gnu-emacs@gnu.org; Tue, 03 Feb 2015 19:42:38 -0500 Received: from mail-we0-x231.google.com ([2a00:1450:400c:c03::231]:50561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIo37-0001tA-FZ for bug-gnu-emacs@gnu.org; Tue, 03 Feb 2015 19:42:33 -0500 Received: by mail-we0-f177.google.com with SMTP id l61so47997341wev.8 for ; Tue, 03 Feb 2015 16:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=skoAIEtmz3h+mdac4alGih/fDuTf10uSCvILDJElQZc=; b=ACjREtweNoncHL66sx1X+v5Wx7TtMY3FNKN8doJV3EcQW+KVh0kaeVAXJeqt64ssEq F121DuJMyzCjCrTmR0p65nVsOpl93oh6aQaASFLLzuuc812uOm7g774rKC8NVm1o7x+/ QCa4OVdVG/OZTIHD2gEKr1SMlEw/nkZ8Xl/cevxz273pihRxT4KIAV7dn+8XWYo4B8/Z jwL0RNhdr4xcG2s1AlGp8rVIlTRvn3QpPb2Ca2dO4HzU9J6S4Zf34htxvI0UxF2dOPAx HTmUBfwPJVReIdqWMeTLSP8sNleF90wfo3rFq9c7Rffsbbjvr+8y8aS8ejNwTWRdoT1Q QGLw== X-Received: by 10.180.80.67 with SMTP id p3mr39398252wix.55.1423010552048; Tue, 03 Feb 2015 16:42:32 -0800 (PST) Received: from LAPTOP-ANDREA (net-93-144-97-2.cust.dsl.teletu.it. [93.144.97.2]) by mx.google.com with ESMTPSA id ej10sm22837559wib.1.2015.02.03.16.42.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 03 Feb 2015 16:42:31 -0800 (PST) From: Andrea Rossetti To: bug-gnu-emacs@gnu.org Subject: 24.4; artist-mode: ellipse filled incorrectly Date: Wed, 04 Feb 2015 01:42:30 +0100 Message-ID: <84wq3ypkw9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello, with this recipe: - start emacs -Q - M-x artist-mode RET - C-c C-a c (ellipse drawing tool) - C-c C-a C-f X (use "X" as filling char) - press mouse-1 somewhere in the center of the window, hold pressed - drag mouse-1 lower-right (an empty ASCII ellipse will be drawn interactively) - release mouse-1 the expected result is an ASCII ellipse filled with character X; observer result is different and undesired: 1) a line of XXXXXXXXX appears at the ellipse diameter, but the rest of the ellipse remains empty 2) a half-ellipse of XXXXXXXX appears outside of the ellipse border, in the lower right corner of the window Is it reproducible for you too? kindest regards, Andrea In GNU Emacs 24.4.1 (x86_64-w64-mingw32) of 2014-10-21 on KAEL Windowing system distributor `Microsoft Corp.', version 6.1.7600 Configured using: `configure --prefix=/z/emacs --host=x86_64-w64-mingw32 --target=x86_64-w64-mingw32 --build=x86_64-w64-mingw32 --with-wide-int --with-jpeg --with-xpm --with-png --with-tiff --with-rsvg --with-xml2 --with-gnutls --with-xft --with-sound=yes --with-file-notification=yes --without-dbus --without-imagemagick 'CFLAGS=-Ofast -fomit-frame-pointer -funroll-loops -g0 -pipe' 'CPPFLAGS=-DNDEBUG -DDBUS_STATIC_BUILD' 'LDFLAGS=-static-libgcc -static-libstdc++ -static -s -Wl,-s'' Important settings: value of $LANG: ITA locale-coding-system: cp1252 ..... From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 04 02:41:44 2015 Received: (at submit) by debbugs.gnu.org; 4 Feb 2015 07:41:44 +0000 Received: from localhost ([127.0.0.1]:33302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YIuam-0006GJ-1v for submit@debbugs.gnu.org; Wed, 04 Feb 2015 02:41:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60604) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YIuak-0006G4-3S for submit@debbugs.gnu.org; Wed, 04 Feb 2015 02:41:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIuae-0006C1-0p for submit@debbugs.gnu.org; Wed, 04 Feb 2015 02:41:36 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIuad-0006Bx-Ux for submit@debbugs.gnu.org; Wed, 04 Feb 2015 02:41:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIuad-0004aR-61 for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2015 02:41:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIuaW-0006AM-BQ for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2015 02:41:35 -0500 Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:53471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIuaW-0006A1-4e for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2015 02:41:28 -0500 Received: by mail-pa0-f46.google.com with SMTP id lj1so237023pab.5 for ; Tue, 03 Feb 2015 23:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:to:subject:in-reply-to:date:message-id:mime-version :content-type; bh=FRtf7U6vLGtTW8dYW4OJkmJnULUcBQHnm3zCYCHnxe8=; b=mlcFv9LVu9zdFblwAR3kgRMA72yLzk5NLkBAyROt/mO0RF8wzLpizKyJczSOh4jh7r FSq8YaE6cBo3+qxHE1k0n4VXmrq5lmY8fLY5VVePkkkWJ6ekJidmuWaTYmGFcNq0Z4df TQ0FXCOCVvPglGt+SyeFwUNEOzXQwnrPn/2gVV9i5dzHblc40XoVVMH5AQ5gEgjpIvMo 9z32ebXnVonLrkj16oGc2k1lTr4xi77chT2Nh8eAwHxR032YJLfcmUj++hQ7UpV6NlPC Mb4hMxj7YdZa/M8H9EIXXG6ZUfSpf75JAVORb0qjQsKGk3caEQ7jhUDOcGywWgFHMNsh yeZQ== X-Received: by 10.70.90.6 with SMTP id bs6mr18272766pdb.128.1423035686554; Tue, 03 Feb 2015 23:41:26 -0800 (PST) Received: from localhost (CPE-120-147-144-248.gdiv2.lon.bigpond.net.au. [120.147.144.248]) by mx.google.com with ESMTPSA id ms5sm1034011pbb.59.2015.02.03.23.41.24 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 03 Feb 2015 23:41:25 -0800 (PST) References: <84wq3ypkw9.fsf@gmail.com> From: Alexis To: bug-gnu-emacs@gnu.org Subject: Re: bug#19763: 24.4; artist-mode: ellipse filled incorrectly In-reply-to: <84wq3ypkw9.fsf@gmail.com> Date: Wed, 04 Feb 2015 18:41:19 +1100 Message-ID: <87h9v2cee8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Andrea Rossetti writes: > Hello, > > with this recipe: > > - start emacs -Q - M-x artist-mode RET - C-c C-a c (ellipse > drawing tool) - C-c C-a C-f X (use "X" as filling char) - press > mouse-1 somewhere in the center of the window, hold pressed - > drag mouse-1 lower-right (an empty ASCII ellipse will be drawn > interactively) > - release mouse-1 > > the expected result is an ASCII ellipse filled with character X; > observer result is different and undesired: > > 1) a line of XXXXXXXXX appears at the ellipse diameter, but the > rest of > the ellipse remains empty > > 2) a half-ellipse of XXXXXXXX appears outside of the ellipse > border, in > the lower right corner of the window > > Is it reproducible for you too? i was able to reproduce this on 24.4.1 (manually compiled on Debian Wheezy+updates x86_64). Alexis. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 04 10:35:30 2015 Received: (at 19763-done) by debbugs.gnu.org; 4 Feb 2015 15:35:30 +0000 Received: from localhost ([127.0.0.1]:34030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YJ1zG-0003lx-4n for submit@debbugs.gnu.org; Wed, 04 Feb 2015 10:35:30 -0500 Received: from mtaout28.012.net.il ([80.179.55.184]:52197) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YJ1zD-0003lc-Tv for 19763-done@debbugs.gnu.org; Wed, 04 Feb 2015 10:35:29 -0500 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NJ900D0072CPQ00@mtaout28.012.net.il> for 19763-done@debbugs.gnu.org; Wed, 04 Feb 2015 17:33:19 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJ900DLV77I3G10@mtaout28.012.net.il>; Wed, 04 Feb 2015 17:33:19 +0200 (IST) Date: Wed, 04 Feb 2015 17:34:58 +0200 From: Eli Zaretskii Subject: Re: bug#19763: 24.4; artist-mode: ellipse filled incorrectly In-reply-to: <87h9v2cee8.fsf@gmail.com> X-012-Sender: halo1@inter.net.il To: Alexis Message-id: <83zj8tg065.fsf@gnu.org> References: <84wq3ypkw9.fsf@gmail.com> <87h9v2cee8.fsf@gmail.com> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19763-done Cc: 19763-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Alexis > Date: Wed, 04 Feb 2015 18:41:19 +1100 > > > the expected result is an ASCII ellipse filled with character X; > > observer result is different and undesired: > > > > 1) a line of XXXXXXXXX appears at the ellipse diameter, but the > > rest of > > the ellipse remains empty > > > > 2) a half-ellipse of XXXXXXXX appears outside of the ellipse > > border, in > > the lower right corner of the window > > > > Is it reproducible for you too? > > i was able to reproduce this on 24.4.1 (manually compiled on > Debian Wheezy+updates x86_64). It became broken in Emacs 23, by someone's too eager replacement of mapcar with mapc. Fixed for Emacs 24.5. The patch is below, so the OP can apply it to her current sources without waiting for Emacs 24.5. Thanks. commit d825f66db83501588f1c84aa4d78e644e0d5f896 Author: Eli Zaretskii Date: Wed Feb 4 17:31:37 2015 +0200 Fix filling circle/ellipse in Artist Mode (Bug#19763) lisp/textmodes/artist.el (artist-ellipse-compute-fill-info): Use mapcar, not mapc, to create the other half of fill-info. diff --git a/lisp/ChangeLog b/lisp/ChangeLog index e52f9a3..e0c8815 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,9 @@ +2015-02-04 Eli Zaretskii + + * textmodes/artist.el (artist-ellipse-compute-fill-info): Use + mapcar, not mapc, to create the other half of fill-info. + (Bug#19763) + 2015-02-04 Nicolas Petton * emacs-lisp/authors.el (authors-ignored-files) diff --git a/lisp/textmodes/artist.el b/lisp/textmodes/artist.el index 85d9410..930c39c 100644 --- a/lisp/textmodes/artist.el +++ b/lisp/textmodes/artist.el @@ -3372,7 +3372,7 @@ (defun artist-ellipse-compute-fill-info (point-list) ;; Create the other half by mirroring the first half. (setq both-halves (append first-half - (mapc + (mapcar (lambda (i) (artist-new-fill-item (artist-fill-item-get-x i) (- (artist-fill-item-get-y i)) From unknown Sun Jun 22 00:02:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Mar 2015 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator