From unknown Fri Aug 15 19:31:10 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#1975: Reusing dead shell buffers Reply-To: jemarch@gnu.org, 1975-quiet@debbugs.gnu.org Resent-From: jemarch@gnu.org Original-Sender: Glenn Morris Resent-To: Resent-Date: Wed, 21 Jan 2009 05:25:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 1975 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by quiet@emacsbugs.donarmstrong.com id=Q.123251514621068 (code Q ref -1); Wed, 21 Jan 2009 05:25:04 +0000 Received: (at quiet) by emacsbugs.donarmstrong.com; 21 Jan 2009 05:19:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=MURPHY_DRUGS_REL8, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0L5J3AP021062 for ; Tue, 20 Jan 2009 21:19:04 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LPVT3-0003yC-7M for quiet@emacsbugs.donarmstrong.com; Wed, 21 Jan 2009 00:17:33 -0500 From: jemarch@gnu.org To: quiet@debbugs.gnu.org Date: Sun, 11 Jan 2009 21:19:21 +0100 Lines: 31 =?UTF-8?Q?(Shij=C5=8D)?= APEL/10.6 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-From-Line: emacs-devel-bounces+rgm=gnu.org@gnu.org Sun Jan 11 18:52:15 2009 Received: from mail.gnu.org ([199.232.76.166]:48057 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LMA6J-0000YC-Nt for rgm@gnu.org; Sun, 11 Jan 2009 18:52:15 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LMA7Y-0006Qc-Ar for rgm@gnu.org; Sun, 11 Jan 2009 18:53:32 -0500 Received: from lists.gnu.org ([199.232.76.165]:44629) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LMA7Y-0006QU-2U for rgm@gnu.org; Sun, 11 Jan 2009 18:53:32 -0500 Received: from localhost ([127.0.0.1]:47546 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LMA7Y-0000kv-0I for rgm@gnu.org; Sun, 11 Jan 2009 18:53:32 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LM6PW-00076k-UD for emacs-devel@gnu.org; Sun, 11 Jan 2009 14:55:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LM6PW-00076I-FH for emacs-devel@gnu.org; Sun, 11 Jan 2009 14:55:50 -0500 Received: from [199.232.76.173] (port=34784 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LM6PW-000768-BR for emacs-devel@gnu.org; Sun, 11 Jan 2009 14:55:50 -0500 Received: from p54b14dd8.dip.t-dialin.net ([84.177.77.216]:40976 helo=malditobastardo.gnu.org) by monty-python.gnu.org with esmtpa (Exim 4.60) (envelope-from ) id 1LM6PV-00046q-MZ for emacs-devel@gnu.org; Sun, 11 Jan 2009 14:55:50 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-Mailman-Approved-At: Sun, 11 Jan 2009 18:53:02 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+rgm=gnu.org@gnu.org X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: Glenn Morris Severity: wishlist [ resent from http://lists.gnu.org/archive/html/emacs-devel/2009-01/msg00295.html ] Hi. Just a tiny patch for shell. The patch assumes that the person launching M-xshell while in a shell-mode buffer with a terminated process really wants to launch a shell process in the current buffer instead to switch to "*shell*". The semantics of C-uM-xshell are not changed by the patch. Index: shell.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/shell.el,v retrieving revision 1.165 diff -u -r1.165 shell.el --- shell.el 5 Jan 2009 03:19:45 -0000 1.165 +++ shell.el 11 Jan 2009 19:46:35 -0000 @@ -555,6 +555,9 @@ (read-file-name "Default directory: " default-directory default-directory t nil 'file-directory-p)))))))) + ;; If the current buffer is a dead shell buffer, use it. + (if (and (not buffer) (eq major-mode 'shell-mode)) + (setq buffer (current-buffer))) (setq buffer (get-buffer-create (or buffer "*shell*"))) ;; Pop to buffer, so that the buffer's window will be correctly set ;; when we call comint (so that comint sets the COLUMNS env var properly). From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 19 20:40:54 2010 Received: (at control) by debbugs.gnu.org; 20 Jan 2010 01:40:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXPYz-0007Wd-5s for submit@debbugs.gnu.org; Tue, 19 Jan 2010 20:40:53 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXPYl-0007WW-Uj for control@debbugs.gnu.org; Tue, 19 Jan 2010 20:40:52 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NXPYi-0007Sl-Bs; Tue, 19 Jan 2010 20:40:36 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19286.24340.350706.582414@gargle.gargle.HOWL> Date: Tue, 19 Jan 2010 20:40:36 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: cyan X-Ran: 8WU:4P)DBN*0i&7=5k?sw9O_ List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) close 2951 tags 4206 moreinfo tags 3098 patch tags 2499 patch tags 5297 patch tags 5290 patch tags 1975 patch tags 4470 patch tags 5055 patch tags 3541 patch tags 2527 patch tags 5119 patch tags 2404 patch From unknown Fri Aug 15 19:31:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#1975: Reusing dead shell buffers References: In-Reply-To: Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Apr 2010 19:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: jemarch@gnu.org Cc: 1975@debbugs.gnu.org Received: via spool by 1975-submit@debbugs.gnu.org id=B1975.127092762014028 (code B ref 1975); Sat, 10 Apr 2010 19:27:02 +0000 Received: (at 1975) by debbugs.gnu.org; 10 Apr 2010 19:27:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0gKZ-0003eD-GZ for submit@debbugs.gnu.org; Sat, 10 Apr 2010 15:26:59 -0400 Received: from pantheon-po15.its.yale.edu ([130.132.50.71]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0gKY-0003e4-1n for 1975@debbugs.gnu.org; Sat, 10 Apr 2010 15:26:58 -0400 Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po15.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o3AJQuIw032130 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 10 Apr 2010 15:26:56 -0400 Received: by furry (Postfix, from userid 1000) id 232F9C055; Sat, 10 Apr 2010 15:26:56 -0400 (EDT) From: Chong Yidong Date: Sat, 10 Apr 2010 15:26:56 -0400 Message-ID: <87r5mn3y7z.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.9 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) > Just a tiny patch for shell. > > The patch assumes that the person launching M-xshell while in a > shell-mode buffer with a terminated process really wants to launch a > shell process in the current buffer instead to switch to "*shell*". > > The semantics of C-uM-xshell are not changed by the patch. Could you explain why you think this is necessary? The current behavior, where M-x shell reuses the *shell* buffer, seems fine. From unknown Fri Aug 15 19:31:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#1975: Reusing dead shell buffers Resent-From: Jose E. Marchesi Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Apr 2010 20:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: cyd@stupidchicken.com Cc: 1975@debbugs.gnu.org Received: via spool by 1975-submit@debbugs.gnu.org id=B1975.127093000815676 (code B ref 1975); Sat, 10 Apr 2010 20:07:02 +0000 Received: (at 1975) by debbugs.gnu.org; 10 Apr 2010 20:06:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0gx6-00044n-LB for submit@debbugs.gnu.org; Sat, 10 Apr 2010 16:06:48 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0gsf-00042o-Dc for 1975@debbugs.gnu.org; Sat, 10 Apr 2010 16:02:13 -0400 Received: from p5dc1f41e.dip.t-dialin.net ([93.193.244.30]:45196 helo=localhost) by monty-python.gnu.org with esmtpa (Exim 4.60) (envelope-from ) id 1O0gsc-0001JU-VB; Sat, 10 Apr 2010 16:02:11 -0400 Date: Sat, 10 Apr 2010 22:05:03 +0200 (CEST) Message-Id: <20100410.220503.264135546.jemarch@gnu.org> From: Jose E. Marchesi In-Reply-To: <87r5mn3y7z.fsf@stupidchicken.com> References: <87r5mn3y7z.fsf@stupidchicken.com> X-Mailer: Mew version 6.3 on Emacs 23.1.91 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -6.6 (------) X-Mailman-Approved-At: Sat, 10 Apr 2010 16:06:48 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) > Just a tiny patch for shell. > > The patch assumes that the person launching M-xshell while in a > shell-mode buffer with a terminated process really wants to launch a > shell process in the current buffer instead to switch to "*shell*". > > The semantics of C-uM-xshell are not changed by the patch. Could you explain why you think this is necessary? The current behavior, where M-x shell reuses the *shell* buffer, seems fine. Just consider the situation where you use different shells simultaneously with meaningful names. For example, debugging an application: shell-daemon, shell-mmi and shell-gdb. If I want to restart the shell that is running in shell-gdb, I usually Ctrl-D to terminate it and then I reuse the buffer. Without the patch I have to C-uM-xshell and then type shell-gdb. From unknown Fri Aug 15 19:31:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#1975: Reusing dead shell buffers Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Apr 2012 12:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jose E. Marchesi Cc: 1975@debbugs.gnu.org, cyd@stupidchicken.com Received: via spool by 1975-submit@debbugs.gnu.org id=B1975.13341477665193 (code B ref 1975); Wed, 11 Apr 2012 12:37:02 +0000 Received: (at 1975) by debbugs.gnu.org; 11 Apr 2012 12:36:06 +0000 Received: from localhost ([127.0.0.1]:50628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHwmM-0001Li-1w for submit@debbugs.gnu.org; Wed, 11 Apr 2012 08:36:06 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:41401) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHwmJ-0001La-3Q for 1975@debbugs.gnu.org; Wed, 11 Apr 2012 08:36:04 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SHwl4-0002LH-FA; Wed, 11 Apr 2012 14:34:46 +0200 From: Lars Magne Ingebrigtsen References: <87r5mn3y7z.fsf@stupidchicken.com> <20100410.220503.264135546.jemarch@gnu.org> X-Now-Playing: Zazou, Bikaye & Cy1's _Noir et Blanc_: "Lamuka" Date: Wed, 11 Apr 2012 14:34:44 +0200 In-Reply-To: <20100410.220503.264135546.jemarch@gnu.org> (Jose E. Marchesi's message of "Sat, 10 Apr 2010 22:05:03 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1SHwl4-0002LH-FA X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334752486.59438@8fpi0WL1v+O4NasSHkSajQ X-Spam-Status: No X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Jose E. Marchesi writes: > If I want to restart the shell that is running in shell-gdb, I usually > Ctrl-D to terminate it and then I reuse the buffer. Without the patch > I have to C-uM-xshell and then type shell-gdb. Currently `C-u M-x shell' defaults to "*shell*", which seems pretty nonsensical. Surely if the user wanted to use that buffer, then she would have just typed `M-x shell'. So perhaps `C-u M-x shell' should just default to the current buffer instead? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Fri Aug 15 19:31:10 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: jemarch@gnu.org Subject: bug#1975: closed (Re: bug#1975: Reusing dead shell buffers) Message-ID: References: <87obifldkm.fsf@gnu.org> X-Gnu-PR-Message: they-closed 1975 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 1975@debbugs.gnu.org Date: Fri, 30 Nov 2012 08:09:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1354262942-15840-1" This is a multi-part message in MIME format... ------------=_1354262942-15840-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #1975: Reusing dead shell buffers which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 1975@debbugs.gnu.org. --=20 1975: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D1975 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1354262942-15840-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 1975-done) by debbugs.gnu.org; 30 Nov 2012 08:08:56 +0000 Received: from localhost ([127.0.0.1]:46120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TeLeW-000478-9n for submit@debbugs.gnu.org; Fri, 30 Nov 2012 03:08:56 -0500 Received: from mail-da0-f44.google.com ([209.85.210.44]:56658) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TeLeQ-00046v-5G for 1975-done@debbugs.gnu.org; Fri, 30 Nov 2012 03:08:50 -0500 Received: by mail-da0-f44.google.com with SMTP id z20so112472dae.3 for <1975-done@debbugs.gnu.org>; Fri, 30 Nov 2012 00:06:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=MdTpj8ISyX40t980WrkE8p8jxpwDF4LtH1TyaZBPOGs=; b=lbV/Cjp/ilscu6DUmolGwVGy4W3Qdz2TVulEY5EVcmqZhZmPsO5717IfhCylhLnCep isRLAGaFcXVikrmQ37/S7pwXuLJ3sbW70LYhy5JLfNJlwDfRv/jE1nzjADF+ommVWFJL ISuGUE7TVKMZjDBzn7Pb8PizM+55nr9bbaYs17vr3+WtdDQ0/6g7MDhvYJVF7HVojSSq XBG47PyF0DqO6UHQUZZidXr3tV6qSTuu/4YRYbQoLXs85xxYTt1QN/VP0z892qN10GLJ wpfjnd6KT0JTn7rrvmK0rMS8iEKyjqleJuAPY9LzuZDiNHSuyPmxauFh0XYNk5cIo3VC mKug== Received: by 10.68.192.97 with SMTP id hf1mr3354518pbc.106.1354262801337; Fri, 30 Nov 2012 00:06:41 -0800 (PST) Received: from ulysses ([155.69.16.180]) by mx.google.com with ESMTPS id pv8sm2659889pbc.26.2012.11.30.00.06.37 (version=SSLv3 cipher=OTHER); Fri, 30 Nov 2012 00:06:39 -0800 (PST) From: Chong Yidong To: Lars Magne Ingebrigtsen Subject: Re: bug#1975: Reusing dead shell buffers References: <87r5mn3y7z.fsf@stupidchicken.com> <20100410.220503.264135546.jemarch@gnu.org> Date: Fri, 30 Nov 2012 16:06:33 +0800 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Wed, 11 Apr 2012 14:34:44 +0200") Message-ID: <87obifldkm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 1975-done Cc: 1975-done@debbugs.gnu.org, "Jose E. Marchesi" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Lars Magne Ingebrigtsen writes: > Currently `C-u M-x shell' defaults to "*shell*", which seems pretty > nonsensical. Surely if the user wanted to use that buffer, then she > would have just typed `M-x shell'. > > So perhaps `C-u M-x shell' should just default to the current buffer > instead? Agreed. Implemented in trunk. ------------=_1354262942-15840-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at quiet) by emacsbugs.donarmstrong.com; 21 Jan 2009 05:19:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=MURPHY_DRUGS_REL8, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0L5J3AP021062 for ; Tue, 20 Jan 2009 21:19:04 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LPVT3-0003yC-7M for quiet@emacsbugs.donarmstrong.com; Wed, 21 Jan 2009 00:17:33 -0500 From: jemarch@gnu.org To: quiet@debbugs.gnu.org Subject: Reusing dead shell buffers Date: Sun, 11 Jan 2009 21:19:21 +0100 Lines: 31 =?utf-8?Q?=28Shij=C5=8D=29?= APEL/10.6 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-From-Line: emacs-devel-bounces+rgm=gnu.org@gnu.org Sun Jan 11 18:52:15 2009 Received: from mail.gnu.org ([199.232.76.166]:48057 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LMA6J-0000YC-Nt for rgm@gnu.org; Sun, 11 Jan 2009 18:52:15 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LMA7Y-0006Qc-Ar for rgm@gnu.org; Sun, 11 Jan 2009 18:53:32 -0500 Received: from lists.gnu.org ([199.232.76.165]:44629) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LMA7Y-0006QU-2U for rgm@gnu.org; Sun, 11 Jan 2009 18:53:32 -0500 Received: from localhost ([127.0.0.1]:47546 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LMA7Y-0000kv-0I for rgm@gnu.org; Sun, 11 Jan 2009 18:53:32 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LM6PW-00076k-UD for emacs-devel@gnu.org; Sun, 11 Jan 2009 14:55:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LM6PW-00076I-FH for emacs-devel@gnu.org; Sun, 11 Jan 2009 14:55:50 -0500 Received: from [199.232.76.173] (port=34784 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LM6PW-000768-BR for emacs-devel@gnu.org; Sun, 11 Jan 2009 14:55:50 -0500 Received: from p54b14dd8.dip.t-dialin.net ([84.177.77.216]:40976 helo=malditobastardo.gnu.org) by monty-python.gnu.org with esmtpa (Exim 4.60) (envelope-from ) id 1LM6PV-00046q-MZ for emacs-devel@gnu.org; Sun, 11 Jan 2009 14:55:50 -0500 X-Debbugs-No-Ack: yes X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-Mailman-Approved-At: Sun, 11 Jan 2009 18:53:02 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+rgm=gnu.org@gnu.org X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: Glenn Morris Severity: wishlist [ resent from http://lists.gnu.org/archive/html/emacs-devel/2009-01/msg00295.html ] Hi. Just a tiny patch for shell. The patch assumes that the person launching M-xshell while in a shell-mode buffer with a terminated process really wants to launch a shell process in the current buffer instead to switch to "*shell*". The semantics of C-uM-xshell are not changed by the patch. Index: shell.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/shell.el,v retrieving revision 1.165 diff -u -r1.165 shell.el --- shell.el 5 Jan 2009 03:19:45 -0000 1.165 +++ shell.el 11 Jan 2009 19:46:35 -0000 @@ -555,6 +555,9 @@ (read-file-name "Default directory: " default-directory default-directory t nil 'file-directory-p)))))))) + ;; If the current buffer is a dead shell buffer, use it. + (if (and (not buffer) (eq major-mode 'shell-mode)) + (setq buffer (current-buffer))) (setq buffer (get-buffer-create (or buffer "*shell*"))) ;; Pop to buffer, so that the buffer's window will be correctly set ;; when we call comint (so that comint sets the COLUMNS env var properly). ------------=_1354262942-15840-1--