From unknown Wed Aug 20 04:10:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19743: 'wrap-program' should preserve symbolic links Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 01 Feb 2015 23:32:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19743 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 19743@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14228335205358 (code B ref -1); Sun, 01 Feb 2015 23:32:03 +0000 Received: (at submit) by debbugs.gnu.org; 1 Feb 2015 23:32:00 +0000 Received: from localhost ([127.0.0.1]:59889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YI3zj-0001OL-Mz for submit@debbugs.gnu.org; Sun, 01 Feb 2015 18:31:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56029) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YI3zh-0001Nu-71 for submit@debbugs.gnu.org; Sun, 01 Feb 2015 18:31:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YI3zX-0006CG-41 for submit@debbugs.gnu.org; Sun, 01 Feb 2015 18:31:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI3zX-0006CC-1w for submit@debbugs.gnu.org; Sun, 01 Feb 2015 18:31:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI3zW-0006eK-6r for bug-guix@gnu.org; Sun, 01 Feb 2015 18:31:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YI3zN-00069F-7N for bug-guix@gnu.org; Sun, 01 Feb 2015 18:31:46 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI3zN-00069B-4e for bug-guix@gnu.org; Sun, 01 Feb 2015 18:31:37 -0500 Received: from reverse-83.fdn.fr ([80.67.176.83]:44744 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1YI3zM-0000eR-MN for bug-guix@gnu.org; Sun, 01 Feb 2015 18:31:37 -0500 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Date: Sun, 01 Feb 2015 22:41:57 +0100 Message-ID: <87386pe2ca.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 =?UTF-8?Q?Pluvi=C3=B4se?= an 223 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable When =E2=80=98wrap-program=E2=80=99 is called on a symbolic link, it should= preserve its symboliclinkness instead of copying it. Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/guix/build/utils.scm b/guix/build/utils.scm index 4407f9a..56f682c 100644 --- a/guix/build/utils.scm +++ b/guix/build/utils.scm @@ -837,7 +837,7 @@ the previous wrapper." (if (zero? number) (let ((prog-real (string-append (dirname prog) "/." (basename prog) "-real"))) - (copy-file prog prog-real) + (rename-file prog prog-real) prog-real) (wrapper-file-name number))) --=-=-=-- From unknown Wed Aug 20 04:10:52 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#19743: closed (Close) Message-ID: References: <20150216142720.GA5801@debian.math.u-bordeaux1.fr> <87386pe2ca.fsf@gnu.org> X-Gnu-PR-Message: they-closed 19743 X-Gnu-PR-Package: guix Reply-To: 19743@debbugs.gnu.org Date: Mon, 16 Feb 2015 14:28:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1424096884-5664-1" This is a multi-part message in MIME format... ------------=_1424096884-5664-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #19743: 'wrap-program' should preserve symbolic links which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19743@debbugs.gnu.org. --=20 19743: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19743 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1424096884-5664-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 19743-done) by debbugs.gnu.org; 16 Feb 2015 14:27:30 +0000 Received: from localhost ([127.0.0.1]:45250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNMe2-0001Sf-5i for submit@debbugs.gnu.org; Mon, 16 Feb 2015 09:27:30 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:55325) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNMdz-0001SS-R6 for 19743-done@debbugs.gnu.org; Mon, 16 Feb 2015 09:27:28 -0500 Received: from debian.math.u-bordeaux1.fr ([147.210.21.57]) by mrelayeu.kundenserver.de (mreue005) with ESMTPSA (Nemesis) id 0MdH3n-1Y5yDS3LX9-00IX91; Mon, 16 Feb 2015 15:27:21 +0100 Date: Mon, 16 Feb 2015 15:27:20 +0100 From: Andreas Enge To: 19743-done@debbugs.gnu.org Subject: Close Message-ID: <20150216142720.GA5801@debian.math.u-bordeaux1.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Provags-ID: V03:K0:sADOcd4Q7vd5DeVvfYnE3qlYYMKpNoghm3fn1cfEyxBrKlSixAP +7P3ysOtbD315QIGOWsn1mxQ+NZNyd3RTzwWB/oMrPgdDCTS7CP0bs1Z0KRTfvA08bLNyLR xee/NFPfWMuajLM3Vs5cIMfZSKoLHTvsQ6+Z6oHJiO6SSpAbhPXA6SZtM9GWoPeb2vk5SXL mc8d7zrQb436Ss3pT1diQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19743-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Applied in commit da466f7ff63e34aca271e603090f25ba471f009e. Andreas ------------=_1424096884-5664-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Feb 2015 23:32:00 +0000 Received: from localhost ([127.0.0.1]:59889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YI3zj-0001OL-Mz for submit@debbugs.gnu.org; Sun, 01 Feb 2015 18:31:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56029) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YI3zh-0001Nu-71 for submit@debbugs.gnu.org; Sun, 01 Feb 2015 18:31:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YI3zX-0006CG-41 for submit@debbugs.gnu.org; Sun, 01 Feb 2015 18:31:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI3zX-0006CC-1w for submit@debbugs.gnu.org; Sun, 01 Feb 2015 18:31:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI3zW-0006eK-6r for bug-guix@gnu.org; Sun, 01 Feb 2015 18:31:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YI3zN-00069F-7N for bug-guix@gnu.org; Sun, 01 Feb 2015 18:31:46 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI3zN-00069B-4e for bug-guix@gnu.org; Sun, 01 Feb 2015 18:31:37 -0500 Received: from reverse-83.fdn.fr ([80.67.176.83]:44744 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1YI3zM-0000eR-MN for bug-guix@gnu.org; Sun, 01 Feb 2015 18:31:37 -0500 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: bug-guix@gnu.org Subject: 'wrap-program' should preserve symbolic links Date: Sun, 01 Feb 2015 22:41:57 +0100 Message-ID: <87386pe2ca.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 =?utf-8?Q?Pluvi=C3=B4se?= an 223 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable When =E2=80=98wrap-program=E2=80=99 is called on a symbolic link, it should= preserve its symboliclinkness instead of copying it. Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/guix/build/utils.scm b/guix/build/utils.scm index 4407f9a..56f682c 100644 --- a/guix/build/utils.scm +++ b/guix/build/utils.scm @@ -837,7 +837,7 @@ the previous wrapper." (if (zero? number) (let ((prog-real (string-append (dirname prog) "/." (basename prog) "-real"))) - (copy-file prog prog-real) + (rename-file prog prog-real) prog-real) (wrapper-file-name number))) --=-=-=-- ------------=_1424096884-5664-1-- From unknown Wed Aug 20 04:10:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19743: 'wrap-program' should preserve symbolic links Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 23 Feb 2015 19:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19743 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Andreas Enge Cc: 19743@debbugs.gnu.org Received: via spool by 19743-submit@debbugs.gnu.org id=B19743.142472071322469 (code B ref 19743); Mon, 23 Feb 2015 19:46:02 +0000 Received: (at 19743) by debbugs.gnu.org; 23 Feb 2015 19:45:13 +0000 Received: from localhost ([127.0.0.1]:55854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPywK-0005qI-HI for submit@debbugs.gnu.org; Mon, 23 Feb 2015 14:45:13 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:46797 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPywI-0005q6-GW for 19743@debbugs.gnu.org; Mon, 23 Feb 2015 14:45:10 -0500 Received: from reverse-83.fdn.fr ([80.67.176.83]:34752 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1YPywF-0005Wv-St; Mon, 23 Feb 2015 14:45:10 -0500 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87386pe2ca.fsf@gnu.org> <20150215164206.GA6486@debian> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 =?UTF-8?Q?Vent=C3=B4se?= an 223 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Mon, 23 Feb 2015 20:45:00 +0100 In-Reply-To: <20150215164206.GA6486@debian> (Andreas Enge's message of "Sun, 15 Feb 2015 17:42:06 +0100") Message-ID: <87vbis4dkz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Andreas Enge skribis: > From cced64ffd33754434d732c552bdbb5c038891a8d Mon Sep 17 00:00:00 2001 > From: Andreas Enge > Date: Sun, 15 Feb 2015 17:40:17 +0100 > Subject: [PATCH] utils: Preserve symbolic links in 'wrap-program'. > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > > * guix/build/utils.scm (wrap-program): Preserve symbolic links instead of > copying the contents of the link. ^^ No extra space here please. > Co-authored-by: Ludovic Court=C3=A8s > > Closes . Use =E2=80=9CFixes: ...=E2=80=9D as in the other commits. OK for =E2=80=98core-updates=E2=80=99. Thank you! Ludo=E2=80=99.