From unknown Mon Jun 23 02:24:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19734: 25.0.50; nested backquotes: recent changes not backward compatible Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jan 2015 17:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 19734@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: michael_heerdegen@web.de Received: via spool by submit@debbugs.gnu.org id=B.14226402223186 (code B ref -1); Fri, 30 Jan 2015 17:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Jan 2015 17:50:22 +0000 Received: from localhost ([127.0.0.1]:58254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHFi1-0000pJ-7o for submit@debbugs.gnu.org; Fri, 30 Jan 2015 12:50:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36852) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHFhx-0000p3-PM for submit@debbugs.gnu.org; Fri, 30 Jan 2015 12:50:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHFhm-00067a-DP for submit@debbugs.gnu.org; Fri, 30 Jan 2015 12:50:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHFhm-00066f-AZ for submit@debbugs.gnu.org; Fri, 30 Jan 2015 12:50:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHFhk-0007sC-Ue for bug-gnu-emacs@gnu.org; Fri, 30 Jan 2015 12:50:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHFhg-0005wF-Se for bug-gnu-emacs@gnu.org; Fri, 30 Jan 2015 12:50:04 -0500 Received: from mout.web.de ([212.227.17.12]:61187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHFhg-0005w3-Ha for bug-gnu-emacs@gnu.org; Fri, 30 Jan 2015 12:50:00 -0500 Received: from drachen.dragon ([90.187.246.243]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0MJl1M-1YILdC1i9k-0019K3 for ; Fri, 30 Jan 2015 18:49:58 +0100 From: Michael Heerdegen Date: Fri, 30 Jan 2015 18:49:52 +0100 Message-ID: <871tmcrwe7.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:NsP6RNmkE0QI+J5vn+7OMTRZcz6vnlXRKYPyOUHHg0Ui2jAWvgW i0RtK9Jdw8IrlGde8oP6/6/OZ7Ss/AHh/G6uiMdLx+XAJRqu4qX2b/j6L87ROY0xBuSbqjL ipG2QM+QttJyfp0GWrarpt5TGmAMI8F5eoWhkll11bqe4x3MF0UPgzdmSjlQh/Pqch65TL8 uRIYcG4j2o1NOqpkiEUyA== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Hello, Recent changes in backquote.el, I guess especially in this commit: 86009dd5d886f1101358990e4f8f69a5d1467eb8 Author: Stefan Monnier Date: Sat Nov 15 23:59:50 2014 -0500 * lisp/emacs-lisp/backquote.el (backquote-process): Optimize away the ,' case. were not backwards compatible. If this was intended (?), it should be mentioned in the news I think. Here is an example. In Emacs 24, I had something like this in my config (massively shortened): --8<---------------cut here---------------start------------->8--- (defun my-make-feh-cmd () "Return a feh command line suitble for dired. Take the current screen resolution at account." (if (not window-system) "feh" (let* ((display-pixel-width (display-pixel-width)) (width (- display-pixel-width (frame-pixel-width)))) (format "feh -Z -g %sx%s+%s *" width (- (x-display-pixel-height) 30) (min (+ (frame-pixel-width) 2) (- display-pixel-width width)))))) (require 'dired-x) (let ((programs '("vlc *" "smplayer *"))) (setq-default dired-guess-shell-alist-user `((".*" (if (file-directory-p file) `(,,'(my-make-feh-cmd) ;compute at runtime! ,@',programs) ',programs))))) --8<---------------cut here---------------end--------------->8--- In trunk, the backquote expression evals to something different now, and AFAICT ,,'(my-make-feh-cmd) from above must now be ,(my-make-feh-cmd) That looks less frightening, but I had to find this out myself because my code was broken and there was no news entry. Thanks, Michael. In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.14.5) of 2015-01-29 on drachen Repository revision: 1dc1959ebf50401c69adeb6d182950b59835f94d Windowing system distributor `The X.Org Foundation', version 11.0.11602901 System Description: Debian GNU/Linux 8.0 (jessie) Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GSETTINGS NOTIFY LIBXML2 FREETYPE XFT ZLIB From unknown Mon Jun 23 02:24:36 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: michael_heerdegen@web.de Subject: bug#19734: closed (Re: bug#19734: 25.0.50; nested backquotes: recent changes not backward compatible) Message-ID: References: <871tmcrwe7.fsf@web.de> X-Gnu-PR-Message: they-closed 19734 X-Gnu-PR-Package: emacs Reply-To: 19734@debbugs.gnu.org Date: Fri, 30 Jan 2015 21:03:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1422651782-21385-1" This is a multi-part message in MIME format... ------------=_1422651782-21385-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #19734: 25.0.50; nested backquotes: recent changes not backward compatible which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19734@debbugs.gnu.org. --=20 19734: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19734 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1422651782-21385-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 19734-done) by debbugs.gnu.org; 30 Jan 2015 21:02:26 +0000 Received: from localhost ([127.0.0.1]:58288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHIhu-0005Y2-8v for submit@debbugs.gnu.org; Fri, 30 Jan 2015 16:02:26 -0500 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:47167) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHIhs-0005Xu-97 for 19734-done@debbugs.gnu.org; Fri, 30 Jan 2015 16:02:24 -0500 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 5CDA985EC6; Fri, 30 Jan 2015 16:02:23 -0500 (EST) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id E9B7B1E5B8D; Fri, 30 Jan 2015 16:01:55 -0500 (EST) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id C7A29B4102; Fri, 30 Jan 2015 16:01:55 -0500 (EST) From: Stefan Monnier To: Michael Heerdegen Subject: Re: bug#19734: 25.0.50; nested backquotes: recent changes not backward compatible Message-ID: References: <871tmcrwe7.fsf@web.de> Date: Fri, 30 Jan 2015 16:01:55 -0500 In-Reply-To: <871tmcrwe7.fsf@web.de> (Michael Heerdegen's message of "Fri, 30 Jan 2015 18:49:52 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19734-done Cc: 19734-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > * lisp/emacs-lisp/backquote.el (backquote-process): Optimize away > the ,' case. > were not backwards compatible. If this was intended (?), it should be > mentioned in the news I think. As the commit message indicates, this was supposed to be an optimization, i.e. no change in observable behavior. > In trunk, the backquote expression evals to something different now, and > ,,'(my-make-feh-cmd) > from above must now be > ,(my-make-feh-cmd) Yes, your rewrite is correct and desirable, but indeed we had a bug which I've just fixed in master. Thanks. Stefan ------------=_1422651782-21385-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Jan 2015 17:50:22 +0000 Received: from localhost ([127.0.0.1]:58254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHFi1-0000pJ-7o for submit@debbugs.gnu.org; Fri, 30 Jan 2015 12:50:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36852) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHFhx-0000p3-PM for submit@debbugs.gnu.org; Fri, 30 Jan 2015 12:50:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHFhm-00067a-DP for submit@debbugs.gnu.org; Fri, 30 Jan 2015 12:50:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHFhm-00066f-AZ for submit@debbugs.gnu.org; Fri, 30 Jan 2015 12:50:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHFhk-0007sC-Ue for bug-gnu-emacs@gnu.org; Fri, 30 Jan 2015 12:50:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHFhg-0005wF-Se for bug-gnu-emacs@gnu.org; Fri, 30 Jan 2015 12:50:04 -0500 Received: from mout.web.de ([212.227.17.12]:61187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHFhg-0005w3-Ha for bug-gnu-emacs@gnu.org; Fri, 30 Jan 2015 12:50:00 -0500 Received: from drachen.dragon ([90.187.246.243]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0MJl1M-1YILdC1i9k-0019K3 for ; Fri, 30 Jan 2015 18:49:58 +0100 From: Michael Heerdegen To: bug-gnu-emacs@gnu.org Subject: 25.0.50; nested backquotes: recent changes not backward compatible Date: Fri, 30 Jan 2015 18:49:52 +0100 Message-ID: <871tmcrwe7.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:NsP6RNmkE0QI+J5vn+7OMTRZcz6vnlXRKYPyOUHHg0Ui2jAWvgW i0RtK9Jdw8IrlGde8oP6/6/OZ7Ss/AHh/G6uiMdLx+XAJRqu4qX2b/j6L87ROY0xBuSbqjL ipG2QM+QttJyfp0GWrarpt5TGmAMI8F5eoWhkll11bqe4x3MF0UPgzdmSjlQh/Pqch65TL8 uRIYcG4j2o1NOqpkiEUyA== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: michael_heerdegen@web.de List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Hello, Recent changes in backquote.el, I guess especially in this commit: 86009dd5d886f1101358990e4f8f69a5d1467eb8 Author: Stefan Monnier Date: Sat Nov 15 23:59:50 2014 -0500 * lisp/emacs-lisp/backquote.el (backquote-process): Optimize away the ,' case. were not backwards compatible. If this was intended (?), it should be mentioned in the news I think. Here is an example. In Emacs 24, I had something like this in my config (massively shortened): --8<---------------cut here---------------start------------->8--- (defun my-make-feh-cmd () "Return a feh command line suitble for dired. Take the current screen resolution at account." (if (not window-system) "feh" (let* ((display-pixel-width (display-pixel-width)) (width (- display-pixel-width (frame-pixel-width)))) (format "feh -Z -g %sx%s+%s *" width (- (x-display-pixel-height) 30) (min (+ (frame-pixel-width) 2) (- display-pixel-width width)))))) (require 'dired-x) (let ((programs '("vlc *" "smplayer *"))) (setq-default dired-guess-shell-alist-user `((".*" (if (file-directory-p file) `(,,'(my-make-feh-cmd) ;compute at runtime! ,@',programs) ',programs))))) --8<---------------cut here---------------end--------------->8--- In trunk, the backquote expression evals to something different now, and AFAICT ,,'(my-make-feh-cmd) from above must now be ,(my-make-feh-cmd) That looks less frightening, but I had to find this out myself because my code was broken and there was no news entry. Thanks, Michael. In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.14.5) of 2015-01-29 on drachen Repository revision: 1dc1959ebf50401c69adeb6d182950b59835f94d Windowing system distributor `The X.Org Foundation', version 11.0.11602901 System Description: Debian GNU/Linux 8.0 (jessie) Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GSETTINGS NOTIFY LIBXML2 FREETYPE XFT ZLIB ------------=_1422651782-21385-1--