From unknown Mon Jun 23 00:37:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19727: 25.0.50; setting a todo item to done puts point at the end of the buffer Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jan 2015 17:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 19727@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14225514106601 (code B ref -1); Thu, 29 Jan 2015 17:11:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jan 2015 17:10:10 +0000 Received: from localhost ([127.0.0.1]:57462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGsba-0001iO-5y for submit@debbugs.gnu.org; Thu, 29 Jan 2015 12:10:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49911) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGm49-0006BE-Aa for submit@debbugs.gnu.org; Thu, 29 Jan 2015 05:11:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGm42-0006Q2-T0 for submit@debbugs.gnu.org; Thu, 29 Jan 2015 05:11:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGm42-0006Py-QJ for submit@debbugs.gnu.org; Thu, 29 Jan 2015 05:11:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGm3y-0007L2-Vq for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 05:11:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGm3u-0006P6-N6 for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 05:11:02 -0500 Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:36445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGm3u-0006P2-Fy for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 05:10:58 -0500 Received: by mail-we0-f181.google.com with SMTP id k48so23085118wev.12 for ; Thu, 29 Jan 2015 02:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=E2vabU2xZhLCz6OZsO9SOhLk+CeWvLWQynv02E/0QbA=; b=hAgvU0yHQRIohIp1lEsM1HOvVa+75nFdTloEAzCpGAwJoY9kPDTvPg6f9Qb2zuj58S mcRo84P6CTK4mouwtyQ9xhh2u6AxkpxX6PFZd2+LZv90joJdybhlDCf2mAwDcAHny51z UZO/mAmWkzzCJIdZdn1ssmCLsElkSsI6TQbIi3vpRjj+PARQK+RiB86/V1yAmInpM6jp 1HtWJNkJP28dlqWEGNBnT218sAuAtvgu1eg4T/GWffeDkWIG0LNHe47WSV+prpoeLZQG noFTmqfVhUEPH/HAL6gQWSVxfVL8gq4RUaOGXFakfNDDLsEEHG6srueMVRLfG5Xi6wdx KsuQ== X-Received: by 10.194.84.176 with SMTP id a16mr16135574wjz.113.1422526257378; Thu, 29 Jan 2015 02:10:57 -0800 (PST) Received: from RPLUIM (vav06-1-78-207-202-9.fbx.proxad.net. [78.207.202.9]) by mx.google.com with ESMTPSA id p6sm1798540wia.14.2015.01.29.02.10.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jan 2015 02:10:56 -0800 (PST) From: Robert Pluim Date: Thu, 29 Jan 2015 11:10:47 +0100 Message-ID: <827fw5oq1k.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Thu, 29 Jan 2015 12:10:08 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Hi, when I set an item to done in a todo-mode buffer, point ends up at the end of the buffer, which is somewhat surprising. Attached patch remembers where point was, and restores it. Regards Robert In GNU Emacs 25.0.50.6 (i686-pc-cygwin) of 2015-01-28 on RPLUIM Repository revision: 8a8bd38fedb89b2d04cca2419698813a22862c3b Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --with-w32 --with-wide-int' --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=todo-mode-done-restore-point.patch diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 90681c8..060cbf7 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2015-01-26 Robert Pluim + + * calendar/todo-mode.el (todo-item-done): Initialize opoint so + that point stays where it is when setting items to DONE. + 2015-01-28 Tassilo Horn * textmodes/reftex.el (reftex-syntax-table-for-bib): Give ( and ) diff --git a/lisp/calendar/todo-mode.el b/lisp/calendar/todo-mode.el index 7ca57a4..2fb7e2e 100644 --- a/lisp/calendar/todo-mode.el +++ b/lisp/calendar/todo-mode.el @@ -2816,7 +2816,8 @@ (defun todo-item-done (&optional arg) (goto-char (point-min)) (re-search-forward todo-done-string-start nil t))) (buffer-read-only nil) - item done-item opoint) + item done-item + (opoint (point))) ;; Don't add empty comment to done item. (setq comment (unless (zerop (length comment)) (concat " [" todo-comment-string ": " comment "]"))) --=-=-=-- From unknown Mon Jun 23 00:37:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19727: 25.0.50; setting a todo item to done puts point at the end of the buffer Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Feb 2015 22:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 19727@debbugs.gnu.org Received: via spool by 19727-submit@debbugs.gnu.org id=B19727.142300321028295 (code B ref 19727); Tue, 03 Feb 2015 22:41:02 +0000 Received: (at 19727) by debbugs.gnu.org; 3 Feb 2015 22:40:10 +0000 Received: from localhost ([127.0.0.1]:33215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YIm8g-0007MJ-FJ for submit@debbugs.gnu.org; Tue, 03 Feb 2015 17:40:10 -0500 Received: from mout.gmx.net ([212.227.15.18]:60170) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YIm8e-0007M5-JL for 19727@debbugs.gnu.org; Tue, 03 Feb 2015 17:40:09 -0500 Received: from rosalinde ([89.245.93.18]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LskKv-1XcncU16in-012GlK; Tue, 03 Feb 2015 23:39:59 +0100 From: Stephen Berman References: <827fw5oq1k.fsf@gmail.com> Date: Tue, 03 Feb 2015 23:39:58 +0100 In-Reply-To: <827fw5oq1k.fsf@gmail.com> (Robert Pluim's message of "Thu, 29 Jan 2015 11:10:47 +0100") Message-ID: <87egq6bow1.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:0lZxKh5iBxdI+/ubSJOPNhtT97AhT0KiyD/M9DuOl5W0euI0XK6 LCZc4a38Fu+R1T43iOegvMwrzN1QWuFsrRKr2fpNv2hW8dDtVvarzW8MDWW3TTHMvqRiAIA slO7W3uOrxIeimj9VKsWhRs9Vj3P7nOwX2AK+HA6EerRAQHojgGZULyWCqNfRyq3k9OOBKE GDkTj+7bfsV/Or2PZEhvA== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Thu, 29 Jan 2015 11:10:47 +0100 Robert Pluim wrote: > when I set an item to done in a todo-mode buffer, point ends up at the > end of the buffer, which is somewhat surprising. Attached patch > remembers where point was, and restores it. As the todo-mode.el maintainer, sorry for not responding sooner. I guess it's reasonable to leave point where the previously not-done item was when the done items section is hidden. I take it you have no objection to the current behavior of point moving to the item just set to done when the done items section is visible, since your patch doesn't alter that. If so, then I'll install your patch as is (but with a more appropriate commit message and ChangeLog entry). Before I do that, have you submitted a copyright assignment for Emacs? If not, I'll install it as a tiny change. Thanks for the patch. Steve Berman From unknown Mon Jun 23 00:37:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19727: 25.0.50; setting a todo item to done puts point at the end of the buffer In-Reply-To: <827fw5oq1k.fsf@gmail.com> Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Feb 2015 13:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 19727@debbugs.gnu.org Cc: Stephen Berman X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.142305642829296 (code B ref -1); Wed, 04 Feb 2015 13:28:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Feb 2015 13:27:08 +0000 Received: from localhost ([127.0.0.1]:33479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YIzz0-0007cP-5g for submit@debbugs.gnu.org; Wed, 04 Feb 2015 08:27:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59896) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YIzyw-0007bs-Pf for submit@debbugs.gnu.org; Wed, 04 Feb 2015 08:27:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIzyq-0003vu-E9 for submit@debbugs.gnu.org; Wed, 04 Feb 2015 08:26:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIzyq-0003vo-Bn for submit@debbugs.gnu.org; Wed, 04 Feb 2015 08:26:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIzyn-00063U-5e for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2015 08:26:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIznS-0008LX-H9 for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2015 08:15:18 -0500 Received: from plane.gmane.org ([80.91.229.3]:42668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIznS-0008JZ-3F for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2015 08:15:10 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YIznM-0005Gf-NR for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2015 14:15:04 +0100 Received: from arennes-650-1-29-196.w90-32.abo.wanadoo.fr ([90.32.212.196]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 04 Feb 2015 14:15:04 +0100 Received: from rpluim by arennes-650-1-29-196.w90-32.abo.wanadoo.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 04 Feb 2015 14:15:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org From: Robert Pluim Date: Wed, 04 Feb 2015 13:48:37 +0100 Organization: not if I can help it Lines: 33 Message-ID: <82bnl93kre.fsf@gmail.com> References: <827fw5oq1k.fsf@gmail.com> <87egq6bow1.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: arennes-650-1-29-196.w90-32.abo.wanadoo.fr Mail-Copies-To: never User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (cygwin) Cancel-Lock: sha1:JapaNTtUEEL3VDTpdSLz1M8yHuA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Stephen Berman writes: > On Thu, 29 Jan 2015 11:10:47 +0100 Robert Pluim wrote: > >> when I set an item to done in a todo-mode buffer, point ends up at the >> end of the buffer, which is somewhat surprising. Attached patch >> remembers where point was, and restores it. > > As the todo-mode.el maintainer, sorry for not responding sooner. I can carry local patches forever :-) > I > guess it's reasonable to leave point where the previously not-done item > was when the done items section is hidden. I take it you have no > objection to the current behavior of point moving to the item just set > to done when the done items section is visible, since your patch doesn't > alter that. I never set the done items to visible, so can't offer an opinion there. > If so, then I'll install your patch as is (but with a more > appropriate commit message and ChangeLog entry). Before I do that, have > you submitted a copyright assignment for Emacs? If not, I'll install it > as a tiny change. Thanks for the patch. I don't have a copyright assignment on file. I have no objection to doing so if necessary, but for such a small change I suspect it would be more effort than it's worth. Regards Robert From unknown Mon Jun 23 00:37:18 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Robert Pluim Subject: bug#19727: closed (Re: bug#19727: 25.0.50; setting a todo item to done puts point at the end of the buffer) Message-ID: References: <87r3u5wdsh.fsf@gmx.net> <827fw5oq1k.fsf@gmail.com> X-Gnu-PR-Message: they-closed 19727 X-Gnu-PR-Package: emacs Reply-To: 19727@debbugs.gnu.org Date: Wed, 04 Feb 2015 21:47:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1423086422-23933-1" This is a multi-part message in MIME format... ------------=_1423086422-23933-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #19727: 25.0.50; setting a todo item to done puts point at the end of the b= uffer which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19727@debbugs.gnu.org. --=20 19727: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19727 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1423086422-23933-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 19727-done) by debbugs.gnu.org; 4 Feb 2015 21:46:31 +0000 Received: from localhost ([127.0.0.1]:34308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YJ7mJ-0006DF-84 for submit@debbugs.gnu.org; Wed, 04 Feb 2015 16:46:31 -0500 Received: from mout.gmx.net ([212.227.17.20]:53395) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YJ7mH-0006D0-E0 for 19727-done@debbugs.gnu.org; Wed, 04 Feb 2015 16:46:29 -0500 Received: from rosalinde ([89.245.108.118]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MKLeM-1YJg0O40k2-001jhh; Wed, 04 Feb 2015 22:46:23 +0100 From: Stephen Berman To: 19727-done@debbugs.gnu.org Subject: Re: bug#19727: 25.0.50; setting a todo item to done puts point at the end of the buffer References: <827fw5oq1k.fsf@gmail.com> <87egq6bow1.fsf@gmx.net> <82bnl93kre.fsf@gmail.com> Date: Wed, 04 Feb 2015 22:46:22 +0100 In-Reply-To: <82bnl93kre.fsf@gmail.com> (Robert Pluim's message of "Wed, 04 Feb 2015 13:48:37 +0100") Message-ID: <87r3u5wdsh.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:TI4/TE3MKdETrWxU3i4F4ri0A5F2yPeU9bS8ocYkJUzsVBcFOSO 8ivqCHgZhJBtETulOokG+3rGWl8wL0Zsad5I2ypHCZbOr0DF/dKyP6bmUZMY9NEQuNnxsVP Iuw0hkGs+sX7zgwSePEl3uPhg9AuENBRp11cCLRox83alwgnUC1/Q0oXhludZYWxzqmgWMF 5AxnDgoHxmrqSLnB5YD2Q== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19727-done Cc: Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Wed, 04 Feb 2015 13:48:37 +0100 Robert Pluim wrote: > I don't have a copyright assignment on file. I have no objection to > doing so if necessary, but for such a small change I suspect it would be > more effort than it's worth. I committed your patch to emacs-24 and am closing this bug. Thanks again. Steve Berman ------------=_1423086422-23933-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Jan 2015 17:10:10 +0000 Received: from localhost ([127.0.0.1]:57462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGsba-0001iO-5y for submit@debbugs.gnu.org; Thu, 29 Jan 2015 12:10:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49911) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGm49-0006BE-Aa for submit@debbugs.gnu.org; Thu, 29 Jan 2015 05:11:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGm42-0006Q2-T0 for submit@debbugs.gnu.org; Thu, 29 Jan 2015 05:11:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGm42-0006Py-QJ for submit@debbugs.gnu.org; Thu, 29 Jan 2015 05:11:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGm3y-0007L2-Vq for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 05:11:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGm3u-0006P6-N6 for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 05:11:02 -0500 Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:36445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGm3u-0006P2-Fy for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 05:10:58 -0500 Received: by mail-we0-f181.google.com with SMTP id k48so23085118wev.12 for ; Thu, 29 Jan 2015 02:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=E2vabU2xZhLCz6OZsO9SOhLk+CeWvLWQynv02E/0QbA=; b=hAgvU0yHQRIohIp1lEsM1HOvVa+75nFdTloEAzCpGAwJoY9kPDTvPg6f9Qb2zuj58S mcRo84P6CTK4mouwtyQ9xhh2u6AxkpxX6PFZd2+LZv90joJdybhlDCf2mAwDcAHny51z UZO/mAmWkzzCJIdZdn1ssmCLsElkSsI6TQbIi3vpRjj+PARQK+RiB86/V1yAmInpM6jp 1HtWJNkJP28dlqWEGNBnT218sAuAtvgu1eg4T/GWffeDkWIG0LNHe47WSV+prpoeLZQG noFTmqfVhUEPH/HAL6gQWSVxfVL8gq4RUaOGXFakfNDDLsEEHG6srueMVRLfG5Xi6wdx KsuQ== X-Received: by 10.194.84.176 with SMTP id a16mr16135574wjz.113.1422526257378; Thu, 29 Jan 2015 02:10:57 -0800 (PST) Received: from RPLUIM (vav06-1-78-207-202-9.fbx.proxad.net. [78.207.202.9]) by mx.google.com with ESMTPSA id p6sm1798540wia.14.2015.01.29.02.10.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jan 2015 02:10:56 -0800 (PST) From: Robert Pluim To: bug-gnu-emacs@gnu.org Subject: 25.0.50; setting a todo item to done puts point at the end of the buffer Date: Thu, 29 Jan 2015 11:10:47 +0100 Message-ID: <827fw5oq1k.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 29 Jan 2015 12:10:08 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Hi, when I set an item to done in a todo-mode buffer, point ends up at the end of the buffer, which is somewhat surprising. Attached patch remembers where point was, and restores it. Regards Robert In GNU Emacs 25.0.50.6 (i686-pc-cygwin) of 2015-01-28 on RPLUIM Repository revision: 8a8bd38fedb89b2d04cca2419698813a22862c3b Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --with-w32 --with-wide-int' --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=todo-mode-done-restore-point.patch diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 90681c8..060cbf7 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2015-01-26 Robert Pluim + + * calendar/todo-mode.el (todo-item-done): Initialize opoint so + that point stays where it is when setting items to DONE. + 2015-01-28 Tassilo Horn * textmodes/reftex.el (reftex-syntax-table-for-bib): Give ( and ) diff --git a/lisp/calendar/todo-mode.el b/lisp/calendar/todo-mode.el index 7ca57a4..2fb7e2e 100644 --- a/lisp/calendar/todo-mode.el +++ b/lisp/calendar/todo-mode.el @@ -2816,7 +2816,8 @@ (defun todo-item-done (&optional arg) (goto-char (point-min)) (re-search-forward todo-done-string-start nil t))) (buffer-read-only nil) - item done-item opoint) + item done-item + (opoint (point))) ;; Don't add empty comment to done item. (setq comment (unless (zerop (length comment)) (concat " [" todo-comment-string ": " comment "]"))) --=-=-=-- ------------=_1423086422-23933-1--