From unknown Tue Aug 19 21:04:09 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19711 <19711@debbugs.gnu.org> To: bug#19711 <19711@debbugs.gnu.org> Subject: Status: 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym)) Reply-To: bug#19711 <19711@debbugs.gnu.org> Date: Wed, 20 Aug 2025 04:04:09 +0000 retitle 19711 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p = (advice--symbol-function sym)) reassign 19711 emacs submitter 19711 Oleh Krehel severity 19711 normal tag 19711 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 28 08:58:56 2015 Received: (at submit) by debbugs.gnu.org; 28 Jan 2015 13:58:57 +0000 Received: from localhost ([127.0.0.1]:58592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGT8x-0004fm-Cf for submit@debbugs.gnu.org; Wed, 28 Jan 2015 08:58:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41026) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGT8s-0004fU-BR for submit@debbugs.gnu.org; Wed, 28 Jan 2015 08:58:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGT8m-0000YW-83 for submit@debbugs.gnu.org; Wed, 28 Jan 2015 08:58:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGT8m-0000YS-59 for submit@debbugs.gnu.org; Wed, 28 Jan 2015 08:58:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGT8l-0002F1-C2 for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 08:58:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGT8g-0000Wz-90 for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 08:58:43 -0500 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:61384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGT8g-0000Wv-1S for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 08:58:38 -0500 Received: by mail-wg0-f50.google.com with SMTP id b13so20669226wgh.9 for ; Wed, 28 Jan 2015 05:58:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=6bo15gOSUGrOYM7k9foBXnQHmqIw3SVK25sqVGdqLwk=; b=K22vy6tZXtWWZkaWB20eYnK7DFcHcJgTaipKe486FeCxvfp3Wv2A3k63euZyE1sdx3 zV+cF8SLznO2Alyq7LQ5WNeszNpmZKpaRMPP2Nwtm1AX+rvSnDaF+QwciOtyMaUFRooQ 1oyc1otvyUmyBFEhrITW12VzZJD7ZmBvnJSovzxFxmO9mUXnnaxENxlcACnKqpmyzd0Z LR4Ngl/D1V3pM4+vaauZZ62ef1lheeNpX36/m5vUcYilIHShWCr2G2Cr4S0YgyXryszV aXE4b0cUejCzqck7McYT4Z+St5h6adVc4WYyx7e2jStK2COx2dRR7r0CMwtAf6QptiO6 bBLQ== X-Received: by 10.180.211.2 with SMTP id my2mr7278195wic.3.1422453517170; Wed, 28 Jan 2015 05:58:37 -0800 (PST) Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by mx.google.com with ESMTPSA id i4sm6228810wje.20.2015.01.28.05.58.36 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 28 Jan 2015 05:58:36 -0800 (PST) From: Oleh Krehel To: bug-gnu-emacs@gnu.org Subject: 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym)) Date: Wed, 28 Jan 2015 14:55:01 +0100 Message-ID: <87y4on57t6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) `ad-is-adviced' expands to: (get 'foo 'ad-advice-info) This code will not detect if the function `foo' is being instrumented with `elp-instrument-package' (which is a form of advice). On the other hand, this code from `advice-remove' will work: (advice--p (advice--symbol-function 'foo)) To summarize, functions instrumented by elp aren't recognized as adviced by `ad-is-advised', even though :around advice: even shows up in the docstring. A fix could be to change `ad-is-adviced' to expand to either (or (get 'foo 'ad-advice-info) (get 'foo 'elp-info)) or (advice--p (advice--symbol-function 'foo)) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 28 14:55:48 2015 Received: (at 19711) by debbugs.gnu.org; 28 Jan 2015 19:55:48 +0000 Received: from localhost ([127.0.0.1]:59268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGYiK-00071P-41 for submit@debbugs.gnu.org; Wed, 28 Jan 2015 14:55:48 -0500 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:57508) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGYiH-00071F-PN for 19711@debbugs.gnu.org; Wed, 28 Jan 2015 14:55:46 -0500 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 89D3785E9E; Wed, 28 Jan 2015 14:55:44 -0500 (EST) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 7F4301E5B8D; Wed, 28 Jan 2015 14:55:19 -0500 (EST) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 637ABB4102; Wed, 28 Jan 2015 14:55:19 -0500 (EST) From: Stefan Monnier To: Oleh Krehel Subject: Re: bug#19711: 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym)) Message-ID: References: <87y4on57t6.fsf@gmail.com> Date: Wed, 28 Jan 2015 14:55:19 -0500 In-Reply-To: <87y4on57t6.fsf@gmail.com> (Oleh Krehel's message of "Wed, 28 Jan 2015 14:55:01 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19711 Cc: 19711@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > `ad-is-advised' expands to: > (get 'foo 'ad-advice-info) > This code will not detect if the function `foo' is being instrumented > with `elp-instrument-package' (which is a form of advice). That's because ad-is-advised tells you "is there a "defadvice" on this function" rather than "is there some kind of advice-like thingy on this function". Since this is used by advice.el internally, changing it might just break advice.el. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 28 15:07:44 2015 Received: (at 19711) by debbugs.gnu.org; 28 Jan 2015 20:07:45 +0000 Received: from localhost ([127.0.0.1]:59272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGYts-0007Ju-Cm for submit@debbugs.gnu.org; Wed, 28 Jan 2015 15:07:44 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:34091) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGYtq-0007Ji-Pb for 19711@debbugs.gnu.org; Wed, 28 Jan 2015 15:07:43 -0500 Received: by mail-wi0-f174.google.com with SMTP id n3so14531832wiv.1 for <19711@debbugs.gnu.org>; Wed, 28 Jan 2015 12:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Iq1lt6G1jIqTdF56zmu5Hai7zak4rcRQI2UsemooLK8=; b=IdaCZ/MwU9JIhqps4HlH16mqp+vN3q0yoMK6H0taiHMeyZ9RiYz0Y5/ThFhI7qPo33 +/NYocwjjL6m3GUGoocIzJog+pYNJr1uxBN8Sy6UrIu3NaSHiygWn5XVIvWplVcdfTRw ppVsQ6qtAGJ5KSawImwXnBvqPwcSq1xhIXQLznD0RdhOKUxPAa+oFqWBnKnmLPsKSaPK hss/dyeCTLuDfpboHuEojzJ33Bh5E8Y17q5Td5VrZjRTniIajYJjC1awE93y96ZF8Qin QMKqMKPumTyUHAd40ECjMr4C/JUQo64b7KPJWsaP4ynnUcFWH9PJEl69puHAyNG6T80b xFVw== MIME-Version: 1.0 X-Received: by 10.194.234.2 with SMTP id ua2mr10953240wjc.40.1422475657051; Wed, 28 Jan 2015 12:07:37 -0800 (PST) Received: by 10.27.137.137 with HTTP; Wed, 28 Jan 2015 12:07:36 -0800 (PST) In-Reply-To: References: <87y4on57t6.fsf@gmail.com> Date: Wed, 28 Jan 2015 21:07:36 +0100 Message-ID: Subject: Re: bug#19711: 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym)) From: Oleh Krehel To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19711 Cc: 19711@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Jan 28, 2015 at 8:55 PM, Stefan Monnier wrote: >> `ad-is-advised' expands to: >> (get 'foo 'ad-advice-info) >> This code will not detect if the function `foo' is being instrumented >> with `elp-instrument-package' (which is a form of advice). > > That's because ad-is-advised tells you "is there a "defadvice" on this > function" rather than "is there some kind of advice-like thingy on this > function". > Since this is used by advice.el internally, changing it might just break > advice.el. I'm mainly interested in this application: (help-function-arglist (if (ad-is-advised fun) (ad-get-orig-definition fun) fun) t) I can't get the original arguments of FUN if it's adviced (instrumented also falls here), so I'd like to detect if it is. If `ad-is-advised` isn't enough, what other (public) function could I use? From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 28 16:47:00 2015 Received: (at 19711) by debbugs.gnu.org; 28 Jan 2015 21:47:00 +0000 Received: from localhost ([127.0.0.1]:56750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGaRw-0002IB-AD for submit@debbugs.gnu.org; Wed, 28 Jan 2015 16:47:00 -0500 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:35247) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGaRs-0002Hz-TH for 19711@debbugs.gnu.org; Wed, 28 Jan 2015 16:46:57 -0500 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id CAB2A85D8C; Wed, 28 Jan 2015 16:46:55 -0500 (EST) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 097ED1E5B8B; Wed, 28 Jan 2015 16:46:33 -0500 (EST) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id D79F1B4102; Wed, 28 Jan 2015 16:46:32 -0500 (EST) From: Stefan Monnier To: Oleh Krehel Subject: Re: bug#19711: 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym)) Message-ID: References: <87y4on57t6.fsf@gmail.com> Date: Wed, 28 Jan 2015 16:46:32 -0500 In-Reply-To: (Oleh Krehel's message of "Wed, 28 Jan 2015 21:07:36 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19711 Cc: 19711@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > I'm mainly interested in this application: > (help-function-arglist > (if (ad-is-advised fun) > (ad-get-orig-definition fun) > fun) > t) Ah, I think this is just a bug of help-function-arglist: it should automatically peel off any advice and look for the arglist of the unadvised function instead. > If `ad-is-advised` isn't enough, what other (public) function could I use? Good question. I think currently all the functions that could help come with a "--". Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 16 09:16:07 2021 Received: (at 19711) by debbugs.gnu.org; 16 Aug 2021 13:16:07 +0000 Received: from localhost ([127.0.0.1]:48973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFcTC-0005uR-P0 for submit@debbugs.gnu.org; Mon, 16 Aug 2021 09:16:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFcT7-0005kh-2V for 19711@debbugs.gnu.org; Mon, 16 Aug 2021 09:16:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=An4juIfrAFmlGuPnQwhuTvFfsA4YngNCd2Tx+Q2cBVE=; b=WUvj6+cYQWIU8SHsx07KfeFzak uOJP6R22NAhPqJt6EWR5VtLlT+RZbLtzXQSkM/l8eRPNUSntRk7PpWPQEirkiegl9Cb+9LbyznBLm Nx3s4o46G1Kzw3/Bz4S9HH6dwqrHagtWGTBcZhPqG0AGbRi3K65nN6Wh1juwVeDzCjQs=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFcSv-00058o-6N; Mon, 16 Aug 2021 15:15:49 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#19711: 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym)) References: <87y4on57t6.fsf@gmail.com> Date: Mon, 16 Aug 2021 15:15:44 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 28 Jan 2015 16:46:32 -0500") Message-ID: <8735r9bke7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> I'm mainly interested in this application: > >> (help-function-arglist >> (if (ad-is-advised fun) >> (ad-get-orig-definition fun) >> fun) >> t) > > Ah, I think this is just a bug of help-function-a [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19711 Cc: 19711@debbugs.gnu.org, Oleh Krehel X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> I'm mainly interested in this application: > >> (help-function-arglist >> (if (ad-is-advised fun) >> (ad-get-orig-definition fun) >> fun) >> t) > > Ah, I think this is just a bug of help-function-arglist: it should > automatically peel off any advice and look for the arglist of the > unadvised function instead. I think this was basically fixed by: commit 6e2d6d54e1236216462c13655ea1fe573d9672e7 Author: Stefan Monnier AuthorDate: Fri Jul 14 11:27:21 2017 -0400 That is, "other advise" (not detected by `ad-is-advised') is now peeled off by `help-function-arglist' itself, so the code in question should work as expected, I think. So I don't think there's anything to fix here (any more). Is that correct? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 16 09:16:07 2021 Received: (at control) by debbugs.gnu.org; 16 Aug 2021 13:16:07 +0000 Received: from localhost ([127.0.0.1]:48975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFcTH-0005yf-7a for submit@debbugs.gnu.org; Mon, 16 Aug 2021 09:16:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFcTA-0005nl-DY for control@debbugs.gnu.org; Mon, 16 Aug 2021 09:16:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5XdKQh/K2YcLXzJdE8LPZiYW93mzortiue0QuQSXIFc=; b=Qeg/q3pvwvtMmbGaPsnRcvr5xq iBXTxwIbcsqrskUNFAJ22YbjonAzShyV6XupPO01AVlJmoghS4GHey7QfbsXAGgLOK9eR+2D1zEo6 VK5BbG8RsGjuX8I07lLLDkLTVUygejxb4PZO1ctl9GwDXDWWNa3Vx+hJ87BT7ybhDzvo=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFcT2-00058x-LV for control@debbugs.gnu.org; Mon, 16 Aug 2021 15:15:54 +0200 Date: Mon, 16 Aug 2021 15:15:52 +0200 Message-Id: <871r6tbkdz.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #19711 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 19711 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 19711 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 16 13:39:42 2021 Received: (at 19711-done) by debbugs.gnu.org; 16 Aug 2021 17:39:42 +0000 Received: from localhost ([127.0.0.1]:50894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFgaM-0001pQ-6t for submit@debbugs.gnu.org; Mon, 16 Aug 2021 13:39:42 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFgaJ-0001p8-Jq for 19711-done@debbugs.gnu.org; Mon, 16 Aug 2021 13:39:40 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 71D10440B85; Mon, 16 Aug 2021 13:39:33 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 516C6440B17; Mon, 16 Aug 2021 13:39:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1629135572; bh=Br5w6Ezxb9ane27ZetCyTmRCDtng8L9d5Hx/BE+zpEs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Jg5aqEJSHZQX9wRqX5bKsVvVMWD2v5mBZd+wNH0/0v2hgF1yJlsiLDGYSjkb3kflj ij+cBUW5joWLOFAGj+MhiXrtCfZpGuUXigBCPrPiosCVtcGuEwgjD3pfCuO2a2doO9 wiFLywWCYbPnrWWCLJlYvBkJxjGRbv7HRNgHSJkwn+iED+GMvol65Ug9i20gMWUiUs /mtnmZWsuPB9bksYvbQHevnFIUw18V2aMjV4vS270KrR2BoPQDRs74TuHOA3lTxGss RVEBXqZ/DQca5Hq2rGiiP6TZ5K9TkVEBXs4VZYhEqCs5hoiCSNvjYHqgEwMnnsGl7u a0vcLeMUXbiQw== Received: from alfajor (unknown [104.247.244.135]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 10E16120315; Mon, 16 Aug 2021 13:39:32 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#19711: 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym)) Message-ID: References: <87y4on57t6.fsf@gmail.com> <8735r9bke7.fsf@gnus.org> Date: Mon, 16 Aug 2021 13:39:31 -0400 In-Reply-To: <8735r9bke7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 16 Aug 2021 15:15:44 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.154 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19711-done Cc: 19711-done@debbugs.gnu.org, Oleh Krehel X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I think this was basically fixed by: > > commit 6e2d6d54e1236216462c13655ea1fe573d9672e7 > Author: Stefan Monnier > AuthorDate: Fri Jul 14 11:27:21 2017 -0400 Agreed, closing, Stefan From unknown Tue Aug 19 21:04:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 14 Sep 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator