From unknown Wed Aug 20 01:21:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19710: 24.4.51; Isearch is broken in comints which relly on regexp Resent-From: Vitalie Spinu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jan 2015 09:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 19710@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.142243622512528 (code B ref -1); Wed, 28 Jan 2015 09:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jan 2015 09:10:25 +0000 Received: from localhost ([127.0.0.1]:58448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGOdk-0003Fz-6K for submit@debbugs.gnu.org; Wed, 28 Jan 2015 04:10:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56451) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGOdh-0003Fi-Gh for submit@debbugs.gnu.org; Wed, 28 Jan 2015 04:10:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGOdY-0001qm-9r for submit@debbugs.gnu.org; Wed, 28 Jan 2015 04:10:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGOdY-0001qa-79 for submit@debbugs.gnu.org; Wed, 28 Jan 2015 04:10:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGOdX-00077I-5J for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 04:10:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGOdR-0001id-Ma for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 04:10:11 -0500 Received: from mail-we0-x232.google.com ([2a00:1450:400c:c03::232]:43304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGOdR-0001ez-H4 for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 04:10:05 -0500 Received: by mail-we0-f178.google.com with SMTP id k48so19495212wev.9 for ; Wed, 28 Jan 2015 01:10:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=Cxa3L7Ap+lDBcC+lksNsyFA2X97q6fprSnTPzXTaWIs=; b=exTfP0M1L4b2WIcuI6Czy7B17IQifbvJ9Ek/AG1/cceiZCs4gEUbw7XCe3omc9HU9M POK79tif4VX1htEBnZQGrZQyYG25HVO4ehbUo/nrGmwftrfufcJGP8Rhotm88GM/MMym ke+HwEZsDM2BIrjWm1YF1LMCSCqhBKyXHU4r6pCrkoIvqZKFW5gWIy/YCBuxyc6Lo9uM +QfxLgyGxChsfujsuhKpbJ6cgH20S+rna/8yLtbr9pPwN11m+j9pbt7jc0jrRWC2cnjM 6Asy5Sa0iOkGJU1lWSpg+6NghqKUVYwrNLA++neTx9Adt+fsAJ2eEOAKW0cFPVSb0Yfo oUBw== X-Received: by 10.194.81.104 with SMTP id z8mr5002727wjx.45.1422436204092; Wed, 28 Jan 2015 01:10:04 -0800 (PST) Received: from localhost (dhcp-077-251-128-242.chello.nl. [77.251.128.242]) by mx.google.com with ESMTPSA id gm10sm1864533wib.19.2015.01.28.01.10.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jan 2015 01:10:03 -0800 (PST) From: Vitalie Spinu Date: Wed, 28 Jan 2015 10:10:02 +0100 Message-ID: <87oapjmfth.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Recent changes to commit to allow for multiline search assume fields throughout. The common case when comint-use-prompt-regexp is non-nil is not captured. To see the problem start shell and issue a couple of commands. Then (setq comint-use-prompt-regexp t), and add a couple of RETs. Then try M-r. You should see "Regexp history I-search backward:" several lines above where it should be and isearch will not work as expected. If you restart your shell, you will not even see the "Regexp history I-search backward:" as there are no fields in the buffer. Vitalie ----- In GNU Emacs 24.4.51.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2) of 2015-01-28 on galago Repository revision: 9664defd262252faf037c5fe1ea095f1cc4b308b Windowing system distributor `The X.Org Foundation', version 11.0.11600000 System Description: Ubuntu 14.10 From unknown Wed Aug 20 01:21:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19710: 24.4.51; Isearch is broken in comints which relly on regexp Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jan 2015 01:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Vitalie Spinu Cc: 19710@debbugs.gnu.org Received: via spool by 19710-submit@debbugs.gnu.org id=B19710.142249333526644 (code B ref 19710); Thu, 29 Jan 2015 01:03:02 +0000 Received: (at 19710) by debbugs.gnu.org; 29 Jan 2015 01:02:15 +0000 Received: from localhost ([127.0.0.1]:56760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGdUs-0006vf-Et for submit@debbugs.gnu.org; Wed, 28 Jan 2015 20:02:14 -0500 Received: from ps18281.dreamhost.com ([69.163.222.226]:51324 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGdUo-0006vV-Jo for 19710@debbugs.gnu.org; Wed, 28 Jan 2015 20:02:11 -0500 Received: from localhost.linkov.net (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 6905A362E859EF; Wed, 28 Jan 2015 17:02:08 -0800 (PST) From: Juri Linkov Organization: LINKOV.NET References: <87oapjmfth.fsf@gmail.com> Date: Thu, 29 Jan 2015 02:50:33 +0200 In-Reply-To: <87oapjmfth.fsf@gmail.com> (Vitalie Spinu's message of "Wed, 28 Jan 2015 10:10:02 +0100") Message-ID: <874mrawgcu.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Recent changes to commit to allow for multiline search assume fields > throughout. The common case when comint-use-prompt-regexp is non-nil is > not captured. > > To see the problem start shell and issue a couple of commands. Then > (setq comint-use-prompt-regexp t), and add a couple of RETs. Then try M-r. > > You should see "Regexp history I-search backward:" several lines above > where it should be and isearch will not work as expected. > > If you restart your shell, you will not even see the "Regexp history > I-search backward:" as there are no fields in the buffer. Thanks for the report. This can be fixed by the patch that reverts the change of callers, and instead modifies `comint-line-beginning-position' to support multi-line input for both cases of comint-use-prompt-regexp = t/nil: diff --git a/lisp/comint.el b/lisp/comint.el index 30c4dda..1333a0b 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -1475,7 +1475,7 @@ (defun comint-history-isearch-search () (or ;; 1. First try searching in the initial comint text (funcall search-fun string - (if isearch-forward bound (field-beginning)) + (if isearch-forward bound (comint-line-beginning-position)) noerror) ;; 2. If the above search fails, start putting next/prev history ;; elements in the comint successively, and search the string @@ -1491,7 +1491,7 @@ (defun comint-history-isearch-search () (when (null comint-input-ring-index) (error "End of history; no next item")) (comint-next-input 1) - (goto-char (field-beginning))) + (goto-char (comint-line-beginning-position))) (t ;; Signal an error here explicitly, because ;; `comint-previous-input' doesn't signal an error. @@ -1509,7 +1509,7 @@ (defun comint-history-isearch-search () (unless isearch-forward ;; For backward search, don't search ;; in the comint prompt - (field-beginning)) + (comint-line-beginning-position)) noerror))) ;; Return point of the new search result (point)) @@ -1533,16 +1533,16 @@ (defun comint-history-isearch-message (&optional c-q-hack ellipsis) (if (overlayp comint-history-isearch-message-overlay) (move-overlay comint-history-isearch-message-overlay (save-excursion - (goto-char (field-beginning)) + (goto-char (comint-line-beginning-position)) (forward-line 0) (point)) - (field-beginning)) + (comint-line-beginning-position)) (setq comint-history-isearch-message-overlay (make-overlay (save-excursion - (goto-char (field-beginning)) + (goto-char (comint-line-beginning-position)) (forward-line 0) (point)) - (field-beginning))) + (comint-line-beginning-position))) (overlay-put comint-history-isearch-message-overlay 'evaporate t)) (overlay-put comint-history-isearch-message-overlay 'display (isearch-message-prefix ellipsis isearch-nonincremental)) @@ -1563,7 +1563,7 @@ (defun comint-history-isearch-wrap () (comint-goto-input (1- (ring-length comint-input-ring))) (comint-goto-input nil)) (setq isearch-success t) - (goto-char (if isearch-forward (field-beginning) (point-max)))) + (goto-char (if isearch-forward (comint-line-beginning-position) (point-max)))) (defun comint-history-isearch-push-state () "Save a function restoring the state of input history search. @@ -1787,7 +1787,10 @@ (defun comint-send-input (&optional no-newline artificial) (widen) (let* ((pmark (process-mark proc)) (intxt (if (>= (point) (marker-position pmark)) - (progn (if comint-eol-on-send (goto-char (field-end))) + (progn (if comint-eol-on-send + (if comint-use-prompt-regexp + (end-of-line) + (goto-char (field-end)))) (buffer-substring pmark (point))) (let ((copy (funcall comint-get-old-input))) (goto-char pmark) @@ -2266,6 +2269,7 @@ (defun comint-line-beginning-position () (if comint-use-prompt-regexp ;; Use comint-prompt-regexp (save-excursion + (re-search-backward (concat comint-prompt-regexp ".*") nil t) (beginning-of-line) (comint-skip-prompt) (point)) @@ -2276,7 +2280,7 @@ (defun comint-line-beginning-position () ;; if there are two fields on a line, then the first one is the ;; prompt, and the second one is an input field, and is front-sticky ;; (as input fields should be). - (constrain-to-field (line-beginning-position) (line-end-position)))) + (constrain-to-field (field-beginning) (line-end-position)))) (defun comint-bol (&optional arg) "Go to the beginning of line, then skip past the prompt, if any. From unknown Wed Aug 20 01:21:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19710: 24.4.51; Isearch is broken in comints which relly on regexp Resent-From: Vitalie Spinu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jan 2015 08:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 19710@debbugs.gnu.org Received: via spool by 19710-submit@debbugs.gnu.org id=B19710.14225192002229 (code B ref 19710); Thu, 29 Jan 2015 08:14:02 +0000 Received: (at 19710) by debbugs.gnu.org; 29 Jan 2015 08:13:20 +0000 Received: from localhost ([127.0.0.1]:56818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGkE3-0000Zs-Qq for submit@debbugs.gnu.org; Thu, 29 Jan 2015 03:13:20 -0500 Received: from mail-wi0-f182.google.com ([209.85.212.182]:54643) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGkDz-0000ZY-T5 for 19710@debbugs.gnu.org; Thu, 29 Jan 2015 03:13:16 -0500 Received: by mail-wi0-f182.google.com with SMTP id n3so20877225wiv.3 for <19710@debbugs.gnu.org>; Thu, 29 Jan 2015 00:13:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=NHVvy3QPV4nWC/iBNzXgMcY/snxJn+tsPGnrwks5JXA=; b=JqWLi5YHdJde1RKf7X9GkIjtMu5NeDBbJzaF86rFpXtdTOz7/Mpb1evvStnIknSBig 0a439s0Yoz84nzaqN71YRh0DqoSs/Kh/0Nt2xi2gRquyb5Zmwg70YLwT6UTPcD4lQjC5 TaYJb7CC5Ddf2iCQ3qTog3krbeuFdeqnsMjZTT70WTu4siCuOgJGNnNbJlvL2R5gGes+ bQn2s6TQxIRFwi++1afKdMH+pmzXIx26+qvgGDGwdRLwEenC6kn2ExPJZ+ek+4ykxYWT +3yaIUV+LFyV3alvAdYFvSqQl1qZhC1vnTheioxrHJkQIGU2AqMg4v0ofUmt5svd5RWC DTfA== X-Received: by 10.194.91.199 with SMTP id cg7mr16368893wjb.114.1422519190244; Thu, 29 Jan 2015 00:13:10 -0800 (PST) Received: from localhost (dhcp-077-251-128-242.chello.nl. [77.251.128.242]) by mx.google.com with ESMTPSA id hl1sm9371674wjc.18.2015.01.29.00.13.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jan 2015 00:13:09 -0800 (PST) From: Vitalie Spinu References: <87oapjmfth.fsf@gmail.com> <874mrawgcu.fsf@mail.linkov.net> Date: Thu, 29 Jan 2015 09:13:08 +0100 In-Reply-To: <874mrawgcu.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 29 Jan 2015 02:50:33 +0200") Message-ID: <87oapi6m3v.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.51 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Thanks Juri, this patch solves the problem indeed. Vitalie >>> Juri Linkov on Thu, 29 Jan 2015 02:50:33 +0200 wrote: >> Recent changes to commit to allow for multiline search assume fields >> throughout. The common case when comint-use-prompt-regexp is non-nil is >> not captured. >> >> To see the problem start shell and issue a couple of commands. Then >> (setq comint-use-prompt-regexp t), and add a couple of RETs. Then try M-r. >> >> You should see "Regexp history I-search backward:" several lines above >> where it should be and isearch will not work as expected. >> >> If you restart your shell, you will not even see the "Regexp history >> I-search backward:" as there are no fields in the buffer. > Thanks for the report. This can be fixed by the patch that > reverts the change of callers, and instead modifies > `comint-line-beginning-position' to support multi-line input > for both cases of comint-use-prompt-regexp = t/nil: > diff --git a/lisp/comint.el b/lisp/comint.el > index 30c4dda..1333a0b 100644 > --- a/lisp/comint.el > +++ b/lisp/comint.el > @@ -1475,7 +1475,7 @@ (defun comint-history-isearch-search () > (or > ;; 1. First try searching in the initial comint text > (funcall search-fun string > - (if isearch-forward bound (field-beginning)) > + (if isearch-forward bound (comint-line-beginning-position)) > noerror) > ;; 2. If the above search fails, start putting next/prev history > ;; elements in the comint successively, and search the string > @@ -1491,7 +1491,7 @@ (defun comint-history-isearch-search () > (when (null comint-input-ring-index) > (error "End of history; no next item")) > (comint-next-input 1) > - (goto-char (field-beginning))) > + (goto-char (comint-line-beginning-position))) > (t > ;; Signal an error here explicitly, because > ;; `comint-previous-input' doesn't signal an error. > @@ -1509,7 +1509,7 @@ (defun comint-history-isearch-search () > (unless isearch-forward > ;; For backward search, don't search > ;; in the comint prompt > - (field-beginning)) > + (comint-line-beginning-position)) > noerror))) > ;; Return point of the new search result > (point)) > @@ -1533,16 +1533,16 @@ (defun comint-history-isearch-message (&optional c-q-hack ellipsis) > (if (overlayp comint-history-isearch-message-overlay) > (move-overlay comint-history-isearch-message-overlay > (save-excursion > - (goto-char (field-beginning)) > + (goto-char (comint-line-beginning-position)) > (forward-line 0) > (point)) > - (field-beginning)) > + (comint-line-beginning-position)) > (setq comint-history-isearch-message-overlay > (make-overlay (save-excursion > - (goto-char (field-beginning)) > + (goto-char (comint-line-beginning-position)) > (forward-line 0) > (point)) > - (field-beginning))) > + (comint-line-beginning-position))) > (overlay-put comint-history-isearch-message-overlay 'evaporate t)) > (overlay-put comint-history-isearch-message-overlay > 'display (isearch-message-prefix ellipsis isearch-nonincremental)) > @@ -1563,7 +1563,7 @@ (defun comint-history-isearch-wrap () > (comint-goto-input (1- (ring-length comint-input-ring))) > (comint-goto-input nil)) > (setq isearch-success t) > - (goto-char (if isearch-forward (field-beginning) (point-max)))) > + (goto-char (if isearch-forward (comint-line-beginning-position) (point-max)))) > (defun comint-history-isearch-push-state () > "Save a function restoring the state of input history search. > @@ -1787,7 +1787,10 @@ (defun comint-send-input (&optional no-newline artificial) > (widen) > (let* ((pmark (process-mark proc)) > (intxt (if (>= (point) (marker-position pmark)) > - (progn (if comint-eol-on-send (goto-char (field-end))) > + (progn (if comint-eol-on-send > + (if comint-use-prompt-regexp > + (end-of-line) > + (goto-char (field-end)))) > (buffer-substring pmark (point))) > (let ((copy (funcall comint-get-old-input))) > (goto-char pmark) > @@ -2266,6 +2269,7 @@ (defun comint-line-beginning-position () > (if comint-use-prompt-regexp > ;; Use comint-prompt-regexp > (save-excursion > + (re-search-backward (concat comint-prompt-regexp ".*") nil t) > (beginning-of-line) > (comint-skip-prompt) > (point)) > @@ -2276,7 +2280,7 @@ (defun comint-line-beginning-position () > ;; if there are two fields on a line, then the first one is the > ;; prompt, and the second one is an input field, and is front-sticky > ;; (as input fields should be). > - (constrain-to-field (line-beginning-position) (line-end-position)))) > + (constrain-to-field (field-beginning) (line-end-position)))) > (defun comint-bol (&optional arg) > "Go to the beginning of line, then skip past the prompt, if any. From unknown Wed Aug 20 01:21:35 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Vitalie Spinu Subject: bug#19710: closed (Re: bug#19710: 24.4.51; Isearch is broken in comints which relly on regexp) Message-ID: References: <87vbjhdvas.fsf@mail.linkov.net> <87oapjmfth.fsf@gmail.com> X-Gnu-PR-Message: they-closed 19710 X-Gnu-PR-Package: emacs Reply-To: 19710@debbugs.gnu.org Date: Thu, 05 Feb 2015 01:05:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1423098302-10083-1" This is a multi-part message in MIME format... ------------=_1423098302-10083-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #19710: 24.4.51; Isearch is broken in comints which relly on regexp which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19710@debbugs.gnu.org. --=20 19710: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19710 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1423098302-10083-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 19710-done) by debbugs.gnu.org; 5 Feb 2015 01:04:52 +0000 Received: from localhost ([127.0.0.1]:34401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YJAsG-0002cB-H4 for submit@debbugs.gnu.org; Wed, 04 Feb 2015 20:04:52 -0500 Received: from ps18281.dreamhost.com ([69.163.222.226]:40279 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YJAsF-0002c3-3K for 19710-done@debbugs.gnu.org; Wed, 04 Feb 2015 20:04:51 -0500 Received: from localhost.linkov.net (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 3D829302CA9DB4; Wed, 4 Feb 2015 17:04:49 -0800 (PST) From: Juri Linkov To: Vitalie Spinu Subject: Re: bug#19710: 24.4.51; Isearch is broken in comints which relly on regexp Organization: LINKOV.NET References: <87oapjmfth.fsf@gmail.com> <874mrawgcu.fsf@mail.linkov.net> <87oapi6m3v.fsf@gmail.com> Date: Thu, 05 Feb 2015 02:57:07 +0200 In-Reply-To: <87oapi6m3v.fsf@gmail.com> (Vitalie Spinu's message of "Thu, 29 Jan 2015 09:13:08 +0100") Message-ID: <87vbjhdvas.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19710-done Cc: 19710-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > >> Recent changes to commit to allow for multiline search assume fields > >> throughout. The common case when comint-use-prompt-regexp is non-nil is > >> not captured. > >> > >> To see the problem start shell and issue a couple of commands. Then > >> (setq comint-use-prompt-regexp t), and add a couple of RETs. Then try M-r. > >> > >> You should see "Regexp history I-search backward:" several lines above > >> where it should be and isearch will not work as expected. > >> > >> If you restart your shell, you will not even see the "Regexp history > >> I-search backward:" as there are no fields in the buffer. > > > Thanks for the report. This can be fixed by the patch that > > reverts the change of callers, and instead modifies > > `comint-line-beginning-position' to support multi-line input > > for both cases of comint-use-prompt-regexp = t/nil: > > Thanks Juri, this patch solves the problem indeed. I fixed this on the emacs-24 branch because bug#19572 backported previous changes to emacs-24. ------------=_1423098302-10083-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Jan 2015 09:10:25 +0000 Received: from localhost ([127.0.0.1]:58448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGOdk-0003Fz-6K for submit@debbugs.gnu.org; Wed, 28 Jan 2015 04:10:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56451) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGOdh-0003Fi-Gh for submit@debbugs.gnu.org; Wed, 28 Jan 2015 04:10:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGOdY-0001qm-9r for submit@debbugs.gnu.org; Wed, 28 Jan 2015 04:10:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGOdY-0001qa-79 for submit@debbugs.gnu.org; Wed, 28 Jan 2015 04:10:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGOdX-00077I-5J for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 04:10:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGOdR-0001id-Ma for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 04:10:11 -0500 Received: from mail-we0-x232.google.com ([2a00:1450:400c:c03::232]:43304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGOdR-0001ez-H4 for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 04:10:05 -0500 Received: by mail-we0-f178.google.com with SMTP id k48so19495212wev.9 for ; Wed, 28 Jan 2015 01:10:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=Cxa3L7Ap+lDBcC+lksNsyFA2X97q6fprSnTPzXTaWIs=; b=exTfP0M1L4b2WIcuI6Czy7B17IQifbvJ9Ek/AG1/cceiZCs4gEUbw7XCe3omc9HU9M POK79tif4VX1htEBnZQGrZQyYG25HVO4ehbUo/nrGmwftrfufcJGP8Rhotm88GM/MMym ke+HwEZsDM2BIrjWm1YF1LMCSCqhBKyXHU4r6pCrkoIvqZKFW5gWIy/YCBuxyc6Lo9uM +QfxLgyGxChsfujsuhKpbJ6cgH20S+rna/8yLtbr9pPwN11m+j9pbt7jc0jrRWC2cnjM 6Asy5Sa0iOkGJU1lWSpg+6NghqKUVYwrNLA++neTx9Adt+fsAJ2eEOAKW0cFPVSb0Yfo oUBw== X-Received: by 10.194.81.104 with SMTP id z8mr5002727wjx.45.1422436204092; Wed, 28 Jan 2015 01:10:04 -0800 (PST) Received: from localhost (dhcp-077-251-128-242.chello.nl. [77.251.128.242]) by mx.google.com with ESMTPSA id gm10sm1864533wib.19.2015.01.28.01.10.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jan 2015 01:10:03 -0800 (PST) From: Vitalie Spinu To: bug-gnu-emacs@gnu.org Subject: 24.4.51; Isearch is broken in comints which relly on regexp Date: Wed, 28 Jan 2015 10:10:02 +0100 Message-ID: <87oapjmfth.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Recent changes to commit to allow for multiline search assume fields throughout. The common case when comint-use-prompt-regexp is non-nil is not captured. To see the problem start shell and issue a couple of commands. Then (setq comint-use-prompt-regexp t), and add a couple of RETs. Then try M-r. You should see "Regexp history I-search backward:" several lines above where it should be and isearch will not work as expected. If you restart your shell, you will not even see the "Regexp history I-search backward:" as there are no fields in the buffer. Vitalie ----- In GNU Emacs 24.4.51.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2) of 2015-01-28 on galago Repository revision: 9664defd262252faf037c5fe1ea095f1cc4b308b Windowing system distributor `The X.Org Foundation', version 11.0.11600000 System Description: Ubuntu 14.10 ------------=_1423098302-10083-1-- From unknown Wed Aug 20 01:21:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19710: 24.4.51; Isearch is broken in comints which relly on regexp Resent-From: Vitalie Spinu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Feb 2015 10:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 19710-done@debbugs.gnu.org Received: via spool by 19710-done@debbugs.gnu.org id=D19710.14231306311287 (code D ref 19710); Thu, 05 Feb 2015 10:04:01 +0000 Received: (at 19710-done) by debbugs.gnu.org; 5 Feb 2015 10:03:51 +0000 Received: from localhost ([127.0.0.1]:34519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YJJHq-0000Kg-O5 for submit@debbugs.gnu.org; Thu, 05 Feb 2015 05:03:50 -0500 Received: from mail-wi0-f170.google.com ([209.85.212.170]:48175) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YJJHp-0000KT-Fs for 19710-done@debbugs.gnu.org; Thu, 05 Feb 2015 05:03:50 -0500 Received: by mail-wi0-f170.google.com with SMTP id bs8so1317231wib.1 for <19710-done@debbugs.gnu.org>; Thu, 05 Feb 2015 02:03:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=NWkwEae2CgEYqfTVY6Qn5zM0wAnQUj/Huc95yn9hlYo=; b=TBzvhnPIbmiDtsuyj2/dEo9AQYprY5eFdd3ckBL7u6dZa28+6jZSoIIBIKBc0mG+1O lntRvIvMPiFVjuFzLSVr51d6QVlect6KyDS30i/y3M79PjKeIjEVuy9LFbc8iOoWKlTG nX8u/mhwFgEM9j5/JuTtMuIlosb9ufOUKpas0FSIulcAn3Pvee8RUg3K1AZqUOfJ2HWq hYxs0DHe9pigCpL4TNEQNhooXt4U3JcRB8Y9rKtesrZW0JF90KjRWsdO/faBHWlNVQdF nSy1cQNTMv2sF4QjULZxEbDV5RUm1ZXxqR0UVy46wfLU6imbdVBFVQzscpOEv3o9cV6U QFGA== X-Received: by 10.180.99.42 with SMTP id en10mr45793502wib.26.1423130623783; Thu, 05 Feb 2015 02:03:43 -0800 (PST) Received: from localhost (dhcp-077-251-128-242.chello.nl. [77.251.128.242]) by mx.google.com with ESMTPSA id n6sm6623888wjy.8.2015.02.05.02.03.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Feb 2015 02:03:42 -0800 (PST) From: Vitalie Spinu References: <87oapjmfth.fsf@gmail.com> <874mrawgcu.fsf@mail.linkov.net> <87oapi6m3v.fsf@gmail.com> <87vbjhdvas.fsf@mail.linkov.net> Date: Thu, 05 Feb 2015 11:03:41 +0100 In-Reply-To: <87vbjhdvas.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 05 Feb 2015 02:57:07 +0200") Message-ID: <877fvwvfnm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.51 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Thanks. It works. Vitalie >>> Juri Linkov on Thu, 05 Feb 2015 02:57:07 +0200 wrote: >> >> Recent changes to commit to allow for multiline search assume fields >> >> throughout. The common case when comint-use-prompt-regexp is non-nil is >> >> not captured. >> >> >> >> To see the problem start shell and issue a couple of commands. Then >> >> (setq comint-use-prompt-regexp t), and add a couple of RETs. Then try M-r. >> >> >> >> You should see "Regexp history I-search backward:" several lines above >> >> where it should be and isearch will not work as expected. >> >> >> >> If you restart your shell, you will not even see the "Regexp history >> >> I-search backward:" as there are no fields in the buffer. >> >> > Thanks for the report. This can be fixed by the patch that >> > reverts the change of callers, and instead modifies >> > `comint-line-beginning-position' to support multi-line input >> > for both cases of comint-use-prompt-regexp = t/nil: >> >> Thanks Juri, this patch solves the problem indeed. > I fixed this on the emacs-24 branch because bug#19572 backported > previous changes to emacs-24. From unknown Wed Aug 20 01:21:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19710: 24.4.51; Isearch is broken in comints which relly on regexp Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Feb 2015 00:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Vitalie Spinu Cc: 19710@debbugs.gnu.org Received: via spool by 19710-submit@debbugs.gnu.org id=B19710.142352879017559 (code B ref 19710); Tue, 10 Feb 2015 00:40:01 +0000 Received: (at 19710) by debbugs.gnu.org; 10 Feb 2015 00:39:50 +0000 Received: from localhost ([127.0.0.1]:38630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YKyrm-0004Z9-E9 for submit@debbugs.gnu.org; Mon, 09 Feb 2015 19:39:50 -0500 Received: from ps18281.dreamhost.com ([69.163.222.226]:47455 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YKyrk-0004Z1-Ro for 19710@debbugs.gnu.org; Mon, 09 Feb 2015 19:39:49 -0500 Received: from localhost.linkov.net (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 01D0D30B115D1E; Mon, 9 Feb 2015 16:39:46 -0800 (PST) From: Juri Linkov Organization: LINKOV.NET References: <87oapjmfth.fsf@gmail.com> <874mrawgcu.fsf@mail.linkov.net> <87oapi6m3v.fsf@gmail.com> <87vbjhdvas.fsf@mail.linkov.net> <877fvwvfnm.fsf@gmail.com> Date: Tue, 10 Feb 2015 02:39:08 +0200 In-Reply-To: <877fvwvfnm.fsf@gmail.com> (Vitalie Spinu's message of "Thu, 05 Feb 2015 11:03:41 +0100") Message-ID: <87pp9ipplf.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Thanks. It works. I noticed that it works differently when typing RET while point is on the prompt, so I had to add support for this case for the users who might want to do such a strange thing. From unknown Wed Aug 20 01:21:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19710: 24.4.51; Isearch is broken in comints which relly on regexp Resent-From: Vitalie Spinu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Feb 2015 15:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 19710@debbugs.gnu.org Received: via spool by 19710-submit@debbugs.gnu.org id=B19710.1424274956682 (code B ref 19710); Wed, 18 Feb 2015 15:56:02 +0000 Received: (at 19710) by debbugs.gnu.org; 18 Feb 2015 15:55:56 +0000 Received: from localhost ([127.0.0.1]:47912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YO6yi-0000Av-27 for submit@debbugs.gnu.org; Wed, 18 Feb 2015 10:55:56 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:35596) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YO6yg-0000Af-0W for 19710@debbugs.gnu.org; Wed, 18 Feb 2015 10:55:54 -0500 Received: by wesp10 with SMTP id p10so2034033wes.2 for <19710@debbugs.gnu.org>; Wed, 18 Feb 2015 07:55:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=1RgO8QCVeQRPYV7Bllrlg9igUvAAzh/N9gMbrczAfkg=; b=CwsVLC4vnnbsan/cgeohfhBI+XfecIA70/RFYNpPpA5FNBeoFocMzcg9KVN2ffehpI ZC+gqcIaarh+a1LhKMUHo5vtjBh43q3odWtMVpI/ITMvwq1UnM72k1BF/UvHpNU7l5cD 4LV6LprsTDeFeBhEuN+v3yJoj2oujzdbCSAFAhLv41WDCUCMUlQkDFRrYdqLM5Wf4eX8 9QFBCeNDPrW9HEkbTMK9AMpZHoT3MQaxtzUZTKxLKm4RcIvd0V5sE3tqhgPSoKH3Yc3L V6e4AcUKR7ymUowpTKLz3AymoTVUMHJ4EBoOc7Fmma7rGgNARQm3ZJCs+k3L9cjsCOZs U2EA== X-Received: by 10.180.210.203 with SMTP id mw11mr6208082wic.53.1424274948356; Wed, 18 Feb 2015 07:55:48 -0800 (PST) Received: from localhost (host-static-86-106-238-197.moldtelecom.md. [86.106.238.197]) by mx.google.com with ESMTPSA id qb8sm27126362wjc.4.2015.02.18.07.55.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Feb 2015 07:55:47 -0800 (PST) From: Vitalie Spinu References: <87oapjmfth.fsf@gmail.com> <874mrawgcu.fsf@mail.linkov.net> <87oapi6m3v.fsf@gmail.com> <87vbjhdvas.fsf@mail.linkov.net> <877fvwvfnm.fsf@gmail.com> <87pp9ipplf.fsf@mail.linkov.net> Date: Wed, 18 Feb 2015 17:55:46 +0200 In-Reply-To: <87pp9ipplf.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 10 Feb 2015 02:39:08 +0200") Message-ID: <878ufvkyd9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Relatedly, comint-bol inside multiline output regions is broken. In shell buffer: $ locate pwd then go to a previous line and M-x comint-bol. It will jump all the way back to comint-prompt-regexp. Vitalie >>> Juri Linkov on Tue, 10 Feb 2015 02:39:08 +0200 wrote: >> Thanks. It works. > I noticed that it works differently when typing RET while point is > on the prompt, so I had to add support for this case for the users > who might want to do such a strange thing. From unknown Wed Aug 20 01:21:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19710: 24.4.51; Isearch is broken in comints which relly on regexp Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Feb 2015 17:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Vitalie Spinu Cc: 19710@debbugs.gnu.org Received: via spool by 19710-submit@debbugs.gnu.org id=B19710.142427914912503 (code B ref 19710); Wed, 18 Feb 2015 17:06:01 +0000 Received: (at 19710) by debbugs.gnu.org; 18 Feb 2015 17:05:49 +0000 Received: from localhost ([127.0.0.1]:47945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YO84L-0003Fb-9J for submit@debbugs.gnu.org; Wed, 18 Feb 2015 12:05:49 -0500 Received: from ps18281.dreamhost.com ([69.163.222.226]:58140 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YO84I-0003FS-UJ for 19710@debbugs.gnu.org; Wed, 18 Feb 2015 12:05:47 -0500 Received: from localhost.linkov.net (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 6D8E7302ADCDD6; Wed, 18 Feb 2015 09:05:45 -0800 (PST) From: Juri Linkov Organization: LINKOV.NET References: <87oapjmfth.fsf@gmail.com> <874mrawgcu.fsf@mail.linkov.net> <87oapi6m3v.fsf@gmail.com> <87vbjhdvas.fsf@mail.linkov.net> <877fvwvfnm.fsf@gmail.com> <87pp9ipplf.fsf@mail.linkov.net> <878ufvkyd9.fsf@gmail.com> Date: Wed, 18 Feb 2015 19:01:52 +0200 In-Reply-To: <878ufvkyd9.fsf@gmail.com> (Vitalie Spinu's message of "Wed, 18 Feb 2015 17:55:46 +0200") Message-ID: <874mqjfa3n.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Relatedly, comint-bol inside multiline output regions is broken. > > In shell buffer: > > $ locate pwd > > then go to a previous line and M-x comint-bol. It will jump all the way > back to comint-prompt-regexp. The following patch for the emacs-24 branch should fix this regression. It distinguishes two cases: when point is on the output or input depending on the field property, for the case of comint-use-prompt-regexp=nil. This means that we can't support multi-line commands for the case when comint-use-prompt-regexp=t because it doesn't use fields, thus there is no way to distinguish input from output. So for comint-use-prompt-regexp=t `M-x comint-bol' will work as in the previous release, but `M-x comint-bol' will be fixed for comint-use-prompt-regexp=nil: diff --git a/lisp/comint.el b/lisp/comint.el index c81551a..2532dd7 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -2267,8 +2267,6 @@ (defun comint-line-beginning-position () ;; Use comint-prompt-regexp (save-excursion (beginning-of-line) - (unless (looking-at comint-prompt-regexp) - (re-search-backward comint-prompt-regexp nil t)) (comint-skip-prompt) (point)) ;; Use input fields. Note that, unlike the behavior of @@ -2278,7 +2276,10 @@ (defun comint-line-beginning-position () ;; if there are two fields on a line, then the first one is the ;; prompt, and the second one is an input field, and is front-sticky ;; (as input fields should be). - (constrain-to-field (field-beginning) (line-end-position)))) + (constrain-to-field (if (eq (field-at-pos (point)) 'output) + (line-beginning-position) + (field-beginning)) + (line-end-position)))) (defun comint-bol (&optional arg) "Go to the beginning of line, then skip past the prompt, if any. From unknown Wed Aug 20 01:21:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19710: 24.4.51; Isearch is broken in comints which relly on regexp Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Feb 2015 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 19710@debbugs.gnu.org, spinuvit@gmail.com Reply-To: Eli Zaretskii Received: via spool by 19710-submit@debbugs.gnu.org id=B19710.142428160216173 (code B ref 19710); Wed, 18 Feb 2015 17:47:01 +0000 Received: (at 19710) by debbugs.gnu.org; 18 Feb 2015 17:46:42 +0000 Received: from localhost ([127.0.0.1]:47964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YO8ht-0004Cn-Lh for submit@debbugs.gnu.org; Wed, 18 Feb 2015 12:46:41 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:43265) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YO8hq-0004Cc-6A for 19710@debbugs.gnu.org; Wed, 18 Feb 2015 12:46:39 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NJZ00G00AE0D100@a-mtaout20.012.net.il> for 19710@debbugs.gnu.org; Wed, 18 Feb 2015 19:46:36 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJZ00GSTAPN0280@a-mtaout20.012.net.il>; Wed, 18 Feb 2015 19:46:36 +0200 (IST) Date: Wed, 18 Feb 2015 19:46:48 +0200 From: Eli Zaretskii In-reply-to: <874mqjfa3n.fsf@mail.linkov.net> X-012-Sender: halo1@inter.net.il Message-id: <831tln5czb.fsf@gnu.org> References: <87oapjmfth.fsf@gmail.com> <874mrawgcu.fsf@mail.linkov.net> <87oapi6m3v.fsf@gmail.com> <87vbjhdvas.fsf@mail.linkov.net> <877fvwvfnm.fsf@gmail.com> <87pp9ipplf.fsf@mail.linkov.net> <878ufvkyd9.fsf@gmail.com> <874mqjfa3n.fsf@mail.linkov.net> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Juri Linkov > Date: Wed, 18 Feb 2015 19:01:52 +0200 > Cc: 19710@debbugs.gnu.org > > > Relatedly, comint-bol inside multiline output regions is broken. > > > > In shell buffer: > > > > $ locate pwd > > > > then go to a previous line and M-x comint-bol. It will jump all the way > > back to comint-prompt-regexp. > > The following patch for the emacs-24 branch should fix this regression. If this a regression wrt 24.4? From unknown Wed Aug 20 01:21:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19710: 24.4.51; Isearch is broken in comints which relly on regexp Resent-From: Vitalie Spinu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Feb 2015 18:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 19710@debbugs.gnu.org Received: via spool by 19710-submit@debbugs.gnu.org id=B19710.142428351019091 (code B ref 19710); Wed, 18 Feb 2015 18:19:01 +0000 Received: (at 19710) by debbugs.gnu.org; 18 Feb 2015 18:18:30 +0000 Received: from localhost ([127.0.0.1]:47986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YO9Cg-0004xo-2G for submit@debbugs.gnu.org; Wed, 18 Feb 2015 13:18:30 -0500 Received: from mail-we0-f172.google.com ([74.125.82.172]:46202) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YO9Ce-0004xg-A5 for 19710@debbugs.gnu.org; Wed, 18 Feb 2015 13:18:28 -0500 Received: by wevm14 with SMTP id m14so2742142wev.13 for <19710@debbugs.gnu.org>; Wed, 18 Feb 2015 10:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=dClY6K9RmQmJ5PM6/Bp7zh7+j8OvnphMFF7NMgtVH44=; b=ToZRewUzzTC4rtzVBoBvL8vFUOKRDAe8yg/IIRnQLyCM9y+MKyA9BdTCD4Ts465L4N yroHBRLfL0W1Wa+b+SM2fRs6s6U+Y7z7i0pjp3fiq3R6v+WOyyiEYmCaMkUECrxgZNGL PuN2iURAdxw007kqu1gJrhrmHMQ4VdSETTTmC/mLmHdQrgjjoawq3jtebmYRQ+t83e6Y 9lTAM88V30ChNYeM2me4Q6u2cJ6dGeZTWGBKE2XYwuy4mkPHAsgicEGdEKkEnvD1Gqo5 pxfDaqpNW19W8l0UPLrJmfAHWLLH9BzRe+/pZKUbl9+Vo+p/Nus0wL4dGkxdQEUIopF3 +PRQ== X-Received: by 10.194.171.136 with SMTP id au8mr1386486wjc.6.1424283507693; Wed, 18 Feb 2015 10:18:27 -0800 (PST) Received: from localhost (host-static-86-106-238-197.moldtelecom.md. [86.106.238.197]) by mx.google.com with ESMTPSA id n1sm26554990wib.11.2015.02.18.10.18.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Feb 2015 10:18:26 -0800 (PST) From: Vitalie Spinu References: <87oapjmfth.fsf@gmail.com> <874mrawgcu.fsf@mail.linkov.net> <87oapi6m3v.fsf@gmail.com> <87vbjhdvas.fsf@mail.linkov.net> <877fvwvfnm.fsf@gmail.com> <87pp9ipplf.fsf@mail.linkov.net> <878ufvkyd9.fsf@gmail.com> <874mqjfa3n.fsf@mail.linkov.net> Date: Wed, 18 Feb 2015 20:18:25 +0200 In-Reply-To: <874mqjfa3n.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 18 Feb 2015 19:01:52 +0200") Message-ID: <87zj8bjd72.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Works. Thanks! >>> Juri Linkov on Wed, 18 Feb 2015 19:01:52 +0200 wrote: >> Relatedly, comint-bol inside multiline output regions is broken. >> >> In shell buffer: >> >> $ locate pwd >> >> then go to a previous line and M-x comint-bol. It will jump all the way >> back to comint-prompt-regexp. > The following patch for the emacs-24 branch should fix this regression. > It distinguishes two cases: when point is on the output or input > depending on the field property, for the case of comint-use-prompt-regexp=nil. > This means that we can't support multi-line commands for the case > when comint-use-prompt-regexp=t because it doesn't use fields, thus > there is no way to distinguish input from output. > So for comint-use-prompt-regexp=t `M-x comint-bol' will work > as in the previous release, but `M-x comint-bol' will be > fixed for comint-use-prompt-regexp=nil: > diff --git a/lisp/comint.el b/lisp/comint.el > index c81551a..2532dd7 100644 > --- a/lisp/comint.el > +++ b/lisp/comint.el > @@ -2267,8 +2267,6 @@ (defun comint-line-beginning-position () > ;; Use comint-prompt-regexp > (save-excursion > (beginning-of-line) > - (unless (looking-at comint-prompt-regexp) > - (re-search-backward comint-prompt-regexp nil t)) > (comint-skip-prompt) > (point)) > ;; Use input fields. Note that, unlike the behavior of > @@ -2278,7 +2276,10 @@ (defun comint-line-beginning-position () > ;; if there are two fields on a line, then the first one is the > ;; prompt, and the second one is an input field, and is front-sticky > ;; (as input fields should be). > - (constrain-to-field (field-beginning) (line-end-position)))) > + (constrain-to-field (if (eq (field-at-pos (point)) 'output) > + (line-beginning-position) > + (field-beginning)) > + (line-end-position)))) > (defun comint-bol (&optional arg) > "Go to the beginning of line, then skip past the prompt, if any. From unknown Wed Aug 20 01:21:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19710: 24.4.51; Isearch is broken in comints which relly on regexp Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Feb 2015 18:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 19710@debbugs.gnu.org, spinuvit@gmail.com Received: via spool by 19710-submit@debbugs.gnu.org id=B19710.142428390619703 (code B ref 19710); Wed, 18 Feb 2015 18:26:02 +0000 Received: (at 19710) by debbugs.gnu.org; 18 Feb 2015 18:25:06 +0000 Received: from localhost ([127.0.0.1]:47992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YO9J3-00057h-A1 for submit@debbugs.gnu.org; Wed, 18 Feb 2015 13:25:05 -0500 Received: from ps18281.dreamhost.com ([69.163.222.226]:35354 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YO9Iz-000577-SM for 19710@debbugs.gnu.org; Wed, 18 Feb 2015 13:25:02 -0500 Received: from localhost.linkov.net (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id D9B7A31D3DB885; Wed, 18 Feb 2015 10:24:59 -0800 (PST) From: Juri Linkov Organization: LINKOV.NET References: <87oapjmfth.fsf@gmail.com> <874mrawgcu.fsf@mail.linkov.net> <87oapi6m3v.fsf@gmail.com> <87vbjhdvas.fsf@mail.linkov.net> <877fvwvfnm.fsf@gmail.com> <87pp9ipplf.fsf@mail.linkov.net> <878ufvkyd9.fsf@gmail.com> <874mqjfa3n.fsf@mail.linkov.net> <831tln5czb.fsf@gnu.org> Date: Wed, 18 Feb 2015 20:20:58 +0200 In-Reply-To: <831tln5czb.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 18 Feb 2015 19:46:48 +0200") Message-ID: <873863cc6x.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> > Relatedly, comint-bol inside multiline output regions is broken. >> > >> > In shell buffer: >> > >> > $ locate pwd >> > >> > then go to a previous line and M-x comint-bol. It will jump all the way >> > back to comint-prompt-regexp. >> >> The following patch for the emacs-24 branch should fix this regression. > > If this a regression wrt 24.4? Yes, it's a regression wrt 24.4 introduced a month ago.