GNU bug report logs - #19709
Problem with indentation for the closing parenthesis in cperl-mode version 6.1

Previous Next

Package: emacs;

Reported by: Håkon Hægland <hakon.hagland <at> gmail.com>

Date: Wed, 28 Jan 2015 07:31:02 UTC

Severity: minor

Tags: confirmed, fixed

Found in version 26.2

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #15 received at 19709 <at> debbugs.gnu.org (full text, mbox):

From: haj <at> posteo.de (Harald Jörg)
To: 19709 <at> debbugs.gnu.org
Subject: [PATCH] Verify that indentation works with current cperl-mode
Date: Wed, 04 Nov 2020 21:01:33 +0100

[Message part 1 (text/plain, inline)]
This bug apparently can no longer be reproduced.

Using quick'n'dirty bisection (avoiding recompilations of the whole
source tree) I could track the fix back to commit 1bcbcb7e,
"lisp/progmodes/cperl-mode.el: Merge from Jonathan Rockway's version" by
Stefan Monnier, 21st Dec 2017.  This makes sense since this commit
introduced a new function 'cperl-calculate-indent' to cperl-mode.el.

The patch adds a test to verify correct behavior, and also adds the
relevant variable cperl-close-paren-offset (which is explicitly set in
the bug report) to the scope of the cperl-set-style setting "PBP".  This
variable is documented in the book, but wasn't included yet.
--
Cheers,
haj


[0001-cperl-mode-Indentation-of-follows-customisation.patch (text/x-diff, attachment)]
This bug report was last modified 4 years and 254 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.