From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 27 10:22:56 2015 Received: (at submit) by debbugs.gnu.org; 27 Jan 2015 15:22:56 +0000 Received: from localhost ([127.0.0.1]:58092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YG7yh-0001rR-Ur for submit@debbugs.gnu.org; Tue, 27 Jan 2015 10:22:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50322) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YG7yf-0001rC-K7 for submit@debbugs.gnu.org; Tue, 27 Jan 2015 10:22:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YG7yZ-0005F5-8L for submit@debbugs.gnu.org; Tue, 27 Jan 2015 10:22:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG7yZ-0005F1-6B for submit@debbugs.gnu.org; Tue, 27 Jan 2015 10:22:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG7yY-0002WB-5i for bug-gnu-emacs@gnu.org; Tue, 27 Jan 2015 10:22:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YG7yT-00059V-UW for bug-gnu-emacs@gnu.org; Tue, 27 Jan 2015 10:22:46 -0500 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:37860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG7yT-00058M-Oq for bug-gnu-emacs@gnu.org; Tue, 27 Jan 2015 10:22:41 -0500 Received: by mail-wi0-f174.google.com with SMTP id n3so5583880wiv.1 for ; Tue, 27 Jan 2015 07:22:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=lj/m4slL3a4qr2pWElEpUt1leI46VQ+2fWYOM3SGPUU=; b=YQo653vEiIvKi22GPiKDh0lEDA5uiXjFS8NNnmzLokkt3dejSMaka2aYjSR0plWnTM a1r+VzwT19DrNcsMK++jkr168ZoExtTv9hGhLUNn2A14eAEEnVhbgpMq5yqjPiPzc4mO hWfZKAHt0cJYUNBtkvbjPBxP1NfjhEFYG1wrjIbteOY94QEpUSQl5WiQq0IaByuDsdYR P4M13PHzrPDW82s1XCsEsXWAZakiGkqJ9IBX/woPKa5f+IlLJSz1YeDFDFsQiCG4TBDW yJmYtYUZNQl1Eo9qdZTA+/OGRjSD0R92XRo6Rqa/ectfykAG6lMGwdr5c+4Z+guS8Nd3 V5wg== X-Received: by 10.180.208.79 with SMTP id mc15mr34201141wic.23.1422372161210; Tue, 27 Jan 2015 07:22:41 -0800 (PST) Received: from axl ([82.102.93.54]) by mx.google.com with ESMTPSA id p6sm2576956wia.14.2015.01.27.07.22.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2015 07:22:39 -0800 (PST) From: Dmitry Gutov To: bug-gnu-emacs@gnu.org Subject: 25.0.50; funcall with hard-quote inside cl-labels uses the local function binding Date: Tue, 27 Jan 2015 17:22:36 +0200 Message-ID: <86twzc8czn.fsf@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) In emacs-24 the below snippet returns (:global :local), whereas in master now, (:local :local). (defun foo () :global) (cl-labels ((foo () :local)) (list (funcall 'foo) (funcall #'foo))) It's a bug, according to http://lists.gnu.org/archive/html/emacs-devel/2015-01/msg00895.html. In GNU Emacs 25.0.50.7 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2) of 2015-01-27 on axl Repository revision: 11527553647f61798562f04c50b789edb8c15ac3 Windowing system distributor `The X.Org Foundation', version 11.0.11601901 System Description: Ubuntu 14.10 From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 09 22:37:46 2016 Received: (at 19704) by debbugs.gnu.org; 10 Jun 2016 02:37:46 +0000 Received: from localhost ([127.0.0.1]:35035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBCKP-0001h3-UE for submit@debbugs.gnu.org; Thu, 09 Jun 2016 22:37:46 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:32923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBCKN-0001gk-QB for 19704@debbugs.gnu.org; Thu, 09 Jun 2016 22:37:44 -0400 Received: by mail-oi0-f66.google.com with SMTP id e205so5513406oig.0 for <19704@debbugs.gnu.org>; Thu, 09 Jun 2016 19:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:cc; bh=qdJh6vE5UXs5vjxITHAe9x4QJrrjaSxa0pn19PAJCGs=; b=U00f7LpwNKusaL8CnNixqI3s1RSc7Aep2O/NS5llo/Za2s7iWnwVne4npaBZwWeoKm oduqLTlxJjoVmLhRVBInHqqqNUMrbHyw07xuhpjwvy273wHadhMHwzNngjHjCO1XQTSr jlw+Xdt8BV4XU7uiT2P0XjwKtHP/QmJanMMus/mz/C4RsQbGmXm9b/woTEbuTfMkUEkt Z7Qie9ELzZL/X2i5u7B8TaqSgY6Cj5S+r0DWKUKjxeAzL/8i8b0EDu0vvAaTfB2Ubryv w4FqYh75+7EfLjZzF1nWncezEv3rUSqrI42um8+yEXmqff1AB0bp3bdI6mOJ98sa5fVl hMSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to:cc; bh=qdJh6vE5UXs5vjxITHAe9x4QJrrjaSxa0pn19PAJCGs=; b=fongb6CN/HdHJksV+ewcKTzge8B4lKe56yFFZY2OVmoQG86seQivChwpASUgPFBgPn dUhXNjfLNS/Dtfc6fWAoKKkCoO2u72pR23gBITyxj0kbn4k/RTWHIuPRwNMhSfdDitGu V6E7InTh7Z0S9exXm4hg5b/RFntlgLDnqpCS7dLBHw9QigvG3308+RtlXgIUAovPlhuM vLjMwjWQP/oMqO/mlG27buQyoIlyLElUfb+S5pXzpCCxFUu58/idWc/0rxVQ4flFUkB+ KZmg0E+5hGoPj5nPVLjPchEB6qtEhd/WGwzU7znR1M/HR+XVurs4KpVz5pmtbNNs/8y1 CQrw== X-Gm-Message-State: ALyK8tJfYfaq/2ako99UuP8ZHR4YRpzonDKBorq3cQZlnoG7yRXMw8U/xTpZFvDFvLhTQwRDDO++/fMeMk8sUg== X-Received: by 10.202.245.196 with SMTP id t187mr6505731oih.178.1465526258320; Thu, 09 Jun 2016 19:37:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.168 with HTTP; Thu, 9 Jun 2016 19:37:37 -0700 (PDT) From: Noam Postavsky Date: Thu, 9 Jun 2016 22:37:37 -0400 X-Google-Sender-Auth: FQBlrjYBjGTRCXYYoMmTMlB2Njs Message-ID: Subject: 25.0.50; funcall with hard-quote inside cl-labels uses the local function binding To: 19704@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 19704 Cc: Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tag 19704 + patch found 19704 25.0.94 quit Seems that macroexp--expand-all got too aggressive, patch below teaches it to back off in case of locally defined functions: diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el index ed4d6e4..ce5d5dc 100644 --- a/lisp/emacs-lisp/macroexp.el +++ b/lisp/emacs-lisp/macroexp.el @@ -261,9 +261,14 @@ macroexp--expand-all (format "%s quoted with ' rather than with #'" (list 'lambda (nth 1 f) '...)) (macroexp--expand-all `(,fun ,arg1 ,f . ,args)))) - (`(funcall (,(or 'quote 'function) ,(and f (pred symbolp)) . ,_) . ,args) - ;; Rewrite (funcall #'foo bar) to (foo bar), in case `foo' - ;; has a compiler-macro. + ;; Rewrite (funcall #'foo bar) to (foo bar), in case `foo' + ;; has a compiler-macro. + (`(funcall (,(or 'quote 'function) + ,(and f (pred symbolp) + ;; Unless `foo' is a locally bound macro. + (guard (not (assq f macroexpand-all-environment)))) + . ,_) + . ,args) (macroexp--expand-all `(,f . ,args))) (`(,func . ,_) ;; Macro expand compiler macros. This cannot be delayed to From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 18:07:07 2016 Received: (at 19704) by debbugs.gnu.org; 10 Jun 2016 22:07:07 +0000 Received: from localhost ([127.0.0.1]:36301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBUa3-0002i6-8H for submit@debbugs.gnu.org; Fri, 10 Jun 2016 18:07:07 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:35650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBUa0-0002h4-9h for 19704@debbugs.gnu.org; Fri, 10 Jun 2016 18:07:04 -0400 Received: by mail-wm0-f41.google.com with SMTP id v199so8573524wmv.0 for <19704@debbugs.gnu.org>; Fri, 10 Jun 2016 15:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=x0/XCBIoltAoPdC4427b0MN9X2ukp+zUXrSZi18U+6Q=; b=mQhfRins4N8hg66z1IfhFfPpKIs/dqojxfjIJysNArPuQyyEt257WTQmesCGVWWNyM 0PEd5jT4yN54UmcvBVBPM4vRdp1gklpToKAehi/CfH1xaFcwnbRJPkRZxB5Z6XAtKlpT V/+uvtuJAPcpLb/YM08KOgvzgde9eMzhj4M3c30xXMxkBH32yb1wLVy1ZSuRAJnfX5EC zrO6DmCY395QIH0DFPOpOX25n4w3qBNPcou6b07GIAsTGni/0rM0THXr+h6Ajsc9mr7F DNsnjo5kCcosAS1xhUy9DyRRfAv4NtKHUU588RfeEfuB7I2h4LLoPvVFJ8Uc8Jqj+YKd wC1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=x0/XCBIoltAoPdC4427b0MN9X2ukp+zUXrSZi18U+6Q=; b=WVa63MbpccV0UL/R4wZ95rBxwOVXPZ3YBsIODMbcmSvmp+uSSjH7NHZ1/qi+iTg+tS WgJC/CYxk55z9uMT5FQeyvvJdeZ/dTKjnzTibFVZ/S+fx+GGuAWB+EiZ0g07bTnStSI2 C7k3PLKlPc0W5Z6b/yJi93hK6YdePA51hDXsVPh3YMuLH0/EDRadFarofn9J8y81BzsU 6uLlgcslmbpZ1/0CkTBvfkgMi2WOKe8twvIX/n4//MmgJ28xhOEnMlzQcntFJv5eh9sf 6OSHFvziJ06uckSHCYtQUfqCr2gMSd8l8PJ3QLWNmIpwmvdwgVZ32lFqGvvp3IICCaKs 68Dw== X-Gm-Message-State: ALyK8tKf+DCvm4KKJRvoDvo5iTSv1tvfo5Tjj8G2MuM2VaLdpAqneNQ5RKv92YG58T6yPg== X-Received: by 10.194.234.71 with SMTP id uc7mr4499588wjc.80.1465596418579; Fri, 10 Jun 2016 15:06:58 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id x124sm1063800wmg.24.2016.06.10.15.06.56 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 10 Jun 2016 15:06:57 -0700 (PDT) Subject: Re: bug#19704: 25.0.50; funcall with hard-quote inside cl-labels uses the local function binding To: Noam Postavsky , 19704@debbugs.gnu.org References: <86twzc8czn.fsf@yandex.ru> From: Dmitry Gutov Message-ID: Date: Sat, 11 Jun 2016 01:06:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 19704 Cc: Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/10/2016 05:37 AM, Noam Postavsky wrote: > Seems that macroexp--expand-all got too aggressive, patch below > teaches it to back off in case of locally defined functions: Thanks, Noam. Seems to work fine here. Stefan, how does it look to you? Eli, can we have it in emacs-25 (it's a regression)? > diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el > index ed4d6e4..ce5d5dc 100644 > --- a/lisp/emacs-lisp/macroexp.el > +++ b/lisp/emacs-lisp/macroexp.el > @@ -261,9 +261,14 @@ macroexp--expand-all > (format "%s quoted with ' rather than with #'" > (list 'lambda (nth 1 f) '...)) > (macroexp--expand-all `(,fun ,arg1 ,f . ,args)))) > - (`(funcall (,(or 'quote 'function) ,(and f (pred symbolp)) . ,_) . ,args) > - ;; Rewrite (funcall #'foo bar) to (foo bar), in case `foo' > - ;; has a compiler-macro. > + ;; Rewrite (funcall #'foo bar) to (foo bar), in case `foo' > + ;; has a compiler-macro. > + (`(funcall (,(or 'quote 'function) > + ,(and f (pred symbolp) > + ;; Unless `foo' is a locally bound macro. > + (guard (not (assq f macroexpand-all-environment)))) > + . ,_) > + . ,args) > (macroexp--expand-all `(,f . ,args))) > (`(,func . ,_) > ;; Macro expand compiler macros. This cannot be delayed to > From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 22:42:16 2016 Received: (at 19704) by debbugs.gnu.org; 11 Jun 2016 02:42:16 +0000 Received: from localhost ([127.0.0.1]:36361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBYsJ-0002aU-SU for submit@debbugs.gnu.org; Fri, 10 Jun 2016 22:42:16 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:34876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBYsH-0002aK-QW for 19704@debbugs.gnu.org; Fri, 10 Jun 2016 22:42:14 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u5B2gBPV014443; Fri, 10 Jun 2016 22:42:11 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 74A0EAE600; Fri, 10 Jun 2016 22:42:11 -0400 (EDT) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#19704: 25.0.50; funcall with hard-quote inside cl-labels uses the local function binding Message-ID: References: <86twzc8czn.fsf@yandex.ru> Date: Fri, 10 Jun 2016 22:42:11 -0400 In-Reply-To: (Dmitry Gutov's message of "Sat, 11 Jun 2016 01:06:55 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5702=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5702> : inlines <4920> : streams <1649995> : uri <2228252> X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 19704 Cc: 19704@debbugs.gnu.org, Eli Zaretskii , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) >> Seems that macroexp--expand-all got too aggressive, patch below >> teaches it to back off in case of locally defined functions: > Thanks, Noam. Seems to work fine here. > Stefan, how does it look to you? Looks OK, tho a bit on the hackish side. Maybe a simpler solution is to replace (or 'quote 'function) with 'function (i.e. only apply the optimization to (funcall #'foo ...) and not to (funcall 'foo ...)). Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 22:56:15 2016 Received: (at 19704) by debbugs.gnu.org; 11 Jun 2016 02:56:15 +0000 Received: from localhost ([127.0.0.1]:36365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBZ5r-0004bA-7n for submit@debbugs.gnu.org; Fri, 10 Jun 2016 22:56:15 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:33692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBZ5n-0004ap-4L for 19704@debbugs.gnu.org; Fri, 10 Jun 2016 22:56:13 -0400 Received: by mail-oi0-f48.google.com with SMTP id u201so11864652oie.0 for <19704@debbugs.gnu.org>; Fri, 10 Jun 2016 19:56:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=24SXPNYJha7HXnTFpBmM3AgKTxU7tyAkiV/T6Q5LwJo=; b=eWgF5Ay31QfAc60AyFYte0h6TYpEzQeM/z4n2X5YqH0EC5ixUt7FgFcyyNJGGSLsTI 9IttVHG3YlJid6QrV5q7n6q7b2YcVNgm4z0a0tda6KxU4BGGQhUxGGEbpIpTkMuNeij0 wjMtI9fWnGJzoqjz2FmVrw8q9GkqVUOJQktt6rKBMAK6x8fssEGPlVqYG0QsvgBILYtz Nj3SVjOUW2KNlXUv/5KrGYZwZEJp4gfR8hi5Jw/JQ6SUPAmOqJDsK31C1tgDJHAZMuxo iy2ZC5FjZd1pucOrUtIQKjNd5EJ0T09IoK9vfzfjPfkXXpIQ05109KqjGzPYImE/FANa hJ/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=24SXPNYJha7HXnTFpBmM3AgKTxU7tyAkiV/T6Q5LwJo=; b=EO3dPcTNXW2qfvO9klIosNb0DPCiqGoVwGF0aPTetesLY9hyNBx+eXzZoYNfIVg8W+ bYDZEtSaFlyhcy8VZhIT7IZNNk9iwZ3ZpbyfZB1cmpIDepkY1C8Z6SlrunjFcteASqll RJDwIVJwhCBfrNBaUtaqft8OmaiSGVWEr7UaJLyA5BJ8PzL4yrrs9+quiuycST5+/ewc FMK+bAzR2L4fRIGV4Rn/KUS0H95S8SBN55empjmeTdXBfGF/HRZiTIeXFqsR3eVwcv8o A2fQCGQSCgiVfKiiLjso77ojeCiI+Vy6gezRF1XyNespU6T76nU8AfCN7/3ICN1gomcB Q0mg== X-Gm-Message-State: ALyK8tJN5KMHBjzJCqqvBvArwxpcQ15tRxi3UiGQoZYNHZXfkenqz91DtNn066VNp6UR9ubHhA208PWUTTdkLQ== X-Received: by 10.202.197.137 with SMTP id v131mr2385843oif.178.1465613765566; Fri, 10 Jun 2016 19:56:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.168 with HTTP; Fri, 10 Jun 2016 19:56:05 -0700 (PDT) In-Reply-To: References: <86twzc8czn.fsf@yandex.ru> From: Noam Postavsky Date: Fri, 10 Jun 2016 22:56:05 -0400 X-Google-Sender-Auth: f5pV97DB4IhdbptJIuR7cRsii14 Message-ID: Subject: Re: bug#19704: 25.0.50; funcall with hard-quote inside cl-labels uses the local function binding To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 19704 Cc: 19704@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Fri, Jun 10, 2016 at 10:42 PM, Stefan Monnier wrote: > Looks OK, tho a bit on the hackish side. Maybe a simpler solution is to > replace (or 'quote 'function) with 'function (i.e. only apply the > optimization to (funcall #'foo ...) and not to (funcall 'foo ...)). This works, and it matches the existing comment better too. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 11 17:38:39 2016 Received: (at 19704-done) by debbugs.gnu.org; 11 Jun 2016 21:38:39 +0000 Received: from localhost ([127.0.0.1]:37481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBqc3-0001Lq-99 for submit@debbugs.gnu.org; Sat, 11 Jun 2016 17:38:39 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:38026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBqc1-0001Lg-4n for 19704-done@debbugs.gnu.org; Sat, 11 Jun 2016 17:38:37 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u5BLcZfp016712; Sat, 11 Jun 2016 17:38:36 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id D5D5FAE582; Sat, 11 Jun 2016 17:38:34 -0400 (EDT) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#19704: 25.0.50; funcall with hard-quote inside cl-labels uses the local function binding Message-ID: References: <86twzc8czn.fsf@yandex.ru> Date: Sat, 11 Jun 2016 17:38:34 -0400 In-Reply-To: (Noam Postavsky's message of "Fri, 10 Jun 2016 22:56:05 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5703=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5703> : inlines <4921> : streams <1650416> : uri <2228831> X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 19704-done Cc: 19704-done@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) >> Looks OK, tho a bit on the hackish side. Maybe a simpler solution is to >> replace (or 'quote 'function) with 'function (i.e. only apply the >> optimization to (funcall #'foo ...) and not to (funcall 'foo ...)). > This works, and it matches the existing comment better too. Thanks, installed, Stefan From unknown Fri Aug 15 14:48:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 10 Jul 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator