GNU bug report logs - #19681
[PATCH] sync: use syncfs(2) if any argument is specified

Previous Next

Full log

View this message in rfc822 format

From: Pádraig Brady <P <at> draigBrady.com>
To: Giuseppe Scrivano <gscrivan <at> redhat.com>
Cc: 19681 <at> debbugs.gnu.org
Subject: bug#19681: [PATCH] sync: use syncfs(2) if any argument is specified
Date: Tue, 27 Jan 2015 14:58:44 +0000

[Message part 1 (text/plain, inline)]

On 27/01/15 10:48, Giuseppe Scrivano wrote:
> Pádraig Brady <P <at> draigbrady.com> writes:
> 
>> thanks!
>> Pádraig.
> 
> Thanks for the review, I've amended the changes you suggested:

There were a few problems:

 - Compile failure without HAVE_SYNCFS (defined)
 - Various errors() used errno where undefined
 - A file that failed to sync was not identified
 - File descriptors were leaked on failure to sync
 - The command would block if presented with a fifo
 - Write only files ere not supported
 - Various references to "paths" rather than "files"
 - The info docs for --file-system were a bit terse
 - No tests

I've fixed up those issues in the attached,
which I'll push soon.

thanks,
Pádraig.

[sync-args.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.