GNU bug report logs - #19658
unportable test(1) comparison operator

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#19658: closed (unportable test(1) comparison operator)
Date: Sun, 25 Jan 2015 03:04:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 24 Jan 2015 19:03:47 -0800
with message-id <54C45D13.308 <at> cs.ucla.edu>
and subject line Re: unportable test(1) comparison operator
has caused the debbugs.gnu.org bug report #19658,
regarding unportable test(1) comparison operator
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
19658: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19658
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Thomas Klausner <tk <at> giga.or.at>
To: bug-gnu-emacs <at> gnu.org
Subject: unportable test(1) comparison operator
Date: Fri, 23 Jan 2015 00:10:07 +0100

[Message part 3 (text/plain, inline)]

Hi!

In emacs git as of yesterday, test/indent/shell.sh contains the
unportable '==' comparison operator for test(1) -- only bash supports
that, not even GNU coreutils' test(1).

Please use '=' instead; see attached patch.

Thanks,
 Thomas

P.S.: I know it's not intended to be executed, but I'd like to avoid
having bad examples around :)

[patch-af (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 19658-done <at> debbugs.gnu.org
Subject: Re: unportable test(1) comparison operator
Date: Sat, 24 Jan 2015 19:03:47 -0800

Thanks I changed it to '[ $# -eq 0 ]', which is more portable yet, as it works 
even if a purposely-pedantic shell sets $# to '00'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.