From unknown Sun Jun 22 07:51:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19658: unportable test(1) comparison operator Resent-From: Thomas Klausner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Jan 2015 23:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19658 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 19658@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.142196822323803 (code B ref -1); Thu, 22 Jan 2015 23:11:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jan 2015 23:10:23 +0000 Received: from localhost ([127.0.0.1]:53307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEQtK-0006Br-JM for submit@debbugs.gnu.org; Thu, 22 Jan 2015 18:10:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54421) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEQtI-0006Bd-6E for submit@debbugs.gnu.org; Thu, 22 Jan 2015 18:10:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEQtB-0005DS-TQ for submit@debbugs.gnu.org; Thu, 22 Jan 2015 18:10:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEQtB-0005DO-RX for submit@debbugs.gnu.org; Thu, 22 Jan 2015 18:10:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEQtA-0000qm-O9 for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:10:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEQt7-0005Cs-J4 for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:10:12 -0500 Received: from danbala.ifoer.tuwien.ac.at ([128.130.168.64]:50096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEQt7-0005Ak-Cp for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:10:09 -0500 Received: by danbala.ifoer.tuwien.ac.at (Postfix, from userid 116) id B8479A5AA; Fri, 23 Jan 2015 00:10:07 +0100 (CET) Date: Fri, 23 Jan 2015 00:10:07 +0100 From: Thomas Klausner Message-ID: <20150122231007.GA24371@danbala.tuwien.ac.at> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="PNTmBPCT7hxwcZjr" Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi! In emacs git as of yesterday, test/indent/shell.sh contains the unportable '==' comparison operator for test(1) -- only bash supports that, not even GNU coreutils' test(1). Please use '=' instead; see attached patch. Thanks, Thomas P.S.: I know it's not intended to be executed, but I'd like to avoid having bad examples around :) --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=patch-af --- test/indent/shell.sh.orig 2011-02-16 02:00:00.000000000 +0000 +++ test/indent/shell.sh @@ -70,7 +70,7 @@ help2 EOF2 } bar () { - if [ $# == 0 ]; then + if [ $# = 0 ]; then while f # KNOWN INDENT BUG do --PNTmBPCT7hxwcZjr-- From unknown Sun Jun 22 07:51:25 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Thomas Klausner Subject: bug#19658: closed (Re: unportable test(1) comparison operator) Message-ID: References: <54C45D13.308@cs.ucla.edu> <20150122231007.GA24371@danbala.tuwien.ac.at> X-Gnu-PR-Message: they-closed 19658 X-Gnu-PR-Package: emacs Reply-To: 19658@debbugs.gnu.org Date: Sun, 25 Jan 2015 03:04:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1422155043-11061-1" This is a multi-part message in MIME format... ------------=_1422155043-11061-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #19658: unportable test(1) comparison operator which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19658@debbugs.gnu.org. --=20 19658: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19658 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1422155043-11061-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 19658-done) by debbugs.gnu.org; 25 Jan 2015 03:03:56 +0000 Received: from localhost ([127.0.0.1]:55520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFDUR-0002s5-Lo for submit@debbugs.gnu.org; Sat, 24 Jan 2015 22:03:55 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:34565) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFDUP-0002rs-W2 for 19658-done@debbugs.gnu.org; Sat, 24 Jan 2015 22:03:54 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 25719A6002E for <19658-done@debbugs.gnu.org>; Sat, 24 Jan 2015 19:03:48 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KK4QfbSjynMk for <19658-done@debbugs.gnu.org>; Sat, 24 Jan 2015 19:03:48 -0800 (PST) Received: from [192.168.1.9] (pool-173-55-11-52.lsanca.fios.verizon.net [173.55.11.52]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id DC6D6A60023 for <19658-done@debbugs.gnu.org>; Sat, 24 Jan 2015 19:03:47 -0800 (PST) Message-ID: <54C45D13.308@cs.ucla.edu> Date: Sat, 24 Jan 2015 19:03:47 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: 19658-done@debbugs.gnu.org Subject: Re: unportable test(1) comparison operator Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19658-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Thanks I changed it to '[ $# -eq 0 ]', which is more portable yet, as it works even if a purposely-pedantic shell sets $# to '00'. ------------=_1422155043-11061-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Jan 2015 23:10:23 +0000 Received: from localhost ([127.0.0.1]:53307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEQtK-0006Br-JM for submit@debbugs.gnu.org; Thu, 22 Jan 2015 18:10:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54421) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEQtI-0006Bd-6E for submit@debbugs.gnu.org; Thu, 22 Jan 2015 18:10:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEQtB-0005DS-TQ for submit@debbugs.gnu.org; Thu, 22 Jan 2015 18:10:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEQtB-0005DO-RX for submit@debbugs.gnu.org; Thu, 22 Jan 2015 18:10:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEQtA-0000qm-O9 for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:10:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEQt7-0005Cs-J4 for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:10:12 -0500 Received: from danbala.ifoer.tuwien.ac.at ([128.130.168.64]:50096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEQt7-0005Ak-Cp for bug-gnu-emacs@gnu.org; Thu, 22 Jan 2015 18:10:09 -0500 Received: by danbala.ifoer.tuwien.ac.at (Postfix, from userid 116) id B8479A5AA; Fri, 23 Jan 2015 00:10:07 +0100 (CET) Date: Fri, 23 Jan 2015 00:10:07 +0100 From: Thomas Klausner To: bug-gnu-emacs@gnu.org Subject: unportable test(1) comparison operator Message-ID: <20150122231007.GA24371@danbala.tuwien.ac.at> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="PNTmBPCT7hxwcZjr" Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi! In emacs git as of yesterday, test/indent/shell.sh contains the unportable '==' comparison operator for test(1) -- only bash supports that, not even GNU coreutils' test(1). Please use '=' instead; see attached patch. Thanks, Thomas P.S.: I know it's not intended to be executed, but I'd like to avoid having bad examples around :) --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=patch-af --- test/indent/shell.sh.orig 2011-02-16 02:00:00.000000000 +0000 +++ test/indent/shell.sh @@ -70,7 +70,7 @@ help2 EOF2 } bar () { - if [ $# == 0 ]; then + if [ $# = 0 ]; then while f # KNOWN INDENT BUG do --PNTmBPCT7hxwcZjr-- ------------=_1422155043-11061-1--