GNU bug report logs - #19634
counting MANY function args more reliably

Previous Next

Package: emacs;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Tue, 20 Jan 2015 09:28:01 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 19634 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: bug#19634: counting MANY function args more reliably
Date: Thu, 22 Jan 2015 20:16:05 +0200
> Date: Thu, 22 Jan 2015 09:42:10 -0800
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> CC: 19634 <at> debbugs.gnu.org
> 
> On 01/22/2015 08:31 AM, Eli Zaretskii wrote:
> > Do we want to use this for every call to a function that accepts MANY
> > args, or just those where the argument is an array?
> 
> We should use it for calls where counting the number of arguments is 
> likely to be error-prone.
> 
> > I'm asking because the proposed patch left out this part of w32fns.c:
> >
> >    static Lisp_Object
> >    x_create_tip_frame (struct w32_display_info *dpyinfo,
> > 		      Lisp_Object parms, Lisp_Object text)
> >    {
> >      [...]
> >      Ferase_buffer ();
> >      Finsert (1, &text);  <<<<<<<<<<<<<<<<<<<<<<
> 
> The patch does not affect calls like that, as they're unlikely to give 
> rise to the sort of typographical error that motivated the patch.

OK, thanks.




This bug report was last modified 10 years and 121 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.