GNU bug report logs - #19634
counting MANY function args more reliably

Previous Next

Package: emacs;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Tue, 20 Jan 2015 09:28:01 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

Message #13 received at 19634 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 19634 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
Subject: Re: bug#19634: counting MANY function args more reliably
Date: Thu, 22 Jan 2015 18:31:21 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Date: Tue, 20 Jan 2015 11:37:39 -0500
> Cc: 19634 <at> debbugs.gnu.org
> 
> > #define CALLN(f, ...) CALLMANY (f, ((Lisp_Object []) {__VA_ARGS__}))
> 
> I like that,

Do we want to use this for every call to a function that accepts MANY
args, or just those where the argument is an array?

I'm asking because the proposed patch left out this part of w32fns.c:

  static Lisp_Object
  x_create_tip_frame (struct w32_display_info *dpyinfo,
		      Lisp_Object parms, Lisp_Object text)
  {
    [...]
    Ferase_buffer ();
    Finsert (1, &text);  <<<<<<<<<<<<<<<<<<<<<<

and I'm not sure whether this was just an omission or this kind of
calls doesn't need to use CALLN.
This bug report was last modified 10 years and 121 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.