From unknown Thu Sep 11 11:56:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19628 <19628@debbugs.gnu.org> To: bug#19628 <19628@debbugs.gnu.org> Subject: Status: 25.0.50; doc of button functions Reply-To: bug#19628 <19628@debbugs.gnu.org> Date: Thu, 11 Sep 2025 18:56:29 +0000 retitle 19628 25.0.50; doc of button functions reassign 19628 emacs submitter 19628 Drew Adams severity 19628 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 19 11:21:15 2015 Received: (at submit) by debbugs.gnu.org; 19 Jan 2015 16:21:15 +0000 Received: from localhost ([127.0.0.1]:33365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDF4l-0002h1-7s for submit@debbugs.gnu.org; Mon, 19 Jan 2015 11:21:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35814) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDF4i-0002gl-Pe for submit@debbugs.gnu.org; Mon, 19 Jan 2015 11:21:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDF4c-0004c6-J4 for submit@debbugs.gnu.org; Mon, 19 Jan 2015 11:21:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDF4c-0004c2-FM for submit@debbugs.gnu.org; Mon, 19 Jan 2015 11:21:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDF4b-0007Ub-Cs for bug-gnu-emacs@gnu.org; Mon, 19 Jan 2015 11:21:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDF4V-0004aq-PS for bug-gnu-emacs@gnu.org; Mon, 19 Jan 2015 11:21:05 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:40024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDF4V-0004aZ-Is for bug-gnu-emacs@gnu.org; Mon, 19 Jan 2015 11:20:59 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t0JGKwtd021393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 19 Jan 2015 16:20:58 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id t0JGKvbE025978 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Mon, 19 Jan 2015 16:20:57 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t0JGKvtc001991 for ; Mon, 19 Jan 2015 16:20:57 GMT MIME-Version: 1.0 Message-ID: Date: Mon, 19 Jan 2015 08:20:52 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.0.50; doc of button functions X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The doc of `make-button', `insert-button', and `insert-text-button' just mentions "a sequence of PROPERTY VALUE pairs, specifying properties to add to the button", without saying anything about the text properties that are special for these functions. This is true for both the doc strings and the Elisp manual (node `Making Buttons'). Some text properties, such as `face' and `follow-link' are common, used generally, and are explained elsewhere. But others, such as `action', seem to be special to the button code and these functions. So they should be mentioned in this doc. Property `action' is mentioned for function `button-activate' (e.g. nodes `Button Properties', `Manipulating Buttons', and `Button Buffer Commands'). But it and any other properties specific to the button functions should be called out where we speak of such properties. Or else such doc should refer to some location where we do specify such properties. What's more, the doc strings of `push-button' and `button-activate' need to mention property `action', just as the Elisp doc for them does. It is not sufficient for the doc strings to simply refer to the "normal action" of the button, without saying what that means. In GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2014-10-20 on LEG570 Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking=3Dyes,glyphs CPPFLAGS=3D-DGLYPH_DEBUG=3D1' From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 20 13:17:21 2015 Received: (at 19628) by debbugs.gnu.org; 20 Jan 2015 18:17:21 +0000 Received: from localhost ([127.0.0.1]:51001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDdMe-0001nU-PN for submit@debbugs.gnu.org; Tue, 20 Jan 2015 13:17:21 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:65228) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDdMb-0001nD-Od for 19628@debbugs.gnu.org; Tue, 20 Jan 2015 13:17:19 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NIH00B00MQ6X800@a-mtaout20.012.net.il> for 19628@debbugs.gnu.org; Tue, 20 Jan 2015 20:17:10 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NIH00BI8MSMWO10@a-mtaout20.012.net.il>; Tue, 20 Jan 2015 20:17:10 +0200 (IST) Date: Tue, 20 Jan 2015 20:17:04 +0200 From: Eli Zaretskii Subject: Re: bug#19628: 25.0.50; doc of button functions In-reply-to: X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83r3upwc4f.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19628 Cc: 19628@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 19 Jan 2015 08:20:52 -0800 (PST) > From: Drew Adams > > The doc of `make-button', `insert-button', and `insert-text-button' just > mentions "a sequence of PROPERTY VALUE pairs, specifying properties to > add to the button", without saying anything about the text properties > that are special for these functions. This is true for both the doc > strings and the Elisp manual (node `Making Buttons'). The node "Making Buttons" in the ELisp manual has a cross-reference to "Button Properties", where all the properties are described. > Property `action' is mentioned for function `button-activate' > (e.g. nodes `Button Properties', `Manipulating Buttons', and `Button > Buffer Commands'). But it and any other properties specific to the > button functions should be called out where we speak of such properties. > Or else such doc should refer to some location where we do specify such > properties. Sorry, I don't understand what you find missing in the manual. Where the ELisp manual talks about PROPERTY VALUE pairs it immediately refers to "Button Properties", where you find the details. What else is needed in the manual? > What's more, the doc strings of `push-button' and `button-activate' need > to mention property `action', just as the Elisp doc for them does. It > is not sufficient for the doc strings to simply refer to the "normal > action" of the button, without saying what that means. button-activate already mentioned the property; I fixed the doc string of push-button. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 20 13:51:32 2015 Received: (at 19628) by debbugs.gnu.org; 20 Jan 2015 18:51:32 +0000 Received: from localhost ([127.0.0.1]:51023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDdtj-0003zI-AH for submit@debbugs.gnu.org; Tue, 20 Jan 2015 13:51:31 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:50403) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDdth-0003z3-8z for 19628@debbugs.gnu.org; Tue, 20 Jan 2015 13:51:29 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t0KIpMS3022999 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 Jan 2015 18:51:23 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t0KIpLhr013963 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 20 Jan 2015 18:51:22 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t0KIpLLp008102; Tue, 20 Jan 2015 18:51:21 GMT MIME-Version: 1.0 Message-ID: <5d8b8ef5-b579-4984-b5c6-1159205b3974@default> Date: Tue, 20 Jan 2015 10:51:20 -0800 (PST) From: Drew Adams To: Eli Zaretskii Subject: RE: bug#19628: 25.0.50; doc of button functions References: <> <<83r3upwc4f.fsf@gnu.org>> In-Reply-To: <<83r3upwc4f.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19628 Cc: 19628@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > The doc of `make-button', `insert-button', and `insert-text-button' jus= t > > mentions "a sequence of PROPERTY VALUE pairs, specifying properties to > > add to the button", without saying anything about the text properties > > that are special for these functions. This is true for both the doc > > strings and the Elisp manual (node `Making Buttons'). >=20 > The node "Making Buttons" in the ELisp manual has a cross-reference to > "Button Properties", where all the properties are described. OK, scratch the part about "true for both the doc strings and the Elisp manual (node `Making Buttons')". I somehow missed that xref. The problem exists for the doc strings, however. > > Property `action' is mentioned for function `button-activate' > > (e.g. nodes `Button Properties', `Manipulating Buttons', and `Button > > Buffer Commands'). But it and any other properties specific to the > > button functions should be called out where we speak of such properties= . > > Or else such doc should refer to some location where we do specify such > > properties. >=20 > Sorry, I don't understand what you find missing in the manual. Where > the ELisp manual talks about PROPERTY VALUE pairs it immediately > refers to "Button Properties", where you find the details. What else > is needed in the manual? As I said, in `Manipulating Buttons', for example, the description of `button-activate' refers to "BUTTON's `action' property". That property is not explained there, so there should be a cross-ref from there to the place where it is described: `Button Properties'. > > What's more, the doc strings of `push-button' and `button-activate' nee= d > > to mention property `action', just as the Elisp doc for them does. It > > is not sufficient for the doc strings to simply refer to the "normal > > action" of the button, without saying what that means. >=20 > button-activate already mentioned the property; I fixed the doc string > of push-button. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 20 14:23:43 2015 Received: (at 19628-done) by debbugs.gnu.org; 20 Jan 2015 19:23:43 +0000 Received: from localhost ([127.0.0.1]:51035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDeOs-0004lQ-OJ for submit@debbugs.gnu.org; Tue, 20 Jan 2015 14:23:42 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:42793) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDeOp-0004lB-Vg for 19628-done@debbugs.gnu.org; Tue, 20 Jan 2015 14:23:41 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NIH00C00PHV9G00@a-mtaout20.012.net.il> for 19628-done@debbugs.gnu.org; Tue, 20 Jan 2015 21:23:33 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NIH00BJHPV8WO90@a-mtaout20.012.net.il>; Tue, 20 Jan 2015 21:23:33 +0200 (IST) Date: Tue, 20 Jan 2015 21:23:26 +0200 From: Eli Zaretskii Subject: Re: bug#19628: 25.0.50; doc of button functions In-reply-to: <5d8b8ef5-b579-4984-b5c6-1159205b3974@default> X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83iog1w91t.fsf@gnu.org> References: <5d8b8ef5-b579-4984-b5c6-1159205b3974@default> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19628-done Cc: 19628-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 20 Jan 2015 10:51:20 -0800 (PST) > From: Drew Adams > Cc: 19628@debbugs.gnu.org > > As I said, in `Manipulating Buttons', for example, the description of > `button-activate' refers to "BUTTON's `action' property". That property > is not explained there, so there should be a cross-ref from there to the > place where it is described: `Button Properties'. OK, I added a few words about 'action' there. (Having a cross-reference just to save a sentence or two didn't sound right.) From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 20 14:29:26 2015 Received: (at 19628-done) by debbugs.gnu.org; 20 Jan 2015 19:29:26 +0000 Received: from localhost ([127.0.0.1]:51056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDeUP-0004uZ-Hl for submit@debbugs.gnu.org; Tue, 20 Jan 2015 14:29:25 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:21371) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDeUN-0004uM-2S for 19628-done@debbugs.gnu.org; Tue, 20 Jan 2015 14:29:23 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t0KJTGLY019301 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 Jan 2015 19:29:17 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id t0KJTF3Y007306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 20 Jan 2015 19:29:16 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t0KJTFN0005544; Tue, 20 Jan 2015 19:29:15 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 20 Jan 2015 11:29:14 -0800 (PST) From: Drew Adams To: Eli Zaretskii Subject: RE: bug#19628: 25.0.50; doc of button functions References: <<5d8b8ef5-b579-4984-b5c6-1159205b3974@default>> <<83iog1w91t.fsf@gnu.org>> In-Reply-To: <<83iog1w91t.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 19628-done Cc: 19628-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > OK, I added a few words about 'action' there. (Having a > cross-reference just to save a sentence or two didn't sound right.) Muchas gracias. From unknown Thu Sep 11 11:56:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 18 Feb 2015 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator