GNU bug report logs - #19627
25.0.50; eshell: only the first item from eshell-visual-options is honored

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19627 in the body.
You can then email your comments to 19627 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Samer Masterson <nosefrog <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50;
 eshell: only the first item from eshell-visual-options is honored
Date: Mon, 19 Jan 2015 03:30:18 -0800

1. "emacs -Q"
2. M-x eshell
3. "git --help" prints the help text to the buffer
4. (add-to-list 'eshell-visual-options '("git" "--help"))
5. "git --help" brings up the term display (which is quickly killed,
that is bug#18108)
6. (add-to-list 'eshell-visual-options '("git" "--help"))
7. "git --help"
bug:
"git --help" prints the help text to the buffer.
expected behavior:
"git --help" should have brought up a term-mode buffer, as it's still
part of eshell-visual-options.




In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2014-11-18 on samer-dark-horse
Repository revision: b59998eb5b9c4e6e142b530604539c54028acb8d
Windowing system distributor `The X.Org Foundation', version 11.0.11501000
System Description:	Ubuntu 14.04.1 LTS

Configured using:
 `configure --prefix=/home/samer/local'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  magit-auto-revert-mode: t
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  global-flycheck-mode: t
  show-paren-mode: t
  flx-ido-mode: t
  guide-key-mode: t
  popwin-mode: t
  projectile-global-mode: t
  projectile-mode: t
  ido-everywhere: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t

Recent messages:
Redo! [4 times]
Undo!
C-x C-g is undefined
Quit
Mark set
byte-code: There is no version-controlled file in this buffer
Mark set [2 times]
Undo!
Entering debugger...
Quit

Load-path shadows:
/home/samer/.emacs.d/elpa/emms-20141104.1238/tq hides /home/samer/local/share/emacs/25.0.50/lisp/emacs-lisp/tq

Features:
(vc vc-dispatcher shadow emacsbug apropos ediff-merg ediff-wind
ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff company-go
sh-script smie executable make-mode rect eieio-opt conf-mode align js
json cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align
cc-engine cc-vars cc-defs tabify man go-stacktracer magit-blame cal-move
parse-time org-element org-rmail org-mhe org-irc org-info org-gnus
org-docview org-bibtex bibtex org-bbdb org-w3m org org-macro
org-footnote org-pcomplete org-list org-faces org-entities noutline
outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table
ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs
org-loaddefs cal-menu calendar cal-loaddefs deft wid-edit find-dired
debug windmove pp tramp-cache pcmpl-unix em-unix em-term term disp-table
ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-dirs em-cmpl
em-basic em-banner em-alias esh-var esh-io esh-cmd esh-opt esh-ext
esh-proc esh-arg esh-groups eshell esh-module esh-mode esh-util
cap-words superword subword misc hippie-exp ace-jump-mode company-files
company-oddmuse company-keywords company-etags company-gtags
company-dabbrev-code company-dabbrev company-capf company-cmake
company-ropemacs company-xcode company-clang company-semantic
company-eclim company-template company-css company-nxml company-bbdb
company imenu dired-aux magit-key-mode magit view tramp tramp-compat
tramp-loaddefs trampver shell pcomplete autorevert filenotify
git-rebase-mode git-commit-mode log-edit pcvs-util add-log epa-file
gnutls network-stream starttls tls mailalias mail-extr sort misearch
multi-isearch mule-util server vc-git diff-mode easy-mmode remember
flycheck help-mode rx subr-x pcase edmacro kmacro mu4e mu4e-speedbar
speedbar sb-image ezimage dframe mu4e-main mu4e-view epa derived epg
browse-url mu4e-headers mu4e-compose mu4e-draft mu4e-actions rfc2368
smtpmail sendmail mu4e-mark mu4e-message html2text mu4e-proc mu4e-utils
doc-view jka-compr image-mode mu4e-lists mu4e-about mu4e-vars message
format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse
rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils
mailheader hl-line mu4e-meta ctags paren flx-ido flx saveplace smex
go-eldoc go-mode url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf url-util mailcap find-file ffap
url-parse auth-source eieio byte-opt bytecomp byte-compile cl-extra
cconv eieio-core gnus-util time-date mm-util mail-prsvr password-cache
url-vars etags guide-key face-remap popwin projectile advice ibuf-ext
ibuffer pkg-info find-func lisp-mnt epl grep thingatpt help-fns cl-macs
cl gv cl-loaddefs cl-lib ag vc-svn compile comint ansi-color ring ido s
ucs-normalize dash dired go-mode-autoloads info easymenu package
epg-config tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
gfilenotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 16 1241346 112536)
 (symbols 48 47333 45)
 (miscs 40 5342 3741)
 (strings 32 152325 24034)
 (string-bytes 1 4851785)
 (vectors 16 105515)
 (vector-slots 8 2407778 30922)
 (floats 8 12781 3102)
 (intervals 56 101672 5260)
 (buffers 976 240)
 (heap 1024 174273 61924))

Message #8 received at 19627 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Samer Masterson <nosefrog <at> gmail.com>
Cc: 19627 <at> debbugs.gnu.org
Subject: Re: bug#19627: 25.0.50;
 eshell: only the first item from eshell-visual-options is honored
Date: Sun, 03 Jul 2016 22:47:54 -0400

[Message part 1 (text/plain, inline)]

severity 19627 minor
quit

Samer Masterson <nosefrog <at> gmail.com> writes:

> 1. "emacs -Q"
> 2. M-x eshell
> 3. "git --help" prints the help text to the buffer
> 4. (add-to-list 'eshell-visual-options '("git" "--help"))
> 5. "git --help" brings up the term display (which is quickly killed,
> that is bug#18108)
> 6. (add-to-list 'eshell-visual-options '("git" "--help"))

I guess you actually meant "--version" rather than "--help" again here.

> 7. "git --help"
> bug:
> "git --help" prints the help text to the buffer.
> expected behavior:
> "git --help" should have brought up a term-mode buffer, as it's still
> part of eshell-visual-options.

eshell-visual-options is an alist (as mentioned in the docstring), so
the newest "git" entry decides which options are in force.  To get what
you want, you should do:

  (add-to-list 'eshell-visual-options '("git" "--help" "--version"))

or possibly

  (push "--version" (cdr (assoc "git" eshell-visual-options)))

Maybe the docs can be improved to explain this better.  Is it enough to
change the example usage to have 2 different options?

[v1-0001-Clarify-usage-of-eshell-visual-options.patch (text/x-diff, inline)]

From c51bb7b36ef7f0bbe3e69c8fe16abc6b2ca8a6c1 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs <at> gmail.com>
Date: Sun, 3 Jul 2016 22:41:48 -0400
Subject: [PATCH v1] Clarify usage of eshell-visual-options

* lisp/eshell/em-term.el (eshell-visual-options): Add second option to
example usage.
---
 lisp/eshell/em-term.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/eshell/em-term.el b/lisp/eshell/em-term.el
index 3e5de0c..208629c 100644
--- a/lisp/eshell/em-term.el
+++ b/lisp/eshell/em-term.el
@@ -102,10 +102,11 @@ eshell-visual-options
 of commands with options that present their output in a visual
 fashion.  For example, a sensible entry would be
 
-  (\"git\" \"--help\")
+  (\"git\" \"--help\" \"--paginate\")
 
 because \"git <command> --help\" shows the command's
-documentation with a pager.
+documentation with a pager and \"git --paginate <command>\"
+always uses a pager for output.
 
 See also `eshell-visual-commands' and `eshell-visual-subcommands'."
   :type '(repeat (cons (string :tag "Command")
-- 
2.8.0

Message #13 received at 19627 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Samer Masterson <nosefrog <at> gmail.com>
Cc: 19627 <at> debbugs.gnu.org
Subject: Re: bug#19627: 25.0.50;
 eshell: only the first item from eshell-visual-options is honored
Date: Thu, 28 Jul 2016 20:13:09 -0400

close 19627 25.1
quit

npostavs <at> users.sourceforge.net writes:

>
> Maybe the docs can be improved to explain this better.  Is it enough to
> change the example usage to have 2 different options?

I will assume yes, done in 442cc39.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.