GNU bug report logs - #19623
Bug of nnimap-find-expired-articles

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19623 in the body.
You can then email your comments to 19623 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: OGAWA Hirofumi <hirofumi <at> mail.parknet.co.jp>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: Bug of nnimap-find-expired-articles
Date: Sun, 18 Jan 2015 19:38:27 +0900

Hi,

nnimap-find-expired-articles expires wrong articles.

When I am using 'never in expire config, emails in the group should not
be expired. But nnmail-expired-article-p which is used by
nnimap-find-expired-articles returns nil for 'never, and
nnimap-find-expired-articles pass returned nil to decode-time to find
articles.

By using returned nil for decode-time, nnimap-find-expired-articles
returns articles before current time, and expires all emails wrongly.

The following patch is to fix this bug.

Thanks.

Gnus v5.13
GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.25)
 of 2015-01-13 on devron



`nnmail-expired-article-p' can return nil. But
`nnimap-find-expired-articles' doesn't handle nil properly.

---

 lisp/gnus/nnimap.el |   27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff -puN lisp/gnus/nnimap.el~nnimap-find-expired-articles-fix lisp/gnus/nnimap.el
--- emacs/lisp/gnus/nnimap.el~nnimap-find-expired-articles-fix	2014-12-12 22:04:41.587303247 +0900
+++ emacs-hirofumi/lisp/gnus/nnimap.el	2014-12-12 22:04:41.591303236 +0900
@@ -996,19 +996,20 @@ textual parts.")
 
 (defun nnimap-find-expired-articles (group)
   (let ((cutoff (nnmail-expired-article-p group nil nil)))
-    (with-current-buffer (nnimap-buffer)
-      (let ((result
-	     (nnimap-command
-	      "UID SEARCH SENTBEFORE %s"
-	      (format-time-string
-	       (format "%%d-%s-%%Y"
-		       (upcase
-			(car (rassoc (nth 4 (decode-time cutoff))
-				     parse-time-months))))
-	       cutoff))))
-	(and (car result)
-	     (delete 0 (mapcar #'string-to-number
-			       (cdr (assoc "SEARCH" (cdr result))))))))))
+    (when cutoff
+      (with-current-buffer (nnimap-buffer)
+	(let ((result
+	       (nnimap-command
+		"UID SEARCH SENTBEFORE %s"
+		(format-time-string
+		 (format "%%d-%s-%%Y"
+			 (upcase
+			  (car (rassoc (nth 4 (decode-time cutoff))
+				       parse-time-months))))
+		 cutoff))))
+	  (and (car result)
+	       (delete 0 (mapcar #'string-to-number
+				 (cdr (assoc "SEARCH" (cdr result)))))))))))
 
 
 (defun nnimap-find-article-by-message-id (group server message-id
_
-- 
OGAWA Hirofumi <hirofumi <at> mail.parknet.co.jp>

Message #8 received at 19623 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: OGAWA Hirofumi <hirofumi <at> mail.parknet.co.jp>
Cc: 19623 <at> debbugs.gnu.org
Subject: Re: bug#19623: Bug of nnimap-find-expired-articles
Date: Wed, 25 Jan 2017 22:17:34 +0100

Sorry for the late response; the bug report has been sitting in a part
of the bug tracker that nobody has looked at due to a misunderstanding.

OGAWA Hirofumi <hirofumi <at> mail.parknet.co.jp> writes:

> nnimap-find-expired-articles expires wrong articles.
>
> When I am using 'never in expire config, emails in the group should not
> be expired. But nnmail-expired-article-p which is used by
> nnimap-find-expired-articles returns nil for 'never, and
> nnimap-find-expired-articles pass returned nil to decode-time to find
> articles.
>
> By using returned nil for decode-time, nnimap-find-expired-articles
> returns articles before current time, and expires all emails wrongly.
>
> The following patch is to fix this bug.

Thanks for the patch.  It seems like somebody else has applied the same
fix in the meantime, though.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.