From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 16 10:01:24 2015 Received: (at submit) by debbugs.gnu.org; 16 Jan 2015 15:01:24 +0000 Received: from localhost ([127.0.0.1]:59457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YC8Oq-00065i-EX for submit@debbugs.gnu.org; Fri, 16 Jan 2015 10:01:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41659) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YC8Oo-00065S-LQ for submit@debbugs.gnu.org; Fri, 16 Jan 2015 10:01:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YC8Of-0003PZ-9g for submit@debbugs.gnu.org; Fri, 16 Jan 2015 10:01:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC8Of-0003PV-5t for submit@debbugs.gnu.org; Fri, 16 Jan 2015 10:01:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC8Oe-0000Kt-0S for bug-automake@gnu.org; Fri, 16 Jan 2015 10:01:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YC8OZ-0003Od-03 for bug-automake@gnu.org; Fri, 16 Jan 2015 10:01:11 -0500 Received: from mout.gmx.net ([212.227.15.18]:53831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC8OY-0003Nl-LQ for bug-automake@gnu.org; Fri, 16 Jan 2015 10:01:06 -0500 Received: from [10.25.0.194] ([195.159.234.190]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MhiTL-1YPgwH3cBf-00MrHD for ; Fri, 16 Jan 2015 16:01:02 +0100 Date: Fri, 16 Jan 2015 16:01:01 +0100 (CET) From: Dimitrios Apostolou To: bug-automake@gnu.org Subject: make dist exits succesfully even when tar exits with error Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII X-Provags-ID: V03:K0:euqsKeXGAaAL/zbJQNB7JKcccthNNivilFwJlBwNAHYbziB4oii PKGFpJ2/np4FS+bkn96IUf7bz2i/+LZ/2/OGvdM2boXY59+NVz5pmxt3IfMdxQp/PsFTLl7 2uMsXob2jOQiHUjA/o+aoQI+LYYflUtEnbUEMqpeHfB1IZj6WaksM7x0S+yUqmvvUlhYT2C uTZ24/9ayUwBEQwGUMPJQ== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) (Please keep me CC'd as I'm not subscribed.) Hello list, as the title says, I believe running "make dist" should fail when tar fails. The problem is that because there is a shell pipeline with gzip, the exit code of the pipeline is 0. I'm not aware of a portable way to fix this (named pipes maybe?), but most convenient would be bash's "set -o pipefail". Relevant output from "make V=1 dist": tardir=cfengine-3.7.0a1.5ffcc54 && tar --format=ustar -chf - "$tardir" | GZIP=--best gzip -c >cfengine-3.7.0a1.5ffcc54.tar.gz tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_password_hash_is_not_cached_hpux_trusted.cf: link name is too long; not dumped tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_modify_user_unlock_with_password_hpux_trusted.cf: link name is too long; not dumped tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/10_modify_user_with_many_attributes_warn.cf: link name is too long; not dumped tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_modify_user_with_hashed_password_hpux_trusted.cf: link name is too long; not dumped tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_modify_user_lock_with_password_hpux_trusted.cf: link name is too long; not dumped tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_add_user_with_many_attributes_warn_hpux_trusted.cf: link name is too long; not dumped tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_modify_user_with_password_hpux_trusted.cf: link name is too long; not dumped tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/10_newly_created_account_should_not_count_as_locked.cf: link name is too long; not dumped tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_modify_user_with_many_attributes_hpux_trusted.cf: link name is too long; not dumped tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_add_user_with_hashed_password_hpux_trusted.cf: link name is too long; not dumped tar: Exiting with failure status due to previous errors (A separate bug report will come soon about the "link failure" despite tar "-h" option being used.) Thanks, Dimitris From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 16 11:48:02 2015 Received: (at 19614) by debbugs.gnu.org; 16 Jan 2015 16:48:02 +0000 Received: from localhost ([127.0.0.1]:59477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YCA42-0000cm-8S for submit@debbugs.gnu.org; Fri, 16 Jan 2015 11:48:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52524) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YCA3z-0000cF-Tf for 19614@debbugs.gnu.org; Fri, 16 Jan 2015 11:48:00 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0GGlrPV008369 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 16 Jan 2015 11:47:53 -0500 Received: from [10.3.113.41] (ovpn-113-41.phx2.redhat.com [10.3.113.41]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0GGlqpa014126; Fri, 16 Jan 2015 11:47:53 -0500 Message-ID: <54B940B7.80002@redhat.com> Date: Fri, 16 Jan 2015 09:47:51 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Dimitrios Apostolou , 19614@debbugs.gnu.org Subject: Re: bug#19614: make dist exits succesfully even when tar exits with error References: In-Reply-To: OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BtX7wL4Wl46EXoHEc2LnaqVjhB6bHHIj3" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 19614 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BtX7wL4Wl46EXoHEc2LnaqVjhB6bHHIj3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/16/2015 08:01 AM, Dimitrios Apostolou wrote: > (Please keep me CC'd as I'm not subscribed.) In general, GNU list policy is to reply-to-all, precisely so you don't have to leave disclaimers like that :) >=20 > Hello list, >=20 > as the title says, I believe running "make dist" should fail when tar > fails. The problem is that because there is a shell pipeline with gzip,= > the exit code of the pipeline is 0. I'm not aware of a portable way to > fix this (named pipes maybe?), but most convenient would be bash's "set= > -o pipefail". Alas, pipefail is not portable. >=20 > Relevant output from "make V=3D1 dist": >=20 > tardir=3Dcfengine-3.7.0a1.5ffcc54 && tar --format=3Dustar -chf - "$tard= ir" | > GZIP=3D--best gzip -c >cfengine-3.7.0a1.5ffcc54.tar.gz It is portable to do something hairy like: { tar ...; echo $? > file; } | gzip ... inspect file It is even possible to avoid an intermediate file with even hairier exec operations to shuffle fds around. It may be simpler to break things into two steps, with an intermediate file instead of a pipeline, although I'm not sure it would be efficient. But you definitely make a point that we should fix things to detect tar failure. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BtX7wL4Wl46EXoHEc2LnaqVjhB6bHHIj3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUuUC3AAoJEKeha0olJ0NqPTAH/1g0iC2Yb5fJ/omw3RBoeWms qxiFUzeLSP6Kz4JVCV6e8MpJLcY9od9WnT8Z9fA2GAKnVtaXV3mXTHwO7yxvFHkD aTTWMdDw+4cE3T88e8V5+0WnYmLODjeHxdwAuPV8Y+bIkG27fiu/u4bl+/Loi2uu Uw+53X+tNAn7bVuwKORXHvlZBw8eljdoIMBQl/kmlUY2pHcJhaI6nBQtj9lsw7mR Cify0OTtMuBonLVx1dmonVjfx/4PBV2kSVmXiMXuJI2O+hkB43rDSB0RTOdsN4EU 5EPAnk8yIyTxB6ZaR1V5WOxTdJIMnStCQXeNuy6P8aCtfbKtzvauDcrssmQesXk= =Tv9E -----END PGP SIGNATURE----- --BtX7wL4Wl46EXoHEc2LnaqVjhB6bHHIj3-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 16 12:15:21 2015 Received: (at 19614) by debbugs.gnu.org; 16 Jan 2015 17:15:21 +0000 Received: from localhost ([127.0.0.1]:59501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YCAUR-0001gI-Pm for submit@debbugs.gnu.org; Fri, 16 Jan 2015 12:15:20 -0500 Received: from mout.gmx.net ([212.227.17.22]:52461) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YCAUQ-0001Xm-7q for 19614@debbugs.gnu.org; Fri, 16 Jan 2015 12:15:18 -0500 Received: from [10.25.0.194] ([195.159.234.190]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0M82zV-1Xpypi05eD-00ve9r; Fri, 16 Jan 2015 18:15:11 +0100 Date: Fri, 16 Jan 2015 18:15:08 +0100 (CET) From: Dimitrios Apostolou To: Eric Blake Subject: Re: bug#19614: make dist exits succesfully even when tar exits with error In-Reply-To: <54B940B7.80002@redhat.com> Message-ID: References: <54B940B7.80002@redhat.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Provags-ID: V03:K0:u7uACp+p+2QRII+iUBiJTFs6pIRjyFPVepPBfn1LOpwIklW1Jow 84NJqqK7u6SxQUiJlHUWLHsnmNCmyngczpPUv9qCYshXuJxvsFiUOTULt2XbGCEyneubJAt pEzqco2FYeC2jmd5SUSBC+9V27XzczvpZlDj6sCmEV0pkkep7Y+BxNIQBayzS0yT6pgjeVw 37k0CBRQu+l2NfohzOHRQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19614 Cc: 19614@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Fri, 16 Jan 2015, Eric Blake wrote: > On 01/16/2015 08:01 AM, Dimitrios Apostolou wrote: >> Relevant output from "make V=1 dist": >> >> tardir=cfengine-3.7.0a1.5ffcc54 && tar --format=ustar -chf - "$tardir" | >> GZIP=--best gzip -c >cfengine-3.7.0a1.5ffcc54.tar.gz > > It is portable to do something hairy like: > > { tar ...; echo $? > file; } | gzip ... > inspect file > > It is even possible to avoid an intermediate file with even hairier exec > operations to shuffle fds around. > > It may be simpler to break things into two steps, with an intermediate > file instead of a pipeline, although I'm not sure it would be efficient. > > But you definitely make a point that we should fix things to detect tar > failure. What if we just grep stderr for *any* output from any command in the pipeline? { tar ... | gzip ... ; } 2>&1 1>/dev/null | grep . Nobody guarantees that it can't fail silently or it can't succeed despite output in stderr, but it's pretty rare. Dimitris From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 07 22:47:21 2022 Received: (at control) by debbugs.gnu.org; 8 Feb 2022 03:47:21 +0000 Received: from localhost ([127.0.0.1]:44571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHHTN-0005On-6R for submit@debbugs.gnu.org; Mon, 07 Feb 2022 22:47:21 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:42894 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHHTL-0005Oa-Sz for control@debbugs.gnu.org; Mon, 07 Feb 2022 22:47:20 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 3F44A342D35; Tue, 8 Feb 2022 03:47:13 +0000 (UTC) From: Mike Frysinger To: control@debbugs.gnu.org Subject: Control message Message-Id: <20220208034713.3F44A342D35@smtp.gentoo.org> Date: Tue, 8 Feb 2022 03:47:13 +0000 (UTC) X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) tag 19614 = confirmed thankyou From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 12:52:07 2022 Received: (at submit) by debbugs.gnu.org; 30 Dec 2022 17:52:08 +0000 Received: from localhost ([127.0.0.1]:36078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBJY6-0006FR-SP for submit@debbugs.gnu.org; Fri, 30 Dec 2022 12:52:07 -0500 Received: from lists.gnu.org ([209.51.188.17]:34248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBFET-0003YD-HB for submit@debbugs.gnu.org; Fri, 30 Dec 2022 08:15:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBFET-0005eU-Aj for automake-patches@gnu.org; Fri, 30 Dec 2022 08:15:33 -0500 Received: from mout.gmx.net ([212.227.17.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBFEL-0002sM-D3 for automake-patches@gnu.org; Fri, 30 Dec 2022 08:15:29 -0500 Received: from [0.0.0.0] ([185.129.61.10]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N63RQ-1ompcG1VV2-016LsJ for ; Fri, 30 Dec 2022 14:15:22 +0100 Content-Type: multipart/mixed; boundary="------------Z9P2aoRYg0wA9oF7VIsHe2Fm" Message-ID: <2f50f549-4b2d-10cb-2c37-e06de7676773@gmx.us> Date: Fri, 30 Dec 2022 14:15:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: automake-patches@gnu.org Content-Language: en-GB, sv-SE From: Bogdan Subject: [bug#19614] Split packaging invocation to catch errors X-Provags-ID: V03:K1:wPuhMq7wSbIPyv+BdI8gcETqvoSrnlQOq/2XY5zDUGXs87VzpyM whqShTjt4pphthAx1nwVT8V00/0/qLUqRJYTHZXFqG4P5/AYEaaJzfVS0MriQsYmJKEdLdN kcLRKNSxOvH1SHLEx7ZvYLVvHI6YA40Rp6PPJdfeeeaPvwaH2PLfAhsUXwFWYxpGtAMHJ8m KOoVT9XvfkaVPQh3Pao7w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:FkQrADB/KEM=;h30jBL2p8vGmHnoFeLhx3M0sw1P vh38mCgC+s8xgswATLAKtbW14/IeMSybbNjnbODrQb6l0WL9Di1edjFQjYUhBbhYjC2kirf0b NRGT610iPTzUjOqw2gBMxB0PM0ZhzmyusY3om3txKp7Ny/k6YPItF51eWOxFNazinAEM+EVY8 tzu4dhzaonh8POfhgChtcQfPncjE+F/NMbDS9lgJx3VSy7qkZkkGhNrIMtwo7CyYLWsacG1o+ NQfCI5l2Lf6gEcBnsGtZGnxxl38uiONa4hVHQwNm8i+HNv03Z2vkrsi9fBuq89Q84QLOxefQ3 FO+ExmPkYThFDImWVjXM+YoWo5kT1GsdJFRvnkj7MIfnxcBqatcn35G02ovU5kMCxO1eQUxd/ qVXbw9+i4sV6uXxOWqT0Ys+68w06MrE8OxIC9wDIjM5Qj57Coy17opdxYqTYYoasHIJPLD+Me TdrbqMTnJRhOV8BGKlL7KjMk2xjTvjNrG7K1UEOLsCWowp40VPa/7JUaIDors/eUG7ny3ZbAq yB76bfvwMDar31Q29cvICQo1vYlixNbw06bYoTcyM0+cr1u7mw43kM7VuLyXorLehatH0ML+j lw4fVobNUKOoSjPPHKG1kFzspJSo73TKsm+mVHjhrgvcXCll2/dNGhukigjdvCKBfaZOdCZSE V0sNnJe2esFC8+kNBGWsTxybJScRbrRYiZpOn9ajdpN5H+kBA7NNDfMW/hlWXi+YZOfu89T9c zHV9do7J5s4RwYijMyYkzIDQnxvj0kWGixLGgVv7BhM0NxpgRJkIG8H46tqaT2gA2OMpoAj59 696G0AFYygQm0z/VOmDJyaKM6KmYryhCj201M1lCE16cTLGWSar4nolSUzOMzrPG+ocM3a2C7 u/es0EmfPp2ftQowNfECKQcXJ6tedbUedo8JY4bGD+0BUAx8Qa22wlRAEtmXuQZVN80CpSx2d SDvd8oMBXBJzlzQlHSJGmb+W4E8pCtsM8aSQ7itf1wOtj8r6 Received-SPF: pass client-ip=212.227.17.22; envelope-from=bogdro_rep@gmx.us; helo=mout.gmx.net X-Spam_score_int: 7 X-Spam_score: 0.7 X-Spam_bar: / X-Spam_report: (0.7 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello again. This time a patch that splits 'tar ... | gzip/bzip2/whatever' into 2 commands. Yes, this introduces a requirement for a "temporary" .tar file (and i-node allocation, and filesystem free space/performance, and ...), but gives gains (I hope they're gains): Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.129.61.10 listed in zen.spamhaus.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (bogdro_rep[at]gmx.us) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.51.188.17 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=bogdro_rep%40gmx.us; ip=209.51.188.17; r=debbugs.gnu.org] X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 30 Dec 2022 12:52:01 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello again. This time a patch that splits 'tar ... | gzip/bzip2/whatever' into 2 commands. Yes, this introduces a requirement for a "temporary" .tar file (and i-node allocation, and filesystem free space/performance, and ...), but gives gains (I hope they're gains): Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.51.188.17 listed in wl.mailspike.net] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.129.61.10 listed in zen.spamhaus.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (bogdro_rep[at]gmx.us) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=bogdro_rep%40gmx.us;ip=209.51.188.17;r=debbugs.gnu.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager This is a multi-part message in MIME format. --------------Z9P2aoRYg0wA9oF7VIsHe2Fm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello again. This time a patch that splits 'tar ... | gzip/bzip2/whatever' into 2 commands. Yes, this introduces a requirement for a "temporary" .tar file (and i-node allocation, and filesystem free space/performance, and ...), but gives gains (I hope they're gains): 1) when 'tar' exits with an error, 'make' handles it and stops the packaging instead of letting the second packer in the chain possibly create an incomplete package, 2) when 'tar' fails but does NOT exit with an error, I check the standard error output for any messages. If present, I assume an error and let 'make' handle it like in case 1). GNU tar behaves nicely: when a problem is encountered, it stops with an error exit code. The unfortunate default on my system, BSD tar, doesn't. In case of a problem, just a warning is emitted, the exit code is success even though files are missing from the resulting .tar file. And there is no way to turn those warnings into errors. No idea who thought of that. Hence manual checking stderr. Feel free to modify the test if needed. I assumed all dist types are available, but that may not always be the case - maybe some conditionals are needed. Regards, Bogdan Drozdowski -- Regards - Bogdan ('bogdro') D. (GNU/Linux & FreeDOS) X86 assembly (DOS, GNU/Linux): http://bogdro.evai.pl/index-en.php Soft(EN): http://bogdro.evai.pl/soft http://bogdro.evai.pl/soft4asm www.Xiph.org www.TorProject.org www.LibreOffice.org www.GnuPG.org --------------Z9P2aoRYg0wA9oF7VIsHe2Fm Content-Type: text/x-patch; charset=UTF-8; name="automake-tar-err-fails-mail.diff" Content-Disposition: attachment; filename="automake-tar-err-fails-mail.diff" Content-Transfer-Encoding: base64 RnJvbSBjM2VlMWM5MTY5M2JmMDljMjgxNTY0NDkzM2U2YWJkMGFmYWNjZGQ2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCb2dkYW4gRHJvemRvd3NraSA8PgpEYXRlOiBUdWUs IDI3IERlYyAyMDIyIDIyOjM5OjU4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gU3BsaXQgcGFj a2FnaW5nIHNvIHRhciBlcnJvciBmYWlscyB0aGUgYnVpbGQKCi0tLQogbGliL2FtL2Rpc3Rk aXIuYW0gIHwgNDIgKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQogdC9saXN0LW9m LXRlc3RzLm1rIHwgIDEgKwogdC90YXItc3BsaXQtY21kLnNoIHwgNjIgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCA5 OSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IHQv dGFyLXNwbGl0LWNtZC5zaAoKZGlmZiAtLWdpdCBhL2xpYi9hbS9kaXN0ZGlyLmFtIGIvbGli L2FtL2Rpc3RkaXIuYW0KaW5kZXggYWEyYmU1MjM4Li41Y2NhZTUzOTcgMTAwNjQ0Ci0tLSBh L2xpYi9hbS9kaXN0ZGlyLmFtCisrKyBiL2xpYi9hbS9kaXN0ZGlyLmFtCkBAIC0zMzQsMzEg KzMzNCw1NiBAQCBpZiAlP1RPUERJUl9QJQogR1pJUF9FTlYgPSAtLWJlc3QKIC5QSE9OWTog ZGlzdC1nemlwCiBkaXN0LWd6aXA6IGRpc3RkaXIKLQl0YXJkaXI9JChkaXN0ZGlyKSAmJiAk KGFtX190YXIpIHwgZXZhbCBHWklQPSBnemlwICQoR1pJUF9FTlYpIC1jID4kKGRpc3RkaXIp LnRhci5negorCXRhcmRpcj0kKGRpc3RkaXIpICYmICQoYW1fX3RhcikgPiAkKGRpc3RkaXIp LnRhciAyPiQoZGlzdGRpcikuZXJyCisJdGVzdCAhIC1zICQoZGlzdGRpcikuZXJyIHx8IChj YXQgJChkaXN0ZGlyKS5lcnIgJiYgXAorCQlybSAtcmYgJChESVNUX0FSQ0hJVkVTKSAkKGRp c3RkaXIpLnRhciAkKGRpc3RkaXIpLmVyciAmJiBcCisJCSQoYW1fX3Bvc3RfcmVtb3ZlX2Rp c3RkaXIpICYmIFwKKwkJZXhpdCAxKQorCWV2YWwgR1pJUD0gZ3ppcCAkKEdaSVBfRU5WKSAk KGRpc3RkaXIpLnRhciAtYyA+JChkaXN0ZGlyKS50YXIuZ3oKIAkkKGFtX19wb3N0X3JlbW92 ZV9kaXN0ZGlyKQogCiA/QlpJUDI/RElTVF9BUkNISVZFUyArPSAkKGRpc3RkaXIpLnRhci5i ejIKIC5QSE9OWTogZGlzdC1iemlwMgogZGlzdC1iemlwMjogZGlzdGRpcgotCXRhcmRpcj0k KGRpc3RkaXIpICYmICQoYW1fX3RhcikgfCBCWklQMj0kJHtCWklQMi0tOX0gYnppcDIgLWMg PiQoZGlzdGRpcikudGFyLmJ6MgorCXRhcmRpcj0kKGRpc3RkaXIpICYmICQoYW1fX3Rhcikg PiAkKGRpc3RkaXIpLnRhciAyPiQoZGlzdGRpcikuZXJyCisJdGVzdCAhIC1zICQoZGlzdGRp cikuZXJyIHx8IChjYXQgJChkaXN0ZGlyKS5lcnIgJiYgXAorCQlybSAtcmYgJChESVNUX0FS Q0hJVkVTKSAkKGRpc3RkaXIpLnRhciAkKGRpc3RkaXIpLmVyciAmJiBcCisJCSQoYW1fX3Bv c3RfcmVtb3ZlX2Rpc3RkaXIpICYmIFwKKwkJZXhpdCAxKQorCUJaSVAyPSQke0JaSVAyLS05 fSBiemlwMiAtYyAkKGRpc3RkaXIpLnRhciA+JChkaXN0ZGlyKS50YXIuYnoyCiAJJChhbV9f cG9zdF9yZW1vdmVfZGlzdGRpcikKIAogP0xaSVA/RElTVF9BUkNISVZFUyArPSAkKGRpc3Rk aXIpLnRhci5segogLlBIT05ZOiBkaXN0LWx6aXAKIGRpc3QtbHppcDogZGlzdGRpcgotCXRh cmRpcj0kKGRpc3RkaXIpICYmICQoYW1fX3RhcikgfCBsemlwIC1jICQke0xaSVBfT1BULS05 fSA+JChkaXN0ZGlyKS50YXIubHoKKwl0YXJkaXI9JChkaXN0ZGlyKSAmJiAkKGFtX190YXIp ID4gJChkaXN0ZGlyKS50YXIgMj4kKGRpc3RkaXIpLmVycgorCXRlc3QgISAtcyAkKGRpc3Rk aXIpLmVyciB8fCAoY2F0ICQoZGlzdGRpcikuZXJyICYmIFwKKwkJcm0gLXJmICQoRElTVF9B UkNISVZFUykgJChkaXN0ZGlyKS50YXIgJChkaXN0ZGlyKS5lcnIgJiYgXAorCQkkKGFtX19w b3N0X3JlbW92ZV9kaXN0ZGlyKSAmJiBcCisJCWV4aXQgMSkKKwlsemlwIC1jICQke0xaSVBf T1BULS05fSAkKGRpc3RkaXIpLnRhciA+JChkaXN0ZGlyKS50YXIubHoKIAkkKGFtX19wb3N0 X3JlbW92ZV9kaXN0ZGlyKQogCiA/WFo/RElTVF9BUkNISVZFUyArPSAkKGRpc3RkaXIpLnRh ci54egogLlBIT05ZOiBkaXN0LXh6CiBkaXN0LXh6OiBkaXN0ZGlyCi0JdGFyZGlyPSQoZGlz dGRpcikgJiYgJChhbV9fdGFyKSB8IFhaX09QVD0kJHtYWl9PUFQtLWV9IHh6IC1jID4kKGRp c3RkaXIpLnRhci54egorCXRhcmRpcj0kKGRpc3RkaXIpICYmICQoYW1fX3RhcikgPiAkKGRp c3RkaXIpLnRhciAyPiQoZGlzdGRpcikuZXJyCisJdGVzdCAhIC1zICQoZGlzdGRpcikuZXJy IHx8IChjYXQgJChkaXN0ZGlyKS5lcnIgJiYgXAorCQlybSAtcmYgJChESVNUX0FSQ0hJVkVT KSAkKGRpc3RkaXIpLnRhciAkKGRpc3RkaXIpLmVyciAmJiBcCisJCSQoYW1fX3Bvc3RfcmVt b3ZlX2Rpc3RkaXIpICYmIFwKKwkJZXhpdCAxKQorCVhaX09QVD0kJHtYWl9PUFQtLWV9IHh6 IC1jICQoZGlzdGRpcikudGFyID4kKGRpc3RkaXIpLnRhci54egogCSQoYW1fX3Bvc3RfcmVt b3ZlX2Rpc3RkaXIpCiAKID9aU1REP0RJU1RfQVJDSElWRVMgKz0gJChkaXN0ZGlyKS50YXIu enN0CiAuUEhPTlk6IGRpc3QtenN0ZAogZGlzdC16c3RkOiBkaXN0ZGlyCi0JdGFyZGlyPSQo ZGlzdGRpcikgJiYgJChhbV9fdGFyKSB8IHpzdGQgLWMgJCR7WlNURF9DTEVWRUwtJCR7WlNU RF9PUFQtLTE5fX0gPiQoZGlzdGRpcikudGFyLnpzdAorCXRhcmRpcj0kKGRpc3RkaXIpICYm ICQoYW1fX3RhcikgPiAkKGRpc3RkaXIpLnRhciAyPiQoZGlzdGRpcikuZXJyCisJdGVzdCAh IC1zICQoZGlzdGRpcikuZXJyIHx8IChjYXQgJChkaXN0ZGlyKS5lcnIgJiYgXAorCQlybSAt cmYgJChESVNUX0FSQ0hJVkVTKSAkKGRpc3RkaXIpLnRhciAkKGRpc3RkaXIpLmVyciAmJiBc CisJCSQoYW1fX3Bvc3RfcmVtb3ZlX2Rpc3RkaXIpICYmIFwKKwkJZXhpdCAxKQorCXpzdGQg LWMgJCR7WlNURF9DTEVWRUwtJCR7WlNURF9PUFQtLTE5fX0gJChkaXN0ZGlyKS50YXIgPiQo ZGlzdGRpcikudGFyLnpzdAogCSQoYW1fX3Bvc3RfcmVtb3ZlX2Rpc3RkaXIpCiAKID9DT01Q UkVTUz9ESVNUX0FSQ0hJVkVTICs9ICQoZGlzdGRpcikudGFyLloKQEAgLTM2Nyw3ICszOTIs MTIgQEAgZGlzdC10YXJaOiBkaXN0ZGlyCiAJQGVjaG8gV0FSTklORzogIlN1cHBvcnQgZm9y IGRpc3RyaWJ1dGlvbiBhcmNoaXZlcyBjb21wcmVzc2VkIHdpdGgiIFwKIAkJICAgICAgICJs ZWdhY3kgcHJvZ3JhbSAnY29tcHJlc3MnIGlzIGRlcHJlY2F0ZWQuIiA+JjIKIAlAZWNobyBX QVJOSU5HOiAiSXQgd2lsbCBiZSByZW1vdmVkIGFsdG9nZXRoZXIgaW4gQXV0b21ha2UgMi4w IiA+JjIKLQl0YXJkaXI9JChkaXN0ZGlyKSAmJiAkKGFtX190YXIpIHwgY29tcHJlc3MgLWMg PiQoZGlzdGRpcikudGFyLloKKwl0YXJkaXI9JChkaXN0ZGlyKSAmJiAkKGFtX190YXIpID4g JChkaXN0ZGlyKS50YXIgMj4kKGRpc3RkaXIpLmVycgorCXRlc3QgISAtcyAkKGRpc3RkaXIp LmVyciB8fCAoY2F0ICQoZGlzdGRpcikuZXJyICYmIFwKKwkJcm0gLXJmICQoRElTVF9BUkNI SVZFUykgJChkaXN0ZGlyKS50YXIgJChkaXN0ZGlyKS5lcnIgJiYgXAorCQkkKGFtX19wb3N0 X3JlbW92ZV9kaXN0ZGlyKSAmJiBcCisJCWV4aXQgMSkKKwljb21wcmVzcyAtYyAkKGRpc3Rk aXIpLnRhciA+JChkaXN0ZGlyKS50YXIuWgogCSQoYW1fX3Bvc3RfcmVtb3ZlX2Rpc3RkaXIp CiAKID9TSEFSP0RJU1RfQVJDSElWRVMgKz0gJChkaXN0ZGlyKS5zaGFyLmd6CmRpZmYgLS1n aXQgYS90L2xpc3Qtb2YtdGVzdHMubWsgYi90L2xpc3Qtb2YtdGVzdHMubWsKaW5kZXggZDgy Y2Y5YzRkLi44ZjhlMDg4ODUgMTAwNjQ0Ci0tLSBhL3QvbGlzdC1vZi10ZXN0cy5taworKysg Yi90L2xpc3Qtb2YtdGVzdHMubWsKQEAgLTEyMTAsNiArMTIxMCw3IEBAIHQvdGFyLXBheC5z aCBcCiB0L3Rhci1vcHRzLWVycm9ycy5zaCBcCiB0L3Rhci11c3Rhci1pZC10b28taGlnaC5z aCBcCiB0L3Rhci1vdmVycmlkZS5zaCBcCit0L3Rhci1zcGxpdC1jbWQuc2ggXAogdC90YXJn ZXQtY2ZsYWdzLnNoIFwKIHQvdGFyZ2V0Y2xhc2guc2ggXAogdC90ZXN0cy1lbnZpcm9ubWVu dC1mZC1yZWRpcmVjdC5zaCBcCmRpZmYgLS1naXQgYS90L3Rhci1zcGxpdC1jbWQuc2ggYi90 L3Rhci1zcGxpdC1jbWQuc2gKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw Li5mM2E0M2M4MTEKLS0tIC9kZXYvbnVsbAorKysgYi90L3Rhci1zcGxpdC1jbWQuc2gKQEAg LTAsMCArMSw2MiBAQAorIyEgL2Jpbi9zaAorIyBDb3B5cmlnaHQgKEMpIDIwMDQtMjAyMiBG cmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKyMKKyMgVGhpcyBwcm9ncmFtIGlzIGZy ZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKKyMg aXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBh cyBwdWJsaXNoZWQgYnkKKyMgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVy IHZlcnNpb24gMiwgb3IgKGF0IHlvdXIgb3B0aW9uKQorIyBhbnkgbGF0ZXIgdmVyc2lvbi4K KyMKKyMgVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQg d2lsbCBiZSB1c2VmdWwsCisjIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBl dmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisjIE1FUkNIQU5UQUJJTElUWSBvciBGSVRO RVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKKyMgR05VIEdlbmVyYWwg UHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKyMKKyMgWW91IHNob3VsZCBoYXZl IHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKyMg YWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cHM6Ly93d3cuZ251 Lm9yZy9saWNlbnNlcy8+LgorCisjIENoZWNrIGlmIGZhaWxpbmcgJ3RhcicgaXMgbm90IHNp bGVuY2VkIGFuZCBmYWlscyB0aGUgYnVpbGQuCisKKy4gdGVzdC1pbml0LnNoCisKK3Zlcj0x LjAKKworY2F0ID4gY29uZmlndXJlLmFjIDw8RU5EQ09ORgorQUNfSU5JVChbJG1lXSwgWyR2 ZXJdKQorQU1fSU5JVF9BVVRPTUFLRSgpCitBQ19DT05GSUdfRklMRVMoW01ha2VmaWxlXSkK K0FDX09VVFBVVAorRU5EQ09ORgorCitmbmFtZT1taXNzLW9iajAxMjM0NTY3ODkwMTIzNDU2 Nzg5MDEyMzQ1Njc4OTAxMjM0NTY3ODkwMTIzNDU2Nzg5MDEyMzQ1Njc4OTAxMjM0NTY3ODkw MTIzNDU2Nzg5MDEyMzQ1Njc4OTAxMjM0NTY3ODkwMTIzNDU2Nzg5Cit0b3VjaCAkZm5hbWUK KyNscyAtbCAjIGRlYnVnCisKK2NhdCA+IE1ha2VmaWxlLmFtIDw8RU5ETUFLRQorRVhUUkFf RElTVD0kZm5hbWUKK0VORE1BS0UKKworJEFDTE9DQUwKKyRBVVRPQ09ORgorJEFVVE9NQUtF CisuL2NvbmZpZ3VyZQorCitybSAtZiAkbWUtJHZlci50YXIqCisKKyMgZXhwZWN0ZWQgdG8g ZmFpbDoKKyRNQUtFIGRpc3QtZ3ppcCAyPiYxIHx8IHRydWUKKyNscyAtbCAjIGRlYnVnCit0 ZXN0ICEgLWUgJG1lLSR2ZXIudGFyLmd6IHx8IGV4aXQgMQorCiskTUFLRSBkaXN0LWJ6aXAy IDI+JjEgfHwgdHJ1ZQordGVzdCAhIC1lICRtZS0kdmVyLnRhci5iejIgfHwgZXhpdCAyCisK KyRNQUtFIGRpc3QtbHppcCAyPiYxIHx8IHRydWUKK3Rlc3QgISAtZSAkbWUtJHZlci50YXIu bHogfHwgZXhpdCAzCisKKyRNQUtFIGRpc3QteHogMj4mMSB8fCB0cnVlCit0ZXN0ICEgLWUg JG1lLSR2ZXIudGFyLnh6IHx8IGV4aXQgNAorCiskTUFLRSBkaXN0LXpzdGQgMj4mMSB8fCB0 cnVlCit0ZXN0ICEgLWUgJG1lLSR2ZXIudGFyLnpzdCB8fCBleGl0IDUKKworOgotLSAKMi4z NS4xCgo= --------------Z9P2aoRYg0wA9oF7VIsHe2Fm-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 21:23:02 2023 Received: (at submit) by debbugs.gnu.org; 18 Jul 2023 01:23:02 +0000 Received: from localhost ([127.0.0.1]:51251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLZQb-0006s3-Fo for submit@debbugs.gnu.org; Mon, 17 Jul 2023 21:23:02 -0400 Received: from lists.gnu.org ([2001:470:142::17]:43884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLZQV-0006re-Vo for submit@debbugs.gnu.org; Mon, 17 Jul 2023 21:22:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLZQP-0007Dr-JW for automake-patches@gnu.org; Mon, 17 Jul 2023 21:22:49 -0400 Received: from frenzy.freefriends.org ([198.99.81.75] helo=freefriends.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLZQM-0004aP-Ev for automake-patches@gnu.org; Mon, 17 Jul 2023 21:22:48 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 36I1MdWO012565 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jul 2023 19:22:39 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 36I1MdKM012564; Mon, 17 Jul 2023 19:22:39 -0600 Date: Mon, 17 Jul 2023 19:22:39 -0600 Message-Id: <202307180122.36I1MdKM012564@freefriends.org> From: Karl Berry To: bogdro_rep@gmx.us, jimis@gmx.net Subject: Re: bug#19614: Split packaging invocation to catch errors In-Reply-To: <2f50f549-4b2d-10cb-2c37-e06de7676773@gmx.us> Received-SPF: pass client-ip=198.99.81.75; envelope-from=karl@freefriends.org; helo=freefriends.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit Cc: automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dimitrios, Bogdan - back on this bug from 2015 (sorry): https://debbugs.gnu.org/cgi/bugreport.cgi?bug=19614 Bogdan sent a patch that splits the tar and compress into separate invocations. It seems basically good to me, but the dist-formats test fails because it builds multiple archive formats (.tar.gz, .tar.bz2, etc.) in parallel, and so removing $(distdir).tar (and .err) files are subject to a race condition. So my question is, will it suffice in this limited case to just put $$ into the filenames? It seems like it should be ok to me, but I'm not sure I have enough imagination to know why that would fail. I can't see figuring out how to run mktemp here. Advice please? --thanks, karl. P.S. I also made small changes to the patch 1) to use a ".tarerr" file instead of just ".tar" to save stderr, since I think ".err" might already be in use by some packages, and 2) remove the .tar and .tarerr in the event of success, else make distclean leaves them behind. Here's the diff I've currently got for distdir.am. diff --git a/lib/am/distdir.am b/lib/am/distdir.am index 264713c33..62a781be6 100644 --- a/lib/am/distdir.am +++ b/lib/am/distdir.am @@ -33,7 +33,11 @@ am__remove_distdir = \ ## See automake bug#10470. || { sleep 5 && rm -rf "$(distdir)"; }; \ else :; fi -am__post_remove_distdir = $(am__remove_distdir) +## We now generate and compress the tar file in separate commands, +## and also save stderr, all to detect errors from tar. Clean up. +am__post_remove_distdir = \ + rm -f $(distdir).tar $(distdir).tarerr \ + && $(am__remove_distdir) endif %?TOPDIR_P% if %?SUBDIRS% @@ -334,31 +338,56 @@ if %?TOPDIR_P% GZIP_ENV = --best .PHONY: dist-gzip dist-gzip: distdir - tardir=$(distdir) && $(am__tar) | eval GZIP= gzip $(GZIP_ENV) -c >$(distdir).tar.gz + tardir=$(distdir) && $(am__tar) > $(distdir).tar 2>$(distdir).tarerr + test ! -s $(distdir).tarerr || (cat $(distdir).tarerr && \ + rm -rf $(DIST_ARCHIVES) $(distdir).tar $(distdir).tarerr && \ + $(am__post_remove_distdir) && \ + exit 1) + eval GZIP= gzip $(GZIP_ENV) $(distdir).tar -c >$(distdir).tar.gz $(am__post_remove_distdir) ?BZIP2?DIST_ARCHIVES += $(distdir).tar.bz2 .PHONY: dist-bzip2 dist-bzip2: distdir - tardir=$(distdir) && $(am__tar) | BZIP2=$${BZIP2--9} bzip2 -c >$(distdir).tar.bz2 + tardir=$(distdir) && $(am__tar) > $(distdir).tar 2>$(distdir).tarerr + test ! -s $(distdir).tarerr || (cat $(distdir).tarerr && \ + rm -rf $(DIST_ARCHIVES) $(distdir).tar $(distdir).tarerr && \ + $(am__post_remove_distdir) && \ + exit 1) + BZIP2=$${BZIP2--9} bzip2 -c $(distdir).tar >$(distdir).tar.bz2 $(am__post_remove_distdir) ?LZIP?DIST_ARCHIVES += $(distdir).tar.lz .PHONY: dist-lzip dist-lzip: distdir - tardir=$(distdir) && $(am__tar) | lzip -c $${LZIP_OPT--9} >$(distdir).tar.lz + tardir=$(distdir) && $(am__tar) > $(distdir).tar 2>$(distdir).tarerr + test ! -s $(distdir).tarerr || (cat $(distdir).tarerr && \ + rm -rf $(DIST_ARCHIVES) $(distdir).tar $(distdir).tarerr && \ + $(am__post_remove_distdir) && \ + exit 1) + lzip -c $${LZIP_OPT--9} $(distdir).tar >$(distdir).tar.lz $(am__post_remove_distdir) ?XZ?DIST_ARCHIVES += $(distdir).tar.xz .PHONY: dist-xz dist-xz: distdir - tardir=$(distdir) && $(am__tar) | XZ_OPT=$${XZ_OPT--e} xz -c >$(distdir).tar.xz + tardir=$(distdir) && $(am__tar) > $(distdir).tar 2>$(distdir).tarerr + test ! -s $(distdir).tarerr || (cat $(distdir).tarerr && \ + rm -rf $(DIST_ARCHIVES) $(distdir).tar $(distdir).tarerr && \ + $(am__post_remove_distdir) && \ + exit 1) + XZ_OPT=$${XZ_OPT--e} xz -c $(distdir).tar >$(distdir).tar.xz $(am__post_remove_distdir) ?ZSTD?DIST_ARCHIVES += $(distdir).tar.zst .PHONY: dist-zstd dist-zstd: distdir - tardir=$(distdir) && $(am__tar) | zstd -c $${ZSTD_CLEVEL-$${ZSTD_OPT--19}} >$(distdir).tar.zst + tardir=$(distdir) && $(am__tar) > $(distdir).tar 2>$(distdir).tarerr + test ! -s $(distdir).tarerr || (cat $(distdir).tarerr && \ + rm -rf $(DIST_ARCHIVES) $(distdir).tar $(distdir).tarerr && \ + $(am__post_remove_distdir) && \ + exit 1) + zstd -c $${ZSTD_CLEVEL-$${ZSTD_OPT--19}} $(distdir).tar >$(distdir).tar.zst $(am__post_remove_distdir) ?COMPRESS?DIST_ARCHIVES += $(distdir).tar.Z @@ -367,7 +396,12 @@ dist-tarZ: distdir @echo WARNING: "Support for distribution archives compressed with" \ "legacy program 'compress' is deprecated." >&2 @echo WARNING: "It will be removed altogether in Automake 2.0" >&2 - tardir=$(distdir) && $(am__tar) | compress -c >$(distdir).tar.Z + tardir=$(distdir) && $(am__tar) > $(distdir).tar 2>$(distdir).tarerr + test ! -s $(distdir).tarerr || (cat $(distdir).tarerr && \ + rm -rf $(DIST_ARCHIVES) $(distdir).tar $(distdir).tarerr && \ + $(am__post_remove_distdir) && \ + exit 1) + compress -c $(distdir).tar >$(distdir).tar.Z $(am__post_remove_distdir) ?SHAR?DIST_ARCHIVES += $(distdir).shar.gz From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 02:56:11 2023 Received: (at submit) by debbugs.gnu.org; 18 Jul 2023 06:56:11 +0000 Received: from localhost ([127.0.0.1]:51396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLed0-0007kU-VY for submit@debbugs.gnu.org; Tue, 18 Jul 2023 02:56:11 -0400 Received: from lists.gnu.org ([2001:470:142::17]:52440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLecw-0007jx-Bk for submit@debbugs.gnu.org; Tue, 18 Jul 2023 02:56:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLecp-00061I-F8 for automake-patches@gnu.org; Tue, 18 Jul 2023 02:56:01 -0400 Received: from mail-vs1-xe2e.google.com ([2607:f8b0:4864:20::e2e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLecm-0004sd-4E for automake-patches@gnu.org; Tue, 18 Jul 2023 02:55:58 -0400 Received: by mail-vs1-xe2e.google.com with SMTP id ada2fe7eead31-440b66adc81so1605617137.1 for ; Mon, 17 Jul 2023 23:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=draconx-ca.20221208.gappssmtp.com; s=20221208; t=1689663354; x=1692255354; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=I1uJLqRTMjpURQtu3E+nu3xv2CbRFpG3sjJjgFhqZe4=; b=x2nrw6phOvvzzUabZNB1yi3XcJFleJpTH7in4VhjdQDQ3DlPR/OseY2BeATApx4aOO ThJrlh+L2egKmqBcl002KkvgkuCQay2qUa9BCEq3c9DD1Ugl5iyIGCxFGuJQXOjy8HdT hrAdy+lGNV0y/p/au4e0rLHmZgvJnyJ4jZyTw/7s2fz+b1gExAF2/1h47WjMtY877R+w srG71fX6qG+xR09Yc3e2V80AhDxWy487oA40JMhzenRRHK6hDrPzsc8GwrVAr8wVqEkf nA7C+FdTF8LKLLkX6WMGWXUCePzgmUIALJ8VaXOntj52Sb+UvX/a2zaGucWr1GUjwTeY mAKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689663354; x=1692255354; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I1uJLqRTMjpURQtu3E+nu3xv2CbRFpG3sjJjgFhqZe4=; b=LyA1bIh3Qb/povNuT7QRw5AckJ9k/kPhlE1uAEH8k7larNpz4ygEXiXLVurflnwtKx jHW42s+pJSgfCIRNd7RosL7QsiBeRjt9ID+BdbBRm4tg56oyOg1tbCmUs8a9sFVaAZky iePkmZrceBsOft0w6PJg8TX+8bdOCRlTnMUyOymEBvJnMH46jkbMy1yIXMfpcdFgcj2f 85DtxMSMbwckFk0SU5QfRmrOHp807fZXRXdHeLLOA5hJL+jQqOX8TQ7/SFxExbzbd7iT PF4EEAc8GBsYhe7e4lnkE9/Y2NMb+6Wqy7iInQzusoLnrBQyLOjhXUGEcZXqMpbK75GF YEBQ== X-Gm-Message-State: ABy/qLb2m2u6TR7iuntPDzi9eEUll+oK9jIqx+ErsGv20TfkfhPR2xg8 3S5Nd1a/NAhA+1PhllXmJP1lFX1SkXgGnnstBi174Q== X-Google-Smtp-Source: APBJJlH5mkI9Q9ZbcCap+WO4Pdrojv4bizhCQ5S750xFW1lJwOeuRTR5XCh5t5r0lHU8tiPcI6yDUSVklXWoskYqNMc= X-Received: by 2002:a67:fc41:0:b0:443:8549:163e with SMTP id p1-20020a67fc41000000b004438549163emr6640849vsq.34.1689663353727; Mon, 17 Jul 2023 23:55:53 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ab0:6597:0:b0:794:1113:bb24 with HTTP; Mon, 17 Jul 2023 23:55:53 -0700 (PDT) X-Originating-IP: [24.53.241.2] In-Reply-To: <202307180122.36I1MdKM012564@freefriends.org> References: <2f50f549-4b2d-10cb-2c37-e06de7676773@gmx.us> <202307180122.36I1MdKM012564@freefriends.org> From: Nick Bowler Date: Tue, 18 Jul 2023 02:55:53 -0400 Message-ID: Subject: Re: bug#19614: Split packaging invocation to catch errors To: Karl Berry Content-Type: text/plain; charset="UTF-8" Received-SPF: none client-ip=2607:f8b0:4864:20::e2e; envelope-from=nbowler@draconx.ca; helo=mail-vs1-xe2e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit Cc: jimis@gmx.net, bogdro_rep@gmx.us, automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2023-07-17, Karl Berry wrote: > Hi Dimitrios, Bogdan - back on this bug from 2015 (sorry): > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=19614 > > Bogdan sent a patch that splits the tar and compress into separate > invocations. It seems basically good to me, but the dist-formats test > fails because it builds multiple archive formats (.tar.gz, .tar.bz2, > etc.) in parallel, and so removing $(distdir).tar (and .err) files are > subject to a race condition. > dist-gzip: distdir > - tardir=$(distdir) && $(am__tar) | eval GZIP= gzip $(GZIP_ENV) -c >>$(distdir).tar.gz > + tardir=$(distdir) && $(am__tar) > $(distdir).tar 2>$(distdir).tarerr > > So my question is, will it suffice in this limited case to just put $$ > into the filenames? It seems like it should be ok to me, but I'm not > sure I have enough imagination to know why that would fail. I can't see > figuring out how to run mktemp here. With the tar file generation as a separate command, it should be straightforward to avoid this problem by just moving the tar generation and error checking commands into a separate rule. Then changing all the various dist-xyz commands to depend on that instead of distdir. Example: $(distdir).tar: distdir commands to tar it dist-gzip: $(distdir).tar commands to gzip it and so on. Then there should be no race with parallel "make dist" as the tar file will only be generated once. Additional context/suggestion (not directly relevant to this bug report): Note that "make dist" (parallel or othewrise) with multiple compressors enabled only works because "make dist" itself does a recursive make invocation and overrides am__post_remove_distdir. Otherwise the cleanup commands would conflict too. It's quite hacky, and as a result it currently doesn't work to explicitly call multiple dist targets in a single make invocation, e.g., make dist-zip dist-gzip # fails Using a separate rule to generate the tar file should let us fix this problem pretty easily too, should just be a matter of: - do not add "rm -f $(distdir).tar" to am__post_remove_distdir - arrange for make dist and make clean to delete $(distdir).tar - add the rule .INTERMEDIATE: $(distdir).tar The last item instructs GNU make to delete the temporary tar file in normal cases once all the rules that depend on it have been run. Explicit deletion in "make dist" and "make clean" is then mostly for the benefit of other implementations. On other makes, the tar file will be left behind in some cases (e.g., if the user runs make dist-zip). This makes a change from current behaviour but probably not a real problem. Cheers, Nick From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 15:27:21 2023 Received: (at submit) by debbugs.gnu.org; 18 Jul 2023 19:27:21 +0000 Received: from localhost ([127.0.0.1]:54328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLqLw-0000Dd-Ar for submit@debbugs.gnu.org; Tue, 18 Jul 2023 15:27:21 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLqLr-0000DM-Rc for submit@debbugs.gnu.org; Tue, 18 Jul 2023 15:27:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLqLi-00046M-Pj for automake-patches@gnu.org; Tue, 18 Jul 2023 15:27:06 -0400 Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLqLd-0006Wz-28 for automake-patches@gnu.org; Tue, 18 Jul 2023 15:27:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.us; s=s31663417; t=1689708409; x=1690313209; i=bogdro_rep@gmx.us; bh=T3DWULRtjuAaTeu6D4doJ9NEofxOgwLXlIEky5OPrA8=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=L7moKRfW4pzXsplMgGnq2w78nKbq4vUIMfXWDCQsPwmFJxVP6fMgnCHSXYg1PNE/Cx5x2Gc uSq3evq23EJYp3ID++alI9ispsfSZU5O6sT3AsucE6C95iQDfvlv6P1nWMUQHSH6exFPvoUt7 wRqqNXtoZ814RR/vJQP+2JrJqJyIfb+II1fdmQGfBIa7Dkznothimjd0yQeV1lB4xdysUmpeY 5X6U/lyeuGX9gYVJHFA2728Mp8jIMnF01TRMZHgG2Pz2mhrCunezxpstJ1ldFWQ3lIrejV/jF 6f2W9fQfhaxqARW8hav6FNVrs38Q788YB0aiQqejxgJ6Fza7pftA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.0.245] ([89.64.101.248]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MulqN-1q3lCE1Tox-00rqz9; Tue, 18 Jul 2023 21:26:49 +0200 Message-ID: <686fd277-d386-04a6-0f57-8a810f38f399@gmx.us> Date: Tue, 18 Jul 2023 21:26:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#19614: Split packaging invocation to catch errors Content-Language: en-GB To: Nick Bowler , Karl Berry References: <2f50f549-4b2d-10cb-2c37-e06de7676773@gmx.us> <202307180122.36I1MdKM012564@freefriends.org> From: Bogdan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:P656diaPiB4Lc9mnn8IlMtrOyZcknUlwOKv8ljqleHLUrm2x+tT sO5CnfTDfCQDCu6g/fZVK2MuYALsVNjse1rOgZEyYFE38ZJ0h5rNT4KE4tlIZUC6gcLzq+6 4+0400gEymuBlVDuwK8rIeS6trGR3d7hHSY6ZgMLaNf1myi6lNz8kFWaa/+6C0c1qekPdZQ Kfp63yN/F8uoqsN4zDOiw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:qHoyvXUVNsc=;KivyFFpF2MS5OLwfHRoGQ4XaVd1 IQRXyhNDHYeKx9ja+zBpmeMOpv/NrA//r7/x0y4vF+RstPhSZobTkgB5FN0EOmLbKScnIyf2d Cmi9llrPuYyBbEe0k7yNYjzDMzZQkXCStAm6RUhGJzLHlQOYcUz5RCQ5WEfGhYm1xZGiQInfv BsOlhNa8BBt3sC2uZ78my9Q5R/p5H0vDJi0RNOMBnjnbef3P54M8U8CXiazbGzZgZD4X3lq10 chtVXccb0J0+65HuO7Pwy1/5He/3yHdL95LQGeubgh9EN6vuNmbYCcpy01HxWzVoULDObZ/9i BndEcrEE8PFRNv14OgBDXHu7p2xKt9cQwaWfJNc9US7wUl/kNWmqZreafcy7OkQoPL9ESkctI t1MSOy7gdPG9Kpg0PXQG2nSIeMT3IuV5+tUS3nPtgCydT/KW1FhnLMtc/HQ4ZwkkmUueIEJ6S IXriV9u/5gd2KZe0guBaKqG8OfHKNy8QEhqDOH29uidIhFOKCX+frP5EFhATdzBQSKNJcAt2K vmvTGPO8oozn/UtuuglGY0+0J/VIJJ49NdCRsMz67MRXsep7soJxeP/DKOR//B7TOALLLKerb Q6Em8Dqf6F7RvQgVUEuN7aKGkF5hXUKZflRh0kIHdTK0qaOvRwdlnQTtz+NoBfTNR1koKiNkE OfqKNiOvjx9PKiuFIuV163RMZknxH6h8Bi3HlwBKC8uoWvpl8+rjO61qGukvzQwwfPOautzh8 TahJ5Zb/zTlrTNKDvIyq/nXOYzstqtytddzCuPX7CPmcZEDR9Wz1aAJBOi/glMOrX+qLxsaq5 YJninL1Ki3DDxZWdaZfj/IqX7Ij3hMEB5boOyKd50ipjOGFulEL5TRLRbCZsds7fIH7wlWowb ogTdcf1T/8nuBf+Xt/jDNvunjw1XPP7dPBiFJD1KDrrGgPE/6pD1feFZjFsBcWFXyrGtSnEIv /FUSFoGdnzFAl6cWGAAorlwzJqo= Received-SPF: pass client-ip=212.227.17.21; envelope-from=bogdro_rep@gmx.us; helo=mout.gmx.net X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.095, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: jimis@gmx.net, automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Nick Bowler , Tue Jul 18 2023 08:55:53 GMT+0200 (Central European Summer Time) > On 2023-07-17, Karl Berry wrote: >> Hi Dimitrios, Bogdan - back on this bug from 2015 (sorry): >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19614 >> >> Bogdan sent a patch that splits the tar and compress into separate >> invocations. It seems basically good to me, but the dist-formats test >> fails because it builds multiple archive formats (.tar.gz, .tar.bz2, >> etc.) in parallel, and so removing $(distdir).tar (and .err) files are >> subject to a race condition. > >> dist-gzip: distdir >> - tardir=3D$(distdir) && $(am__tar) | eval GZIP=3D gzip $(GZIP_ENV) -c >>> $(distdir).tar.gz >> + tardir=3D$(distdir) && $(am__tar) > $(distdir).tar 2>$(distdir).tarer= r >> >> So my question is, will it suffice in this limited case to just put $$ >> into the filenames? It seems like it should be ok to me, but I'm not >> sure I have enough imagination to know why that would fail. I can't see >> figuring out how to run mktemp here. > > With the tar file generation as a separate command, it should be > straightforward to avoid this problem by just moving the tar generation > and error checking commands into a separate rule. Then changing all the > various dist-xyz commands to depend on that instead of distdir. Example= : > > $(distdir).tar: distdir > commands to tar it > > dist-gzip: $(distdir).tar > commands to gzip it > > and so on. Then there should be no race with parallel "make dist" as > the tar file will only be generated once. Probably a better idea than mine, e.g. tmpname=3D`mktemp $(distdir)/dist.XXXXXX` tardir=3D$(distdir) && $(am__tar) > $(tmpname).tar 2>$(distdir).err or tardir=3D$(distdir) && $(am__tar) > $(distdir)-$RANDOM.tar 2>$(distdir).er= r [...] =2D- Regards - Bogdan ('bogdro') D. (GNU/Linux & FreeDOS) X86 assembly (DOS, GNU/Linux): http://bogdro.evai.pl/index-en.php Soft(EN): http://bogdro.evai.pl/soft http://bogdro.evai.pl/soft4asm www.Xiph.org www.TorProject.org www.LibreOffice.org www.GnuPG.org From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 16:51:36 2023 Received: (at submit) by debbugs.gnu.org; 18 Jul 2023 20:51:36 +0000 Received: from localhost ([127.0.0.1]:54438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLrfU-00050A-2G for submit@debbugs.gnu.org; Tue, 18 Jul 2023 16:51:36 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLrfS-0004zy-Gz for submit@debbugs.gnu.org; Tue, 18 Jul 2023 16:51:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLrfN-0007Xu-8k for automake-patches@gnu.org; Tue, 18 Jul 2023 16:51:29 -0400 Received: from frenzy.freefriends.org ([198.99.81.75] helo=freefriends.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLrfL-0001YT-DU for automake-patches@gnu.org; Tue, 18 Jul 2023 16:51:29 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 36IKpKDW025002 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jul 2023 14:51:20 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 36IKpJxT025001; Tue, 18 Jul 2023 14:51:19 -0600 Date: Tue, 18 Jul 2023 14:51:19 -0600 Message-Id: <202307182051.36IKpJxT025001@freefriends.org> From: Karl Berry To: bogdro_rep@gmx.us Subject: Re: bug#19614: Split packaging invocation to catch errors In-Reply-To: <686fd277-d386-04a6-0f57-8a810f38f399@gmx.us> Received-SPF: pass client-ip=198.99.81.75; envelope-from=karl@freefriends.org; helo=freefriends.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit Cc: nbowler@draconx.ca, jimis@gmx.net, automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tmpname=`mktemp $(distdir)/dist.XXXXXX` I don't think we can safely assume mktemp in automake rules. tardir=$(distdir) && $(am__tar) > $(distdir)-$RANDOM.tar 2>$(distdir).err That was my idea ($$ instead of $RANDOM). Certainly simple, but I agree Nick's idea is cleaner: > straightforward to avoid this problem by just moving the tar generation > and error checking commands into a separate rule. Good thought, Nick. Bogdan (or Nick or anyone), maybe you'd be up for trying to redo the patch along those lines? Due to other commitments, it will be some time before I can get back to actually factoring out the code, rerunning all the tests, fixing the inevitable bugs, repeat ... --thanks, karl.