From unknown Wed Jun 18 23:08:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19613 <19613@debbugs.gnu.org> To: bug#19613 <19613@debbugs.gnu.org> Subject: Status: 25.0.50; cl-labels bug Reply-To: bug#19613 <19613@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:08:20 +0000 retitle 19613 25.0.50; cl-labels bug reassign 19613 emacs submitter 19613 Katsumi Yamaoka severity 19613 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 16 00:19:33 2015 Received: (at submit) by debbugs.gnu.org; 16 Jan 2015 05:19:33 +0000 Received: from localhost ([127.0.0.1]:58348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBzJl-0006qw-De for submit@debbugs.gnu.org; Fri, 16 Jan 2015 00:19:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48879) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBzJk-0006ql-35 for submit@debbugs.gnu.org; Fri, 16 Jan 2015 00:19:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBzJe-0002RO-1T for submit@debbugs.gnu.org; Fri, 16 Jan 2015 00:19:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBzJd-0002RK-VB for submit@debbugs.gnu.org; Fri, 16 Jan 2015 00:19:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBzJd-0008DN-3D for bug-gnu-emacs@gnu.org; Fri, 16 Jan 2015 00:19:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBzJZ-0002Qv-TB for bug-gnu-emacs@gnu.org; Fri, 16 Jan 2015 00:19:25 -0500 Received: from mail-halifax.hostforweb.net ([205.234.137.17]:51671 helo=halifax.hostforweb.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBzJZ-0002Po-P4 for bug-gnu-emacs@gnu.org; Fri, 16 Jan 2015 00:19:21 -0500 Received: from [127.0.0.1] (port=57286 helo=localhost) by halifax.hostforweb.net with smtp (Exim 4.82) (envelope-from ) id 1YBzJU-0007Fn-Nx; Thu, 15 Jan 2015 23:19:17 -0600 Date: Fri, 16 Jan 2015 14:19:11 +0900 Message-ID: From: Katsumi Yamaoka To: bug-gnu-emacs@gnu.org Subject: 25.0.50; cl-labels bug Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?iso-2022-jp?B?GyRCPz8bKEI=?= Gnus v0.12) Emacs/25.0.50 (i686-pc-cygwin) Cancel-Lock: sha1:LQPoT6XBf35kktFTjGAV1pghIno= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - halifax.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: halifax.hostforweb.net: acl_c_authenticated_local_user: yamaokac X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (barebone) [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, This form got not to work recently: (cl-labels ((fn (arg) arg)) (apply #'fn (list "arg"))) It is because `fn' is not substituted with the one CL defines: (let (--cl-fn--) (setq --cl-fn-- #'(lambda (arg) arg)) (apply #'fn (list "arg"))) Thanks. In GNU Emacs 25.0.50.1 (i686-pc-cygwin, GTK+ Version 3.10.9) of 2015-01-16 on localhost Windowing system distributor `The Cygwin/X Project', version 11.0.11501000 Configured using: `configure --verbose --with-x-toolkit=gtk3' From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 16 09:50:08 2015 Received: (at 19613) by debbugs.gnu.org; 16 Jan 2015 14:50:08 +0000 Received: from localhost ([127.0.0.1]:58675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YC8Dv-0005bL-Kz for submit@debbugs.gnu.org; Fri, 16 Jan 2015 09:50:08 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:59676) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YC8Dt-0005bB-AE for 19613@debbugs.gnu.org; Fri, 16 Jan 2015 09:50:06 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t0GEo3Kf003411; Fri, 16 Jan 2015 09:50:03 -0500 Received: by pastel.home (Postfix, from userid 20848) id 60D1890C; Fri, 16 Jan 2015 09:50:03 -0500 (EST) From: Stefan Monnier To: Katsumi Yamaoka Subject: Re: bug#19613: 25.0.50; cl-labels bug Message-ID: References: Date: Fri, 16 Jan 2015 09:50:03 -0500 In-Reply-To: (Katsumi Yamaoka's message of "Fri, 16 Jan 2015 14:19:11 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5188=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5188> : inlines <1783> : streams <1374363> : uri <1842617> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19613 Cc: 19613@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > This form got not to work recently: > (cl-labels ((fn (arg) arg)) > (apply #'fn (list "arg"))) > It is because `fn' is not substituted with the one CL defines: > (let (--cl-fn--) > (setq --cl-fn-- #'(lambda (arg) arg)) > (apply #'fn (list "arg"))) I believe this was fixed yesterday, even before you filed the bug. Could you double check? Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 16 15:09:33 2015 Received: (at 19613) by debbugs.gnu.org; 16 Jan 2015 20:09:33 +0000 Received: from localhost ([127.0.0.1]:59547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YCDD2-00075z-Jk for submit@debbugs.gnu.org; Fri, 16 Jan 2015 15:09:32 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:52106 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YCDCz-00075r-SI for 19613@debbugs.gnu.org; Fri, 16 Jan 2015 15:09:30 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YCDCz-000611-0x; Fri, 16 Jan 2015 15:09:29 -0500 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#19613: 25.0.50; cl-labels bug References: X-Spook: SCUD missile ARPA Montenegro Ron Brown ISEC Medco X-Ran: j80Ua-!G,KJ15E}16!zk/(GROi\hcaLK:)#qk@IforK?ipryhCv{0v0R/M"hm#uo~JIZb3 X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 16 Jan 2015 15:09:28 -0500 In-Reply-To: (Stefan Monnier's message of "Fri, 16 Jan 2015 09:50:03 -0500") Message-ID: <7h4mrqmqrr.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 19613 Cc: Katsumi Yamaoka , 19613@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Stefan Monnier wrote: > I believe this was fixed yesterday, even before you filed the bug. > Could you double check? No, it still fails. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 16 22:57:36 2015 Received: (at 19613-done) by debbugs.gnu.org; 17 Jan 2015 03:57:36 +0000 Received: from localhost ([127.0.0.1]:59611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YCKW0-0005yD-2X for submit@debbugs.gnu.org; Fri, 16 Jan 2015 22:57:36 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:39178) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YCKVx-0005x1-DU for 19613-done@debbugs.gnu.org; Fri, 16 Jan 2015 22:57:34 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aj8PAOwQflS4rwoL/2dsb2JhbABbgweDYIVawjuCYgQCAoEkFwEBAQEBAXyEAwEBAwFWIxALDiYSFBgNJIhKCdZZAQEBAQEBBAEBAQEBHZBvB4RIBYsBpC6BeIQZIYJ3AQEB X-IPAS-Result: Aj8PAOwQflS4rwoL/2dsb2JhbABbgweDYIVawjuCYgQCAoEkFwEBAQEBAXyEAwEBAwFWIxALDiYSFBgNJIhKCdZZAQEBAQEBBAEBAQEBHZBvB4RIBYsBpC6BeIQZIYJ3AQEB X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="108034370" Received: from 184-175-10-11.dsl.teksavvy.com (HELO pastel.home) ([184.175.10.11]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 16 Jan 2015 22:57:27 -0500 Received: by pastel.home (Postfix, from userid 20848) id 6C9E8260B; Fri, 16 Jan 2015 22:57:27 -0500 (EST) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#19613: 25.0.50; cl-labels bug Message-ID: References: <7h4mrqmqrr.fsf@fencepost.gnu.org> Date: Fri, 16 Jan 2015 22:57:27 -0500 In-Reply-To: <7h4mrqmqrr.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 16 Jan 2015 15:09:28 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19613-done Cc: 19613-done@debbugs.gnu.org, Katsumi Yamaoka X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> I believe this was fixed yesterday, even before you filed the bug. >> Could you double check? > No, it still fails. I believe this time it is fixed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 22 02:07:29 2015 Received: (at 19613) by debbugs.gnu.org; 22 Jan 2015 07:07:29 +0000 Received: from localhost ([127.0.0.1]:52265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEBrV-0002cO-D2 for submit@debbugs.gnu.org; Thu, 22 Jan 2015 02:07:29 -0500 Received: from memphis-mail.hostforweb.net ([216.246.47.48]:57335 helo=memphis.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEBrT-0002cB-Fg for 19613@debbugs.gnu.org; Thu, 22 Jan 2015 02:07:28 -0500 Received: from localhost ([127.0.0.1]:58520) by memphis.hostforweb.net with smtp (Exim 4.84) (envelope-from ) id 1YEBrN-002Edx-F0; Thu, 22 Jan 2015 01:07:21 -0600 Date: Thu, 22 Jan 2015 16:07:17 +0900 Message-ID: From: Katsumi Yamaoka To: 19613@debbugs.gnu.org Subject: Re: bug#19613: 25.0.50; cl-labels bug References: <7h4mrqmqrr.fsf@fencepost.gnu.org> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?iso-2022-jp?B?GyRCPz8bKEI=?= Gnus v0.12) Emacs/25.0.50 (i686-pc-cygwin) Cancel-Lock: sha1:b4XSsBuZz907v7g6gQ5hDPt7Xck= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - memphis.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: memphis.hostforweb.net: acl_c_authenticated_local_user: yamaokac X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19613 Cc: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Fri, 16 Jan 2015 22:57:27 -0500, Stefan Monnier wrote: > I believe this time it is fixed, I have still a problem with `cl-labels' used within `lexical-let'. (lexical-let (var) (cl-labels ((fn (arg) arg)) (apply #'fn (list "arg")))) => apply: Symbol's function definition is void: fn Emacs-w3m uses this kind of macros. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 26 00:57:57 2015 Received: (at 19613) by debbugs.gnu.org; 26 Jan 2015 05:57:57 +0000 Received: from localhost ([127.0.0.1]:56464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFcgP-0007z2-6Z for submit@debbugs.gnu.org; Mon, 26 Jan 2015 00:57:57 -0500 Received: from memphis-mail.hostforweb.net ([216.246.47.48]:58845 helo=memphis.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFcgM-0007yn-7P for 19613@debbugs.gnu.org; Mon, 26 Jan 2015 00:57:54 -0500 Received: from localhost ([127.0.0.1]:37929) by memphis.hostforweb.net with smtp (Exim 4.84) (envelope-from ) id 1YFcgG-001E68-4o for 19613@debbugs.gnu.org; Sun, 25 Jan 2015 23:57:48 -0600 Date: Mon, 26 Jan 2015 14:57:49 +0900 Message-ID: From: Katsumi Yamaoka To: 19613@debbugs.gnu.org Subject: Re: bug#19613: 25.0.50; cl-labels bug References: <7h4mrqmqrr.fsf@fencepost.gnu.org> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?iso-2022-jp?B?GyRCPz8bKEI=?= Gnus v0.12) Emacs/25.0.50 (i686-pc-cygwin) Cancel-Lock: sha1:/wdBIO+exo7643rjIA/AhhmzZPU= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - memphis.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: memphis.hostforweb.net: acl_c_authenticated_local_user: yamaokac X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19613 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= On Thu, 22 Jan 2015 16:07:17 +0900, Katsumi Yamaoka wrote: > I have still a problem with `cl-labels' used within `lexical-let'. > (lexical-let (var) > (cl-labels ((fn (arg) arg)) > (apply #'fn (list "arg")))) > => apply: Symbol's function definition is void: fn When a `cl-labels' form is wrapped with `lexical-let', it runs `cl--function-convert' instead of `cl--labels-convert'. So, `cl--function-convert' also needs to be fixed like the ones Stefan did in `cl--labels-convert'[1], doesn't it? I tried the attached patch and verified it fixes not only the `cl-labels' bug but also the `cl-flet' bug[2]. [1] git diff -U 9d940c6 69f36af lisp/emacs-lisp/cl-macs.el [2] (lexical-let (var) (cl-flet ((fn (arg) arg)) (apply #'fn (list "arg")))) => apply: Symbol's function definition is void: fn --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- cl.el~ 2015-01-26 04:16:45.291325300 +0000 +++ cl.el 2015-01-26 05:53:38.810655900 +0000 @@ -374,10 +374,12 @@ (setq cl--function-convert-cache (cons newf res)) res)))) (t - (let ((found (assq f macroexpand-all-environment))) - (if (and found (ignore-errors - (eq (cadr (cl-caddr found)) 'cl-labels-args))) - (cadr (cl-caddr (cl-cadddr found))) + (let* ((found (assq f macroexpand-all-environment)) + (replacement (and found + (ignore-errors + (funcall (cdr found) cl--labels-magic))))) + (if (and replacement (eq cl--labels-magic (car replacement))) + (nth 1 replacement) (let ((res `(function ,f))) (setq cl--function-convert-cache (cons f res)) res)))))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 26 10:15:00 2015 Received: (at 19613) by debbugs.gnu.org; 26 Jan 2015 15:15:00 +0000 Received: from localhost ([127.0.0.1]:57179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFlNU-000626-1l for submit@debbugs.gnu.org; Mon, 26 Jan 2015 10:15:00 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:51231) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFlNR-00061y-Op for 19613@debbugs.gnu.org; Mon, 26 Jan 2015 10:14:58 -0500 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t0QFEurE005473; Mon, 26 Jan 2015 10:14:56 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 3694266135; Mon, 26 Jan 2015 10:14:56 -0500 (EST) From: Stefan Monnier To: Katsumi Yamaoka Subject: Re: bug#19613: 25.0.50; cl-labels bug Message-ID: References: <7h4mrqmqrr.fsf@fencepost.gnu.org> Date: Mon, 26 Jan 2015 10:14:56 -0500 In-Reply-To: (Katsumi Yamaoka's message of "Mon, 26 Jan 2015 14:57:49 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5198=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5198> : inlines <1948> : streams <1379777> : uri <1843897> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19613 Cc: 19613@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > - (let ((found (assq f macroexpand-all-environment))) > - (if (and found (ignore-errors > - (eq (cadr (cl-caddr found)) 'cl-labels-args))) > - (cadr (cl-caddr (cl-cadddr found))) > + (let* ((found (assq f macroexpand-all-environment)) > + (replacement (and found > + (ignore-errors > + (funcall (cdr found) cl--labels-magic))))) > + (if (and replacement (eq cl--labels-magic (car replacement))) > + (nth 1 replacement) > (let ((res `(function ,f))) > (setq cl--function-convert-cache (cons f res)) > res)))))) This looks correct. Ideally this part of cl--function-convert should delegate to cl--labels-convert to avoid the code duplication, tho. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 26 18:01:04 2015 Received: (at 19613) by debbugs.gnu.org; 26 Jan 2015 23:01:04 +0000 Received: from localhost ([127.0.0.1]:57374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFseW-0001Nn-18 for submit@debbugs.gnu.org; Mon, 26 Jan 2015 18:01:04 -0500 Received: from memphis-mail.hostforweb.net ([216.246.47.48]:59665 helo=memphis.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFseT-0001NC-UN for 19613@debbugs.gnu.org; Mon, 26 Jan 2015 18:01:02 -0500 Received: from localhost ([127.0.0.1]:52334) by memphis.hostforweb.net with smtp (Exim 4.84) (envelope-from ) id 1YFseN-0005SE-Su; Mon, 26 Jan 2015 17:00:56 -0600 Date: Tue, 27 Jan 2015 08:00:57 +0900 Message-ID: From: Katsumi Yamaoka To: Stefan Monnier Subject: Re: bug#19613: 25.0.50; cl-labels bug References: <7h4mrqmqrr.fsf@fencepost.gnu.org> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?utf-8?Q?=E7=9C=9F?= Gnus v0.12) Emacs/25.0.50 (i686-pc-cygwin) Cancel-Lock: sha1:lHZkXhWPAIs5dIWW3FyNgNBAV1E= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - memphis.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: memphis.hostforweb.net: acl_c_authenticated_local_user: yamaokac X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19613 Cc: 19613@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= On Mon, 26 Jan 2015 10:14:56 -0500, Stefan Monnier wrote: [...] > This looks correct. Ideally this part of cl--function-convert should > delegate to cl--labels-convert to avoid the code duplication, tho. That's much better. Here it is: --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable --- cl.el~ 2015-01-26 04:16:45.291325300 +0000 +++ cl.el 2015-01-26 22:57:02.040588600 +0000 @@ -342,6 +342,7 @@ - renaming of F when it's a function defined via `cl-labels' or `labels'." (require 'cl-macs) (declare-function cl--expr-contains-any "cl-macs" (x y)) + (declare-function cl--labels-convert "cl-macs" (f)) (cond ;; =C2=A1=C2=A1Big Ugly Hack!! We can't use a compiler-macro because th= ose are checked ;; *after* handling `function', but we want to stop macroexpansion from @@ -374,13 +375,8 @@ (setq cl--function-convert-cache (cons newf res)) res)))) (t - (let ((found (assq f macroexpand-all-environment))) - (if (and found (ignore-errors - (eq (cadr (cl-caddr found)) 'cl-labels-args))) - (cadr (cl-caddr (cl-cadddr found))) - (let ((res `(function ,f))) - (setq cl--function-convert-cache (cons f res)) - res)))))) + (setq cl--labels-convert-cache cl--function-convert-cache) + (cl--labels-convert f)))) =20 (defmacro lexical-let (bindings &rest body) "Like `let', but lexically scoped. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 26 18:25:53 2015 Received: (at 19613) by debbugs.gnu.org; 26 Jan 2015 23:25:53 +0000 Received: from localhost ([127.0.0.1]:57399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFt2X-0001yM-9o for submit@debbugs.gnu.org; Mon, 26 Jan 2015 18:25:53 -0500 Received: from memphis-mail.hostforweb.net ([216.246.47.48]:40128 helo=memphis.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFt2V-0001y2-Bi for 19613@debbugs.gnu.org; Mon, 26 Jan 2015 18:25:51 -0500 Received: from localhost ([127.0.0.1]:60090) by memphis.hostforweb.net with smtp (Exim 4.84) (envelope-from ) id 1YFt2P-000MeA-Q1; Mon, 26 Jan 2015 17:25:46 -0600 Date: Tue, 27 Jan 2015 08:25:49 +0900 Message-ID: From: Katsumi Yamaoka To: Stefan Monnier Subject: Re: bug#19613: 25.0.50; cl-labels bug References: <7h4mrqmqrr.fsf@fencepost.gnu.org> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?utf-8?Q?=E7=9C=9F?= Gnus v0.12) Emacs/25.0.50 (i686-pc-cygwin) Cancel-Lock: sha1:C+sgdECKcUdnU4YHdYkRmKbVtNk= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - memphis.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: memphis.hostforweb.net: acl_c_authenticated_local_user: yamaokac X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19613 Cc: 19613@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Tue, 27 Jan 2015 08:00:57 +0900, Katsumi Yamaoka wrote: > --- cl.el~ 2015-01-26 04:16:45.291325300 +0000 > +++ cl.el 2015-01-26 22:57:02.040588600 +0000 > @@ -342,6 +342,7 @@ > - renaming of F when it's a function defined via `cl-labels' or `labels'." > (require 'cl-macs) > (declare-function cl--expr-contains-any "cl-macs" (x y)) > + (declare-function cl--labels-convert "cl-macs" (f)) There needs to be: + (defvar cl--labels-convert-cache) From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 26 21:06:21 2015 Received: (at 19613) by debbugs.gnu.org; 27 Jan 2015 02:06:21 +0000 Received: from localhost ([127.0.0.1]:57432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFvXp-0005zl-2n for submit@debbugs.gnu.org; Mon, 26 Jan 2015 21:06:21 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:45515) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFvXl-0005zZ-Tj for 19613@debbugs.gnu.org; Mon, 26 Jan 2015 21:06:18 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t0R26Fe4019235; Mon, 26 Jan 2015 21:06:15 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 199FAAE121; Mon, 26 Jan 2015 21:06:16 -0500 (EST) From: Stefan Monnier To: Katsumi Yamaoka Subject: Re: bug#19613: 25.0.50; cl-labels bug Message-ID: References: <7h4mrqmqrr.fsf@fencepost.gnu.org> Date: Mon, 26 Jan 2015 21:06:16 -0500 In-Reply-To: (Katsumi Yamaoka's message of "Tue, 27 Jan 2015 08:00:57 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5198=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5198> : inlines <1959> : streams <1380023> : uri <1843954> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19613 Cc: 19613@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > That's much better. Here it is: Looks great, thanks, Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 26 22:16:05 2015 Received: (at 19613-done) by debbugs.gnu.org; 27 Jan 2015 03:16:05 +0000 Received: from localhost ([127.0.0.1]:57463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFwdJ-0007kN-G4 for submit@debbugs.gnu.org; Mon, 26 Jan 2015 22:16:05 -0500 Received: from memphis-mail.hostforweb.net ([216.246.47.48]:34590 helo=memphis.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFwdI-0007jk-5i for 19613-done@debbugs.gnu.org; Mon, 26 Jan 2015 22:16:04 -0500 Received: from localhost ([127.0.0.1]:36647) by memphis.hostforweb.net with smtp (Exim 4.84) (envelope-from ) id 1YFwdC-003NXl-8G; Mon, 26 Jan 2015 21:15:58 -0600 Date: Tue, 27 Jan 2015 12:16:00 +0900 Message-ID: From: Katsumi Yamaoka To: Stefan Monnier Subject: Re: bug#19613: 25.0.50; cl-labels bug References: <7h4mrqmqrr.fsf@fencepost.gnu.org> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?iso-2022-jp?B?GyRCPz8bKEI=?= Gnus v0.12) Emacs/25.0.50 (i686-pc-cygwin) Cancel-Lock: sha1:/bYoKR94PS2qSna8kKZ/kxWpNlk= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - memphis.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: memphis.hostforweb.net: acl_c_authenticated_local_user: yamaokac X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 19613-done Cc: 19613-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Mon, 26 Jan 2015 21:06:16 -0500, Stefan Monnier wrote: > Looks great, thanks, Thanks. Committed. From unknown Wed Jun 18 23:08:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 24 Feb 2015 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator