GNU bug report logs - #19583
nntp-open-server: wrong buffer for nnoo-change-server; breaks url-news

Previous Next

Packages: emacs, gnus;

Reported by: Ivan Shmakov <ivan <at> siamics.net>

Date: Tue, 13 Jan 2015 16:13:01 UTC

Severity: normal

Tags: patch

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 19583 <at> debbugs.gnu.org
Subject: bug#19583: nntp-open-server: wrong buffer for nnoo-change-server; breaks url-news
Date: Tue, 23 Feb 2016 22:21:04 +1100
Ivan Shmakov <ivan <at> siamics.net> writes:

> 	BTW, I don’t seem to understand which nntp- functions do expect
> 	to be called from the server buffer.  For one thing,
> 	nntp-open-connection uses the nntp- variables intended (unless I
> 	be mistaken) to be local to the server buffer, yet I fail to see
> 	where the buffer gets switched.

I can't really see any local variables in the " *nntpd*" buffer.  There
are plenty of them in the " *server ...*" buffer, though.

So I can't really see how this would make any difference:

-    (nnoo-change-server 'nntp server defs)
-    (if connectionless
-	t
-      (or (nntp-find-connection nntp-server-buffer)
-	  (nntp-open-connection nntp-server-buffer)))))
+    (with-current-buffer nntp-server-buffer
+      (nnoo-change-server 'nntp server defs)
+      (if connectionless
+	  t
+	(or (nntp-find-connection nntp-server-buffer)
+	    (nntp-open-connection nntp-server-buffer))))))

nntp-server-buffer => #<buffer  *nntpd*>

Are you still seeing this problem?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 8 years and 115 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.