From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jan 2015 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 19582@debbugs.gnu.org Cc: Jay Belanger X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14211594475847 (code B ref -1); Tue, 13 Jan 2015 14:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jan 2015 14:30:47 +0000 Received: from localhost ([127.0.0.1]:55137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB2UX-0001WE-M1 for submit@debbugs.gnu.org; Tue, 13 Jan 2015 09:30:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57821) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB2UL-0001Vo-BY for submit@debbugs.gnu.org; Tue, 13 Jan 2015 09:30:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB2U9-0007df-Vu for submit@debbugs.gnu.org; Tue, 13 Jan 2015 09:30:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB2U9-0007dW-RZ for submit@debbugs.gnu.org; Tue, 13 Jan 2015 09:30:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB2U3-0002zI-U5 for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 09:30:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB2Ty-0007UM-4z for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 09:30:15 -0500 Received: from b2bfep14.mx.upcmail.net ([62.179.121.59]:37115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB2Tx-0007Qw-Ac for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 09:30:10 -0500 Received: from edge12.upcmail.net ([192.168.13.82]) by b2bfep14.mx.upcmail.net (InterMail vM.8.01.05.11 201-2260-151-128-20120928) with ESMTP id <20150113143005.EWIA11972.b2bfep14-int.chello.at@edge12.upcmail.net> for ; Tue, 13 Jan 2015 15:30:05 +0100 Received: from iznogoud.viz ([85.127.90.213]) by edge12.upcmail.net with edge id fSW41p02K4cBfQ50CSW5e2; Tue, 13 Jan 2015 15:30:05 +0100 X-SourceIP: 85.127.90.213 Received: from wolfgang by iznogoud.viz with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1YB2Ts-0000v0-PI; Tue, 13 Jan 2015 15:30:04 +0100 From: Wolfgang Jenkner Date: Tue, 13 Jan 2015 15:22:28 +0100 Message-ID: <851tmyah3n.fsf@iznogoud.viz> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Start Calc (M-x calc). Try to convert -1m to cm. Type '-1muc Then Calc asks `(The expression is unitless when simplified) Old Units:' This is the first glitch here, but, regardless, answer the question m Now, it asks (correctly) for new units, so type cm This gives the surprising result `-100 m' on top of the stack. Now, if you do the same thing with -2 instead of -1, everything works fine. The reason is that some of the functions in calc-units.el which, in various ways, test for the presence of units in a given (simplified) expression forget to handle subexpressions of the form (neg ). I propose the attached patch, which also contains some modest additions to test/automated/cl-lib-tests.el. There's also some math-defsimplify stuff in calc-units.el which fails to handle the neg operator, but that shouldn't give rise to mathematical errors and will be done in another patch. This patch is also needed for (and, in fact, was prompted by) bug#19401. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Handle-the-neg-operator-in-some-calc-units-functions.patch Content-Description: neg operator glitches >From 3b8d9b69374036a353ddfa53733c58da2c799c1a Mon Sep 17 00:00:00 2001 From: Wolfgang Jenkner Date: Thu, 8 Jan 2015 21:13:44 +0100 Subject: [PATCH] Handle the `neg' operator in some calc-units functions. * lisp/calc/calc-units.el (math-units-in-expr-p) (math-single-units-in-expr-p, math-find-compatible-unit-rec) (math-extract-units): Handle the `neg' operator. * test/automated/calc-tests.el (calc-tests-equal, calc-tests-simple): New functions. (test-calc-remove-units, test-calc-extract-units) (test-calc-convert-units): New tests. --- lisp/ChangeLog | 6 ++++++ lisp/calc/calc-units.el | 16 ++++++++++---- test/ChangeLog | 7 +++++++ test/automated/calc-tests.el | 50 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 75 insertions(+), 4 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 4985ad1..34136e4 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,9 @@ +2015-01-08 Wolfgang Jenkner + + * calc/calc-units.el (math-units-in-expr-p) + (math-single-units-in-expr-p, math-find-compatible-unit-rec) + (math-extract-units): Handle the `neg' operator. + 2015-01-12 Martin Rudalics * progmodes/xref.el (xref-marker-stack-empty-p): Add autoload diff --git a/lisp/calc/calc-units.el b/lisp/calc/calc-units.el index 26a644a..0595086 100644 --- a/lisp/calc/calc-units.el +++ b/lisp/calc/calc-units.el @@ -904,10 +904,12 @@ If COMP or STD is non-nil, put that in the units table instead." (and (consp expr) (if (eq (car expr) 'var) (math-check-unit-name expr) - (and (or sub-exprs - (memq (car expr) '(* / ^))) - (or (math-units-in-expr-p (nth 1 expr) sub-exprs) - (math-units-in-expr-p (nth 2 expr) sub-exprs)))))) + (if (eq (car expr) 'neg) + (math-units-in-expr-p (nth 1 expr) sub-exprs) + (and (or sub-exprs + (memq (car expr) '(* / ^))) + (or (math-units-in-expr-p (nth 1 expr) sub-exprs) + (math-units-in-expr-p (nth 2 expr) sub-exprs))))))) (defun math-only-units-in-expr-p (expr) (and (consp expr) @@ -924,6 +926,8 @@ If COMP or STD is non-nil, put that in the units table instead." (cond ((math-scalarp expr) nil) ((eq (car expr) 'var) (math-check-unit-name expr)) + ((eq (car expr) 'neg) + (math-single-units-in-expr-p (nth 1 expr))) ((eq (car expr) '*) (let ((u1 (math-single-units-in-expr-p (nth 1 expr))) (u2 (math-single-units-in-expr-p (nth 2 expr)))) @@ -1079,6 +1083,8 @@ If COMP or STD is non-nil, put that in the units table instead." ((eq (car-safe expr) '/) (or (math-find-compatible-unit-rec (nth 1 expr) pow) (math-find-compatible-unit-rec (nth 2 expr) (- pow)))) + ((eq (car-safe expr) 'neg) + (math-find-compatible-unit-rec (nth 1 expr) pow)) ((and (eq (car-safe expr) '^) (integerp (nth 2 expr))) (math-find-compatible-unit-rec (nth 1 expr) (* pow (nth 2 expr)))) @@ -1497,6 +1503,8 @@ If COMP or STD is non-nil, put that in the units table instead." ((memq (car-safe expr) '(* /)) (cons (car expr) (mapcar 'math-extract-units (cdr expr)))) + ((eq (car-safe expr) 'neg) + (math-extract-units (nth 1 expr))) ((eq (car-safe expr) '^) (list '^ (math-extract-units (nth 1 expr)) (nth 2 expr))) ((math-check-unit-name expr) expr) diff --git a/test/ChangeLog b/test/ChangeLog index 83bb8bf..527338b 100644 --- a/test/ChangeLog +++ b/test/ChangeLog @@ -1,3 +1,10 @@ +2015-01-08 Wolfgang Jenkner + + * automated/calc-tests.el (calc-tests-equal, calc-tests-simple): + New functions. + (test-calc-remove-units, test-calc-extract-units) + (test-calc-convert-units): New tests. + 2015-01-08 Stefan Monnier * automated/eieio-tests.el (eieio-test-23-inheritance-check): Don't use diff --git a/test/automated/calc-tests.el b/test/automated/calc-tests.el index 331e01e..d134d0a 100644 --- a/test/automated/calc-tests.el +++ b/test/automated/calc-tests.el @@ -27,6 +27,38 @@ (require 'cl-lib) (require 'ert) (require 'calc) +(require 'calc-ext) +(require 'calc-units) + +;; XXX Apparently, the representation of numbers is sometimes +;; influenced by previous results in the same calc stack. Hence this +;; function. +(defun calc-tests-equal (a b) + "Like `equal' but allow for different representations of numbers. +For example: (calc-tests-equal 10 '(float 1 1)) => t. +A and B should be calc expressions." + (cond ((math-numberp a) + (and (math-numberp b) + (math-equal a b))) + ((atom a) + (equal a b)) + ((consp b) + ;; Can't be dotted or circular. + (and (= (length a) (length b)) + (equal (car a) (car b)) + (cl-every #'calc-tests-equal (cdr a) (cdr b)))))) + +(defun calc-tests-simple (fun string &rest args) + "Push STRING on the calc stack, then call FUN and return the new top. +The result is a calc (i.e., lisp) expression, not its string representation. +Also pop the entire stack afterwards. +An existing calc stack is reused, otherwise a new one is created." + (calc-eval string 'push) + (prog1 + (ignore-errors + (apply fun args) + (calc-top-n 1)) + (calc-pop 0))) (ert-deftest test-math-bignum () ;; bug#17556 @@ -34,6 +66,24 @@ (should (math-negp n)) (should (cl-notany #'cl-minusp (cdr n))))) +(ert-deftest test-calc-remove-units () + (should (calc-tests-equal (calc-tests-simple #'calc-remove-units "-1 m") -1))) + +(ert-deftest test-calc-extract-units () + (should (calc-tests-equal (calc-tests-simple #'calc-extract-units "-1 m") + '(var m var-m))) + (should (calc-tests-equal (calc-tests-simple #'calc-extract-units "-1 m*cm") + '(* (float 1 -2) (^ (var m var-m) 2))))) + +(ert-deftest test-calc-convert-units () + ;; Used to ask for `(The expression is unitless when simplified) Old Units: '. + (should (calc-tests-equal (calc-tests-simple #'calc-convert-units "-1 m" nil "cm") + '(* -100 (var cm var-cm)))) + ;; Gave wrong result. + (should (calc-tests-equal (calc-tests-simple #'calc-convert-units "-1 m" + (math-read-expr "1m") "cm") + '(* -100 (var cm var-cm))))) + (provide 'calc-tests) ;;; calc-tests.el ends here -- 2.2.1 --=-=-=-- From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units Resent-From: Jay Belanger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jan 2015 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Wolfgang Jenkner Cc: jay.p.belanger@gmail.com, 19582@debbugs.gnu.org X-Debbugs-Original-Cc: jay.p.belanger@gmail.com, bug-gnu-emacs@gnu.org Reply-To: jay.p.belanger@gmail.com Received: via spool by submit@debbugs.gnu.org id=B.142116457114167 (code B ref -1); Tue, 13 Jan 2015 15:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jan 2015 15:56:11 +0000 Received: from localhost ([127.0.0.1]:55551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB3pC-0003gR-TY for submit@debbugs.gnu.org; Tue, 13 Jan 2015 10:56:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50672) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB3pA-0003gF-U9 for submit@debbugs.gnu.org; Tue, 13 Jan 2015 10:56:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB3p4-0007sQ-Hj for submit@debbugs.gnu.org; Tue, 13 Jan 2015 10:56:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB3p4-0007sM-FV for submit@debbugs.gnu.org; Tue, 13 Jan 2015 10:56:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB3p3-0001yN-OR for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 10:56:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB3oy-0007q6-Vm for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 10:56:01 -0500 Received: from mail.truman.edu ([150.243.165.76]:33453 helo=uranium.truman.edu) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB3oy-0007pa-RN for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 10:55:56 -0500 Received: from vh213601.truman.edu (vh213601.truman.edu [150.243.162.59]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by uranium.truman.edu (Postfix) with ESMTPS id 8DD2A1286CB; Tue, 13 Jan 2015 09:55:42 -0600 (CST) From: Jay Belanger References: <851tmyah3n.fsf@iznogoud.viz> Date: Tue, 13 Jan 2015 09:55:02 -0600 In-Reply-To: <851tmyah3n.fsf@iznogoud.viz> (Wolfgang Jenkner's message of "Tue, 13 Jan 2015 15:22:28 +0100") Message-ID: <87k30q65gp.fsf@vh213601.truman.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) > I propose the attached patch, Fantastic, thanks. I'll apply the patches to Calc as soon as I get to my home computer. But what did you mean when you wrote: Apparently, the representation of numbers is sometimes influenced by previous results in the same calc stack. ? Jay From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jan 2015 16:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jay Belanger Cc: 19582@debbugs.gnu.org X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.142116492114772 (code B ref -1); Tue, 13 Jan 2015 16:02:01 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jan 2015 16:02:01 +0000 Received: from localhost ([127.0.0.1]:55555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB3uq-0003q9-OB for submit@debbugs.gnu.org; Tue, 13 Jan 2015 11:02:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51886) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB3up-0003pw-HH for submit@debbugs.gnu.org; Tue, 13 Jan 2015 11:02:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB3ue-00027M-HH for submit@debbugs.gnu.org; Tue, 13 Jan 2015 11:01:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB3ue-00027G-Eo for submit@debbugs.gnu.org; Tue, 13 Jan 2015 11:01:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB3uY-00038c-U6 for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 11:01:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB3uU-00023T-VG for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 11:01:42 -0500 Received: from b2bfep11.mx.upcmail.net ([62.179.121.56]:59826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB3uU-00021Z-A8 for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 11:01:38 -0500 Received: from edge11.upcmail.net ([192.168.13.81]) by b2bfep11.mx.upcmail.net (InterMail vM.8.01.05.11 201-2260-151-128-20120928) with ESMTP id <20150113160134.ZWAE22355.b2bfep11-int.chello.at@edge11.upcmail.net> for ; Tue, 13 Jan 2015 17:01:34 +0100 Received: from iznogoud.viz ([85.127.90.213]) by edge11.upcmail.net with edge id fU1a1p00J4cBfQ50BU1aKc; Tue, 13 Jan 2015 17:01:34 +0100 X-SourceIP: 85.127.90.213 Received: from wolfgang by iznogoud.viz with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1YB3uQ-0003P9-0J; Tue, 13 Jan 2015 17:01:34 +0100 From: Wolfgang Jenkner References: <851tmyah3n.fsf@iznogoud.viz> <87k30q65gp.fsf@vh213601.truman.edu> Date: Tue, 13 Jan 2015 17:01:33 +0100 In-Reply-To: <87k30q65gp.fsf@vh213601.truman.edu> (Jay Belanger's message of "Tue, 13 Jan 2015 09:55:02 -0600") Message-ID: <85egqy8yaq.fsf@iznogoud.viz> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On Tue, Jan 13 2015, Jay Belanger wrote: >> I propose the attached patch, > > Fantastic, thanks. I'll apply the patches to Calc as soon as I get to > my home computer. I could do this myself, actually... > But what did you mean when you wrote: > Apparently, the representation of numbers is sometimes > influenced by previous results in the same calc stack. The same calculation can return an expression where some sub-expression is a plain integer, say 100, or the corresponding float (float 1 2). I'll provide an explicit example. From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units Resent-From: Jay Belanger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jan 2015 16:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Wolfgang Jenkner Cc: jay.p.belanger@gmail.com, 19582@debbugs.gnu.org X-Debbugs-Original-Cc: jay.p.belanger@gmail.com, bug-gnu-emacs@gnu.org Reply-To: jay.p.belanger@gmail.com Received: via spool by submit@debbugs.gnu.org id=B.142116528415369 (code B ref -1); Tue, 13 Jan 2015 16:09:01 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jan 2015 16:08:04 +0000 Received: from localhost ([127.0.0.1]:55570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB40h-0003zp-OW for submit@debbugs.gnu.org; Tue, 13 Jan 2015 11:08:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53568) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB40f-0003zK-DP for submit@debbugs.gnu.org; Tue, 13 Jan 2015 11:08:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB40Z-0004ss-H0 for submit@debbugs.gnu.org; Tue, 13 Jan 2015 11:07:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB40Z-0004so-E7 for submit@debbugs.gnu.org; Tue, 13 Jan 2015 11:07:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB40Y-0005SZ-GV for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 11:07:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB40V-0004qc-5F for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 11:07:54 -0500 Received: from mail.truman.edu ([150.243.165.76]:35752 helo=uranium.truman.edu) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB40V-0004qU-1E for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 11:07:51 -0500 Received: from vh213601.truman.edu (vh213601.truman.edu [150.243.162.59]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by uranium.truman.edu (Postfix) with ESMTPS id 758C94C0C9; Tue, 13 Jan 2015 10:07:37 -0600 (CST) From: Jay Belanger References: <851tmyah3n.fsf@iznogoud.viz> <87k30q65gp.fsf@vh213601.truman.edu> <85egqy8yaq.fsf@iznogoud.viz> Date: Tue, 13 Jan 2015 10:06:52 -0600 In-Reply-To: <85egqy8yaq.fsf@iznogoud.viz> (Wolfgang Jenkner's message of "Tue, 13 Jan 2015 17:01:33 +0100") Message-ID: <87fvbe64wz.fsf@vh213601.truman.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) >> Fantastic, thanks. I'll apply the patches to Calc as soon as I get to >> my home computer. > > I could do this myself, actually... Great! >> But what did you mean when you wrote: >> Apparently, the representation of numbers is sometimes >> influenced by previous results in the same calc stack. > > The same calculation can return an expression where some sub-expression > is a plain integer, say 100, or the corresponding float (float 1 2). > I'll provide an explicit example. Okay, thanks. Since 100 and (float 1 2) aren't the same, that might be a bug of some kind. I'm not sure that a test should indicate that they are equal, so maybe you shouldn't put that part in yet. From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units In-Reply-To: <851tmyah3n.fsf@iznogoud.viz> Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jan 2015 16:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jay Belanger Cc: 19582@debbugs.gnu.org Received: via spool by 19582-submit@debbugs.gnu.org id=B19582.142116633517165 (code B ref 19582); Tue, 13 Jan 2015 16:26:02 +0000 Received: (at 19582) by debbugs.gnu.org; 13 Jan 2015 16:25:35 +0000 Received: from localhost ([127.0.0.1]:55612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB4He-0004Sm-Sd for submit@debbugs.gnu.org; Tue, 13 Jan 2015 11:25:35 -0500 Received: from b2bfep13.mx.upcmail.net ([62.179.121.58]:41839) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB4Hb-0004SL-TH for 19582@debbugs.gnu.org; Tue, 13 Jan 2015 11:25:33 -0500 Received: from edge12.upcmail.net ([192.168.13.82]) by b2bfep13.mx.upcmail.net (InterMail vM.8.01.05.11 201-2260-151-128-20120928) with ESMTP id <20150113162524.KBWX20529.b2bfep13-int.chello.at@edge12.upcmail.net> for <19582@debbugs.gnu.org>; Tue, 13 Jan 2015 17:25:24 +0100 Received: from iznogoud.viz ([85.127.90.213]) by edge12.upcmail.net with edge id fURP1p0114cBfQ50CURP9V; Tue, 13 Jan 2015 17:25:24 +0100 X-SourceIP: 85.127.90.213 Received: from wolfgang by iznogoud.viz with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1YB4HT-0004re-Du; Tue, 13 Jan 2015 17:25:23 +0100 From: Wolfgang Jenkner References: <851tmyah3n.fsf@iznogoud.viz> <87k30q65gp.fsf@vh213601.truman.edu> <85egqy8yaq.fsf@iznogoud.viz> <87fvbe64wz.fsf@vh213601.truman.edu> Date: Tue, 13 Jan 2015 17:25:23 +0100 Message-ID: <85387e8x70.fsf@iznogoud.viz> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Tue, Jan 13 2015, Jay Belanger wrote: > Since 100 and (float 1 2) aren't the same, that might be a bug of some > kind. Sure, but (math-equal 100 '(float 1 2)) => t and (info "(calc) Predicates") states -- Function: math-equal x y Returns true if X and Y are numerically equal, either because they are `equal', or because their difference is `zerop'. [...] so, IIUC, mathematically, they are as equal as it gets in calc. On the other hand, I'm not sure if calculations with (float ...) are exact (if possible) in calc ? From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units Resent-From: Jay Belanger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jan 2015 16:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Wolfgang Jenkner Cc: jay.p.belanger@gmail.com, 19582@debbugs.gnu.org Reply-To: jay.p.belanger@gmail.com Received: via spool by 19582-submit@debbugs.gnu.org id=B19582.142116694818193 (code B ref 19582); Tue, 13 Jan 2015 16:36:01 +0000 Received: (at 19582) by debbugs.gnu.org; 13 Jan 2015 16:35:48 +0000 Received: from localhost ([127.0.0.1]:55632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB4RY-0004jN-1y for submit@debbugs.gnu.org; Tue, 13 Jan 2015 11:35:48 -0500 Received: from uranium.truman.edu ([150.243.165.76]:38167) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB4RV-0004j5-OP for 19582@debbugs.gnu.org; Tue, 13 Jan 2015 11:35:46 -0500 Received: from vh213601.truman.edu (vh213601.truman.edu [150.243.162.59]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by uranium.truman.edu (Postfix) with ESMTPS id 09D5F4C1C8; Tue, 13 Jan 2015 10:35:27 -0600 (CST) From: Jay Belanger References: <851tmyah3n.fsf@iznogoud.viz> <87k30q65gp.fsf@vh213601.truman.edu> <85egqy8yaq.fsf@iznogoud.viz> <87fvbe64wz.fsf@vh213601.truman.edu> <85387e8x70.fsf@iznogoud.viz> Date: Tue, 13 Jan 2015 10:34:46 -0600 In-Reply-To: <85387e8x70.fsf@iznogoud.viz> (Wolfgang Jenkner's message of "Tue, 13 Jan 2015 17:25:23 +0100") Message-ID: <87bnm263mh.fsf@vh213601.truman.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) >> Since 100 and (float 1 2) aren't the same, that might be a bug of some >> kind. > > Sure, but > > (math-equal 100 '(float 1 2)) => t > > and (info "(calc) Predicates") states > > -- Function: math-equal x y > Returns true if X and Y are numerically equal, either because they > are `equal', or because their difference is `zerop'. [...] > > so, IIUC, mathematically, they are as equal as it gets in calc. Ah, right. But the same calculations on the same objects should produce results which are equal, not just math-equal. > On the other hand, I'm not sure if calculations with (float ...) > are exact (if possible) in calc ? Calc will do the exact computations, since internally it uses base 10 to represents floats. Of course, the user might not consider (float ...)s to be exact. From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units Resent-From: Jay Belanger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jan 2015 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Wolfgang Jenkner Cc: jay.p.belanger@gmail.com, 19582@debbugs.gnu.org Reply-To: jay.p.belanger@gmail.com Received: via spool by 19582-submit@debbugs.gnu.org id=B19582.142116776019622 (code B ref 19582); Tue, 13 Jan 2015 16:50:02 +0000 Received: (at 19582) by debbugs.gnu.org; 13 Jan 2015 16:49:20 +0000 Received: from localhost ([127.0.0.1]:55658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB4ed-00056Q-SG for submit@debbugs.gnu.org; Tue, 13 Jan 2015 11:49:20 -0500 Received: from uranium.truman.edu ([150.243.165.76]:55032) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB4ec-00056D-5a for 19582@debbugs.gnu.org; Tue, 13 Jan 2015 11:49:18 -0500 Received: from vh213601.truman.edu (vh213601.truman.edu [150.243.162.59]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by uranium.truman.edu (Postfix) with ESMTPS id CD5384C188; Tue, 13 Jan 2015 10:48:59 -0600 (CST) From: Jay Belanger References: <851tmyah3n.fsf@iznogoud.viz> <87k30q65gp.fsf@vh213601.truman.edu> <85egqy8yaq.fsf@iznogoud.viz> <87fvbe64wz.fsf@vh213601.truman.edu> <85387e8x70.fsf@iznogoud.viz> <87bnm263mh.fsf@vh213601.truman.edu> Date: Tue, 13 Jan 2015 10:48:19 -0600 In-Reply-To: <87bnm263mh.fsf@vh213601.truman.edu> (Jay Belanger's message of "Tue, 13 Jan 2015 10:34:46 -0600") Message-ID: <877fwq62zw.fsf@vh213601.truman.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Ah, right. But the same calculations on the same objects should produce > results which are equal, not just math-equal. ... an example will probably clarify the issue. From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jan 2015 19:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jay Belanger Cc: 19582@debbugs.gnu.org Received: via spool by 19582-submit@debbugs.gnu.org id=B19582.14211779583436 (code B ref 19582); Tue, 13 Jan 2015 19:40:01 +0000 Received: (at 19582) by debbugs.gnu.org; 13 Jan 2015 19:39:18 +0000 Received: from localhost ([127.0.0.1]:55800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB7J7-0000tL-Fs for submit@debbugs.gnu.org; Tue, 13 Jan 2015 14:39:17 -0500 Received: from b2bfep13.mx.upcmail.net ([62.179.121.58]:48063) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB7J4-0000t5-35 for 19582@debbugs.gnu.org; Tue, 13 Jan 2015 14:39:15 -0500 Received: from edge12.upcmail.net ([192.168.13.82]) by b2bfep13.mx.upcmail.net (InterMail vM.8.01.05.11 201-2260-151-128-20120928) with ESMTP id <20150113193906.MFMN20529.b2bfep13-int.chello.at@edge12.upcmail.net> for <19582@debbugs.gnu.org>; Tue, 13 Jan 2015 20:39:06 +0100 Received: from iznogoud.viz ([85.127.90.213]) by edge12.upcmail.net with edge id fXf51p00R4cBfQ50CXf5Vp; Tue, 13 Jan 2015 20:39:06 +0100 X-SourceIP: 85.127.90.213 Received: from wolfgang by iznogoud.viz with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1YB7Iv-00054k-HJ; Tue, 13 Jan 2015 20:39:05 +0100 From: Wolfgang Jenkner References: <851tmyah3n.fsf@iznogoud.viz> <87k30q65gp.fsf@vh213601.truman.edu> <85egqy8yaq.fsf@iznogoud.viz> Date: Tue, 13 Jan 2015 20:39:05 +0100 In-Reply-To: <85egqy8yaq.fsf@iznogoud.viz> (Wolfgang Jenkner's message of "Tue, 13 Jan 2015 17:01:33 +0100") Message-ID: <858uh6zd0m.fsf@iznogoud.viz> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Tue, Jan 13 2015, Wolfgang Jenkner wrote: > The same calculation can return an expression where some sub-expression > is a plain integer, say 100, or the corresponding float (float 1 2). > I'll provide an explicit example. So the issue seems to be this: In emacs -Q, do `M-x calc' then convert, say 1m, to cm, i.e., ' 1 m u c c m This gives `100 cm' on top of the stack (a plain integer scalar). Next, start another emacs -Q instance, do `M-x calc' and then, before anything else, `M-: (load-library "calc-units")'. Now the same conversion exercise as before gives `100. cm' on the stack instead (a calc float). From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units Resent-From: Jay Belanger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jan 2015 21:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Wolfgang Jenkner Cc: jay.p.belanger@gmail.com, 19582@debbugs.gnu.org Reply-To: jay.p.belanger@gmail.com Received: via spool by 19582-submit@debbugs.gnu.org id=B19582.142118631616627 (code B ref 19582); Tue, 13 Jan 2015 21:59:01 +0000 Received: (at 19582) by debbugs.gnu.org; 13 Jan 2015 21:58:36 +0000 Received: from localhost ([127.0.0.1]:55914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB9Tv-0004K7-Nx for submit@debbugs.gnu.org; Tue, 13 Jan 2015 16:58:35 -0500 Received: from mail-oi0-f41.google.com ([209.85.218.41]:59315) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB9Tu-0004Jt-N8 for 19582@debbugs.gnu.org; Tue, 13 Jan 2015 16:58:35 -0500 Received: by mail-oi0-f41.google.com with SMTP id i138so4564987oig.0 for <19582@debbugs.gnu.org>; Tue, 13 Jan 2015 13:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:reply-to:cc:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=p9+vzlIJMbRAG9Qc9SPedzGuv28+8E4h8iqexGsB5mk=; b=kL8cifbVZxUoFAdVr3ldo9YvX2B82m5lYLDFTh9rycIcpY2N32bqCwoyYHBl+UP60f Wrfq1vaFI82JpclK/a1sE2jfc6oIQ1ejQYUsHs9iTSzxsT10yrpNdh3PDGg/Z67kcwgQ 7CKBdbaRdWXugCgNEcABSxiPpK9DmM/SGsU/j8Owj0JFZbwvNLiZlorpaNCN/YilSeuX 9cwYizl1Tlt2bMJq5iN1b7y3O39fX9vBEbNbEGZZKS5eX3Dp9VVlr25PgIKLNT+vM6LX cgKqERCERvEE+We200LvqoHT8zj+BSPufu4DioFgOJNjpGOvXcyiHjEwtMmzIkuiw3TE syRw== X-Received: by 10.60.47.112 with SMTP id c16mr345518oen.83.1421186308928; Tue, 13 Jan 2015 13:58:28 -0800 (PST) Received: from belanger-home (67-60-106-71.cpe.cableone.net. [67.60.106.71]) by mx.google.com with ESMTPSA id ko4sm11203817obb.19.2015.01.13.13.58.27 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 13 Jan 2015 13:58:27 -0800 (PST) From: Jay Belanger References: <851tmyah3n.fsf@iznogoud.viz> <87k30q65gp.fsf@vh213601.truman.edu> <85egqy8yaq.fsf@iznogoud.viz> <858uh6zd0m.fsf@iznogoud.viz> Date: Tue, 13 Jan 2015 15:57:04 -0600 In-Reply-To: <858uh6zd0m.fsf@iznogoud.viz> (Wolfgang Jenkner's message of "Tue, 13 Jan 2015 20:39:05 +0100") Message-ID: <87zj9mfiof.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > So the issue seems to be this: > > In emacs -Q, do `M-x calc' then convert, say 1m, to cm, i.e., > > ' 1 m u c c m > > This gives `100 cm' on top of the stack (a plain integer scalar). > > Next, start another emacs -Q instance, do `M-x calc' and then, before > anything else, `M-: (load-library "calc-units")'. > > Now the same conversion exercise as before gives `100. cm' on the stack > instead (a calc float). Huh. Thanks. Well, now I see what you need to use math-equal. As for the float, I'll see if I can fix that before the next release. From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jan 2015 23:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jay Belanger Cc: 19582@debbugs.gnu.org Received: via spool by 19582-submit@debbugs.gnu.org id=B19582.142136612029631 (code B ref 19582); Thu, 15 Jan 2015 23:56:02 +0000 Received: (at 19582) by debbugs.gnu.org; 15 Jan 2015 23:55:20 +0000 Received: from localhost ([127.0.0.1]:58211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBuFz-0007hq-Fo for submit@debbugs.gnu.org; Thu, 15 Jan 2015 18:55:19 -0500 Received: from b2bfep12.mx.upcmail.net ([62.179.121.57]:38481) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBuFx-0007hb-1g for 19582@debbugs.gnu.org; Thu, 15 Jan 2015 18:55:18 -0500 Received: from edge11.upcmail.net ([192.168.13.81]) by b2bfep12.mx.upcmail.net (InterMail vM.8.01.05.11 201-2260-151-128-20120928) with ESMTP id <20150115235509.RUET14748.b2bfep12-int.chello.at@edge11.upcmail.net> for <19582@debbugs.gnu.org>; Fri, 16 Jan 2015 00:55:09 +0100 Received: from iznogoud.viz ([91.119.120.37]) by edge11.upcmail.net with edge id gPv91p0050oWRX70BPv9sa; Fri, 16 Jan 2015 00:55:09 +0100 X-SourceIP: 91.119.120.37 Received: from wolfgang by iznogoud.viz with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1YBuFo-000BSE-Vi; Fri, 16 Jan 2015 00:55:08 +0100 From: Wolfgang Jenkner References: <851tmyah3n.fsf@iznogoud.viz> <87k30q65gp.fsf@vh213601.truman.edu> <85egqy8yaq.fsf@iznogoud.viz> <87fvbe64wz.fsf@vh213601.truman.edu> Date: Fri, 16 Jan 2015 00:55:08 +0100 In-Reply-To: <87fvbe64wz.fsf@vh213601.truman.edu> (Jay Belanger's message of "Tue, 13 Jan 2015 10:06:52 -0600") Message-ID: <85twzrfvkz.fsf@iznogoud.viz> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Tue, Jan 13 2015, Jay Belanger wrote: >>> Fantastic, thanks. I'll apply the patches to Calc as soon as I get to >>> my home computer. >> >> I could do this myself, actually... > > Great! I've committed this now. I only corrected the comment before calc-tests-equal in test/automated/calc-tests.el. Since I'm working on making the simplification functions in calc-units aware of the (neg ...) expressions where needed, I'd like to keep this bug report open a bit longer so that I can send here the patch for review. From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units Resent-From: Wolfgang Jenkner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jan 2015 16:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jay Belanger Cc: 19582@debbugs.gnu.org Received: via spool by 19582-submit@debbugs.gnu.org id=B19582.142159861615063 (code B ref 19582); Sun, 18 Jan 2015 16:31:01 +0000 Received: (at 19582) by debbugs.gnu.org; 18 Jan 2015 16:30:16 +0000 Received: from localhost ([127.0.0.1]:60718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YCsjw-0003us-7L for submit@debbugs.gnu.org; Sun, 18 Jan 2015 11:30:16 -0500 Received: from b2bfep16.mx.upcmail.net ([62.179.121.61]:51582) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YCsjr-0003tj-OQ for 19582@debbugs.gnu.org; Sun, 18 Jan 2015 11:30:13 -0500 Received: from edge12.upcmail.net ([192.168.13.82]) by b2bfep16.mx.upcmail.net (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP id <20150118162954.RCDN3115.b2bfep16-int.chello.at@edge12.upcmail.net> for <19582@debbugs.gnu.org>; Sun, 18 Jan 2015 17:29:54 +0100 Received: from iznogoud.viz ([85.127.10.198]) by edge12.upcmail.net with edge id hUVt1p00j4GNHyl0CUVtFm; Sun, 18 Jan 2015 17:29:54 +0100 X-SourceIP: 85.127.10.198 Received: from wolfgang by iznogoud.viz with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1YCsjZ-0000OT-Ef; Sun, 18 Jan 2015 17:29:53 +0100 From: Wolfgang Jenkner References: <851tmyah3n.fsf@iznogoud.viz> <87k30q65gp.fsf@vh213601.truman.edu> <85egqy8yaq.fsf@iznogoud.viz> <87fvbe64wz.fsf@vh213601.truman.edu> <85twzrfvkz.fsf@iznogoud.viz> Date: Sun, 18 Jan 2015 17:29:53 +0100 In-Reply-To: <85twzrfvkz.fsf@iznogoud.viz> (Wolfgang Jenkner's message of "Fri, 16 Jan 2015 00:55:08 +0100") Message-ID: <85oapwvypq.fsf@iznogoud.viz> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Fri, Jan 16 2015, Wolfgang Jenkner wrote: > I've committed this now. ...to master as commit 2290000ed69b1157739c280f090e5b60112e83fe Author: Wolfgang Jenkner Date: Thu Jan 15 20:02:17 2015 +0100 Handle the `neg' operator in some calc-units functions. However, according to http://permalink.gmane.org/gmane.emacs.devel/181383 it falls within the category of things that should go into emacs-24 instead, so I guess I should backport it. From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units Resent-From: Jay Belanger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jan 2015 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Wolfgang Jenkner Cc: jay.p.belanger@gmail.com, 19582@debbugs.gnu.org Reply-To: jay.p.belanger@gmail.com Received: via spool by 19582-submit@debbugs.gnu.org id=B19582.142245796425264 (code B ref 19582); Wed, 28 Jan 2015 15:13:02 +0000 Received: (at 19582) by debbugs.gnu.org; 28 Jan 2015 15:12:44 +0000 Received: from localhost ([127.0.0.1]:59114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGUIN-0006ZP-D5 for submit@debbugs.gnu.org; Wed, 28 Jan 2015 10:12:43 -0500 Received: from mail-ob0-f176.google.com ([209.85.214.176]:50699) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGUIL-0006Z6-D3 for 19582@debbugs.gnu.org; Wed, 28 Jan 2015 10:12:41 -0500 Received: by mail-ob0-f176.google.com with SMTP id va2so19729433obc.7 for <19582@debbugs.gnu.org>; Wed, 28 Jan 2015 07:12:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:reply-to:cc:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=JjeXJnzyXtCEMzvtCcbkYRU7iWLLNOy2JKHvKIK5WmU=; b=1DAJkeNITzsECCJi3EeMip2Yyb6yXUrCb+KYUBYL0z88RJmE62JtTVNRgvOXmeEr6v 1BKdXhkKoHay16vkoQPSMrRL9sMMUY14Q4UAL1ul8k18E88hv+JYKdj8xydJbLy9kvEu HWz0ougbK8R3B89Pd5d88MQ4l0ajSyGQiX8lzGprI/iyor7xGHItViMRqxJR+/xUAnOM hrdRaGt9zlZeVtsiKyMXBG3Z8qLzycwrBMe3hhzLzaUTgnW5ny+MnMXgMWnW2tJIf2tw HlqOFkZdghKuurjXtM5wESMDCwmceR41HEi61pP0KWm98rmGTVh0bPLwqX41Hlke2Xy1 2OQg== X-Received: by 10.202.50.136 with SMTP id y130mr2216440oiy.91.1422457955735; Wed, 28 Jan 2015 07:12:35 -0800 (PST) Received: from belanger-home (67-60-106-71.cpe.cableone.net. [67.60.106.71]) by mx.google.com with ESMTPSA id uk9sm2333528oeb.0.2015.01.28.07.12.33 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 28 Jan 2015 07:12:34 -0800 (PST) From: Jay Belanger References: <851tmyah3n.fsf@iznogoud.viz> <87k30q65gp.fsf@vh213601.truman.edu> <85egqy8yaq.fsf@iznogoud.viz> <858uh6zd0m.fsf@iznogoud.viz> Date: Wed, 28 Jan 2015 09:11:40 -0600 In-Reply-To: <858uh6zd0m.fsf@iznogoud.viz> (Wolfgang Jenkner's message of "Tue, 13 Jan 2015 20:39:05 +0100") Message-ID: <877fw7c53n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > So the issue seems to be this: > > In emacs -Q, do `M-x calc' then convert, say 1m, to cm, i.e., > > ' 1 m u c c m > > This gives `100 cm' on top of the stack (a plain integer scalar). > > Next, start another emacs -Q instance, do `M-x calc' and then, before > anything else, `M-: (load-library "calc-units")'. > > Now the same conversion exercise as before gives `100. cm' on the stack > instead (a calc float). This is easy enough to fix, but loading error occurs when the libraries are loaded out of order; that shouldn't be done. When Calc is used properly, getting `100. m' instead of `100 m' would be a bug. From unknown Tue Jun 17 01:43:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19582: 25.0.50; [PATCH] Calc: glitches with negation of units Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Feb 2016 11:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Wolfgang Jenkner Cc: Jay Belanger , 19582@debbugs.gnu.org Received: via spool by 19582-submit@debbugs.gnu.org id=B19582.145622666012876 (code B ref 19582); Tue, 23 Feb 2016 11:25:02 +0000 Received: (at 19582) by debbugs.gnu.org; 23 Feb 2016 11:24:20 +0000 Received: from localhost ([127.0.0.1]:39327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYB4m-0003Lb-Ag for submit@debbugs.gnu.org; Tue, 23 Feb 2016 06:24:20 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:33752) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYB4k-0003LU-Sa for 19582@debbugs.gnu.org; Tue, 23 Feb 2016 06:24:19 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYB4M-0004hA-Bd; Tue, 23 Feb 2016 12:23:55 +0100 From: Lars Ingebrigtsen References: <851tmyah3n.fsf@iznogoud.viz> <87k30q65gp.fsf@vh213601.truman.edu> <85egqy8yaq.fsf@iznogoud.viz> <87fvbe64wz.fsf@vh213601.truman.edu> <85twzrfvkz.fsf@iznogoud.viz> Date: Tue, 23 Feb 2016 22:23:05 +1100 In-Reply-To: <85twzrfvkz.fsf@iznogoud.viz> (Wolfgang Jenkner's message of "Fri, 16 Jan 2015 00:55:08 +0100") Message-ID: <87io1fr7qe.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aYB4M-0004hA-Bd X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456831435.49791@xlKJ/yGH3R8C3b4srNSb8A X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Wolfgang Jenkner writes: > Since I'm working on making the simplification functions in calc-units > aware of the (neg ...) expressions where needed, I'd like to keep this > bug report open a bit longer so that I can send here the patch for > review. That was a year ago... I'm assuming this was fixed by now? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 19:45:50 2016 Received: (at control) by debbugs.gnu.org; 24 Feb 2016 00:45:50 +0000 Received: from localhost ([127.0.0.1]:41821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYNaP-0000gY-T8 for submit@debbugs.gnu.org; Tue, 23 Feb 2016 19:45:50 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:34058) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYNaO-0000gP-Dx for control@debbugs.gnu.org; Tue, 23 Feb 2016 19:45:48 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYNa1-0002o0-KA for control@debbugs.gnu.org; Wed, 24 Feb 2016 01:45:26 +0100 Date: Wed, 24 Feb 2016 11:45:21 +1100 Message-Id: <87k2lvos0u.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #19582 X-MailScanner-ID: 1aYNa1-0002o0-KA X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456879526.42514@C/VlpLx9e6lRrxA5q2EzBA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 19582 fixed close 19582