GNU bug report logs - #19576
24.4; Broken function in `window-size-change-functions' cause `write-file' to write the wrong buffer

Previous Next

Full log

Message #104 received at 19576 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: acm <at> muc.de, 19576 <at> debbugs.gnu.org, andlind <at> gmail.com, juri <at> linkov.net
Subject: Re: bug#19576: write-file writes the wrong buffer
Date: Fri, 20 Nov 2015 10:34:51 +0200

> Date: Fri, 20 Nov 2015 09:22:28 +0100
> From: martin rudalics <rudalics <at> gmx.at>
> CC: acm <at> muc.de, juri <at> linkov.net, andlind <at> gmail.com, 
>  19576 <at> debbugs.gnu.org
> 
>  >> No particular reason.  But note that ‘delete-other-windows-internal’ may
>  >> bypass window_resize_apply, so in that particular case we have to
>  >> manually make sure that the window_sizes_changed flag gets set.  I hope
>  >> this is the only case where it matters.
>  >
>  > Would you mind doing this on the master branch, please?
> 
> It might have interesting consequences.  Presumably, you expect that
> this way we'll be finally able to run ‘window-size-change-functions’ if
> and only if the size of windows really changed.  Correct?

No, not really.  It's just a cleanup, IMO: instead of asking each
caller of window_resize_apply to set that flag, set it in that
function itself.  I didn't envision any changes in functionality due
to this change.  What did I miss?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.