From unknown Sun Jun 22 22:46:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19572: 24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries Resent-From: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jan 2015 10:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19572 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 19572@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.142105898928305 (code B ref -1); Mon, 12 Jan 2015 10:37:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Jan 2015 10:36:29 +0000 Received: from localhost ([127.0.0.1]:54057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAcMH-0007MT-Gh for submit@debbugs.gnu.org; Mon, 12 Jan 2015 05:36:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58784) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAcMF-0007ME-HV for submit@debbugs.gnu.org; Mon, 12 Jan 2015 05:36:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAcM9-0001rG-DM for submit@debbugs.gnu.org; Mon, 12 Jan 2015 05:36:22 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAcM9-0001rC-Ad for submit@debbugs.gnu.org; Mon, 12 Jan 2015 05:36:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAcM8-0005pf-JE for bug-gnu-emacs@gnu.org; Mon, 12 Jan 2015 05:36:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAcM5-0001qd-De for bug-gnu-emacs@gnu.org; Mon, 12 Jan 2015 05:36:20 -0500 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:38490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAcM5-0001qU-7n for bug-gnu-emacs@gnu.org; Mon, 12 Jan 2015 05:36:17 -0500 Received: by mail-wi0-f182.google.com with SMTP id h11so13580737wiw.3 for ; Mon, 12 Jan 2015 02:36:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type:content-transfer-encoding; bh=EuC2lOR7AcCNXjrwQc+HxdDyh1SJ1Vt6HxS2eYScWuI=; b=b6PzCuna2iEFQl2TpDdaG5UGlDpJDtSYS1Ely+HZXEtkQU4VRRTC6HV7dhstqFsvVF 55h1o92NDVKo8jXKbgYuptBSOTh/u7mc3Xg4zrbWO7VEPJnnSvmSOv2gz8doiB2QhgoJ 9TBB1l+us2XMknjhfaWQkZF2lRuphyzjO1eXXcCoOE//GqQUNpQ3IbM2hMLWnp18M9EK y7X/Da5fORf/X3X74bcU1mT+/Tpmtk/0cdYhHMBPNqW9aAvZUcNBHBW8pNp1n3sdX71r MTcsv1Zfp5wChszQdbMvvIoLzAo6pPwA94dnUGKlTk7iDql/jqyR0EAliXJiEejO6DIk 2jsw== X-Received: by 10.194.63.169 with SMTP id h9mr262117wjs.23.1421058976246; Mon, 12 Jan 2015 02:36:16 -0800 (PST) Received: from GONDOMAR.yourcompany.com (53.236.108.93.rev.vodafone.pt. [93.108.236.53]) by mx.google.com with ESMTPSA id fo2sm9651188wib.10.2015.01.12.02.36.14 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Jan 2015 02:36:15 -0800 (PST) From: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Date: Mon, 12 Jan 2015 10:36:12 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -Q M-x ielm RET 'foo RET 'bar RET '(baz M-j bin) RET M-x comint-history-isearch-backward RET b a z expected the multi-line entry to be restored to input, but comint.el fails to find it. This is because `comint-history-isearch-search' uses (goto-char (comint-line-beginning-position)) I think it should use `comint-goto-process-mark'. comint.el is a big beast but I think this makes sense. Should I fix it thusly? (unless anyone beats me to it) Jo=E3o From unknown Sun Jun 22 22:46:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19572: Acknowledgement (24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries) Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jan 2015 10:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19572 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 19572@debbugs.gnu.org Received: via spool by 19572-submit@debbugs.gnu.org id=B19572.142105939928929 (code B ref 19572); Mon, 12 Jan 2015 10:44:02 +0000 Received: (at 19572) by debbugs.gnu.org; 12 Jan 2015 10:43:19 +0000 Received: from localhost ([127.0.0.1]:54062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAcSo-0007WS-AK for submit@debbugs.gnu.org; Mon, 12 Jan 2015 05:43:19 -0500 Received: from mail-ig0-f177.google.com ([209.85.213.177]:55875) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAcSm-0007WH-Om for 19572@debbugs.gnu.org; Mon, 12 Jan 2015 05:43:13 -0500 Received: by mail-ig0-f177.google.com with SMTP id z20so10852002igj.4 for <19572@debbugs.gnu.org>; Mon, 12 Jan 2015 02:43:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; bh=7Enyeoczyc6oNaeXbOmB0XuxbHmOYijPqgzxJgtr4/c=; b=dWjm8ST/HwBZXPpnbWy1kAqra+evJBV580AzTIFxorVMoK1xYkYmCJsn/IEQMfZLk7 6QdymA7eIEOY15d5g3kZwDXuxqdi4CcjUZKrrVNjrZcN+fsYh/TALjzXTrgXwMb+0vut Fafp75VEPh3xeaw361Dk+trliS1HY8GCvB1OjZ8yHniNwuKYDMDeQGM/0lFyT1mbmr/2 QLQhu6BCmsvO+jwgEH0lW63KVA+3YaSm7kMKTtGFZLiFz32lUmuNFKL5/deKDugMFyzA pcPkiTuKxPEz7cY/SAH+UWXC/S95PTCk8MYwUllqytI1hrlOlzkP2ba81q+wADrMJwGe KPAQ== X-Received: by 10.50.136.228 with SMTP id qd4mr13427135igb.13.1421059387048; Mon, 12 Jan 2015 02:43:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.25.200 with HTTP; Mon, 12 Jan 2015 02:42:46 -0800 (PST) In-Reply-To: References: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Mon, 12 Jan 2015 10:42:46 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi, In the meantime, I found that https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.html offers a fix to exactly this problem, but I didn't find in the emacs-24 bra= nch. Shouldn't it go to emacs-24 as well? Jo=C3=A3o On Mon, Jan 12, 2015 at 10:37 AM, GNU bug Tracking System wrote: > Thank you for filing a new bug report with debbugs.gnu.org. > > This is an automatically generated reply to let you know your message > has been received. > > Your message is being forwarded to the package maintainers and other > interested parties for their attention; they will reply in due course. > > Your message has been sent to the package maintainer(s): > bug-gnu-emacs@gnu.org > > If you wish to submit further information on this problem, please > send it to 19572@debbugs.gnu.org. > > Please do not send mail to help-debbugs@gnu.org unless you wish > to report a problem with the Bug-tracking system. > > -- > 19572: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19572 > GNU Bug Tracking System > Contact help-debbugs@gnu.org with problems --=20 Jo=C3=A3o T=C3=A1vora From unknown Sun Jun 22 22:46:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19572: Acknowledgement (24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries) Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jan 2015 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19572 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 19572@debbugs.gnu.org Received: via spool by 19572-submit@debbugs.gnu.org id=B19572.142107574927389 (code B ref 19572); Mon, 12 Jan 2015 15:16:02 +0000 Received: (at 19572) by debbugs.gnu.org; 12 Jan 2015 15:15:49 +0000 Received: from localhost ([127.0.0.1]:54618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAgib-00077h-4X for submit@debbugs.gnu.org; Mon, 12 Jan 2015 10:15:49 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:51607) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAgiY-00077R-Pe for 19572@debbugs.gnu.org; Mon, 12 Jan 2015 10:15:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Au8IAOwQflS4rwoL/2dsb2JhbABbgwdSWYI1xDYeCoYZBAICgSQXAQEBAQEBfIQDAQEBAgEBAlMjBQsLNAcLFBQEDSSISgkN1kwBAQEBAQUBAQEBARkEkG8HhEgFiwGKHoN5lheBeII3gWIhMAGCRgEBAQ X-IPAS-Result: Au8IAOwQflS4rwoL/2dsb2JhbABbgwdSWYI1xDYeCoYZBAICgSQXAQEBAQEBfIQDAQEBAgEBAlMjBQsLNAcLFBQEDSSISgkN1kwBAQEBAQUBAQEBARkEkG8HhEgFiwGKHoN5lheBeII3gWIhMAGCRgEBAQ X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="107570273" Received: from 184-175-10-11.dsl.teksavvy.com (HELO ceviche.home) ([184.175.10.11]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 12 Jan 2015 10:15:41 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 099FA660FB; Mon, 12 Jan 2015 10:15:41 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Mon, 12 Jan 2015 10:15:41 -0500 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 12 Jan 2015 10:42:46 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > In the meantime, I found that > > https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.html > > offers a fix to exactly this problem, but I didn't find in the > emacs-24 branch. > > Shouldn't it go to emacs-24 as well? Hmm... I guess you're right, it probably belongs in emacs-24. Can you backport it? Stefan From unknown Sun Jun 22 22:46:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19572: Acknowledgement (24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries) Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jan 2015 21:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19572 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 19572@debbugs.gnu.org Received: via spool by 19572-submit@debbugs.gnu.org id=B19572.142109671528136 (code B ref 19572); Mon, 12 Jan 2015 21:06:02 +0000 Received: (at 19572) by debbugs.gnu.org; 12 Jan 2015 21:05:15 +0000 Received: from localhost ([127.0.0.1]:54773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAmAl-0007Jj-C0 for submit@debbugs.gnu.org; Mon, 12 Jan 2015 16:05:15 -0500 Received: from ps18281.dreamhost.com ([69.163.222.226]:35515 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAmAi-0007Ja-Kj for 19572@debbugs.gnu.org; Mon, 12 Jan 2015 16:05:13 -0500 Received: from localhost.linkov.net (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id A6F4437291553D; Mon, 12 Jan 2015 13:05:10 -0800 (PST) From: Juri Linkov Organization: LINKOV.NET References: Date: Mon, 12 Jan 2015 23:02:05 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 12 Jan 2015 10:15:41 -0500") Message-ID: <87a91nbtm9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> In the meantime, I found that >> >> https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.html >> >> offers a fix to exactly this problem, but I didn't find in the >> emacs-24 branch. >> >> Shouldn't it go to emacs-24 as well? > > Hmm... I guess you're right, it probably belongs in emacs-24. > Can you backport it? Sorry, I didn't realize that support for multi-line input should go to emacs-24. The commits that need to be backported are: f6c3965074dbf5f355ecce739104fb89fb4d90f8 a0ae3d7331f6126941f90c6b80c293685004e165 From unknown Sun Jun 22 22:46:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19572: Acknowledgement (24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries) Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jan 2015 07:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19572 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov , 19572-done@debbugs.gnu.org Cc: Stefan Monnier , 19572@debbugs.gnu.org Received: via spool by 19572-submit@debbugs.gnu.org id=B19572.142113571312865 (code B ref 19572); Tue, 13 Jan 2015 07:56:02 +0000 Received: (at 19572) by debbugs.gnu.org; 13 Jan 2015 07:55:13 +0000 Received: from localhost ([127.0.0.1]:54929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAwJk-0003LL-4z for submit@debbugs.gnu.org; Tue, 13 Jan 2015 02:55:12 -0500 Received: from mail-ig0-f175.google.com ([209.85.213.175]:48743) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAwJh-0003L0-M2; Tue, 13 Jan 2015 02:55:10 -0500 Received: by mail-ig0-f175.google.com with SMTP id h15so15697084igd.2; Mon, 12 Jan 2015 23:55:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=aCt9v8/K1Yj1fll78eTaDNfBMyM0hDLkJ/kouB/qC0c=; b=y0ZvEiQPISkVxPT7T0umOLlu7Ww48FZTV7upnOZTDEShB8xewab2+3teN8hDBZf42F Y1/+WuXeXn2UYJvm8N9Cfd4dozdNCDaD0kMRnEPFccOE0xHejIoCUMV0nK6gJUw810Ta 7LlXdFSlfRgTPefWOWgNupKycNNzQzD97o1ndUyM11C6Kovp7Eu7Ji2KgwfFZeXcCYDZ j0P2JHyfhaH5aULaK3R7DXQsUyDudvVysnHky4XasmqSnEj9IhFKFdYwb4zY/XraOAVA SvcB6sA4TQx9fEFh9Mq8c6rPbDh+M7LjvZ4D1/isjTYhXwNZ2KyCGhcJVXk1+TUXVlx6 avVg== X-Received: by 10.50.134.65 with SMTP id pi1mr887018igb.32.1421135704005; Mon, 12 Jan 2015 23:55:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.34.68 with HTTP; Mon, 12 Jan 2015 23:54:43 -0800 (PST) In-Reply-To: <87a91nbtm9.fsf@mail.linkov.net> References: <87a91nbtm9.fsf@mail.linkov.net> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Tue, 13 Jan 2015 07:54:43 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Done. Two commits, one ChangeLog entry, informal backport references copied from what others do. Looked ok. On Mon, Jan 12, 2015 at 9:02 PM, Juri Linkov wrote: >>> In the meantime, I found that >>> >>> https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.htm= l >>> >>> offers a fix to exactly this problem, but I didn't find in the >>> emacs-24 branch. >>> >>> Shouldn't it go to emacs-24 as well? >> >> Hmm... I guess you're right, it probably belongs in emacs-24. >> Can you backport it? > > Sorry, I didn't realize that support for multi-line input should go > to emacs-24. The commits that need to be backported are: > > f6c3965074dbf5f355ecce739104fb89fb4d90f8 > a0ae3d7331f6126941f90c6b80c293685004e165 --=20 Jo=C3=A3o T=C3=A1vora From unknown Sun Jun 22 22:46:41 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Subject: bug#19572: closed (Re: bug#19572: Acknowledgement (24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries)) Message-ID: References: X-Gnu-PR-Message: they-closed 19572 X-Gnu-PR-Package: emacs Reply-To: 19572@debbugs.gnu.org Date: Tue, 13 Jan 2015 07:56:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1421135763-12938-1" This is a multi-part message in MIME format... ------------=_1421135763-12938-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #19572: 24.4; M-x comint-history-isearch-backward doesn't search multi-line= history entries which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19572@debbugs.gnu.org. --=20 19572: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19572 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1421135763-12938-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 19572-done) by debbugs.gnu.org; 13 Jan 2015 07:55:12 +0000 Received: from localhost ([127.0.0.1]:54927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAwJj-0003LJ-IP for submit@debbugs.gnu.org; Tue, 13 Jan 2015 02:55:11 -0500 Received: from mail-ig0-f175.google.com ([209.85.213.175]:48743) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAwJh-0003L0-M2; Tue, 13 Jan 2015 02:55:10 -0500 Received: by mail-ig0-f175.google.com with SMTP id h15so15697084igd.2; Mon, 12 Jan 2015 23:55:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=aCt9v8/K1Yj1fll78eTaDNfBMyM0hDLkJ/kouB/qC0c=; b=y0ZvEiQPISkVxPT7T0umOLlu7Ww48FZTV7upnOZTDEShB8xewab2+3teN8hDBZf42F Y1/+WuXeXn2UYJvm8N9Cfd4dozdNCDaD0kMRnEPFccOE0xHejIoCUMV0nK6gJUw810Ta 7LlXdFSlfRgTPefWOWgNupKycNNzQzD97o1ndUyM11C6Kovp7Eu7Ji2KgwfFZeXcCYDZ j0P2JHyfhaH5aULaK3R7DXQsUyDudvVysnHky4XasmqSnEj9IhFKFdYwb4zY/XraOAVA SvcB6sA4TQx9fEFh9Mq8c6rPbDh+M7LjvZ4D1/isjTYhXwNZ2KyCGhcJVXk1+TUXVlx6 avVg== X-Received: by 10.50.134.65 with SMTP id pi1mr887018igb.32.1421135704005; Mon, 12 Jan 2015 23:55:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.34.68 with HTTP; Mon, 12 Jan 2015 23:54:43 -0800 (PST) In-Reply-To: <87a91nbtm9.fsf@mail.linkov.net> References: <87a91nbtm9.fsf@mail.linkov.net> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 13 Jan 2015 07:54:43 +0000 Message-ID: Subject: Re: bug#19572: Acknowledgement (24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries) To: Juri Linkov , 19572-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19572-done Cc: Stefan Monnier , 19572@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Done. Two commits, one ChangeLog entry, informal backport references copied from what others do. Looked ok. On Mon, Jan 12, 2015 at 9:02 PM, Juri Linkov wrote: >>> In the meantime, I found that >>> >>> https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.htm= l >>> >>> offers a fix to exactly this problem, but I didn't find in the >>> emacs-24 branch. >>> >>> Shouldn't it go to emacs-24 as well? >> >> Hmm... I guess you're right, it probably belongs in emacs-24. >> Can you backport it? > > Sorry, I didn't realize that support for multi-line input should go > to emacs-24. The commits that need to be backported are: > > f6c3965074dbf5f355ecce739104fb89fb4d90f8 > a0ae3d7331f6126941f90c6b80c293685004e165 --=20 Jo=C3=A3o T=C3=A1vora ------------=_1421135763-12938-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Jan 2015 10:36:29 +0000 Received: from localhost ([127.0.0.1]:54057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAcMH-0007MT-Gh for submit@debbugs.gnu.org; Mon, 12 Jan 2015 05:36:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58784) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAcMF-0007ME-HV for submit@debbugs.gnu.org; Mon, 12 Jan 2015 05:36:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAcM9-0001rG-DM for submit@debbugs.gnu.org; Mon, 12 Jan 2015 05:36:22 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAcM9-0001rC-Ad for submit@debbugs.gnu.org; Mon, 12 Jan 2015 05:36:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAcM8-0005pf-JE for bug-gnu-emacs@gnu.org; Mon, 12 Jan 2015 05:36:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAcM5-0001qd-De for bug-gnu-emacs@gnu.org; Mon, 12 Jan 2015 05:36:20 -0500 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:38490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAcM5-0001qU-7n for bug-gnu-emacs@gnu.org; Mon, 12 Jan 2015 05:36:17 -0500 Received: by mail-wi0-f182.google.com with SMTP id h11so13580737wiw.3 for ; Mon, 12 Jan 2015 02:36:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type:content-transfer-encoding; bh=EuC2lOR7AcCNXjrwQc+HxdDyh1SJ1Vt6HxS2eYScWuI=; b=b6PzCuna2iEFQl2TpDdaG5UGlDpJDtSYS1Ely+HZXEtkQU4VRRTC6HV7dhstqFsvVF 55h1o92NDVKo8jXKbgYuptBSOTh/u7mc3Xg4zrbWO7VEPJnnSvmSOv2gz8doiB2QhgoJ 9TBB1l+us2XMknjhfaWQkZF2lRuphyzjO1eXXcCoOE//GqQUNpQ3IbM2hMLWnp18M9EK y7X/Da5fORf/X3X74bcU1mT+/Tpmtk/0cdYhHMBPNqW9aAvZUcNBHBW8pNp1n3sdX71r MTcsv1Zfp5wChszQdbMvvIoLzAo6pPwA94dnUGKlTk7iDql/jqyR0EAliXJiEejO6DIk 2jsw== X-Received: by 10.194.63.169 with SMTP id h9mr262117wjs.23.1421058976246; Mon, 12 Jan 2015 02:36:16 -0800 (PST) Received: from GONDOMAR.yourcompany.com (53.236.108.93.rev.vodafone.pt. [93.108.236.53]) by mx.google.com with ESMTPSA id fo2sm9651188wib.10.2015.01.12.02.36.14 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Jan 2015 02:36:15 -0800 (PST) From: joaotavora@gmail.com (=?iso-8859-1?Q?Jo=E3o_T=E1vora?=) To: bug-gnu-emacs@gnu.org Subject: 24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries Date: Mon, 12 Jan 2015 10:36:12 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -Q M-x ielm RET 'foo RET 'bar RET '(baz M-j bin) RET M-x comint-history-isearch-backward RET b a z expected the multi-line entry to be restored to input, but comint.el fails to find it. This is because `comint-history-isearch-search' uses (goto-char (comint-line-beginning-position)) I think it should use `comint-goto-process-mark'. comint.el is a big beast but I think this makes sense. Should I fix it thusly? (unless anyone beats me to it) Jo=E3o ------------=_1421135763-12938-1--