GNU bug report logs - #19572
24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19572 in the body.
You can then email your comments to 19572 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: joaotavora <at> gmail.com (João Távora)
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4;
 M-x comint-history-isearch-backward doesn't search multi-line history
 entries
Date: Mon, 12 Jan 2015 10:36:12 +0000

   emacs -Q
   M-x ielm RET
   'foo RET
   'bar RET
   '(baz M-j bin) RET
   M-x comint-history-isearch-backward RET b a z

expected the multi-line entry to be restored to input, but
comint.el fails to find it.

This is because `comint-history-isearch-search' uses

    (goto-char (comint-line-beginning-position))

I think it should use `comint-goto-process-mark'. comint.el is a big
beast but I think this makes sense. Should I fix it thusly? (unless
anyone beats me to it)

João

Message #8 received at 19572 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: 19572 <at> debbugs.gnu.org
Subject: Re: bug#19572: Acknowledgement (24.4;
 M-x comint-history-isearch-backward
 doesn't search multi-line history entries)
Date: Mon, 12 Jan 2015 10:42:46 +0000

Hi,

In the meantime, I found that

    https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.html

offers a fix to exactly this problem, but I didn't find in the emacs-24 branch.

Shouldn't it go to emacs-24 as well?

João

On Mon, Jan 12, 2015 at 10:37 AM, GNU bug Tracking System
<help-debbugs <at> gnu.org> wrote:
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
>  bug-gnu-emacs <at> gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 19572 <at> debbugs.gnu.org.
>
> Please do not send mail to help-debbugs <at> gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
> --
> 19572: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19572
> GNU Bug Tracking System
> Contact help-debbugs <at> gnu.org with problems



-- 
João Távora

Message #11 received at 19572 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: João Távora <joaotavora <at> gmail.com>
Cc: 19572 <at> debbugs.gnu.org
Subject: Re: bug#19572: Acknowledgement (24.4;
 M-x comint-history-isearch-backward doesn't search multi-line history
 entries)
Date: Mon, 12 Jan 2015 10:15:41 -0500

> In the meantime, I found that
>
>     https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.html
>
> offers a fix to exactly this problem, but I didn't find in the
> emacs-24 branch.
>
> Shouldn't it go to emacs-24 as well?

Hmm... I guess you're right, it probably belongs in emacs-24.
Can you backport it?


        Stefan

Message #14 received at 19572 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: João Távora <joaotavora <at> gmail.com>,
 19572 <at> debbugs.gnu.org
Subject: Re: bug#19572: Acknowledgement (24.4;
 M-x comint-history-isearch-backward doesn't search multi-line history
 entries)
Date: Mon, 12 Jan 2015 23:02:05 +0200

>> In the meantime, I found that
>>
>>     https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.html
>>
>> offers a fix to exactly this problem, but I didn't find in the
>> emacs-24 branch.
>>
>> Shouldn't it go to emacs-24 as well?
>
> Hmm... I guess you're right, it probably belongs in emacs-24.
> Can you backport it?

Sorry, I didn't realize that support for multi-line input should go
to emacs-24.  The commits that need to be backported are:

f6c3965074dbf5f355ecce739104fb89fb4d90f8
a0ae3d7331f6126941f90c6b80c293685004e165

Message #17 received at 19572 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>, 19572-done <at> debbugs.gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 19572 <at> debbugs.gnu.org
Subject: Re: bug#19572: Acknowledgement (24.4;
 M-x comint-history-isearch-backward
 doesn't search multi-line history entries)
Date: Tue, 13 Jan 2015 07:54:43 +0000

Done. Two commits, one ChangeLog entry, informal backport references
copied from what others do. Looked ok.

On Mon, Jan 12, 2015 at 9:02 PM, Juri Linkov <juri <at> linkov.net> wrote:
>>> In the meantime, I found that
>>>
>>>     https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.html
>>>
>>> offers a fix to exactly this problem, but I didn't find in the
>>> emacs-24 branch.
>>>
>>> Shouldn't it go to emacs-24 as well?
>>
>> Hmm... I guess you're right, it probably belongs in emacs-24.
>> Can you backport it?
>
> Sorry, I didn't realize that support for multi-line input should go
> to emacs-24.  The commits that need to be backported are:
>
> f6c3965074dbf5f355ecce739104fb89fb4d90f8
> a0ae3d7331f6126941f90c6b80c293685004e165



-- 
João Távora

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.