From unknown Sun Jun 22 04:34:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19566: (unload-feature 'misearch) breaks isearch Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jan 2015 11:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19566 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 19566@debbugs.gnu.org X-Debbugs-Original-To: submit@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.142097629428021 (code B ref -1); Sun, 11 Jan 2015 11:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jan 2015 11:38:14 +0000 Received: from localhost ([127.0.0.1]:42411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAGqT-0007Hs-7C for submit@debbugs.gnu.org; Sun, 11 Jan 2015 06:38:13 -0500 Received: from fely.am-1.org ([78.47.74.50]:48880) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAGqP-0007Hf-Ip for submit@debbugs.gnu.org; Sun, 11 Jan 2015 06:38:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=ahjmLOeeG0N8tSJ9sVHH/FFWTuksvsmox5jt751GMHE=; b=nqrqxWH4398qKVP+mgCbwlj+yNteDcLsihzKWHljaiJ3E0mEDi+Ta2MF1Ri5l0Zds9J1EEn/h3TiVK54wDf6pJGE1mJZ/KR7YS0kgRYwdZwYIFu4I5xVZG4vo4XSFVdMOXmmmU8ygjA1L+yoIo++v/N+rCtmJl32odFFPQRkBzc=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YAGqL-0003KQ-Tj for submit@debbugs.gnu.org; Sun, 11 Jan 2015 11:38:06 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YAGqE-0005GZ-Ih for submit@debbugs.gnu.org; Sun, 11 Jan 2015 18:37:58 +0700 From: Ivan Shmakov Date: Sun, 11 Jan 2015 11:37:57 +0000 Message-ID: <87y4p9y2cq.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Severity: minor Tags: patch Using unload-feature to unload misearch.el also undefines the autoloaded variables, which breaks isearch.el as it still uses them. Please thus consider the patch MIMEd. * lisp/misearch.el (multi-isearch-unload-function): New function to retain definitions of autoloaded variables when unloading. (misearch-unload-function): New alias. --=20 FSF associate member #7257 np. The Middle Path =E2=80=94 David Modica B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/misearch.el +++ b/lisp/misearch.el @@ -377,6 +377,25 @@ (goto-char (if isearch-forward (point-min) (point-max))) (isearch-forward-regexp nil t))) +(defun multi-isearch-unload-function () + "Remove autoloaded variables from `unload-function-defs-list'. +Also prevent the feature from being reloaded via `isearch-mode-hook'." + (remove-hook 'isearch-mode-hook 'multi-isearch-setup) + (let ((defs (list (car unload-function-defs-list))) + (auto '(multi-isearch-next-buffer-function + multi-isearch-next-buffer-current-function + multi-isearch-current-buffer + multi-isearch-buffer-list multi-isearch-file-list))) + (dolist (def (cdr unload-function-defs-list)) + (unless (and (symbolp def) + (memq def auto)) + (push def defs))) + (setq unload-function-defs-list (nreverse defs)) + ;; . + nil)) + +(defalias 'misearch-unload-function 'multi-isearch-unload-function) + (provide 'multi-isearch) (provide 'misearch) --=-=-=-- From unknown Sun Jun 22 04:34:49 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19566: (unload-feature 'misearch) breaks isearch Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jan 2015 21:03:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19566 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Ivan Shmakov Cc: 19566@debbugs.gnu.org Received: via spool by 19566-submit@debbugs.gnu.org id=B19566.142101014726883 (code B ref 19566); Sun, 11 Jan 2015 21:03:03 +0000 Received: (at 19566) by debbugs.gnu.org; 11 Jan 2015 21:02:27 +0000 Received: from localhost ([127.0.0.1]:42906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAPeU-0006zW-Lb for submit@debbugs.gnu.org; Sun, 11 Jan 2015 16:02:26 -0500 Received: from ps18281.dreamhost.com ([69.163.222.226]:48970 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAPeT-0006zM-1C for 19566@debbugs.gnu.org; Sun, 11 Jan 2015 16:02:25 -0500 Received: from localhost.linkov.net (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 23C8331601D70B; Sun, 11 Jan 2015 13:02:22 -0800 (PST) From: Juri Linkov Organization: LINKOV.NET References: <87y4p9y2cq.fsf@violet.siamics.net> Date: Sun, 11 Jan 2015 22:44:15 +0200 In-Reply-To: <87y4p9y2cq.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sun, 11 Jan 2015 11:37:57 +0000") Message-ID: <87387hvyy7.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Using unload-feature to unload misearch.el also undefines the > autoloaded variables, which breaks isearch.el as it still uses > them. > > Please thus consider the patch MIMEd. > > * lisp/misearch.el (multi-isearch-unload-function): New function > to retain definitions of autoloaded variables when unloading. > (misearch-unload-function): New alias. Even though I see no way to reproduce the test case which breaks isearch.el (after unloading, isearch.el just re-loads misearch.el again), I agree that we definitely should correctly unload them. From unknown Sun Jun 22 04:34:49 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ivan Shmakov Subject: bug#19566: closed (Re: bug#19566: unloading support for misearch ) Message-ID: References: <8761bxpo98.fsf@violet.siamics.net> <87y4p9y2cq.fsf@violet.siamics.net> X-Gnu-PR-Message: they-closed 19566 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 19566@debbugs.gnu.org Date: Fri, 23 Jan 2015 14:27:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1422023223-7585-1" This is a multi-part message in MIME format... ------------=_1422023223-7585-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #19566: (unload-feature 'misearch) breaks isearch=20 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19566@debbugs.gnu.org. --=20 19566: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19566 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1422023223-7585-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 19566-done) by debbugs.gnu.org; 23 Jan 2015 14:26:10 +0000 Received: from localhost ([127.0.0.1]:53667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEfBZ-0001xF-6k for submit@debbugs.gnu.org; Fri, 23 Jan 2015 09:26:09 -0500 Received: from fely.am-1.org ([78.47.74.50]:50652) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEfBU-0001x5-VN for 19566-done@debbugs.gnu.org; Fri, 23 Jan 2015 09:26:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=dVRcb7e6cUAhOE+/kRwL80R36Br0KayyBgEpzEafif4=; b=GHgGmZwP9+F5jilu2U0aPmKUcNc+Nd5GUVHyNvat80Y3UvkibDXGDFKSL7wFYrT26a5NV4lb9Sh2JE9iiltPkzjkqQtl6zz2Ztqomh7RwOSmzngIvUoTkMxkUTRcBTpWtIs1jrMA9yJv9+WP/nDgWnm2yHKE40Ek0RBLD8olMhI=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YEfBT-0002BQ-1Q for 19566-done@debbugs.gnu.org; Fri, 23 Jan 2015 14:26:03 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YEfBL-0002dp-Rl for 19566-done@debbugs.gnu.org; Fri, 23 Jan 2015 21:25:55 +0700 From: Ivan Shmakov To: 19566-done@debbugs.gnu.org Subject: Re: bug#19566: unloading support for misearch References: <87y4p9y2cq.fsf@violet.siamics.net> Mail-Followup-To: 19566@debbugs.gnu.org Date: Fri, 23 Jan 2015 14:25:55 +0000 In-Reply-To: <87y4p9y2cq.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sun, 11 Jan 2015 11:37:57 +0000") Message-ID: <8761bxpo98.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 19566-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Version: 25.1 I=E2=80=99ve pushed the change proposed to =E2=80=98master=E2=80=99 last S= aturday; closing. commit 0aaa5d699bf95afb152317f0788b8e2d2042f59d CommitDate: Sat Jan 17 19:35:52 2015 +0000 Unloading support for misearch. * lisp/misearch.el (multi-isearch-unload-function): New function. (misearch-unload-function): New alias. Fixes: debbugs:19566 --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A ------------=_1422023223-7585-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Jan 2015 11:38:14 +0000 Received: from localhost ([127.0.0.1]:42411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAGqT-0007Hs-7C for submit@debbugs.gnu.org; Sun, 11 Jan 2015 06:38:13 -0500 Received: from fely.am-1.org ([78.47.74.50]:48880) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAGqP-0007Hf-Ip for submit@debbugs.gnu.org; Sun, 11 Jan 2015 06:38:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=ahjmLOeeG0N8tSJ9sVHH/FFWTuksvsmox5jt751GMHE=; b=nqrqxWH4398qKVP+mgCbwlj+yNteDcLsihzKWHljaiJ3E0mEDi+Ta2MF1Ri5l0Zds9J1EEn/h3TiVK54wDf6pJGE1mJZ/KR7YS0kgRYwdZwYIFu4I5xVZG4vo4XSFVdMOXmmmU8ygjA1L+yoIo++v/N+rCtmJl32odFFPQRkBzc=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YAGqL-0003KQ-Tj for submit@debbugs.gnu.org; Sun, 11 Jan 2015 11:38:06 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YAGqE-0005GZ-Ih for submit@debbugs.gnu.org; Sun, 11 Jan 2015 18:37:58 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: (unload-feature 'misearch) breaks isearch Date: Sun, 11 Jan 2015 11:37:57 +0000 Message-ID: <87y4p9y2cq.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Severity: minor Tags: patch Using unload-feature to unload misearch.el also undefines the autoloaded variables, which breaks isearch.el as it still uses them. Please thus consider the patch MIMEd. * lisp/misearch.el (multi-isearch-unload-function): New function to retain definitions of autoloaded variables when unloading. (misearch-unload-function): New alias. --=20 FSF associate member #7257 np. The Middle Path =E2=80=94 David Modica B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/misearch.el +++ b/lisp/misearch.el @@ -377,6 +377,25 @@ (goto-char (if isearch-forward (point-min) (point-max))) (isearch-forward-regexp nil t))) +(defun multi-isearch-unload-function () + "Remove autoloaded variables from `unload-function-defs-list'. +Also prevent the feature from being reloaded via `isearch-mode-hook'." + (remove-hook 'isearch-mode-hook 'multi-isearch-setup) + (let ((defs (list (car unload-function-defs-list))) + (auto '(multi-isearch-next-buffer-function + multi-isearch-next-buffer-current-function + multi-isearch-current-buffer + multi-isearch-buffer-list multi-isearch-file-list))) + (dolist (def (cdr unload-function-defs-list)) + (unless (and (symbolp def) + (memq def auto)) + (push def defs))) + (setq unload-function-defs-list (nreverse defs)) + ;; . + nil)) + +(defalias 'misearch-unload-function 'multi-isearch-unload-function) + (provide 'multi-isearch) (provide 'misearch) --=-=-=-- ------------=_1422023223-7585-1--