From unknown Wed Aug 20 05:43:13 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#19547 <19547@debbugs.gnu.org> To: bug#19547 <19547@debbugs.gnu.org> Subject: Status: 25.0.50; throw-on-input "fires" when switching workspace Reply-To: bug#19547 <19547@debbugs.gnu.org> Date: Wed, 20 Aug 2025 12:43:13 +0000 retitle 19547 25.0.50; throw-on-input "fires" when switching workspace reassign 19547 emacs submitter 19547 michael_heerdegen@web.de severity 19547 normal tag 19547 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 09 10:47:21 2015 Received: (at submit) by debbugs.gnu.org; 9 Jan 2015 15:47:21 +0000 Received: from localhost ([127.0.0.1]:41042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9bmS-0004lF-PV for submit@debbugs.gnu.org; Fri, 09 Jan 2015 10:47:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44150) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9bmP-0004l4-24 for submit@debbugs.gnu.org; Fri, 09 Jan 2015 10:47:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9bmN-0003Xc-4s for submit@debbugs.gnu.org; Fri, 09 Jan 2015 10:47:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9bmN-0003XW-24 for submit@debbugs.gnu.org; Fri, 09 Jan 2015 10:47:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9bmM-0006FN-1n for bug-gnu-emacs@gnu.org; Fri, 09 Jan 2015 10:47:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9bmH-0003Vu-Rm for bug-gnu-emacs@gnu.org; Fri, 09 Jan 2015 10:47:13 -0500 Received: from mout.web.de ([212.227.15.3]:52416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9bmH-0003VL-ER for bug-gnu-emacs@gnu.org; Fri, 09 Jan 2015 10:47:09 -0500 Received: from drachen.dragon ([90.186.20.170]) by smtp.web.de (mrweb001) with ESMTPSA (Nemesis) id 0LzK2z-1Xn4hc2mwr-014QmO for ; Fri, 09 Jan 2015 16:47:05 +0100 From: Michael Heerdegen To: bug-gnu-emacs@gnu.org Subject: 25.0.50; throw-on-input "fires" when switching workspace Date: Fri, 09 Jan 2015 16:46:58 +0100 Message-ID: <874ms03qj1.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:1GM9Fi4cVn1sv0V1djeZpTDz5r7kVQgtaKIZ1cL3Tw7KBO3oHim L5717Y1QtvmEbzUg8UAqNZ325crNDnT0uAOwLyO/4Uqm8PkIEDWjxbufWDcIEJo4cd2fCNM cDzLPVJYFJqhvK4tn9YPHKkQydx6zrjCUKP6I6u56ARQ2M7kM4aKVXf5cml3EurRtj8+XLd QzJTvqEFXXnOviZn1xAYg== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: michael_heerdegen@web.de List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Hello, I'm using Debian Gnu/Linux here. Eval (catch 'tag (let ((throw-on-input 'tag)) (while t))) and switch to a different (X) workspace. The loop is exited immediately. I don't think it is useful to count switching workspaces as input. I hope we can change this. Some background: in Helm, we use `while-no-input' around the code performing the matching against the candidates. This way, we can immediately react when new input arrives - we avoid a delay caused by finishing matching candidates against an obsolete input pattern. But currently, when you switch to a different workspace while matching is performed, Helm stops matching. Of course we could work around this and restart matching anew in such a case, but it would be better if switching desktops would not tangle Emacs at all. It is counter-intuitive, at least in this scenario. The doc of throw-on-input only speaks about "keyboard input". Thanks, Michael. In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.14.5) of 2015-01-08 on drachen Windowing system distributor `The X.Org Foundation', version 11.0.11602901 System Description: Debian GNU/Linux 8.0 (jessie) Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GSETTINGS NOTIFY LIBXML2 FREETYPE XFT ZLIB Important settings: value of $LC_ALL: de_DE.utf8 value of $LC_COLLATE: C value of $LC_TIME: C value of $LANG: de_DE.utf8 locale-coding-system: utf-8-unix From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 09 14:59:38 2015 Received: (at 19547) by debbugs.gnu.org; 9 Jan 2015 19:59:38 +0000 Received: from localhost ([127.0.0.1]:41115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9fic-0002YK-55 for submit@debbugs.gnu.org; Fri, 09 Jan 2015 14:59:38 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:47703) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9fiZ-0002YB-LT for 19547@debbugs.gnu.org; Fri, 09 Jan 2015 14:59:37 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NHX00M00DO9NT00@a-mtaout20.012.net.il> for 19547@debbugs.gnu.org; Fri, 09 Jan 2015 21:59:33 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHX00MMQE79FPA0@a-mtaout20.012.net.il>; Fri, 09 Jan 2015 21:59:33 +0200 (IST) Date: Fri, 09 Jan 2015 21:59:51 +0200 From: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace In-reply-to: <874ms03qj1.fsf@web.de> X-012-Sender: halo1@inter.net.il To: michael_heerdegen@web.de Message-id: <83387j67yg.fsf@gnu.org> References: <874ms03qj1.fsf@web.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Heerdegen > Date: Fri, 09 Jan 2015 16:46:58 +0100 > > (catch 'tag > (let ((throw-on-input 'tag)) > (while t))) > > and switch to a different (X) workspace. The loop is exited > immediately. > > I don't think it is useful to count switching workspaces as input. I > hope we can change this. > > Some background: in Helm, we use `while-no-input' around the code > performing the matching against the candidates. This way, we can > immediately react when new input arrives - we avoid a delay caused by > finishing matching candidates against an obsolete input pattern. > > But currently, when you switch to a different workspace while matching > is performed, Helm stops matching. > > Of course we could work around this and restart matching anew in such a > case, but it would be better if switching desktops would not tangle > Emacs at all. It is counter-intuitive, at least in this scenario. The > doc of throw-on-input only speaks about "keyboard input". Documentation problems aside, you can't usefully define which events will be considered as input and which won't, in a way that would DTRT for everyone. The decision is specific to the application, and while-no-input cannot know that. It could be that this particular event can be filtered out, but that's just the top of the iceberg. There are way too many different events flowing into Emacs on a typical modern system, keyboard being just a small part of that. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 09 16:48:36 2015 Received: (at 19547) by debbugs.gnu.org; 9 Jan 2015 21:48:36 +0000 Received: from localhost ([127.0.0.1]:41189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9hQ4-0005GO-Bk for submit@debbugs.gnu.org; Fri, 09 Jan 2015 16:48:36 -0500 Received: from mout.web.de ([212.227.15.4]:50874) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9hQ0-0005GD-Bb for 19547@debbugs.gnu.org; Fri, 09 Jan 2015 16:48:33 -0500 Received: from drachen.dragon ([90.186.20.170]) by smtp.web.de (mrweb003) with ESMTPSA (Nemesis) id 0LvBJK-1XjxK33zGc-010OCK; Fri, 09 Jan 2015 22:48:30 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace References: <874ms03qj1.fsf@web.de> <83387j67yg.fsf@gnu.org> Date: Fri, 09 Jan 2015 22:48:25 +0100 In-Reply-To: <83387j67yg.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 09 Jan 2015 21:59:51 +0200") Message-ID: <87ppanwrpy.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:YUi0Qh/8oARcVXtFH6aotdP/E4gydvOavjxnAdZx426vjOhN74l AmMJEN3zdQeEvt7mn40tF+Rjw+V8UNm3iR9ZUey84fwmYHlNVceCCXpyXEIhtQzwIkwjgdH YPAkmnlXmtPrmEXq8gRC1+4VefgkB7sFeL/Pf8Hn8xlxVzWK6DWvDszqYlXgwP87wACCc/N xnKJE5wxZ/j0V8ixKaDAw== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: > It could be that this particular event can be filtered out, but that's > just the top of the iceberg. There are way too many different events > flowing into Emacs on a typical modern system, keyboard being just a > small part of that. Mmh, I expected that this could be the case. But is there no more or less reasonable way to classify events? Probably not... If there is nothing that can be done about this report - do you see a solution for the problem we see in Helm? Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 09 18:33:14 2015 Received: (at 19547) by debbugs.gnu.org; 9 Jan 2015 23:33:14 +0000 Received: from localhost ([127.0.0.1]:41254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9j3J-0007s8-TM for submit@debbugs.gnu.org; Fri, 09 Jan 2015 18:33:14 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:34929) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9j3H-0007rz-4k for 19547@debbugs.gnu.org; Fri, 09 Jan 2015 18:33:12 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aj8PAOwQflS4rwoL/2dsb2JhbABbgweDYIVawjuCYgQCAoEkFwEBAQEBAXyEAwEBAwFWIwULCzQSFBgNJC6IHAnWWQEBAQEBAQQBAQEBHpBvB4RIBYsBpC6BeIQZIYJ3AQEB X-IPAS-Result: Aj8PAOwQflS4rwoL/2dsb2JhbABbgweDYIVawjuCYgQCAoEkFwEBAQEBAXyEAwEBAwFWIwULCzQSFBgNJC6IHAnWWQEBAQEBAQQBAQEBHpBvB4RIBYsBpC6BeIQZIYJ3AQEB X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="107249587" Received: from 184-175-10-11.dsl.teksavvy.com (HELO ceviche.home) ([184.175.10.11]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 09 Jan 2015 18:33:10 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 346D966100; Fri, 9 Jan 2015 18:33:10 -0500 (EST) From: Stefan Monnier To: Michael Heerdegen Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace Message-ID: References: <874ms03qj1.fsf@web.de> Date: Fri, 09 Jan 2015 18:33:10 -0500 In-Reply-To: <874ms03qj1.fsf@web.de> (Michael Heerdegen's message of "Fri, 09 Jan 2015 16:46:58 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > (catch 'tag > (let ((throw-on-input 'tag)) > (while t))) > > and switch to a different (X) workspace. The loop is exited > immediately. Can you check with C-h l what event Emacs received? > If there is nothing that can be done about this report - That's probably the case. The intention of while-no-input is to abort in response any input that might need execution of Elisp code. So if the event you receive upon workspace-switch might trigger execution of Elisp code, it's probably right for while-no-input to abort. > do you see a solution for the problem we see in Helm? I don't understand exactly the problem you're seeing. Why is it a problem to stop computing the matching candidates when the user switches to another workspace? If "switches to another workspace" means that the selected Emacs frame disappears (a likely scenario), then it seems harmless to stop computing the candidates. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 09 19:01:05 2015 Received: (at 19547) by debbugs.gnu.org; 10 Jan 2015 00:01:06 +0000 Received: from localhost ([127.0.0.1]:41276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9jUH-0001Bw-CC for submit@debbugs.gnu.org; Fri, 09 Jan 2015 19:01:05 -0500 Received: from mout.web.de ([212.227.15.4]:61221) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9jUF-00018M-2K for 19547@debbugs.gnu.org; Fri, 09 Jan 2015 19:01:03 -0500 Received: from drachen.dragon ([90.186.20.170]) by smtp.web.de (mrweb001) with ESMTPSA (Nemesis) id 0Lsy7e-1Xm6iY487u-012UtR; Sat, 10 Jan 2015 01:00:57 +0100 From: Michael Heerdegen To: Stefan Monnier Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace References: <874ms03qj1.fsf@web.de> Date: Sat, 10 Jan 2015 01:00:50 +0100 In-Reply-To: (Stefan Monnier's message of "Fri, 09 Jan 2015 18:33:10 -0500") Message-ID: <87zj9r4i8d.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:T5VuEZh5CFxaz4cKvHy6rTP5hpXUFxTwcjvs2owunM9X1HOAsRk QIO0PkaKP2K5QuFuF4BavSSQlR79jxwVxP9sAQ1NtQQXWIecYHPfz5edcjzTi8o1NlKAnr4 R949uK++evVsWkbkgEyQEqWin0FzMf32Su18nLpnQb5cf7c45ch1yx+BZq1CpYXbl1WbsI5 CvZ8Fk8dyupRuruGPHx3A== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Stefan Monnier writes: > > (catch 'tag > > (let ((throw-on-input 'tag)) > > (while t))) > > > > and switch to a different (X) workspace. The loop is exited > > immediately. > > Can you check with C-h l what event Emacs received? The event isn't listed there. I think it is focus-out or something like that. > I don't understand exactly the problem you're seeing. Why is it > a problem to stop computing the matching candidates when the user > switches to another workspace? If "switches to another workspace" > means that the selected Emacs frame disappears (a likely scenario) Exactly. > then it seems harmless to stop computing the candidates. I switch to a different workspace (or focus a different application) to do something useful until matching has finished. Imagine you have opened some large page on firefox, switch to another app to do something else until the page is ready, and when you come back to firefox, it shows a blank page, because it considers losing focus as an important user input and just stops rendering. That's what Helm currently does with candidate matching cause it relies (and needs to rely) on while-no-input. Note that Helm can't just continue performing matching later, because throw-on-input made Emacs jump out of the code. Which is what we want of cause when there was any "real" user input, i.e., when the user added text to the matching pattern for example. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 09 20:26:48 2015 Received: (at 19547) by debbugs.gnu.org; 10 Jan 2015 01:26:48 +0000 Received: from localhost ([127.0.0.1]:41295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9kpD-0003XF-Q3 for submit@debbugs.gnu.org; Fri, 09 Jan 2015 20:26:48 -0500 Received: from mout.web.de ([212.227.15.14]:55768) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9kpC-0003X7-8C for 19547@debbugs.gnu.org; Fri, 09 Jan 2015 20:26:46 -0500 Received: from drachen.dragon ([90.186.20.170]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0ML8Az-1YA1o041L7-000IOA; Sat, 10 Jan 2015 02:26:42 +0100 From: Michael Heerdegen To: Stefan Monnier Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> Date: Sat, 10 Jan 2015 02:26:32 +0100 In-Reply-To: <87zj9r4i8d.fsf@web.de> (Michael Heerdegen's message of "Sat, 10 Jan 2015 01:00:50 +0100") Message-ID: <87sifj4e9j.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:5EKE4kO8kjTI0iOXO35MEW5Zj9POYYA+1iKAcejCzH5EyXSBMxL TtfsQFnV1wkn/o1HdpLHJaI4OyNxQVlVRnLGMaT/h3pHzu/Y9vuVKMSlp1O5YDRCXjeSOb1 5Ol9/dYzuBYL5i/6jDFZfKXDv4JseM2//7CYtlAVORpSnRFoCHMaC1NKdSSR3TYwmp3ug68 KjkIMzc+N9qJAVbN6Rcjg== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Michael Heerdegen writes: > The event isn't listed there. I think it is focus-out or something like > that. Switching to a different workspace lets Emacs create an iconify-frame event. That one is probably the one letting throw-on-input fire, because it is the first event generated. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 10 04:12:33 2015 Received: (at 19547) by debbugs.gnu.org; 10 Jan 2015 09:12:33 +0000 Received: from localhost ([127.0.0.1]:41445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9s5x-0006vq-0W for submit@debbugs.gnu.org; Sat, 10 Jan 2015 04:12:33 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:40492) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9s5t-0006vf-Ua for 19547@debbugs.gnu.org; Sat, 10 Jan 2015 04:12:31 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NHY00300EW9R000@a-mtaout23.012.net.il> for 19547@debbugs.gnu.org; Sat, 10 Jan 2015 11:12:28 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHY0039JEWRLP90@a-mtaout23.012.net.il>; Sat, 10 Jan 2015 11:12:28 +0200 (IST) Date: Sat, 10 Jan 2015 11:12:47 +0200 From: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace In-reply-to: <87sifj4e9j.fsf@web.de> X-012-Sender: halo1@inter.net.il To: Michael Heerdegen Message-id: <83egr36ltc.fsf@gnu.org> References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19547 Cc: monnier@iro.umontreal.ca, 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Heerdegen > Date: Sat, 10 Jan 2015 02:26:32 +0100 > Cc: 19547@debbugs.gnu.org > > Michael Heerdegen writes: > > > The event isn't listed there. I think it is focus-out or something like > > that. > > Switching to a different workspace lets Emacs create an iconify-frame > event. That one is probably the one letting throw-on-input fire, > because it is the first event generated. I suggest to establish exactly which event causes that, then we could focus on how to filter that out, either in general or in your specific situation. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 10 04:14:47 2015 Received: (at 19547) by debbugs.gnu.org; 10 Jan 2015 09:14:47 +0000 Received: from localhost ([127.0.0.1]:41449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9s83-0006zS-KY for submit@debbugs.gnu.org; Sat, 10 Jan 2015 04:14:47 -0500 Received: from mtaout29.012.net.il ([80.179.55.185]:43836) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9s81-0006zG-3O for 19547@debbugs.gnu.org; Sat, 10 Jan 2015 04:14:42 -0500 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NHY00G00E9FC500@mtaout29.012.net.il> for 19547@debbugs.gnu.org; Sat, 10 Jan 2015 11:11:33 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHY00EPKEV9KA30@mtaout29.012.net.il>; Sat, 10 Jan 2015 11:11:33 +0200 (IST) Date: Sat, 10 Jan 2015 11:14:58 +0200 From: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace In-reply-to: <87ppanwrpy.fsf@web.de> X-012-Sender: halo1@inter.net.il To: Michael Heerdegen Message-id: <83d26n6lpp.fsf@gnu.org> References: <874ms03qj1.fsf@web.de> <83387j67yg.fsf@gnu.org> <87ppanwrpy.fsf@web.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Heerdegen > Cc: 19547@debbugs.gnu.org > Date: Fri, 09 Jan 2015 22:48:25 +0100 > > Eli Zaretskii writes: > > > It could be that this particular event can be filtered out, but that's > > just the top of the iceberg. There are way too many different events > > flowing into Emacs on a typical modern system, keyboard being just a > > small part of that. > > Mmh, I expected that this could be the case. But is there no more or > less reasonable way to classify events? Probably not... If you are thinking about a general-purpose infrastructure to ignore some specific classes of events, we could try considering that. Of course, any such filtering can always be done on the application level, and the question then is how more useful will it be to have it in the infrastructure. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 10 04:17:50 2015 Received: (at 19547) by debbugs.gnu.org; 10 Jan 2015 09:17:50 +0000 Received: from localhost ([127.0.0.1]:41453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9sB3-00074c-Vc for submit@debbugs.gnu.org; Sat, 10 Jan 2015 04:17:50 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:59763) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9sB1-00074S-9J for 19547@debbugs.gnu.org; Sat, 10 Jan 2015 04:17:48 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NHY00600EZ42N00@a-mtaout21.012.net.il> for 19547@debbugs.gnu.org; Sat, 10 Jan 2015 11:17:46 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHY006S0F5L2710@a-mtaout21.012.net.il>; Sat, 10 Jan 2015 11:17:45 +0200 (IST) Date: Sat, 10 Jan 2015 11:18:04 +0200 From: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace In-reply-to: <87zj9r4i8d.fsf@web.de> X-012-Sender: halo1@inter.net.il To: Michael Heerdegen Message-id: <83bnm76lkj.fsf@gnu.org> References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19547 Cc: monnier@iro.umontreal.ca, 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Heerdegen > Date: Sat, 10 Jan 2015 01:00:50 +0100 > Cc: 19547@debbugs.gnu.org > > Stefan Monnier writes: > > > > (catch 'tag > > > (let ((throw-on-input 'tag)) > > > (while t))) > > > > > > and switch to a different (X) workspace. The loop is exited > > > immediately. > > > > Can you check with C-h l what event Emacs received? > > The event isn't listed there. I think it is focus-out or something like > that. You should be able to see it in a C-level debugger, then. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 10 17:24:52 2015 Received: (at 19547) by debbugs.gnu.org; 10 Jan 2015 22:24:52 +0000 Received: from localhost ([127.0.0.1]:42189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YA4Si-0005ly-49 for submit@debbugs.gnu.org; Sat, 10 Jan 2015 17:24:52 -0500 Received: from mout.web.de ([212.227.15.3]:65333) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YA4Sf-0005ln-Q6 for 19547@debbugs.gnu.org; Sat, 10 Jan 2015 17:24:50 -0500 Received: from drachen.dragon ([90.187.217.90]) by smtp.web.de (mrweb004) with ESMTPSA (Nemesis) id 0MHdwC-1YDNJL1r5A-003M5P; Sat, 10 Jan 2015 23:24:47 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> Date: Sat, 10 Jan 2015 23:24:45 +0100 In-Reply-To: <83egr36ltc.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 10 Jan 2015 11:12:47 +0200") Message-ID: <87oaq6l1ea.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:kw4chObuA/aRM/p4iQyd8XZj5ExoY/uo3Taddau8G6xyANccZFs 40N+XAHr0ApWdTyY+mBjgwNIXc6FgfPVxa7KaLUL/ELWfwPuWOLoGFa6+FGCcGRbg+z0lLf EDOU9nrqj/8TvP1Sr66CAej48k4+P3/1Je7f3WnfUgOD6axyQ+Qhuzh4HSLFpbKUXCq+3YF jC9CcuN72S1uKGie4N8Pg== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: > I suggest to establish exactly which event causes that, then we could > focus on how to filter that out, either in general or in your specific > situation. Ok, I did the following, hoping it's good enough. In keyboard.c, near the end of the defun of kbd_buffer_store_event_hold, there is an exclusion list of events ignored by throw_on_input: if (!NILP (Vthrow_on_input) && event->kind != FOCUS_IN_EVENT && event->kind != HELP_EVENT && event->kind != DEICONIFY_EVENT) {... ...} When I add the two lines && event->kind != FOCUS_OUT_EVENT && event->kind != ICONIFY_EVENT my problem is solved and throw-on-input does not fire when switching the workspaces. Helm does not stop matching anymore. Also the (catch 'tag (let ((throw-on-input 'tag)) (while t))) example is not intercepted. When I only add one of either lines, the behavior is not different from what we have now. Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 10 20:47:28 2015 Received: (at 19547) by debbugs.gnu.org; 11 Jan 2015 01:47:28 +0000 Received: from localhost ([127.0.0.1]:42251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YA7cm-0003k6-38 for submit@debbugs.gnu.org; Sat, 10 Jan 2015 20:47:28 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:38807) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YA7cj-0003jy-Ro for 19547@debbugs.gnu.org; Sat, 10 Jan 2015 20:47:26 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t0B1lOtk029279; Sat, 10 Jan 2015 20:47:24 -0500 Received: by pastel.home (Postfix, from userid 20848) id 6D580C22; Sat, 10 Jan 2015 20:47:24 -0500 (EST) From: Stefan Monnier To: Michael Heerdegen Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace Message-ID: References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> Date: Sat, 10 Jan 2015 20:47:24 -0500 In-Reply-To: <87oaq6l1ea.fsf@web.de> (Michael Heerdegen's message of "Sat, 10 Jan 2015 23:24:45 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5182=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5182> : inlines <1750> : streams <1371379> : uri <1842018> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 19547 Cc: Eli Zaretskii , 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > if (!NILP (Vthrow_on_input) > && event->kind != FOCUS_IN_EVENT > && event->kind != HELP_EVENT > && event->kind != DEICONIFY_EVENT) > {... > ...} > When I add the two lines > && event->kind != FOCUS_OUT_EVENT > && event->kind != ICONIFY_EVENT Adding FOCUS_OUT_EVENT seems definitely safe since we already handle FOCUS_IN_EVENT like that. As for ICONIFY_EVENT, it seems a bit more risky, but I think we can give it a try. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 19 21:47:12 2015 Received: (at 19547) by debbugs.gnu.org; 20 Jan 2015 02:47:12 +0000 Received: from localhost ([127.0.0.1]:50167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDOqV-0005lE-UK for submit@debbugs.gnu.org; Mon, 19 Jan 2015 21:47:12 -0500 Received: from mout.web.de ([212.227.17.12]:60637) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDOqU-0005kz-FC for 19547@debbugs.gnu.org; Mon, 19 Jan 2015 21:47:11 -0500 Received: from drachen.dragon ([90.186.204.245]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0Lrs70-1Xk5uY1ro6-013dEG; Tue, 20 Jan 2015 03:47:04 +0100 From: Michael Heerdegen To: 19547@debbugs.gnu.org Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> Date: Tue, 20 Jan 2015 03:46:57 +0100 In-Reply-To: (Stefan Monnier's message of "Sat, 10 Jan 2015 20:47:24 -0500") Message-ID: <87oapudv8e.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:ZEnfu7BMn4OPQjifjg8ESa2AMsOQIeN9bqZpC+uj/ZBCP+nKsPQ xVOYr/tn6+/yjsyxiqptksQ9E0+EQCBN4DzvUF4MYhCgeW3ONqxePLlml79YN3XqJWWHG9U OAyPhn4ktmkhVIT2vv9B9WWo8Hh6t5+pj1J1hUfbCllN69a+MZ/PlbeGZuydLh7Slwt7V2B dxy7MuGVdRSb8B7wtQSTw== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Stefan Monnier writes: > > && event->kind != FOCUS_OUT_EVENT > > && event->kind != ICONIFY_EVENT > > Adding FOCUS_OUT_EVENT seems definitely safe since we already handle > FOCUS_IN_EVENT like that. As for ICONIFY_EVENT, it seems a bit more > risky, but I think we can give it a try. Eli, would that change be acceptable in your eyes? From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 19 22:44:01 2015 Received: (at 19547) by debbugs.gnu.org; 20 Jan 2015 03:44:01 +0000 Received: from localhost ([127.0.0.1]:50194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDPjV-00079i-DU for submit@debbugs.gnu.org; Mon, 19 Jan 2015 22:44:01 -0500 Received: from mtaout29.012.net.il ([80.179.55.185]:44867) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDPjR-00079P-8Q for 19547@debbugs.gnu.org; Mon, 19 Jan 2015 22:43:58 -0500 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NIG00B00HBO3K00@mtaout29.012.net.il> for 19547@debbugs.gnu.org; Tue, 20 Jan 2015 05:40:30 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NIG0045YI7I7B90@mtaout29.012.net.il>; Tue, 20 Jan 2015 05:40:30 +0200 (IST) Date: Tue, 20 Jan 2015 05:43:42 +0200 From: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace In-reply-to: <87oapudv8e.fsf@web.de> X-012-Sender: halo1@inter.net.il To: Michael Heerdegen Message-id: <838ugyxgk1.fsf@gnu.org> References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Heerdegen > Date: Tue, 20 Jan 2015 03:46:57 +0100 > > Stefan Monnier writes: > > > > && event->kind != FOCUS_OUT_EVENT > > > && event->kind != ICONIFY_EVENT > > > > Adding FOCUS_OUT_EVENT seems definitely safe since we already handle > > FOCUS_IN_EVENT like that. As for ICONIFY_EVENT, it seems a bit more > > risky, but I think we can give it a try. > > Eli, would that change be acceptable in your eyes? I don't see any immediate problems, but then I'm not an expert on GUI events. So I agree with Stefan: let's try. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 29 14:59:54 2015 Received: (at 19547) by debbugs.gnu.org; 29 Jan 2015 19:59:55 +0000 Received: from localhost ([127.0.0.1]:57544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGvFq-0005k9-BX for submit@debbugs.gnu.org; Thu, 29 Jan 2015 14:59:54 -0500 Received: from mout.web.de ([212.227.17.12]:64863) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGvFo-0005ju-HH for 19547@debbugs.gnu.org; Thu, 29 Jan 2015 14:59:53 -0500 Received: from drachen.dragon ([90.186.231.215]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0Ljrlt-1Xffcv0quf-00bqV1; Thu, 29 Jan 2015 20:59:44 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace In-Reply-To: <838ugyxgk1.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Jan 2015 05:43:42 +0200") References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Date: Thu, 29 Jan 2015 20:59:42 +0100 Message-ID: <87oaph2w9d.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:YUUwudWc3Hmr7bfyZzutUtZYQjTtH6Lzkp9hhpqprrFl09WzqCT Vlkl86aMVT5k3Jp4A35QRMPYA6/Bp8eR7KE5kpDO4hO+1TzRaklPzkYvkvq3+Ve4uJ+FHQT L8BhFMJPdmYTBV7pq7PpIMkM6PSKE0yHbSPzUu+P/klei3bdOzWpc+d5H/5eTwmFctohae6 zASQlEniG0qHkCOsznzMg== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: > I don't see any immediate problems, but then I'm not an expert on GUI > events. So I agree with Stefan: let's try. Great. Can please someone make the change? I cloned the new git repo today, but am far away from understanding the committing shibboleths (apart from the fact that I probably don't have write access). Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 31 03:38:35 2015 Received: (at 19547) by debbugs.gnu.org; 31 Jan 2015 08:38:35 +0000 Received: from localhost ([127.0.0.1]:58416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHTZa-0006ua-IU for submit@debbugs.gnu.org; Sat, 31 Jan 2015 03:38:34 -0500 Received: from mtaout29.012.net.il ([80.179.55.185]:36931) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHTZY-0006uN-6k for 19547@debbugs.gnu.org; Sat, 31 Jan 2015 03:38:33 -0500 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NJ100O008YFYC00@mtaout29.012.net.il> for 19547@debbugs.gnu.org; Sat, 31 Jan 2015 10:34:50 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJ100JDW962BT60@mtaout29.012.net.il>; Sat, 31 Jan 2015 10:34:50 +0200 (IST) Date: Sat, 31 Jan 2015 10:38:26 +0200 From: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace In-reply-to: <87oaph2w9d.fsf@web.de> X-012-Sender: halo1@inter.net.il To: Michael Heerdegen Message-id: <831tmbl4zh.fsf@gnu.org> References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Heerdegen > Cc: 19547@debbugs.gnu.org > Date: Thu, 29 Jan 2015 20:59:42 +0100 > > Eli Zaretskii writes: > > > I don't see any immediate problems, but then I'm not an expert on GUI > > events. So I agree with Stefan: let's try. > > Great. Can please someone make the change? I did that now (commit eaea02c on master). Please run the test suite and see if there are any regressions. I see a failure in timer-tests-debug-timer-check, but I'm not sure this wasn't happening before the change. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 01 09:26:17 2015 Received: (at 19547) by debbugs.gnu.org; 1 Feb 2015 14:26:18 +0000 Received: from localhost ([127.0.0.1]:59455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHvTc-000559-FS for submit@debbugs.gnu.org; Sun, 01 Feb 2015 09:26:17 -0500 Received: from mout.web.de ([212.227.15.14]:49530) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHvTY-00054r-Sp for 19547@debbugs.gnu.org; Sun, 01 Feb 2015 09:26:13 -0500 Received: from drachen.dragon ([90.186.100.29]) by smtp.web.de (mrweb004) with ESMTPSA (Nemesis) id 0LhhVB-1XwHtK44Nl-00mvbS; Sun, 01 Feb 2015 15:26:04 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> <831tmbl4zh.fsf@gnu.org> Date: Sun, 01 Feb 2015 15:25:56 +0100 In-Reply-To: <831tmbl4zh.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Jan 2015 10:38:26 +0200") Message-ID: <87pp9tlnd7.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:1zQOnSERl2QrnXQBlZ54Er0BehKL4JZscnGka2KjOy0KJx9/F/W v5Q7fJHllP2H5Sdj7ioH6nRodfLWCqSznhdRhD94UTH1Ddh/azvbIvHLoEv1TsT9QfuUcn1 uuXPJ4qUQOVkkpRITQejgstgs2k92SlGVK6LRzZ3oohpnd1DxnMe+6y2MImqp1OP+zhmZol +ZJW5tjaCRKnoOHcGdyww== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: > I did that now (commit eaea02c on master). Thanks. Works as expected. > Please run the test suite and see if there are any regressions. I'll do this. Before that I have to learn how to do it, though. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 01 10:56:07 2015 Received: (at 19547) by debbugs.gnu.org; 1 Feb 2015 15:56:07 +0000 Received: from localhost ([127.0.0.1]:59759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHwsZ-0007LC-6q for submit@debbugs.gnu.org; Sun, 01 Feb 2015 10:56:07 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:35383) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHwsX-0007Kc-Br for 19547@debbugs.gnu.org; Sun, 01 Feb 2015 10:56:06 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NJ300K00O1HOE00@a-mtaout22.012.net.il> for 19547@debbugs.gnu.org; Sun, 01 Feb 2015 17:54:56 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJ300KA5O7JBB70@a-mtaout22.012.net.il>; Sun, 01 Feb 2015 17:54:56 +0200 (IST) Date: Sun, 01 Feb 2015 17:54:39 +0200 From: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace In-reply-to: <87pp9tlnd7.fsf@web.de> X-012-Sender: halo1@inter.net.il To: Michael Heerdegen Message-id: <83k301iq4g.fsf@gnu.org> References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> <831tmbl4zh.fsf@gnu.org> <87pp9tlnd7.fsf@web.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Heerdegen > Cc: 19547@debbugs.gnu.org > Date: Sun, 01 Feb 2015 15:25:56 +0100 > > > Please run the test suite and see if there are any regressions. > > I'll do this. Before that I have to learn how to do it, though. Like this: $ cd tests/automated && make check From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 01 12:22:01 2015 Received: (at 19547) by debbugs.gnu.org; 1 Feb 2015 17:22:01 +0000 Received: from localhost ([127.0.0.1]:59781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHyDh-00011H-7T for submit@debbugs.gnu.org; Sun, 01 Feb 2015 12:22:01 -0500 Received: from mout.web.de ([212.227.17.12]:61375) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHyDf-000113-TJ for 19547@debbugs.gnu.org; Sun, 01 Feb 2015 12:22:00 -0500 Received: from drachen.dragon ([90.186.100.29]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0LrJwm-1XWiiL0Byu-0138Nh; Sun, 01 Feb 2015 18:21:53 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> <831tmbl4zh.fsf@gnu.org> <87pp9tlnd7.fsf@web.de> <83k301iq4g.fsf@gnu.org> Date: Sun, 01 Feb 2015 18:21:48 +0100 In-Reply-To: <83k301iq4g.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 01 Feb 2015 17:54:39 +0200") Message-ID: <87d25tlf83.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:f+1y3PV23E2Zj6tHlRuBquKcBGHsAHFXXY42rb/hHA45MdTR7XO MAf6v/SD1V+UTzoUx0vOjtSQ6Pkk7sxoVn8NoDPjsM6bLOs5rfpXYjMiR6+dVkcuV0p/50O UpddHHp5pQRpMGQkpyv0/vqv06qtI+p5B7ltPaaa+55rLXjGnyiB/33OIuO7qCbltvaGL4e Q54zxwGN+f+tPB0ZfFTaA== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: > Like this: > > $ cd tests/automated && make check (You probably meant test/automated) Seems I get one error: vc-test-svn03-working-revision. Probably unrelated to this issue here. Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 01 12:36:30 2015 Received: (at 19547) by debbugs.gnu.org; 1 Feb 2015 17:36:30 +0000 Received: from localhost ([127.0.0.1]:59789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHyRi-0001NQ-91 for submit@debbugs.gnu.org; Sun, 01 Feb 2015 12:36:30 -0500 Received: from mtaout29.012.net.il ([80.179.55.185]:48526) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHyRf-0001NB-Ay for 19547@debbugs.gnu.org; Sun, 01 Feb 2015 12:36:28 -0500 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NJ300N00SMF9F00@mtaout29.012.net.il> for 19547@debbugs.gnu.org; Sun, 01 Feb 2015 19:32:41 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJ300G0HSQGJO60@mtaout29.012.net.il>; Sun, 01 Feb 2015 19:32:41 +0200 (IST) Date: Sun, 01 Feb 2015 19:35:58 +0200 From: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace In-reply-to: <87d25tlf83.fsf@web.de> X-012-Sender: halo1@inter.net.il To: Michael Heerdegen Message-id: <837fw1ilfl.fsf@gnu.org> References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> <831tmbl4zh.fsf@gnu.org> <87pp9tlnd7.fsf@web.de> <83k301iq4g.fsf@gnu.org> <87d25tlf83.fsf@web.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Heerdegen > Cc: 19547@debbugs.gnu.org > Date: Sun, 01 Feb 2015 18:21:48 +0100 > > Eli Zaretskii writes: > > > Like this: > > > > $ cd tests/automated && make check > > (You probably meant test/automated) Yes, sorry. > Seems I get one error: vc-test-svn03-working-revision. Probably > unrelated to this issue here. Thanks for testing. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 13 06:50:29 2015 Received: (at 19547) by debbugs.gnu.org; 13 Oct 2015 10:50:29 +0000 Received: from localhost ([127.0.0.1]:37848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZlxA4-0000hO-8z for submit@debbugs.gnu.org; Tue, 13 Oct 2015 06:50:28 -0400 Received: from mout.web.de ([212.227.17.12]:61772) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZlxA1-0000hF-6k for 19547@debbugs.gnu.org; Tue, 13 Oct 2015 06:50:25 -0400 Received: from drachen.dragon ([90.186.1.139]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0MWSBi-1a6E5t1D1G-00XcpZ; Tue, 13 Oct 2015 12:50:23 +0200 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> <831tmbl4zh.fsf@gnu.org> <87pp9tlnd7.fsf@web.de> <83k301iq4g.fsf@gnu.org> <87d25tlf83.fsf@web.de> <837fw1ilfl.fsf@gnu.org> Date: Tue, 13 Oct 2015 12:50:19 +0200 In-Reply-To: <837fw1ilfl.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 01 Feb 2015 19:35:58 +0200") Message-ID: <87twpvrqj8.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:e4BQDST1PzS+reCPSBliC1syA+zeNqiqVCYDZh5F/Ae2+riCHWK RM0AUUay0bjAERx7kdqAXKMM5qpK/cpiMEtCRbZmEBEq+XqL9dJun27Y9PJ6DBqj1VW56gy 2feqaUlaDpn8ysIPtqmGVXX5cpkxUgZEnb6D6oljsCACoPjyaLvMA46zawDUmg/Bu23BOeG trsb3HZHFWoSWr0n0Yusg== X-UI-Out-Filterresults: notjunk:1;V01:K0:mZeY7n7kSrY=:Vvv5zNNleb++tCzl3kFnOO BCny4Znrifqj/jc/KnMZA8FQCVm7fBtgm8PosXdM4YpoQchedFC38+1KmrTtSWv9rUCYNim5R p495vogMoiNXPvBmOYHJpHhMSdVkql3NpRHf+znJbr4GtaT7CoCSrZPWVIp44SU4kOSRzip37 3/je0+UY0QB2Awtn7vAM1YvT92Ept469o/Onvy3A6yLv2JzWFhO4LwhXwYYCh+24YD68DEuBM jqe+1pCyx11lq50Pqy+4LGiJzKFJ8Ydxkgr2QK7aFmXT1mP7wu7wrscnQmMJOPBF8rlVs7Sn4 yeSDg0kNZK6yg2RufNMDarvAPnjq2+dLIneCLOhqaSYZypqeJ1EBOY+AgG6nHysf0liLNpWr9 NeknCt+UoXRAF133AdKSO4GtwL8UOQOLkU1Qejua+UzwA25yiQViY1ECjbFEMbFCxf6E2Pw+N y8vEBdxk7EPi0oPOsNZ48eh+bVPOOpDk2txObE6TpmKSpQuJEiLEmwJO3PYTJugdxJ0P9Aa36 R62VK3jOKgX9VpPZckWaz84nJT8+0bh5J2FPUwcsQUjRpO4evhQe3DJwRmj33ms9gr5KW6dwM 6HC5IxijEZWOsi4dK2FtoXmoHI4lKSUf+0ZyoI61HnDoYdNZPn+8n05YgqURaA+kiPpfnYqIa 45J6EdJMJ2rr23Aky36LmDKTmJlkv2DZ8Y1XitFFHXVCuhkbBWjnMhuV1Syz2nwBTps2w1Oqu KUaiStvBcJWyYnuCiod0O5J77sv8JXrjwt1Gh9adz4zw7D0O/aMF/JkA66s9qnqLxyq/aaOTv W0QjxFw X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19547 Cc: Thierry Volpiatto , 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > Thanks for testing. FWIW, we have been bitten by this problem again, for example (just for reference, no need to read the complete thread): https://github.com/emacs-helm/helm/issues/1157 Most or all of the time the problem was related to a tool called "autocutsel". It makes Emacs receiving a SELECTION_REQUEST_EVENT that breaks `while-no-input'. The OP found that this patch: @@ -3542,7 +3542,8 @@ kbd_buffer_store_buffered_event (union buffered_input_event *event, && event->kind != FOCUS_OUT_EVENT && event->kind != HELP_EVENT && event->kind != ICONIFY_EVENT - && event->kind != DEICONIFY_EVENT) + && event->kind != DEICONIFY_EVENT + && event->kind != SELECTION_REQUEST_EVENT) { Vquit_flag = Vthrow_on_input; /* If we're inside a function that wants immediate quits, fixes the problem for him. Dunno if it is a good idea to install that. We kind of misuse `while-no-input' in Helm, but due to the lack of a better alternative. What we would need would be something like `while-no-keyboard-input' that only rewinds when the user hits a key on his keyboard. Any other event breaking `while-no-input' just leaves the user wondering why no candidates have been calculated. Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 10 15:15:00 2015 Received: (at 19547) by debbugs.gnu.org; 10 Dec 2015 20:15:00 +0000 Received: from localhost ([127.0.0.1]:39494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a77cC-0007eQ-CL for submit@debbugs.gnu.org; Thu, 10 Dec 2015 15:15:00 -0500 Received: from mail-pf0-f182.google.com ([209.85.192.182]:32897) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a77cB-0007eC-J1 for 19547@debbugs.gnu.org; Thu, 10 Dec 2015 15:14:59 -0500 Received: by pfnn128 with SMTP id n128so53167541pfn.0 for <19547@debbugs.gnu.org>; Thu, 10 Dec 2015 12:14:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version:content-type; bh=vfp/BfCAAe6qHsruFIoRVuG0eXa2hTQCfuPq8ijYt1g=; b=JT8HHdhGvJeBQpNyWEMmD/rON+cs2jNZzIZHf8vWGH3tg/uvtwMIAhfWDV6V+AWZd+ ZdfR5oZuLAz41x4mDygbz5Yc70R/ONklQArsyQ9ITqlb72O1LLKQnHUdQBUc7/dGpftV q0iIrXyCmnZVfS1z3WH3Hvitqq0HpbZEvPUZHU9PSVJn+8SjLS2UE/3vBbwmmf9UC/JI YbXccMOAKCO0gQVymHW+C7NL6H1snFgI02LW5JHuEz//SDxu7d3qjDAXMkp/Y2N3szYD ZcINPlm9urHOCdcYHPnJxPsA5S3otOyW0QU4JOCF3xTeVIOq0DVQhZf7d/WPrcoV03jg fdsQ== X-Received: by 10.98.18.4 with SMTP id a4mr4280808pfj.54.1449778493861; Thu, 10 Dec 2015 12:14:53 -0800 (PST) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id b17sm20256149pfj.43.2015.12.10.12.14.53 (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 10 Dec 2015 12:14:53 -0800 (PST) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id 3A9CE1141DF56; Thu, 10 Dec 2015 12:14:52 -0800 (PST) To: Michael Heerdegen Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace In-Reply-To: <87twpvrqj8.fsf@web.de> (Michael Heerdegen's message of "Tue, 13 Oct 2015 12:50:19 +0200") Date: Thu, 10 Dec 2015 12:14:49 -0800 Message-ID: References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> <831tmbl4zh.fsf@gnu.org> <87pp9tlnd7.fsf@web.de> <83k301iq4g.fsf@gnu.org> <87d25tlf83.fsf@web.de> <837fw1ilfl.fsf@gnu.org> <87twpvrqj8.fsf@web.de> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19547 Cc: Eli Zaretskii , Thierry Volpiatto , 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >>>>> Michael Heerdegen writes: > Dunno if it is a good idea to install that. We kind of misuse > `while-no-input' in Helm, but due to the lack of a better alternative. What > we would need would be something like `while-no-keyboard-input' that only > rewinds when the user hits a key on his keyboard. Any other event breaking > `while-no-input' just leaves the user wondering why no candidates have been > calculated. So is the current status that you're suggesting we create `while-no-keyboard-input'? That sounds like it could be a useful distinction. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 10 17:05:57 2015 Received: (at 19547) by debbugs.gnu.org; 10 Dec 2015 22:05:57 +0000 Received: from localhost ([127.0.0.1]:39513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a79LZ-0001jt-4y for submit@debbugs.gnu.org; Thu, 10 Dec 2015 17:05:57 -0500 Received: from mout.web.de ([212.227.17.11]:62693) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a79LX-0001jg-1N for 19547@debbugs.gnu.org; Thu, 10 Dec 2015 17:05:55 -0500 Received: from drachen.dragon ([90.186.3.90]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0Lw0ht-1aIihN09O9-017mm7; Thu, 10 Dec 2015 23:05:48 +0100 From: Michael Heerdegen To: John Wiegley Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> <831tmbl4zh.fsf@gnu.org> <87pp9tlnd7.fsf@web.de> <83k301iq4g.fsf@gnu.org> <87d25tlf83.fsf@web.de> <837fw1ilfl.fsf@gnu.org> <87twpvrqj8.fsf@web.de> Date: Thu, 10 Dec 2015 23:05:45 +0100 In-Reply-To: (John Wiegley's message of "Thu, 10 Dec 2015 12:14:49 -0800") Message-ID: <87twnqq7ra.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:FjNhdmZtQviqBOM2Xn4wdAvu/pvKy/PdA1UWsaqWEtCVbcxld5t X9V38umywVS9mnrow2CgPHZNGLWF0Ho8MvQuN8souYpmsROKSRUAhn3yR+LPOkr+bpL1gqu Kk7BU144uuZ/pQOliNiNrCb53Tr9KUJJFcnk/5U4tGUStnioj+KtpHBMdiWt0LN2zzD30ty dyjVPdPsok7wA+aPxd/kA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Zye/67wxkWk=:XOdUuGx4pmViNBTM04KRH2 NO2CH7H5FKYOf2v2FnoXbWvdTBzcroheHYFzLWdURbpBzkejwJfToeGB2dlOVZs2w/hNM8bX/ +8VkuNzGbyhuB59qS2ICH1sSgnj7/ck6ljvBFDfUupVVRiFBPy1URDki3C+tLd+cEgWJ6aYL/ zTKP+HGo05e/DEn+tYRklRwjvLZ6fzuBGQh8visgzUduvNez1YlKBZxA1KFIhGpKsq3q8hh9p B1xba1AccBtHTau1BwlPcjQTjZZj9LZ3hAzAftovxctHsOKDLTUQfx4NGLRX9g7BrV4Nq3Vnd U1KDKJqrRywBIFlEuC0oWdFYIRTsV0pcpzYAS7faWq6dyLx9TlJJ2MxpF4vbf2MXbH/1bsUp3 O2arFnyKkJQ3+i89xJVDwcdDwShdLBoFFP/nPAN9n2FMkrtG9VYSXS/ZcFDAV+3h8U/frNSdq QGnWB4LugkBMR8n8BRieaRN0csw0JzRfhcEEiepa1a4LrtTCEcXkvtu+VcsVYmNyFFziOwlCc +ytS7eSu+rHNedOVeE1onJzSwQU3kBOO+l0BZIMCaDeBhkFUGZeu+fiORZQdVY5qLTBFBt50r GH6s8rDRcOpgTtdrtueVYGv8xhj/cjnZVd9nLJiU2DrOPxAuI+BgM+r6uqiBgGb9ioDtToDpO nZWOAHdFn2WRNHWudTVNrorOzg6F8cwvQfNQzM/6s6kxvvTUbwWoyqS+ShK8dNwpOfDv1/d3U c+V6zM/ZJlj2sUGiD0YWg/U7Bp+U0XH6RH8yHY+5hqY3pBRK56skkwoT7q66inKJcmzXOQQPa H46Itfg X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19547 Cc: Eli Zaretskii , Thierry Volpiatto , 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) John Wiegley writes: > So is the current status that you're suggesting we create > `while-no-keyboard-input'? That sounds like it could be a useful > distinction. It would be very useful, I think, but my knowledge about that C part (all C parts, to be honest) of Emacs is nearly zero. But I think Eli already mentioned that this would not be trivial AFAIR. I guess Emacs can't clearly decide whether an event is a keyboard event. Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 10 18:02:09 2015 Received: (at 19547) by debbugs.gnu.org; 10 Dec 2015 23:02:09 +0000 Received: from localhost ([127.0.0.1]:39518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a7ADx-000330-AM for submit@debbugs.gnu.org; Thu, 10 Dec 2015 18:02:09 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34875) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a7ADv-00032d-Do for 19547@debbugs.gnu.org; Thu, 10 Dec 2015 18:02:07 -0500 Received: by padhk6 with SMTP id hk6so14436223pad.2 for <19547@debbugs.gnu.org>; Thu, 10 Dec 2015 15:02:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version:content-type; bh=uOGvLD0CgIU99YA1GKHsgQx21QWAESMXje+2lTT/eUo=; b=juHvZnD1mrg+xccgYa7vXfgwhDtN+uZ8Em/FepSAhSBiOEeGLCrDE6T9ZAHjCd4mOj jV9b3vErLIrnAsQ+IMlC5pA5UkUdwGfgnOD7yZE5sY+GIymPs9BxuL8/5AzpfuzlgCrP p76rmZbaridOx9ebSYJYbIQbRCJENvwV38k9m0rJ2G2tg4MMfWbCgpjkiIJVgedGf6OY Y5l3/PAaB7ESDmmGND5CDAfFwnoTTVjiPQzCa5iA/zojCoJwOqoC8PIIkD6h8z1QRbcR ueSHSo8RqHqyEkwLRJ/uqpGt602OwAW8MDF39TEiq1MsC7VVi12I0BbyY0b7vk+yRMZK mwUw== X-Received: by 10.66.102.4 with SMTP id fk4mr20717899pab.85.1449788521735; Thu, 10 Dec 2015 15:02:01 -0800 (PST) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id xr8sm21007798pab.26.2015.12.10.15.02.00 (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 10 Dec 2015 15:02:01 -0800 (PST) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id B38B3114222ED; Thu, 10 Dec 2015 15:01:59 -0800 (PST) To: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace In-Reply-To: <87twnqq7ra.fsf@web.de> (Michael Heerdegen's message of "Thu, 10 Dec 2015 23:05:45 +0100") Date: Thu, 10 Dec 2015 15:01:58 -0800 Message-ID: References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> <831tmbl4zh.fsf@gnu.org> <87pp9tlnd7.fsf@web.de> <83k301iq4g.fsf@gnu.org> <87d25tlf83.fsf@web.de> <837fw1ilfl.fsf@gnu.org> <87twpvrqj8.fsf@web.de> <87twnqq7ra.fsf@web.de> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19547 Cc: Michael Heerdegen , Thierry Volpiatto , 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >>>>> Michael Heerdegen writes: > But I think Eli already mentioned that this would not be trivial AFAIR. I > guess Emacs can't clearly decide whether an event is a keyboard event. What are your thoughts now, Eli? -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 11 12:42:31 2015 Received: (at 19547) by debbugs.gnu.org; 11 Dec 2015 17:42:31 +0000 Received: from localhost ([127.0.0.1]:40706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a7RiB-00083t-5j for submit@debbugs.gnu.org; Fri, 11 Dec 2015 12:42:31 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:37928) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a7Ri9-00083h-H9 for 19547@debbugs.gnu.org; Fri, 11 Dec 2015 12:42:29 -0500 Received: by wmec201 with SMTP id c201so80333603wme.1 for <19547@debbugs.gnu.org>; Fri, 11 Dec 2015 09:42:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; bh=FGUj8ng/Dbad8LFFXF7LiCAd5C5GpFj8K3Qv1MI1nh4=; b=pe4b9suizJr3fPYiTioS1q1xuJKHc924J2KAqq4chGtSjSkGDgh+iL4EV3haLPqL13 qogM9aOGG9tacHS+cKlMl5iNDdE95BPKrd/18ICQD1s3VEdr8o3Qfs7JAXnzxsaXoD4J 3CaDaZwcdCy26ymebL1D4MSMIlZKLekWi7t1+y538g2q1g/40s9U9xIIvq/zNfR5Qu4u +aqZGYz4N1XhP0ficZ4ujBMPu5+wraEsXu2CLnrxDqgLk6AVpSNeLoDj0qheNP8VD8qc g2nAHHgLBvde6yCOVPajPLlVWPjtBDdcmvir57+AxKQUpK/2hp/BP5FseFbtfRYp+1c1 Ib8A== X-Received: by 10.28.4.212 with SMTP id 203mr4902098wme.89.1449829033218; Fri, 11 Dec 2015 02:17:13 -0800 (PST) Received: from thierry-MS-7309 (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by smtp.gmail.com with ESMTPSA id gl4sm16339055wjd.17.2015.12.11.02.17.11 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 11 Dec 2015 02:17:12 -0800 (PST) References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> <831tmbl4zh.fsf@gnu.org> <87pp9tlnd7.fsf@web.de> <83k301iq4g.fsf@gnu.org> <87d25tlf83.fsf@web.de> <837fw1ilfl.fsf@gnu.org> <87twpvrqj8.fsf@web.de> <87twnqq7ra.fsf@web.de> <83fuz98gre.fsf@gnu.org> User-agent: mu4e 0.9.15; emacs 24.5.1 From: Thierry Volpiatto To: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace In-reply-to: <83fuz98gre.fsf@gnu.org> Date: Fri, 11 Dec 2015 11:17:10 +0100 Message-ID: <87bn9x5ly1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19547 Cc: michael_heerdegen@web.de, John Wiegley , 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> From: John Wiegley >> Cc: Michael Heerdegen , 19547@debbugs.gnu.org, Thierry Volpiatto >> Date: Thu, 10 Dec 2015 15:01:58 -0800 >> >> >>>>> Michael Heerdegen writes: >> >> > But I think Eli already mentioned that this would not be trivial AFAIR. I >> > guess Emacs can't clearly decide whether an event is a keyboard event. >> >> What are your thoughts now, Eli? > > About what? About adding SELECTION_REQUEST_EVENT to the list of > events ignored by while-no-input, or about adding > while-no-keyboard-input? > > For the former, I guess we could try that on master and see if it > breaks something. Agree, think it would be a good start. > I'm much less sure about the latter: why does it make sense to single > out keyboard events in Emacs? I am not sure the latter i.e while-no-keyboard-input would help for helm. > Yet another possibility would be for Helm to finally get its act > together Not sure to understand this sentence, sorry for by bad english. > and filter the events it doesn't want to handle on the application > level. If you provide an API for this yes, otherwise how am I supposed to do this ? > I mean, how far should we go on such a low level to support a single > package? This issue is not about a single package, but for all code using while-no-input. > All it takes for help is to define its own proxy for while-no-input, > and add a list of events that should not cause that proxy to return. You mean a list of events usable on lisp ? -- Thierry https://emacs-helm.github.io/helm/ From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 11 13:37:57 2015 Received: (at 19547) by debbugs.gnu.org; 11 Dec 2015 18:37:57 +0000 Received: from localhost ([127.0.0.1]:35059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a7SZp-0001Uw-Ep for submit@debbugs.gnu.org; Fri, 11 Dec 2015 13:37:57 -0500 Received: from mout.web.de ([212.227.17.11]:56842) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a7SZo-0001Uj-2I for 19547@debbugs.gnu.org; Fri, 11 Dec 2015 13:37:56 -0500 Received: from drachen.dragon ([90.186.1.176]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0LrK0u-1aEuXQ1ng4-0136py; Fri, 11 Dec 2015 15:23:00 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace References: <874ms03qj1.fsf@web.de> <87zj9r4i8d.fsf@web.de> <87sifj4e9j.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> <831tmbl4zh.fsf@gnu.org> <87pp9tlnd7.fsf@web.de> <83k301iq4g.fsf@gnu.org> <87d25tlf83.fsf@web.de> <837fw1ilfl.fsf@gnu.org> <87twpvrqj8.fsf@web.de> <87twnqq7ra.fsf@web.de> <83fuz98gre.fsf@gnu.org> <87bn9x5ly1.fsf@gmail.com> <838u518d32.fsf@gnu.org> Date: Fri, 11 Dec 2015 15:22:52 +0100 In-Reply-To: <838u518d32.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Dec 2015 13:00:17 +0200") Message-ID: <87egetgj43.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:qeEWgZQ+O05vJe1P31ZtS2zf7ZbqgBSnNScHN+1GB2OfS/I+rJz yS/6s+NJ+2OnOhoAjNUqQvdC/uZO9WFpkjrFj2fDkW7FJGVqIrpj4MKzq9y/hydKJ9GHAU+ eAaKfGxFmukHPultzx04pgYDEkWo2VdEpoK6/fn+9z0hYGKn6zOUNxcSsoT2g2E7F0/laah uWoZYsN73cr38FaquwvjA== X-UI-Out-Filterresults: notjunk:1;V01:K0:lE7zBT2ANs4=:xZYrNnAf43l4XF0wdckLoQ 9miVCyuKMvKvWaE0iW1jMHqSj7n1zA/tq33YUgvr56xUvkhkJ3of4HgUt6DWeVzawun5Y2GA4 Df7F6uiu4lNKDvX/27PUbw4ohlWZwALv73ton+bA51J2zh8W1rMhpT2mFXJfbceKYF8tuizsl pOObLDaVmWUkaPFxkypbQUVDYiYnjowRQ3FG49RDU86958XKrV/+1Qu8awo/5/rNV7JJtX1rm jHF0CF8pfxJEtHMXuUmobV3iSz++mDzbHUsKxOy2pafi2J9d+up0AK+6ASh4XpxevMYigKpjH SV4MW88FIIXsxRkM7loxt6AgSiN4eRvsu+G8BoiioeFtCdlIx1K1L/Nmw8319P0hrjlgkejPb E+HsIdj9PNrudpe4PVU7EQx9ARUw0CoV+Za9vir/QTrLTO5vouQrd0DhdlerfGmB+ROAK9SS5 G8QRuXuc4ZQr/AHyOjl1bZjia2txWQeASJii3oifOGU++4pkjmyCjKmTufp7zqeJYAMzLH2fE htr9+rzDjW0tGsjjikOhqBGhV0VghWzS21MuDUcNlzPFiDouAa/0Q7BZAWQ6/cqB0uz5Yf7x1 ZNazsTsK8Y+qKGxbpB78b5N+xqZNlkp2NWP0RCxzhuzEF/JRtZQdx2U+nzM8R/2Lpxy9+t5eK VoVFSZVHR8sCYlXxZSNSSwXoBaRmk3RFyKBTllMgcA5JtBlb7W1IqDr/vFn0Ddvtkv2a6zOGn mBB9HmvvTh1fDNKS2GsNTUzcs9+NyAT0aT7s0YFgfPpRbeKkF8nu8QSDWrBgWtUguK78H+wUU 9+WLZcrzsldnhHvkKxiuUd4uYiPIw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19547 Cc: jwiegley@gmail.com, 19547@debbugs.gnu.org, Thierry Volpiatto X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > > This issue is not about a single package, but for all code using > > while-no-input. > > No other package complained for quite some time. The last 2 or 3 > complaints were all due to Helm, AFAIR. Maybe we are the only one who succeeded in debugging that problem? It was not trivial to find what caused this rare kind of breakage, and it was hard to reproduce. I'm open for all kinds of solutions, and understand if you don't want to invest a lot of time into that. OTOH I don't think that letting Emacs do something until the user hits a key is such an obscure thing. Maybe Helm is the only place where developers noticed that this kind of thing can be done easily at all? Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 19:37:42 2015 Received: (at 19547) by debbugs.gnu.org; 26 Dec 2015 00:37:42 +0000 Received: from localhost ([127.0.0.1]:36196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCcrd-0005Yx-Vh for submit@debbugs.gnu.org; Fri, 25 Dec 2015 19:37:42 -0500 Received: from mout.web.de ([212.227.17.12]:55025) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCcrc-0005Yg-Ek for 19547@debbugs.gnu.org; Fri, 25 Dec 2015 19:37:40 -0500 Received: from drachen.dragon ([90.186.1.83]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0M73WL-1aOGSn2jHJ-00wqNY; Sat, 26 Dec 2015 01:37:33 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace References: <874ms03qj1.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> <831tmbl4zh.fsf@gnu.org> <87pp9tlnd7.fsf@web.de> <83k301iq4g.fsf@gnu.org> <87d25tlf83.fsf@web.de> <837fw1ilfl.fsf@gnu.org> <87twpvrqj8.fsf@web.de> <87twnqq7ra.fsf@web.de> <83fuz98gre.fsf@gnu.org> <87bn9x5ly1.fsf@gmail.com> <838u518d32.fsf@gnu.org> <87egetgj43.fsf@web.de> <83r3it6m5u.fsf@gnu.org> Date: Sat, 26 Dec 2015 01:37:29 +0100 In-Reply-To: <83r3it6m5u.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Dec 2015 17:27:09 +0200") Message-ID: <87lh8igi46.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:T4aIHPWyyeRudrz1hctLC6RpE4Hs5Rcz9tAlrFc6Pih4qJXLa9b itjqtcdGqZVfkIumBlZKVrX18q7imHTSV7DLN4VLPsDRxhmK++Cqd2qWpjMBEuRVEnE3laE AvdNeiBdCrcIIx2SpIUP4g613dMZFkjfax846ke3NBH08JHNE/gStNLcjhlZ3XgDrSOtcuL qshDfpBws5Jp2gL9C5v5g== X-UI-Out-Filterresults: notjunk:1;V01:K0:NpQtHG5kTDQ=:Ocb8s3YudIQ93jE12v4jcc o3KFAm9MJ3UefrPcynZdARsFg84FP5cqVqk9MbOZw5Sp2F8adzJH1dfHdymtni6KdeeWEbXA/ ru8KGsQ0ty8LmhYPS7d11Xy01aGx3W/TuuEIQJ0Zr6nmE8syCgIcnsTeQ3U2koLIXoCnA7KtV RoMnH5y/4iZgeNI1jIBneikcWeCw9TZQAUuzZJ2H7UHXLV5zX1bNYN48QDlqbGfg5nW0HOIAM Xn2XjgJF8bFXdyI5qWqC/0gW+vPT+/XEN2hnboIz4NdTr2Aq363U+sgPeAayA82U5m+fRDm/a gMz08jEBZbjTR0ln0gtycwHUiN2ZaFdP9vGObi2rNHAmU4zaf7QQPx2xGdAKcdy3QQDnD2w1L oXC6FrLCUJCTebSf28OU+AtbfqunHwEddLgVYRBPEBaLYE6YWLzLu3sGXrhbKspsGotGi4cEp TeUgH/fbhXZcQoNbKFcMyfYPLhEHK2fOT+Pi6DU1F4I1KDaDmiA/Up9OObDgmeKiUmhRpY9Mu Ca1CG2Vr34PK4vB/H7f/y2dPan16YRIF65wPMFdInF3Z2dS6Vwrw2TSALDSZwgwLlTmPzMprU HuQjTrIO9PNx84cZ1J/Zy18xJOA3jFsHEWyvrhhUY9OXlidxEqekJxluuOvEK/z4fxbR6g4jA f1fHO/iJ0731sdf9xgXiTyHTbpnWIvDA7Di3g32cyGgKVHVrxTdoOh/gSslQ6d/p66jU8RNeA enTwpX1FUFDmUg1sXd8LpbvREDzcFz+cH9pbsI1jMxslhVTx8iTsG5rpnarnpPUSDuRyDjEqY T4L3Yxv X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19547 Cc: jwiegley@gmail.com, 19547@debbugs.gnu.org, thierry.volpiatto@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > My suggestion is to make the list of events that input-pending-p > ignores customizable from Lisp, and then Helm could use that to have > its way. We should not put aside this thread and try to reconstruct the issue months later one more time. If nobody has a better idea - Eli's suggestion solves our problem in an easy way, so I would say: let's please try this! I only reluctantly would want to ask Eli to implement this. I can't do it, however. Regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 26 05:00:41 2015 Received: (at 19547) by debbugs.gnu.org; 26 Dec 2015 10:00:41 +0000 Received: from localhost ([127.0.0.1]:36779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCleT-0002LT-Bi for submit@debbugs.gnu.org; Sat, 26 Dec 2015 05:00:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42263) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCleR-0002LH-Uo for 19547@debbugs.gnu.org; Sat, 26 Dec 2015 05:00:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aCleH-0008PB-Sg for 19547@debbugs.gnu.org; Sat, 26 Dec 2015 05:00:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCleH-0008P7-P1; Sat, 26 Dec 2015 05:00:29 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1107 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aCleG-00053f-UK; Sat, 26 Dec 2015 05:00:29 -0500 Date: Sat, 26 Dec 2015 12:01:14 +0200 Message-Id: <8337upjzpx.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-reply-to: <87lh8igi46.fsf@web.de> (message from Michael Heerdegen on Sat, 26 Dec 2015 01:37:29 +0100) Subject: Re: bug#19547: 25.0.50; throw-on-input "fires" when switching workspace References: <874ms03qj1.fsf@web.de> <83egr36ltc.fsf@gnu.org> <87oaq6l1ea.fsf@web.de> <87oapudv8e.fsf@web.de> <838ugyxgk1.fsf@gnu.org> <87oaph2w9d.fsf@web.de> <831tmbl4zh.fsf@gnu.org> <87pp9tlnd7.fsf@web.de> <83k301iq4g.fsf@gnu.org> <87d25tlf83.fsf@web.de> <837fw1ilfl.fsf@gnu.org> <87twpvrqj8.fsf@web.de> <87twnqq7ra.fsf@web.de> <83fuz98gre.fsf@gnu.org> <87bn9x5ly1.fsf@gmail.com> <838u518d32.fsf@gnu.org> <87egetgj43.fsf@web.de> <83r3it6m5u.fsf@gnu.org> <87lh8igi46.fsf@web.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 19547 Cc: jwiegley@gmail.com, 19547@debbugs.gnu.org, thierry.volpiatto@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Michael Heerdegen > Cc: thierry.volpiatto@gmail.com, jwiegley@gmail.com, 19547@debbugs.gnu.org > Date: Sat, 26 Dec 2015 01:37:29 +0100 > > Eli Zaretskii writes: > > > My suggestion is to make the list of events that input-pending-p > > ignores customizable from Lisp, and then Helm could use that to have > > its way. > > We should not put aside this thread and try to reconstruct the issue > months later one more time. > > If nobody has a better idea - Eli's suggestion solves our problem in an > easy way, so I would say: let's please try this! > > I only reluctantly would want to ask Eli to implement this. I can't do > it, however. My priorities are currently to finish updating the docs by going through NEWS, which is a huge job. So it would be best if someone else could take a shot at this. It shouldn't be too hard, I think. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 13:28:38 2016 Received: (at 19547) by debbugs.gnu.org; 8 Nov 2016 18:28:38 +0000 Received: from localhost ([127.0.0.1]:49932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4B8P-00008D-P3 for submit@debbugs.gnu.org; Tue, 08 Nov 2016 13:28:37 -0500 Received: from mail-lf0-f50.google.com ([209.85.215.50]:33708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4B8N-00007x-TN for 19547@debbugs.gnu.org; Tue, 08 Nov 2016 13:28:36 -0500 Received: by mail-lf0-f50.google.com with SMTP id c13so146260334lfg.0 for <19547@debbugs.gnu.org>; Tue, 08 Nov 2016 10:28:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=Xy5WIHYLNQgIPRXQKpVydzQyB+wESjb7jXRwer4iZx8=; b=m6+rW9FwCG3MZ7eUAjQx4fYp9RbvKYH5sJzqYZ6c2R2vcYs3mACR2ARmK51DTjhhOO SI/ai0FDwqaOudRq0QbtLQRvPraajpJHL/STsHKeUS153zq4WRVLfmQd8VucJt90zv3x d+ny4X/WaKbBt+kjFvTtKTuNuJwRpp47HACac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Xy5WIHYLNQgIPRXQKpVydzQyB+wESjb7jXRwer4iZx8=; b=VYoe+gHwZ7yLNiJ4rpr7eanRDQvJqC0PnEogZt3h+g37bnP834OYAKcSPBuPXDKhbO nA5OZg00HBOK8lSRDDPUE8vPMmOr5E9M8VExJMaxXoGzlpXe9e9e1wriSsvM1CwdUsa2 8iNLBk6mHaMwcuGDQqRcp9FkkB4yBWGQIqa1ArEbjz8Xt4FmPQ1AaKKv3mRPazmuH5iJ eADULNGhaNGvLm52puhLEQu7/0/LBZzeey2kyKlRm2z6G4W8rWeA/YXDZ2lv1RVy31JS b02P2Vx0hjYYN5MRvcpX9T9o4WrfmQPZTNXD3VcBj/9OQ9bjNm5AnoErJPatJaQMySh+ bMSQ== X-Gm-Message-State: ABUngveOBxgegen0nR2+aM0Ny/3HbaazClNx+d1VOgLnAilrfQG8jotFF6LiGAlG7/OkICSpanhMdMIShITYqs7f X-Received: by 10.25.135.130 with SMTP id j124mr8397397lfd.88.1478629709610; Tue, 08 Nov 2016 10:28:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.212.211 with HTTP; Tue, 8 Nov 2016 10:28:28 -0800 (PST) From: Reuben Thomas Date: Tue, 8 Nov 2016 18:28:28 +0000 Message-ID: Subject: Patch for this bug To: 19547@debbugs.gnu.org Content-Type: multipart/mixed; boundary=001a113fbc4498bcf90540ce4ec1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19547 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113fbc4498bcf90540ce4ec1 Content-Type: multipart/alternative; boundary=001a113fbc4498bcf50540ce4ebf --001a113fbc4498bcf50540ce4ebf Content-Type: text/plain; charset=UTF-8 I attach a patch for this bug that takes the simple approach of adding SELECTION_REQUEST_EVENT to the list of events to ignore in kbd_buffer_store_buffered_event. This seems simple and safe (it's not something one would normally consider an input event). Further, at present it would not help helm to implement Eli's suggestion of a list of events for input-pending-p to ignore, as Helm currently does not use that (it has a custom version of while-no-input that does not call input-pending-p). As a helm user with an external clipboard manager, I was experiencing this bug. I'm using Emacs with this patch currently; it seems fine, and I don't have the Helm problem any more. -- http://rrt.sc3d.org --001a113fbc4498bcf50540ce4ebf Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I a= ttach a patch for this bug that takes the simple approach of adding SELECTI= ON_REQUEST_EVENT to the list of events to ignore in kbd_buffer_store_buffer= ed_event.
=
This seems= simple and safe (it's not something one would normally consider an inp= ut event).

=
Further, at pr= esent it would not help helm to implement Eli's suggestion of a list of= events for input-pending-p to ignore, as Helm currently does not use that = (it has a custom version of while-no-input that does not call input-pending= -p).

=
As a helm user with = an external clipboard manager, I was experiencing this bug. I'm using E= macs with this patch currently; it seems fine, and I don't have the Hel= m problem any more.

--
http://rrt.sc3d.org
--001a113fbc4498bcf50540ce4ebf-- --001a113fbc4498bcf90540ce4ec1 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Ignore-SELECTION_REQUEST_EVENT-in-while-no-input.patch" Content-Disposition: attachment; filename="0001-Ignore-SELECTION_REQUEST_EVENT-in-while-no-input.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iv9t4kkl0 RnJvbSA2NDBkZmM0YjYxNjViNWIxOTY4YjNiODRmMWM5OWNjNzM1MTM3N2EzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFR1 ZSwgOCBOb3YgMjAxNiAxODowMTozNyArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIElnbm9yZSBTRUxF Q1RJT05fUkVRVUVTVF9FVkVOVCBpbiB3aGlsZS1uby1pbnB1dAoKKiBzcmMva2V5Ym9hcmQuYyAo a2JkX2J1ZmZlcl9zdG9yZV9idWZmZXJlZF9ldmVudCk6IERvIG5vdCB0cmVhdApTRUxFQ1RJT05f UkVRVUVTVF9FVkVOVCBhcyBhbiBpbnB1dCBldmVudCAoQnVnIzE5NTQ3KS4KLS0tCiBzcmMva2V5 Ym9hcmQuYyB8IDMgKystCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2tleWJvYXJkLmMgYi9zcmMva2V5Ym9hcmQuYwppbmRl eCBmMjRkODZlLi5hMWNmNjc3IDEwMDY0NAotLS0gYS9zcmMva2V5Ym9hcmQuYworKysgYi9zcmMv a2V5Ym9hcmQuYwpAQCAtMzU1OSw3ICszNTU5LDggQEAga2JkX2J1ZmZlcl9zdG9yZV9idWZmZXJl ZF9ldmVudCAodW5pb24gYnVmZmVyZWRfaW5wdXRfZXZlbnQgKmV2ZW50LAogICAgICAgJiYgZXZl bnQtPmtpbmQgIT0gRk9DVVNfT1VUX0VWRU5UCiAgICAgICAmJiBldmVudC0+a2luZCAhPSBIRUxQ X0VWRU5UCiAgICAgICAmJiBldmVudC0+a2luZCAhPSBJQ09OSUZZX0VWRU5UCi0gICAgICAmJiBl dmVudC0+a2luZCAhPSBERUlDT05JRllfRVZFTlQpCisgICAgICAmJiBldmVudC0+a2luZCAhPSBE RUlDT05JRllfRVZFTlQKKyAgICAgICYmIGV2ZW50LT5raW5kICE9IFNFTEVDVElPTl9SRVFVRVNU X0VWRU5UKQogICAgIHsKICAgICAgIFZxdWl0X2ZsYWcgPSBWdGhyb3dfb25faW5wdXQ7CiAgICAg ICAvKiBJZiB3ZSdyZSBpbnNpZGUgYSBmdW5jdGlvbiB0aGF0IHdhbnRzIGltbWVkaWF0ZSBxdWl0 cywKLS0gCjIuNy40Cgo= --001a113fbc4498bcf90540ce4ec1-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 15:40:48 2016 Received: (at 19547) by debbugs.gnu.org; 8 Nov 2016 20:40:48 +0000 Received: from localhost ([127.0.0.1]:50046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4DCK-0003NA-25 for submit@debbugs.gnu.org; Tue, 08 Nov 2016 15:40:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4DCI-0003Mx-8Z for 19547@debbugs.gnu.org; Tue, 08 Nov 2016 15:40:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4DC9-0002XI-Un for 19547@debbugs.gnu.org; Tue, 08 Nov 2016 15:40:41 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4DC9-0002XE-Rn; Tue, 08 Nov 2016 15:40:37 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3306 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c4DC7-00076h-TC; Tue, 08 Nov 2016 15:40:37 -0500 Date: Tue, 08 Nov 2016 22:40:07 +0200 Message-Id: <8360nxhfiw.fsf@gnu.org> From: Eli Zaretskii To: Reuben Thomas In-reply-to: (message from Reuben Thomas on Tue, 8 Nov 2016 18:28:28 +0000) Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Reuben Thomas > Date: Tue, 8 Nov 2016 18:28:28 +0000 > > Further, at present it would not help helm to implement Eli's suggestion of a list of events for input-pending-p > to ignore, as Helm currently does not use that (it has a custom version of while-no-input that does not call > input-pending-p). The suggestion was not that specific. The idea was to let Lisp programs specify which special events they would like to consider as input. E.g., define a variable that holds a list of such events, and test the value of that variable in the same place where you propose to add yet another event to those ignored for the purposes of throw-on-input (IMO, the same list should be looked at in readable_events, which will then make input-pending-p consistent with while-no-input and any other similar functionality). It shouldn't be too hard to implement that, and we gain a certain peace of mind in that we don't have to worry about some hypothetical application that would like to do stuff differently from Helm. IOW, since this is going to go on master, I see no reason to hurry with a simple solution, and would prefer a slightly more complex one, but one that is more future-proof. Can you do that? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 17:20:21 2016 Received: (at 19547) by debbugs.gnu.org; 8 Nov 2016 22:20:21 +0000 Received: from localhost ([127.0.0.1]:50106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4Ekf-0005p2-1e for submit@debbugs.gnu.org; Tue, 08 Nov 2016 17:20:21 -0500 Received: from mail-lf0-f53.google.com ([209.85.215.53]:35441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4Ekb-0005ok-Hw for 19547@debbugs.gnu.org; Tue, 08 Nov 2016 17:20:19 -0500 Received: by mail-lf0-f53.google.com with SMTP id b14so150494904lfg.2 for <19547@debbugs.gnu.org>; Tue, 08 Nov 2016 14:20:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uiEneZUSLsRFeKOtcSIllBLFrR3rRy1Fhn6iJCql5eg=; b=j7AQQRLTn4vafiaX0Qg6CejgNF2zojJaNszvV5io7ATguCkVpwm4g9MgdJ58y62AOs o4KKL+wDRoxrbZq4ed413KgMKbGLriEWYk83bJoox6vq8qCNYMnmuD99lcCJKKJO1DJ+ IMZfnnvVdzn0LTAPF22Gha5Kqw7wofMsWT5IU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uiEneZUSLsRFeKOtcSIllBLFrR3rRy1Fhn6iJCql5eg=; b=KXeu/5bnZffXL0x4l05vIY4sR+8DWHANGzueaRQDLfGU3WHQpcuDjx+QAguCantjRj YB46KV5qwPM0iHg4vzyxbyIPHY6k+0VG5BzXHzefT09Zqcz+IwJEZC6YAxlbWx6js3o8 k3GPd5VXb5xHUkYLKcDiENst6TMQ7ZNJgIB7mbrsuWh2IatxaqRGYswRB6RvzGMiMvhL jUVxTwaRJDzHBQCo+TuScd2PYNiiAvAuReJ9JJcyAe2H6Gdex/R3vhS0rk4gW+MYhx9D KRlcEm3VW9ERM1YHeF/XKbjVNwC1vGv1FRC41gxh5R1IjzxFhzuPrG67tKM4XEuwvDQE eHNg== X-Gm-Message-State: ABUngvfiGI90dNJM/gBMShQorJQ90QlmH9TwBsA3BylFjxoGt8Wd0/VVW0Ewqc+OjwXebMh28J+VIx/vAGUQs2tt X-Received: by 10.25.139.195 with SMTP id n186mr8459408lfd.27.1478643611666; Tue, 08 Nov 2016 14:20:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.212.211 with HTTP; Tue, 8 Nov 2016 14:20:11 -0800 (PST) In-Reply-To: <8360nxhfiw.fsf@gnu.org> References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> From: Reuben Thomas Date: Tue, 8 Nov 2016 22:20:11 +0000 Message-ID: Subject: Re: bug#19547: Patch for this bug To: Eli Zaretskii Content-Type: multipart/alternative; boundary=001a113ebaa6392c690540d18b10 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --001a113ebaa6392c690540d18b10 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 8 November 2016 at 20:40, Eli Zaretskii wrote: > > From: Reuben Thomas > > Date: Tue, 8 Nov 2016 18:28:28 +0000 > > > > Further, at present it would not help helm to implement Eli's suggestio= n > of a list of events for input-pending-p > > to ignore, as Helm currently does not use that (it has a custom version > of while-no-input that does not call > > input-pending-p). > > The suggestion was not that specific. The idea was to let Lisp > programs specify which special events they would like to consider as > input. E.g., define a variable that holds a list of such events, and > test the value of that variable in the same place where you propose to > add yet another event to those ignored for the purposes of > throw-on-input (IMO, the same list should be looked at in > readable_events, which will then make input-pending-p consistent with > while-no-input and any other similar functionality). It shouldn't be > too hard to implement that, and we gain a certain peace of mind in > that we don't have to worry about some hypothetical application that > would like to do stuff differently from Helm. > > IOW, since this is going to go on master, I see no reason to hurry > with a simple solution, and would prefer a slightly more complex one, > but one that is more future-proof. Can you do that? > =E2=80=8BI'm in the middle of a long list of Emacs bugs I am trying to fix,= and this one came up by chance at the same time, because I was suffering from the bug. I'd rather have a simple fix that can also go on the emacs-25 branch, and I don't really have more time to work on a proper fix, sorry. On the other hand, I think it would be sad to have to wait (perhaps forever!) for a "good" fix, when an acceptable fix is available. In particular, no reasonable application is going to expect a request for the selection to trigger a keyboard input event. So indeed future applications may need the "good" fix, but no (reasonable) application will be adversely affected by this fix. --=20 http://rrt.sc3d.org --001a113ebaa6392c690540d18b10 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 8 November 2016 at 20:40, Eli Zaretskii <eliz@gnu.org> wrote:
=
> From: Reuben Thomas <rrt@sc3d.org>
> Date: Tue, 8 Nov 2016 18:28:28 +0000
>
> Further, at present it would not help helm to implement Eli's sugg= estion of a list of events for input-pending-p
> to ignore, as Helm currently does not use that (it has a custom versio= n of while-no-input that does not call
> input-pending-p).

The suggestion was not that specific.=C2=A0 The idea was to let Lisp
programs specify which special events they would like to consider as
input.=C2=A0 E.g., define a variable that holds a list of such events, and<= br> test the value of that variable in the same place where you propose to
add yet another event to those ignored for the purposes of
throw-on-input (IMO, the same list should be looked at in
readable_events, which will then make input-pending-p consistent with
while-no-input and any other similar functionality).=C2=A0 It shouldn't= be
too hard to implement that, and we gain a certain peace of mind in
that we don't have to worry about some hypothetical application that would like to do stuff differently from Helm.

IOW, since this is going to go on master, I see no reason to hurry
with a simple solution, and would prefer a slightly more complex one,
but one that is more future-proof.=C2=A0 Can you do that?
<= div>
= =E2=80=8BI'm in the middle of a long list of Emacs bugs I am trying to = fix, and this one came up by chance at the same time, because I was sufferi= ng from the bug.

I&= #39;d rather have a simple fix that can also go on the emacs-25 branch, and= I don't really have more time to work on a proper fix, sorry.

On the other hand, I think it wou= ld be sad to have to wait (perhaps forever!) for a "good" fix, wh= en an acceptable fix is available. In particular, no reasonable application= is going to expect a request for the selection to trigger a keyboard input= event. So indeed future applications may need the "good" fix, bu= t no (reasonable) application will be adversely affected by this fix.
=

--=C2=A0
http://rrt.sc3d.org
--001a113ebaa6392c690540d18b10-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 09 14:43:59 2016 Received: (at 19547) by debbugs.gnu.org; 9 Nov 2016 19:43:59 +0000 Received: from localhost ([127.0.0.1]:51242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4Ymt-0000yN-6Z for submit@debbugs.gnu.org; Wed, 09 Nov 2016 14:43:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4Ymr-0000y7-7x for 19547@debbugs.gnu.org; Wed, 09 Nov 2016 14:43:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4Ymh-0002dN-KS for 19547@debbugs.gnu.org; Wed, 09 Nov 2016 14:43:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4Ymh-0002dG-GM; Wed, 09 Nov 2016 14:43:47 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4189 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c4Ymf-0002Sq-6a; Wed, 09 Nov 2016 14:43:47 -0500 Date: Wed, 09 Nov 2016 21:43:31 +0200 Message-Id: <83k2ccfnh8.fsf@gnu.org> From: Eli Zaretskii To: Reuben Thomas In-reply-to: (message from Reuben Thomas on Tue, 8 Nov 2016 22:20:11 +0000) Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Reuben Thomas > Date: Tue, 8 Nov 2016 22:20:11 +0000 > Cc: 19547@debbugs.gnu.org > > ​I'm in the middle of a long list of Emacs bugs I am trying to fix, and this one came up by chance at the same > time, because I was suffering from the bug. > > I'd rather have a simple fix that can also go on the emacs-25 branch, and I don't really have more time to work > on a proper fix, sorry. This change will not be on emacs-25 (as this issue existed forever), so there's no rush in implementing it. You can do it whenever you have time. If you cannot afford working more on this issue, then I guess we will have to wait for someone else to implement my suggestion (or something similar). > On the other hand, I think it would be sad to have to wait (perhaps forever!) for a "good" fix, when an > acceptable fix is available. In particular, no reasonable application is going to expect a request for the selection > to trigger a keyboard input event. So indeed future applications may need the "good" fix, but no (reasonable) > application will be adversely affected by this fix. I don't think I asked for something so complicated and hard to accomplish that it would justify partial fixes on master. I'm very uneasy with having the list of hard-coded events we ignore for this purpose continue to grow one event at a time. Making this controlled by a Lisp variable will make its future maintenance much easier, including when someone, perhaps you, comes up complaining about yet another obscure event. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 09 17:03:42 2016 Received: (at 19547) by debbugs.gnu.org; 9 Nov 2016 22:03:42 +0000 Received: from localhost ([127.0.0.1]:51356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4ay5-00066l-TE for submit@debbugs.gnu.org; Wed, 09 Nov 2016 17:03:42 -0500 Received: from mail-lf0-f43.google.com ([209.85.215.43]:36841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4ay4-00066Y-8s for 19547@debbugs.gnu.org; Wed, 09 Nov 2016 17:03:40 -0500 Received: by mail-lf0-f43.google.com with SMTP id t196so175780014lff.3 for <19547@debbugs.gnu.org>; Wed, 09 Nov 2016 14:03:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QwG4WH9HnZtW2x1Soh0Lu7LtbOzb/t7lkh3acwoJOVw=; b=rFRHTyMbxhTqkMv9bXtTJACIn3zIgNgqU3SYeb4NY2ageIv1LHmq1/3G+4qZVYSt13 lQ0lS6eSt0PEDqGlidtRje6atiNlJYXKHs8ggglf0I1Q5A5yl0KIN9IL5bapZmrb/CFy S2d34fXK2ca5RYE2XmaOE/ZYyDpt/rUZTsvGY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QwG4WH9HnZtW2x1Soh0Lu7LtbOzb/t7lkh3acwoJOVw=; b=mJLRN5dIGa3BuGXPwurlGgkZJ28L7V810v4AJckj1lSHnwwsTY4XvaRihvyMD6gqKq jAIFI3qcnJbYINS2rc33ogz4LXDDyxlO3K/MUhfPwJ6lF+1jMuuFUBwQo7dNHvePvFqw Xt8pxxTqEEJLT5FHYe2Iac375Ke5DN24xwrcJFubHmhuVZ/3pSf2wkd5toeqDfNLhVYE yJQxm3Kc+9qLzAm99C6NvOLCl95UilpAEwiuzcT1vnz8SX3Kt4eQ8VewaHrJlWMU56A+ YjGf8mcucxZ0HEsIkow5SAtw1zj0UpmYjxokHG272n6f/Sh/G2qWiDvOtIAhQKsgKDJD 6mrA== X-Gm-Message-State: ABUngvd3He1zm/kt+OR/XKm1jvQDD5w686j5RUjuKjb1ifHOLdJ1IfeIZOk18MuEUCYSZ6ahnl67F1m1y1x4mQ1/ X-Received: by 10.25.139.195 with SMTP id n186mr976103lfd.27.1478729014517; Wed, 09 Nov 2016 14:03:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.212.211 with HTTP; Wed, 9 Nov 2016 14:03:34 -0800 (PST) In-Reply-To: <83k2ccfnh8.fsf@gnu.org> References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> From: Reuben Thomas Date: Wed, 9 Nov 2016 22:03:34 +0000 Message-ID: Subject: Re: bug#19547: Patch for this bug To: Eli Zaretskii Content-Type: multipart/alternative; boundary=001a113ebaa6a13fcd0540e56d88 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --001a113ebaa6a13fcd0540e56d88 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 9 November 2016 at 19:43, Eli Zaretskii wrote: > > I don't think I asked for something so complicated and hard to > accomplish that it would justify partial fixes on master. I'm very > uneasy with having the list of hard-coded events we ignore for this > purpose continue to grow one event at a time. Making this controlled > by a Lisp variable will make its future maintenance much easier, > including when someone, perhaps you, comes up complaining about yet > another obscure event. > =E2=80=8BI already showed I can't see what the correct solution is: I thoug= ht you made a precise suggestion, which I discussed (a list of events for input-pending-p to ignore), but then you said you did not mean anything so precise. So, if you could indicate a precise design that would be acceptable, I will implement it. That seems to me a good medium between extending a hard fix that I agree is inelegant, and my spending lots of time trying to understand yet another area of Emacs. --=20 http://rrt.sc3d.org --001a113ebaa6a13fcd0540e56d88 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 9 November 2016 at 19:43, Eli Zaretskii <eliz@gnu.org> wrote:
=

I don't think I asked for something so complicated and hard to accomplish that it would justify partial fixes on master.=C2=A0 I'm ver= y
uneasy with having the list of hard-coded events we ignore for this
purpose continue to grow one event at a time.=C2=A0 Making this controlled<= br> by a Lisp variable will make its future maintenance much easier,
including when someone, perhaps you, comes up complaining about yet
another obscure event.

=E2=80=8BI already showed I can'= t see what the correct solution is: I thought you made a precise suggestion= , which I discussed (a list of events for input-pending-p to ignore), but t= hen you said you did not mean anything so precise.

So, if you could indicate a precise design that w= ould be acceptable, I will implement it. That seems to me a good medium bet= ween extending a hard fix that I agree is inelegant, and my spending lots o= f time trying to understand yet another area of Emacs.

--
http://rrt.sc3d= .org
--001a113ebaa6a13fcd0540e56d88-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 12:46:49 2016 Received: (at 19547) by debbugs.gnu.org; 10 Nov 2016 17:46:49 +0000 Received: from localhost ([127.0.0.1]:52581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4tR1-0002Oa-FY for submit@debbugs.gnu.org; Thu, 10 Nov 2016 12:46:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4tQz-0002ON-Od for 19547@debbugs.gnu.org; Thu, 10 Nov 2016 12:46:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4tQq-0000Tq-II for 19547@debbugs.gnu.org; Thu, 10 Nov 2016 12:46:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4tQq-0000Tl-FW; Thu, 10 Nov 2016 12:46:36 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4862 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c4tQp-0004mt-QG; Thu, 10 Nov 2016 12:46:36 -0500 Date: Thu, 10 Nov 2016 19:46:37 +0200 Message-Id: <83wpgbdy82.fsf@gnu.org> From: Eli Zaretskii To: Reuben Thomas In-reply-to: (message from Reuben Thomas on Wed, 9 Nov 2016 22:03:34 +0000) Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Reuben Thomas > Date: Wed, 9 Nov 2016 22:03:34 +0000 > Cc: 19547@debbugs.gnu.org > > So, if you could indicate a precise design that would be acceptable, I will implement it. That seems to me a > good medium between extending a hard fix that I agree is inelegant, and my spending lots of time trying to > understand yet another area of Emacs. How about the following: Use DEFVAR_LISP to define a Lisp variable with initial value of Qnil. In some preloaded Lisp file, say subr.el, give that variable a value, a list of symbols that name the events we currently don't consider relevant for throw-on-input. (Those symbols will have to be invented, e.g. 'focus-in' for FOCUS_IN_EVENT, etc.) In kbd_buffer_store_buffered_event, where we set Vquit_flag depending on Vthrow_on_input, examine the value of that list variable, and ignore any events that have their symbols in the list. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 25 12:10:27 2016 Received: (at 19547) by debbugs.gnu.org; 25 Nov 2016 17:10:27 +0000 Received: from localhost ([127.0.0.1]:41658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAK15-0007ka-Dr for submit@debbugs.gnu.org; Fri, 25 Nov 2016 12:10:27 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAK13-0007kM-Ek for 19547@debbugs.gnu.org; Fri, 25 Nov 2016 12:10:25 -0500 Received: by mail-wm0-f46.google.com with SMTP id f82so97650392wmf.1 for <19547@debbugs.gnu.org>; Fri, 25 Nov 2016 09:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3umgI3dZjPEu0fRDK3gaAWDyqQkcq0qQp4/dfoYFeIs=; b=q9nVsyewEQwa2kMWDqanCtBAxyQqE3fTyt2/ccLDPNBVrf7FCL9MMy1ZHL5uCxDtyu NhnkY/AJ19NiGPo6Jzuxb3v5hcUdvZOnMmjqIoZW+Ge5zMohUcD8cPu73zHvo29F+WVi Fff++h8HwaNz+1WYYlSFCY/9yjflpHy/PcfdbRu9WOCuM/8Qh9RruaWGi5VDtwWuZ2JG /EKVqBS5k204jDbRcHqQxXXTuWtYYQCH+VZlIhUPoy3DU/jBtLBgB+yh2SAVU3manWY1 7fjMONtbmZI+x8UhN9K1Fi4rmWEsa07VzvPiABPmgfluRvpqzSZHIqRT5I7lM7cCfrdH 0gpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3umgI3dZjPEu0fRDK3gaAWDyqQkcq0qQp4/dfoYFeIs=; b=GrWjerK9K0mESx7p7fDXnicm5xXgBY0s84C6a7EUyIyqVWS1slSURedxJaE00ZYlcz +O3md2VQeAgQnxXCKYgoq+/M7kG2HOOisU+hqo+wilo6oG48vgrrOAZ+JQTf1JqolOsT EBHPMM8+Zim4XVafLSqDdYUtRFSmAKQRsmL2qAdE3mb+Ry+VlJ+4w3OW/FVsJA/+SZvj 3b6nFOYSnvJGFwpuaT36VXnWxPTtDQN7dpnE2iiGfJRbiiTsPoOc99QOvzidtYnkBf10 CHTa4sY5A3z6V1A9Y3L6QK2rQdcMWqDaddBIu14mnv6lcnDheXmWMtNUg11Own4VVSkP qz1A== X-Gm-Message-State: AKaTC003Mk2Om9IMn0w9O1lFWCrVuGU9CnzuhCJqrZsExuOvxMmsiAvPIsVff8UYqmk1hQ== X-Received: by 10.28.153.201 with SMTP id b192mr8834274wme.61.1480093819713; Fri, 25 Nov 2016 09:10:19 -0800 (PST) Received: from dell-14z ([37.167.63.210]) by smtp.gmail.com with ESMTPSA id p144sm14428478wme.23.2016.11.25.09.10.17 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 25 Nov 2016 09:10:18 -0800 (PST) From: Thierry Volpiatto To: Eli Zaretskii Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> Date: Fri, 25 Nov 2016 18:10:15 +0100 In-Reply-To: <83wpgbdy82.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Nov 2016 19:46:37 +0200") Message-ID: <87y4071o5k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org, Reuben Thomas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) As no body is working on this, I started looking at this as I would like to have a fix for this for helm, however I have difficulties as my C level is 0. Could you please bear with me on some points ? Eli Zaretskii writes: >> From: Reuben Thomas >> Date: Wed, 9 Nov 2016 22:03:34 +0000 >> Cc: 19547@debbugs.gnu.org >> >> So, if you could indicate a precise design that would be acceptable, I will implement it. That seems to me a >> good medium between extending a hard fix that I agree is inelegant, and my spending lots of time trying to >> understand yet another area of Emacs. > > How about the following: > > Use DEFVAR_LISP to define a Lisp variable with initial value of Qnil. Ok for this one (I think). > In some preloaded Lisp file, say subr.el, give that variable a value, > a list of symbols that name the events we currently don't consider > relevant for throw-on-input. Ok. > (Those symbols will have to be invented, e.g. 'focus-in' for > FOCUS_IN_EVENT, etc.) It is here I don't understand, how do I make the correspondance with e.g focus-in (the lisp symbol) and FOCUS_IN_EVENT ? > In kbd_buffer_store_buffered_event, where we set Vquit_flag depending > on Vthrow_on_input, examine the value of that list variable, and > ignore any events that have their symbols in the list. Ok, well you will tell me when I send patch... From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 02:40:42 2016 Received: (at 19547) by debbugs.gnu.org; 26 Nov 2016 07:40:42 +0000 Received: from localhost ([127.0.0.1]:42057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAXbG-0007FH-8t for submit@debbugs.gnu.org; Sat, 26 Nov 2016 02:40:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAXbE-0007F4-Va for 19547@debbugs.gnu.org; Sat, 26 Nov 2016 02:40:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAXb6-0007SW-Em for 19547@debbugs.gnu.org; Sat, 26 Nov 2016 02:40:35 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAXb6-0007SQ-46; Sat, 26 Nov 2016 02:40:32 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3537 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cAXb4-0001YO-ST; Sat, 26 Nov 2016 02:40:31 -0500 Date: Sat, 26 Nov 2016 09:40:24 +0200 Message-Id: <83h96u3d07.fsf@gnu.org> From: Eli Zaretskii To: Thierry Volpiatto In-reply-to: <87y4071o5k.fsf@gmail.com> (message from Thierry Volpiatto on Fri, 25 Nov 2016 18:10:15 +0100) Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org, rrt@sc3d.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > From: Thierry Volpiatto > Cc: Reuben Thomas , 19547@debbugs.gnu.org > Date: Fri, 25 Nov 2016 18:10:15 +0100 > > As no body is working on this, I started looking at this as I would like > to have a fix for this for helm, however I have difficulties as my C > level is 0. > Could you please bear with me on some points ? Sure, and thanks for working on this. > > In some preloaded Lisp file, say subr.el, give that variable a value, > > a list of symbols that name the events we currently don't consider > > relevant for throw-on-input. > > Ok. > > > (Those symbols will have to be invented, e.g. 'focus-in' for > > FOCUS_IN_EVENT, etc.) > > It is here I don't understand, how do I make the correspondance with e.g > focus-in (the lisp symbol) and FOCUS_IN_EVENT ? You can do that with a 'switch' in C, or, better, with a C array that holds the symbols and their corresponding C event_kind values, like this: struct event_value { Lisp_Object event_symbol; enum event_kind event_kind; }; static struct event_value symbol_to_kind[] = { { Qfocus_in, FOCUS_IN_EVENT }, { Qhelp, HELP_EVENT }, { Qiconify, ICONIFY_EVENT }, ... }; Then, for each symbol, you can find the corresponding event value by walking the array until you find a match. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 03:39:27 2016 Received: (at 19547) by debbugs.gnu.org; 26 Nov 2016 08:39:27 +0000 Received: from localhost ([127.0.0.1]:42063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAYW6-00005T-US for submit@debbugs.gnu.org; Sat, 26 Nov 2016 03:39:27 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:37198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAYW4-00005I-P3 for 19547@debbugs.gnu.org; Sat, 26 Nov 2016 03:39:25 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3tQmZg47t6z3hjdY; Sat, 26 Nov 2016 09:39:22 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3tQmZf4Ytdzvp5T; Sat, 26 Nov 2016 09:39:22 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id kHiY_bqLa9yu; Sat, 26 Nov 2016 09:39:21 +0100 (CET) X-Auth-Info: yUD/qcBjKSlBm97WXF1fdbWkjuxzunSShu9y8ChEnCY6wQLAsujnF3noHICtz0pG Received: from linux.local (ppp-88-217-27-16.dynamic.mnet-online.de [88.217.27.16]) by mail.mnet-online.de (Postfix) with ESMTPA; Sat, 26 Nov 2016 09:39:21 +0100 (CET) Received: by linux.local (Postfix, from userid 501) id D29031E54B3; Sat, 26 Nov 2016 09:39:18 +0100 (CET) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> X-Yow: I FORGOT to do the DISHES!! Date: Sat, 26 Nov 2016 09:39:17 +0100 In-Reply-To: <83h96u3d07.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 26 Nov 2016 09:40:24 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org, rrt@sc3d.org, Thierry Volpiatto X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Nov 26 2016, Eli Zaretskii wrote: > struct event_value { > Lisp_Object event_symbol; > enum event_kind event_kind; > }; > static struct event_value symbol_to_kind[] = { > { Qfocus_in, FOCUS_IN_EVENT }, > { Qhelp, HELP_EVENT }, > { Qiconify, ICONIFY_EVENT }, Qfoo isn't a compile time constant, so you cannot use it for initializing a static variable in C. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 04:02:24 2016 Received: (at 19547) by debbugs.gnu.org; 26 Nov 2016 09:02:24 +0000 Received: from localhost ([127.0.0.1]:42079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAYsK-0000bu-51 for submit@debbugs.gnu.org; Sat, 26 Nov 2016 04:02:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAYsI-0000bh-2X for 19547@debbugs.gnu.org; Sat, 26 Nov 2016 04:02:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAYsC-00056L-Cp for 19547@debbugs.gnu.org; Sat, 26 Nov 2016 04:02:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAYsC-00056G-AN; Sat, 26 Nov 2016 04:02:16 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3612 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cAYsB-0006qP-H9; Sat, 26 Nov 2016 04:02:15 -0500 Date: Sat, 26 Nov 2016 11:02:08 +0200 Message-Id: <834m2u397z.fsf@gnu.org> From: Eli Zaretskii To: Andreas Schwab In-reply-to: (message from Andreas Schwab on Sat, 26 Nov 2016 09:39:17 +0100) Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org, rrt@sc3d.org, thierry.volpiatto@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > From: Andreas Schwab > Cc: Thierry Volpiatto , rrt@sc3d.org, 19547@debbugs.gnu.org > Date: Sat, 26 Nov 2016 09:39:17 +0100 > > On Nov 26 2016, Eli Zaretskii wrote: > > > struct event_value { > > Lisp_Object event_symbol; > > enum event_kind event_kind; > > }; > > static struct event_value symbol_to_kind[] = { > > { Qfocus_in, FOCUS_IN_EVENT }, > > { Qhelp, HELP_EVENT }, > > { Qiconify, ICONIFY_EVENT }, > > Qfoo isn't a compile time constant, so you cannot use it for > initializing a static variable in C. OK, then this array should be filled at startup time. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 13:50:26 2016 Received: (at 19547) by debbugs.gnu.org; 26 Nov 2016 18:50:26 +0000 Received: from localhost ([127.0.0.1]:42630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAi3N-0007do-Qf for submit@debbugs.gnu.org; Sat, 26 Nov 2016 13:50:25 -0500 Received: from mail-wj0-f172.google.com ([209.85.210.172]:34386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAi3L-0007dY-OK for 19547@debbugs.gnu.org; Sat, 26 Nov 2016 13:50:24 -0500 Received: by mail-wj0-f172.google.com with SMTP id mp19so83278780wjc.1 for <19547@debbugs.gnu.org>; Sat, 26 Nov 2016 10:50:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=kpcGWrCE22rFc+UeewcWL9vaJlKPNo/1tjlE5doOkQE=; b=Ch1jAq8opHzY61Up2WY/5XwUFbwBb4Wyrk5fUqV/u0zg48J5kq3KicFwWZki17EYkf 8wIH75gSqe+tAm2IjmaL/oHe9aMVs39Hl07vZChtMJRAMEkUzHrFSlV9GK4od5VPAi9b HfcKBJNeHPGEa2o5PLlWV8Jj3oqzAu+e3firc1626PfhnAT6PV5jIFz7fnBxbPR5vON0 aPv5NT2cMRg7jugJTKCMx4tUZpcWJQaXAfid/riSDWeaffIyuHuf+Y/uOxBtDKmPgvFR QFyEl4ujz/A0jnI8KngmBl4LEKa0xNr5aZNzhHzbKENUxox5zmkwDVT6Ax/irDEbMqvi pqTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=kpcGWrCE22rFc+UeewcWL9vaJlKPNo/1tjlE5doOkQE=; b=IpFqnvDohk4E6AgoPMakcBYYvsDLU87X6n7HTpSUZU8UvPFgf9Kk6nOU1ThkfJM7+a F8oYN5WZHNkb49pb7cT8xzYmcSTvRuEd/uTLeZai3IPuSTBpQtO4nAwfbOK8TSXZF+hs tvUfjOo+qj49Td+9QqXo3clt/pBnNnDAg81NeVQYMMjlzedEj0wbcn56aH/GpStGbtLh /xEmNClnoToz2wxdFIK/d7El2opCxiIGUbRXwAHdyTV6k/jWvBSd135BK2a5EQx2mDFf mbkuxibt1GfDzPFjdTxMsFKMf+rUwa8MUw6M+DLysbFflwuKoayA413BY6Ictuum1fKl nHfQ== X-Gm-Message-State: AKaTC00i1kTEwxMpFHqzOprH0bbMzFQ0eBLwiqjDAGQj+NIFiqs9XFyYqeL7Yo4kK8kKRg== X-Received: by 10.194.15.37 with SMTP id u5mr11978006wjc.117.1480186217719; Sat, 26 Nov 2016 10:50:17 -0800 (PST) Received: from dell-14z ([37.164.88.201]) by smtp.gmail.com with ESMTPSA id v2sm53483470wja.41.2016.11.26.10.50.15 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 26 Nov 2016 10:50:16 -0800 (PST) References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Thierry Volpiatto To: Eli Zaretskii Subject: Re: bug#19547: Patch for this bug In-reply-to: <83h96u3d07.fsf@gnu.org> Date: Sat, 26 Nov 2016 19:50:13 +0100 Message-ID: <87lgw66pp6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org, rrt@sc3d.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Eli Zaretskii writes: > You can do that with a 'switch' in C, or, better, with a C array that > holds the symbols and their corresponding C event_kind values, like > this: > > struct event_value { > Lisp_Object event_symbol; > enum event_kind event_kind; > }; > static struct event_value symbol_to_kind[] = { > { Qfocus_in, FOCUS_IN_EVENT }, > { Qhelp, HELP_EVENT }, > { Qiconify, ICONIFY_EVENT }, > ... > }; > > Then, for each symbol, you can find the corresponding event value by > walking the array until you find a match. Thanks, I will try to learn how to do this with both methods, only able to produce errors for now :-) I tried using Fmemq to check if event (translated with switch) is in new variable Vwhile_no_input_ignore_events, but without success. Will tell you as soon as I can end up with something more or less usable. Thanks again. -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 01:52:40 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 06:52:40 +0000 Received: from localhost ([127.0.0.1]:42850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAtKK-0001WB-IC for submit@debbugs.gnu.org; Sun, 27 Nov 2016 01:52:40 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAtKI-0001Vx-EJ for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 01:52:38 -0500 Received: by mail-wm0-f53.google.com with SMTP id a197so177401884wmd.0 for <19547@debbugs.gnu.org>; Sat, 26 Nov 2016 22:52:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=X6DFWQqG6o6OsIElp9eBshuOImu00AEaUs0ySCJqWok=; b=nWgJkM/EyYNBDnyKgZNYilXNee9yKwUcP4s3viZzR0cKsaQUoSjh7aAXZfExGnxD/d 03BBpw0icmyRNtUqClIARZvNiCS79/RFHSPexCnBh8at0jKi3AtPKmLQZ+7N6zeteqpw BvIRQ6pI5Nd1hh2pbLmjDulKNVEktJx5pictMJfbUH7ChnpOVJFtCkuMf0YRsBCP29nq wvXxSzp/bJWW9FTNDaK5tyLthd5kGS6qtxVdXYSZw0pBrpHR4KzVSUspDpEdGiEiChVO I+fAapdV64WYnXeRaftGD6Ij8QfihpNNNqw9Bz0FtycwcAG4jPDdW+z2V+C67KmQwPyA 7nXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=X6DFWQqG6o6OsIElp9eBshuOImu00AEaUs0ySCJqWok=; b=Q3JgBz4xWoclAHqj4ZZgJmUcuyGZG6lrHic2Ipq0CMDM2sCTLnyGdhziQjA7hG4aMB tFr0NSOi8tkIPtk9fmdimenGYNee9Ea85PIDXX5Q8nVnhnwUfsbx9CHeNzqq6VFkiDE7 lgqf/gmTE3p9Wpj6JU3UqXwt2Y8o8LbwS5rDYBPcHmTbsyM8f7oJ/8nyZ00+va41fMTj 8SmA9ZJ+H5mzHAZhJICrGXhEK9c2EHrsRYleknq0thyXo0QnvKs86ZBxHaGDAkdzlAW9 nb3lIJ6BGB1PGoEUOUe8/3S/hICuNIcB1ent4vCsWqiyPFL+fOQH7BfjxRUupxRXzMhZ BwvQ== X-Gm-Message-State: AKaTC00bL2ZSlIB+y06cIolrW8wkOoAGrkyc7ctT/bP8iyrzgss3L5Y74YuKgGwtZdtC0g== X-Received: by 10.28.6.203 with SMTP id 194mr13526415wmg.16.1480229552437; Sat, 26 Nov 2016 22:52:32 -0800 (PST) Received: from dell-14z ([37.165.55.141]) by smtp.gmail.com with ESMTPSA id pd2sm55652674wjb.31.2016.11.26.22.52.30 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 26 Nov 2016 22:52:31 -0800 (PST) References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Thierry Volpiatto To: Eli Zaretskii Subject: Re: bug#19547: Patch for this bug In-reply-to: <83h96u3d07.fsf@gnu.org> Date: Sun, 27 Nov 2016 07:52:28 +0100 Message-ID: <87zikl8leb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org, rrt@sc3d.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Eli Zaretskii writes: > You can do that with a 'switch' in C, or, better, with a C array that > holds the symbols and their corresponding C event_kind values, like > this: > > struct event_value { > Lisp_Object event_symbol; > enum event_kind event_kind; > }; > static struct event_value symbol_to_kind[] = { > { Qfocus_in, FOCUS_IN_EVENT }, > { Qhelp, HELP_EVENT }, > { Qiconify, ICONIFY_EVENT }, > ... > }; > > Then, for each symbol, you can find the corresponding event value by > walking the array until you find a match. I finally wrote a patch for keyboard.c which is compiling without error, I used switch because I still not understanding how to use the code above (seems that is approach is too advanced for my skills compared to the usage of switch). The patch seems to work fine with helm, though i didn't test with our bug (https://github.com/emacs-helm/helm/issues/1157), but I now don't know where to initialize our variable (while-no-input-ignore-events), I just setq it in scratch buffer after starting helm with a minimal installation (script emacs-helm.sh). Here the patch (please look at it carefully this is the first C code I write): diff --git a/src/keyboard.c b/src/keyboard.c index 65938a5..3caf506 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -3567,14 +3567,22 @@ kbd_buffer_store_buffered_event (union buffered_input_event *event, #endif /* subprocesses */ } + Lisp_Object ignore_event; + + switch (event->kind) + { + case FOCUS_IN_EVENT: ignore_event = Qfocus_in; + case FOCUS_OUT_EVENT: ignore_event = Qfocus_out; + case HELP_EVENT: ignore_event = Qhelp; + case ICONIFY_EVENT: ignore_event = Qiconify; + case DEICONIFY_EVENT: ignore_event = Qdeiconify; + case SELECTION_REQUEST_EVENT: ignore_event = Qselection_request; + } + /* If we're inside while-no-input, and this event qualifies as input, set quit-flag to cause an interrupt. */ if (!NILP (Vthrow_on_input) - && event->kind != FOCUS_IN_EVENT - && event->kind != FOCUS_OUT_EVENT - && event->kind != HELP_EVENT - && event->kind != ICONIFY_EVENT - && event->kind != DEICONIFY_EVENT) + && !NILP (Fmemq (ignore_event, Vwhile_no_input_ignore_events))) { Vquit_flag = Vthrow_on_input; /* If we're inside a function that wants immediate quits, @@ -11164,6 +11172,10 @@ syms_of_keyboard (void) DEFSYM (Qiconify_frame, "iconify-frame"); DEFSYM (Qmake_frame_visible, "make-frame-visible"); DEFSYM (Qselect_window, "select-window"); + DEFSYM (Qhelp, "help"); + DEFSYM (Qiconify, "iconify"); + DEFSYM (Qdeiconify, "deiconify"); + DEFSYM (Qselection_request, "selection-request"); { int i; @@ -11822,6 +11834,12 @@ signals. */); /* Create the initial keyboard. Qt means 'unset'. */ initial_kboard = allocate_kboard (Qt); + + DEFVAR_LISP ("while-no-input-ignore-events", + Vwhile_no_input_ignore_events, + doc: /* Ignored events from while-no-input. */); + Vwhile_no_input_ignore_events = Qnil; + /* = listn (Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, Qselection_request); */ } void Thanks. -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 02:16:49 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 07:16:49 +0000 Received: from localhost ([127.0.0.1]:42865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAthh-000251-Cb for submit@debbugs.gnu.org; Sun, 27 Nov 2016 02:16:49 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:35687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAthg-00024n-2U for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 02:16:48 -0500 Received: by mail-wm0-f54.google.com with SMTP id a197so177651518wmd.0 for <19547@debbugs.gnu.org>; Sat, 26 Nov 2016 23:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=vd/z3wK1hd9z/YaZEf8WVQ6lF07Wel3UHqE2woPsvts=; b=bFVaxTAHsEFg2LvP/ONbf/s5G87QnYDsHHmllNKiLbATLP3Gre7jyF/+/5mvPZ/ite 5S26mcFus8dzI24X1OkcqQuft4I6gyS70N5TCXx5+HZsQfOD0h8Rb1vmllR1MJuhFjbs F30gPiCrL+nt4ZmN3tcMX5QMH7SBpgbkQ9n5zzAvPZ4Y8MiBM22SEtA4V4mRJgK6k3BF Wpd6cZyuSp/2UZdkWtPpCC5X5aZ/1S5cCCoI0jeGkDJQWdme2Z2TSAzM1iIyjLmhf8QO 0nO0bdVT7uGSaEZ7FYP81oQTTIBfmdpuR8fElF6YJ5juQcbpyYvLZngIXUvU+fHASiAa wVPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=vd/z3wK1hd9z/YaZEf8WVQ6lF07Wel3UHqE2woPsvts=; b=Rkhfm0hL+YU4mPBOgj4lvc562z0oPKoFqJQHGjKfz5AaFwzVYPFKo5Bvch3gqk9Kk8 zMM8pLJMrh5Xf9rin649YKXD0bnnhWueEHVCbvgtwJxLuJtjiNciAX7n6ABbZAKbSz/h f/zCJm8OjNkT/+E+iI0nqBbX/lROczKAp6kWV/wJ60bDEcUrh5FuDbyAW4MdCySf6A+R 3uKF0LkzAOeqBc8/qvmg4sMwMxIFhqr8O91TTPY8FAEIynZHeeICSz8+jGs4y3N7Ex8G z7M9ijPRo4amz0PMkiPK1lMQ2GZ4CjoyIz92B5FnqVqJCKuRrY4xioG/XKldEXWBuscU 6nAQ== X-Gm-Message-State: AKaTC02IN3t1YQ42IJXXTxb1QwlLw5B6SqN8s1oCgHMmXNfAwjgt/N1CbHs9yXPk54V4Rg== X-Received: by 10.28.181.197 with SMTP id e188mr13664261wmf.32.1480231002419; Sat, 26 Nov 2016 23:16:42 -0800 (PST) Received: from dell-14z ([37.165.55.141]) by smtp.gmail.com with ESMTPSA id d17sm55646759wjr.14.2016.11.26.23.16.40 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 26 Nov 2016 23:16:41 -0800 (PST) References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Thierry Volpiatto To: Eli Zaretskii Subject: Re: bug#19547: Patch for this bug In-reply-to: <83h96u3d07.fsf@gnu.org> Date: Sun, 27 Nov 2016 08:16:39 +0100 Message-ID: <87y4058ka0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org, rrt@sc3d.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I have installed Parcellite (a clipboard manager). When it is running I can reproduce the bug at every time when running helm-find-files on a very large directory, but with the patch applied and (setq while-no-input-ignore-events '(focus-in focus-out help iconify deiconify selection-request)) it is now working as expected, the listing of directory popup immediately. -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 09:07:04 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 14:07:04 +0000 Received: from localhost ([127.0.0.1]:42977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB06i-0005Lr-1j for submit@debbugs.gnu.org; Sun, 27 Nov 2016 09:07:04 -0500 Received: from mail-io0-f182.google.com ([209.85.223.182]:35708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB06g-0005LM-JE for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 09:07:02 -0500 Received: by mail-io0-f182.google.com with SMTP id a124so190583398ioe.2 for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 06:07:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=oOICYKgK5bfuLzLIQORQhCuklkBDywfN3P/PG3uROoc=; b=uuz07mnKmzWwF/3YzsEpAgJ4AN7lT4mocwr/va5wNfZdOhg5CCzV/kyNbC8/lsV28M FYH49kMaQ8n6lp1YGKSNAtWwQXh6JLD8FUoK97O1ZbqdNBkGjfhvA9Phzb2S2p+UbESa jBkbTK0yGVJ4DMCiX00qTdvcIOqCJsZFKlDlLUYe7mrjIL97FqzrHZY+Spmn2HafVVtS QMHPAAm/P9yN6/zAVG/EedWGKp2DLdMboVpDgN9TnWoNQSk+cz03oyCBz0Qpp5f8iQeE 5olM7sfKZrAbrAzkn8Pnm0HiIXfnWDTE43UYZrp5rPbfruaE4DzngkIgvKyk7PheVvqG Tp/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=oOICYKgK5bfuLzLIQORQhCuklkBDywfN3P/PG3uROoc=; b=PMQRRy+sONoBUkfZh/V4hsfGnwxAgqWhvBT9oQZZW/sQ0ZdFATcqzaKIhEVZaiYunA PsSygW+LFjX2KuRnZGtrEFvPQ6tDnUj9Djzd0fOOnsSNOttFa+BJlogCIeVMiZxNYDL3 3JOLvYAU/OndQbBMh3qwJWDQmr87g8c/EkNmd3x/TBqB6yvJA01Z76Z1IM6j2AHKMhY9 27SZ/XAk2ODUPvbK/7E1o8liryMtsEZzmIQpVQcjvX+m6ZCKBqfJsm4H7fhxHU0OuJfQ nFH9LUk66I3XquKbEBPg+7aAXfm85muAyvpqmSWMyMtxvB18L5Kslr6Ufkp5pqaTv4Ep WiwA== X-Gm-Message-State: AKaTC0098CHo3N8UEOzS/++9FnLhBSIR0Jty94wsDhzKLYNQPAJN9KyClDxmaYtxMaXH7g== X-Received: by 10.107.152.80 with SMTP id a77mr14743267ioe.77.1480255616949; Sun, 27 Nov 2016 06:06:56 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id m4sm18321589iom.20.2016.11.27.06.06.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 27 Nov 2016 06:06:56 -0800 (PST) From: npostavs@users.sourceforge.net To: Thierry Volpiatto Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> Date: Sun, 27 Nov 2016 09:07:51 -0500 In-Reply-To: <87zikl8leb.fsf@gmail.com> (Thierry Volpiatto's message of "Sun, 27 Nov 2016 07:52:28 +0100") Message-ID: <871sxxj9s8.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 19547 Cc: Eli Zaretskii , rrt@sc3d.org, 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Thierry Volpiatto writes: > > + Lisp_Object ignore_event; > + > + switch (event->kind) > + { > + case FOCUS_IN_EVENT: ignore_event = Qfocus_in; > + case FOCUS_OUT_EVENT: ignore_event = Qfocus_out; > + case HELP_EVENT: ignore_event = Qhelp; > + case ICONIFY_EVENT: ignore_event = Qiconify; > + case DEICONIFY_EVENT: ignore_event = Qdeiconify; > + case SELECTION_REQUEST_EVENT: ignore_event = Qselection_request; You need a break at the end of each case, otherwise all events would be treated as SELECTION_REQUEST_EVENT. case FOCUS_IN_EVENT: ignore_event = Qfocus_in; break; > + Vwhile_no_input_ignore_events = Qnil; > + /* = listn (Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, Qselection_request); */ I think something like this should work: listn (CONSTYPE_PURE, 6, Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, Qselection_request); From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 09:54:12 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 14:54:12 +0000 Received: from localhost ([127.0.0.1]:43001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB0qK-0006V0-0V for submit@debbugs.gnu.org; Sun, 27 Nov 2016 09:54:12 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:32856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB0qH-0006Um-Rd for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 09:54:10 -0500 Received: by mail-wm0-f41.google.com with SMTP id c184so35975921wmd.0 for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 06:54:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=V0IrXQJUnmifjaBehiMGN7BkuDQrKRkg2OT0NbQi5Wc=; b=dpEPrcHq7sLvMcpMhpq6Ln/t2HssvMSFAxG0x2frJePQKD1eXXP4WoUybr80b5vPlf P4ZpJyFQTsYC0bwjVvuOJOvNUe3P99PpguSNheNmxZpx7DcOGZaRJLWDnv6n5B9dROPm HncCE59L9fBbtylmuPAmQdb7GmYt7dhFDa6YBLBSbPv8UgrZIUvUcdM7hLsS53/4edyo k3I1YD30g/js38ZfzuR4+NeZl/i0Rlg6UFSmZZ6mIs4mw8YjGXykTaT9frIAnbQB8wQo lwQfB2Hg8g7EV+G4I6mMsBq7zDR9pH3eAZ7qF2ogDkj3SSxY3NEGBlPa7oZIYEy21V7r pZPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=V0IrXQJUnmifjaBehiMGN7BkuDQrKRkg2OT0NbQi5Wc=; b=IY6SW2qAYI43rGXsmdaq9xomgXQFVP2mprxL0iC/6q9bVQTlZYBix/rm9I3deLLXCq 2FG5cRRI9n0NTS0BwyidA/96ZJnBXUzaN2D2wQ8/ht584ImM2wMZ6XVhDzaChXpke3ht esoi4dPizb/9dwjMsex70DQjCF4EeLypImMdBjZov6TOaFERJsXrOzlXUOYP8+8YU4Fz xaJ2oQ3jCxtcjnrLohCu9h8/VhCuwNaroThiUmisquZd8CxldNeZtPmY+U3ONCcsVHx/ UQrtq7ni2nYvIT4Je7G4viXmgVL1xBK6yGKPjCpzgV9Ukbdz3X6D3NVDfklpiRerN7Ku h54w== X-Gm-Message-State: AKaTC01EmqES+zMfmpHw1ICBov7V2BKYXJVKP89ct/2+kBejRmTRgnhgWCayzpx2Zd2qkw== X-Received: by 10.28.111.70 with SMTP id k67mr15174401wmc.32.1480258443807; Sun, 27 Nov 2016 06:54:03 -0800 (PST) Received: from MM061 (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by smtp.gmail.com with ESMTPSA id jm6sm57565766wjb.27.2016.11.27.06.54.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 27 Nov 2016 06:54:02 -0800 (PST) References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Thierry Volpiatto To: npostavs@users.sourceforge.net Subject: Re: bug#19547: Patch for this bug In-reply-to: <871sxxj9s8.fsf@users.sourceforge.net> Date: Sun, 27 Nov 2016 15:53:58 +0100 Message-ID: <87twat6kjd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: Eli Zaretskii , rrt@sc3d.org, 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) npostavs@users.sourceforge.net writes: > Thierry Volpiatto writes: >> >> + Lisp_Object ignore_event; >> + >> + switch (event->kind) >> + { >> + case FOCUS_IN_EVENT: ignore_event = Qfocus_in; >> + case FOCUS_OUT_EVENT: ignore_event = Qfocus_out; >> + case HELP_EVENT: ignore_event = Qhelp; >> + case ICONIFY_EVENT: ignore_event = Qiconify; >> + case DEICONIFY_EVENT: ignore_event = Qdeiconify; >> + case SELECTION_REQUEST_EVENT: ignore_event = Qselection_request; > > You need a break at the end of each case, otherwise all events would be > treated as SELECTION_REQUEST_EVENT. > > case FOCUS_IN_EVENT: ignore_event = Qfocus_in; break; You answer exactly at what I was wondering about, is break needed or not? >> + Vwhile_no_input_ignore_events = Qnil; >> + /* = listn (Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, Qselection_request); */ > > I think something like this should work: > > listn (CONSTYPE_PURE, 6, Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, Qselection_request); Same here, I had to use Qnil because I always had errors when trying to feed this variable here, I will try tonight if that works. I wondered also if instead the variable could be feeded from lisp as suggested by Eli, but I don't know yet where is the good place for this and how. Many thanks for your help. -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 10:55:15 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 15:55:15 +0000 Received: from localhost ([127.0.0.1]:43724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB1nP-0001NV-9F for submit@debbugs.gnu.org; Sun, 27 Nov 2016 10:55:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB1nN-0001NJ-5P for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 10:55:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cB1nH-0005R7-6F for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 10:55:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB1nD-0005PJ-2c; Sun, 27 Nov 2016 10:55:03 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1466 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cB1nC-0000D1-7k; Sun, 27 Nov 2016 10:55:02 -0500 Date: Sun, 27 Nov 2016 17:54:58 +0200 Message-Id: <834m2s2a0d.fsf@gnu.org> From: Eli Zaretskii To: Thierry Volpiatto In-reply-to: <87twat6kjd.fsf@gmail.com> (message from Thierry Volpiatto on Sun, 27 Nov 2016 15:53:58 +0100) Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 19547 Cc: rrt@sc3d.org, 19547@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Thierry Volpiatto > Cc: Eli Zaretskii , 19547@debbugs.gnu.org, rrt@sc3d.org > Date: Sun, 27 Nov 2016 15:53:58 +0100 > > > npostavs@users.sourceforge.net writes: > > > Thierry Volpiatto writes: > >> > >> + Lisp_Object ignore_event; > >> + > >> + switch (event->kind) > >> + { > >> + case FOCUS_IN_EVENT: ignore_event = Qfocus_in; > >> + case FOCUS_OUT_EVENT: ignore_event = Qfocus_out; > >> + case HELP_EVENT: ignore_event = Qhelp; > >> + case ICONIFY_EVENT: ignore_event = Qiconify; > >> + case DEICONIFY_EVENT: ignore_event = Qdeiconify; > >> + case SELECTION_REQUEST_EVENT: ignore_event = Qselection_request; > > > > You need a break at the end of each case, otherwise all events would be > > treated as SELECTION_REQUEST_EVENT. > > > > case FOCUS_IN_EVENT: ignore_event = Qfocus_in; break; > > You answer exactly at what I was wondering about, is break needed or not? In addition to using 'break', you need to initialize ignore_event with some value, otherwise it will hold garbage, which could accidentally be one of the values you want to filter. Alternatively, add a 'default' case to the switch. > >> + Vwhile_no_input_ignore_events = Qnil; > >> + /* = listn (Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, Qselection_request); */ > > > > I think something like this should work: > > > > listn (CONSTYPE_PURE, 6, Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, Qselection_request); > > Same here, I had to use Qnil because I always had errors when trying to > feed this variable here, I will try tonight if that works. I'd suggest to use Flist instead, it should be closer to Lisp (if you want to do this from C). > I wondered also if instead the variable could be feeded from lisp as > suggested by Eli, but I don't know yet where is the good place for this > and how. Something like simple.el should be fine. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 12:59:48 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 17:59:48 +0000 Received: from localhost ([127.0.0.1]:43803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB3jw-0004M0-7p for submit@debbugs.gnu.org; Sun, 27 Nov 2016 12:59:48 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:35745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB3jv-0004Lp-6q for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 12:59:47 -0500 Received: by mail-wm0-f48.google.com with SMTP id a197so185632320wmd.0 for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 09:59:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=yh20OE72HWOiGOTw9p8BBgneb5zb4N546NV5iMzrUBU=; b=fpg08NY5pJDWTvIe6eiAokq2lGPKq34etlRQ97DKAlTHy7oktkNpumPFY09+WO1lmP kudLd9NQ6LklukO0uiTihSN6YSpuNh74O27cB6aVEDp7uM1OrjOoyWVER9GfUlO9tIzd AeHDMGWT1NWF3OejMTAY1IKEMYuh7y8wq3TWkvNfAosINyQwgGKzXIrAllYPwZxc8CRj JHrVAeoHfHl4u46QwlZYqHCQKR7GS3owaDpK6Gun+guTXKiqRuQ34LYLPJ2exk8+F6Mh JqCvltmC9SL1RGeo1j4TFC8V2mrttB760e2PesjTR2QeaH8OCWbshz7UjOcdtuPeNCOY ia0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=yh20OE72HWOiGOTw9p8BBgneb5zb4N546NV5iMzrUBU=; b=j81UGiCGydWWc0jWlyYMAhYusAVdCF4QdrBEo+/Ivr6GD2dbvUvhkAm+BbBuVFH150 dej6iezCxD3SSxNd9COllyrosjKZu1uKQNXWLhblO24YNwO57LXP0ZaPEQJP0gVirQyd EOG/cfm5pkBV+7gCAVksU2rGoKxII9hHU8TgQKqHp2KbFJc/ZgF4I4saLkcVNIM7FTYk saVrgvSqnnPvd8V4FiyuJ8/9VPfjagfLql3SoYOk2vcJjdVA/cbANCIWkTRNFP/FRqyx WZ7pGZnEDpoW6LTV9gb8dIBlu1rBsj4sTqNIDFBqLi8HIylyWmAsLHmoVSbkf4l89iNY eM6Q== X-Gm-Message-State: AKaTC025KlXwGMgpybMkDPt2gOOWO5/qD75gnxb7QFH/ygDUSIBZZQdMB6RX0mL07QTjYw== X-Received: by 10.28.105.78 with SMTP id e75mr17309569wmc.55.1480269581288; Sun, 27 Nov 2016 09:59:41 -0800 (PST) Received: from dell-14z ([37.167.8.218]) by smtp.gmail.com with ESMTPSA id pd2sm58153958wjb.31.2016.11.27.09.59.39 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 27 Nov 2016 09:59:40 -0800 (PST) References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Thierry Volpiatto To: Eli Zaretskii Subject: Re: bug#19547: Patch for this bug In-reply-to: <834m2s2a0d.fsf@gnu.org> Date: Sun, 27 Nov 2016 18:59:37 +0100 Message-ID: <87r35wx0qe.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 19547 Cc: rrt@sc3d.org, 19547@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Eli Zaretskii writes: > In addition to using 'break', you need to initialize ignore_event with > some value, otherwise it will hold garbage, which could accidentally > be one of the values you want to filter. Alternatively, add a > 'default' case to the switch. Is Qnil ok as default value ? > I'd suggest to use Flist instead, it should be closer to Lisp (if you > want to do this from C). Didn't succeed with Flist: keyboard.c:11842:5: error: too many arguments to function ‘Flist’ = Flist (Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, Qselection_request) ^ >> I wondered also if instead the variable could be feeded from lisp as >> suggested by Eli, but I don't know yet where is the good place for this >> and how. > > Something like simple.el should be fine. I would prefer setting the variable from lisp. ok for simple.el, but what is the recommended way for setting it (I don't think throwing a (setq while-no-input-ignore-events [...]) anywhere in simple.el is the way to do) ? Also on my laptop with gcc version 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04.3) I have no warnings, but on an other computer with gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4), I have these warnings (but it compiled fine): keyboard.c: In function ‘kbd_buffer_store_buffered_event’: keyboard.c:3572:3: warning: enumeration value ‘NO_EVENT’ not handled in switch [-Wswitch] switch (event->kind) ^ keyboard.c:3572:3: warning: enumeration value ‘ASCII_KEYSTROKE_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘MULTIBYTE_CHAR_KEYSTROKE_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘NON_ASCII_KEYSTROKE_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘TIMER_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘MOUSE_CLICK_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘WHEEL_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘HORIZ_WHEEL_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘SCROLL_BAR_CLICK_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘HORIZONTAL_SCROLL_BAR_CLICK_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘SELECTION_CLEAR_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘BUFFER_SWITCH_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘DELETE_WINDOW_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘MENU_BAR_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘MENU_BAR_ACTIVATE_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘DRAG_N_DROP_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘USER_SIGNAL_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘TOOL_BAR_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘SELECT_WINDOW_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘SAVE_SESSION_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘GPM_CLICK_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘DBUS_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘CONFIG_CHANGED_EVENT’ not handled in switch [-Wswitch] keyboard.c:3572:3: warning: enumeration value ‘FILE_NOTIFY_EVENT’ not handled in switch [-Wswitch] keyboard.c:3585:11: warning: ‘ignore_event’ may be used uninitialized in this function [-Wmaybe-uninitialized] && !NILP (Fmemq (ignore_event, Vwhile_no_input_ignore_events))) ^ What can I do to avoid this ? Or should I just ignore this ? Thanks. -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 13:05:45 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 18:05:45 +0000 Received: from localhost ([127.0.0.1]:43807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB3ph-0006Ac-51 for submit@debbugs.gnu.org; Sun, 27 Nov 2016 13:05:45 -0500 Received: from mail-lf0-f50.google.com ([209.85.215.50]:35055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB3pf-0006AQ-L8 for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 13:05:44 -0500 Received: by mail-lf0-f50.google.com with SMTP id b14so81250444lfg.2 for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 10:05:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=s7jpTf16P4ilzW+zHC02AvwCs0cgItP5WTbZ47yLPck=; b=YRAkgbFZQhhaUU4a2iKtvdD6aPGyAuscTdJtCwFnxHod7pwdU1utl+TrMYaOyBws/A oVixptGQKtxCLY5sFU6NXTCRcIXTUX4rzLokUzaOeqkWDzjznxJs5jJjkvuikd5TbDXs CMHEFMxt4S+XhyywTuJbjlX0muUVFHAIfYRac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=s7jpTf16P4ilzW+zHC02AvwCs0cgItP5WTbZ47yLPck=; b=mtr8aJE/prGc2KIgiQxk/Mlo4dpZC4FHz5Canp4Dk/VhKT+Nfhw5Rg/8DOtWP5CV7C IcmAP9VzyimCEnwzdUOeeyXChxb7o6xisDwR/AWzhBkEyY08NRnCjkZzGL5G4wL5/1Vu 92gt/g04U8fFxXMj3A3uXB9zsLG1N/ludbJx1qMaoZo4NEpZJ+3BKAVFkho3FWKA3HYm 5jFkab0x7SMesSqFzAvjfdoWw+54fgwYFTzYEROIiTWq6iwKnOuZOPmxPobPXLj5yimW Kvv2lYwjEKgX9MgaiXP0YEP17YLKBICrVba96mkMaQi6QeZ2SfeE4ojHM00hvFfbsXW1 sGLQ== X-Gm-Message-State: AKaTC01areShiC+Jz+h0gVo/q9Ag+NV3HkPIPTUEbrJX91yDUwDqg1oAKefleYheScWvU4rPtqR1lMP0TGG6Jew+ X-Received: by 10.25.56.65 with SMTP id d1mr6339413lfj.171.1480269937821; Sun, 27 Nov 2016 10:05:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.212.211 with HTTP; Sun, 27 Nov 2016 10:05:36 -0800 (PST) In-Reply-To: <87y4071o5k.fsf@gmail.com> References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> From: Reuben Thomas Date: Sun, 27 Nov 2016 18:05:36 +0000 Message-ID: Subject: Re: bug#19547: Patch for this bug To: Thierry Volpiatto Content-Type: multipart/alternative; boundary=f403045ea68ad0e12605424c33c4 X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 19547 Cc: Eli Zaretskii , 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --f403045ea68ad0e12605424c33c4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 25 November 2016 at 17:10, Thierry Volpiatto wrote: > > As no body is working on this, I started looking at this as I would like > to have a fix for this for helm =E2=80=8BThis was still on my to-do list, but thanks very much, Thierry, fo= r taking over.=E2=80=8B --f403045ea68ad0e12605424c33c4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 25 November 2016 at 17:10, Thierry Volpiatto <thierry.volpiatto= @gmail.com> wrote:

As no body is working on this, I started looking at this as I would like to have a fix for this for helm

=E2=80=8BThis was still on my = to-do list, but thanks very much, Thierry, for taking over.=E2=80=8B
<= /div>
--f403045ea68ad0e12605424c33c4-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 13:30:01 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 18:30:02 +0000 Received: from localhost ([127.0.0.1]:43817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4DB-0006j0-CV for submit@debbugs.gnu.org; Sun, 27 Nov 2016 13:30:01 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:36101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4D9-0006ik-Hb for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 13:29:59 -0500 Received: by mail-wm0-f54.google.com with SMTP id g23so186464166wme.1 for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 10:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=gKWOUD6XjtwqppozBTYANeWIxBL3UIBPhMoNMMdrl54=; b=CdDPuIbfa4nlVKtwyQrwcribWewyP1S5KZu5rtb1677YyO0KlFcMb6GNDTS7adHbzs C7QBZSxu9EKHe+r8lME36WFBiXwsAhWsFhyeeT0ShXy5Vdb6Fo+BhHJMYYPMNvmdJUaA 7KVuqZjrfrpkZKF/bXXOgtvwW1L5D8A9dDtvowaVHp2p3ZK5iVlRfRPRgGn1dqdpjvWK RUyn57io+aIcaYglasm7vZJUnjo+8RKp6hHJ1XSwhWl9GkxeM+uP/N5ulPmcBKOiS+Sp AEq1QWutRF8+0/BE0HK6qOdWEFiZ8GDFlWss7JLfQL7KI+9JhzRxY6Qwp2DKhPiWmusy XIBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=gKWOUD6XjtwqppozBTYANeWIxBL3UIBPhMoNMMdrl54=; b=Jl/JtygQuZ8EPgg7lw1WYwPQjo/IVpucXBa51xg68uLNZiauCnn5/iNYZiyjaYRdJn 7V0fJiLhHo6J1Pmjcj8l+mc60efu7qyc4/NoB6gpgZrhFIp8Evscb66dWgoz4Wx5aRD/ xgvTJswZqAPWNIlLvh1O/kh63qXP0y4xrxqc6zNNlmXc4S7gSdN2f+P/wYSuBPNzN2zy 1bsd76I0j51nYzFN45121+movdSuWQbIKsZfrxhYxfGYCZYZpQDxj7ZIeJQixq6ReJa8 2UnjTI/msih1lcfG9b7IbHzTpEgSf9WbvOf+677UAL6BMwxQys9xsRhbf5bEWk6gI3Oc oUaQ== X-Gm-Message-State: AKaTC02ZJAXZfp6nRXYgrOCtIwFbtpUjfSeEfDIMlJ5H+e1+9xjhl81wKJRCfswkCOP0Dw== X-Received: by 10.28.208.203 with SMTP id h194mr15526687wmg.45.1480271393714; Sun, 27 Nov 2016 10:29:53 -0800 (PST) Received: from dell-14z ([37.167.8.218]) by smtp.gmail.com with ESMTPSA id 138sm24725331wms.20.2016.11.27.10.29.52 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 27 Nov 2016 10:29:53 -0800 (PST) References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Thierry Volpiatto To: Reuben Thomas Subject: Re: bug#19547: Patch for this bug In-reply-to: Date: Sun, 27 Nov 2016 19:29:49 +0100 Message-ID: <87polgwzc2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: Eli Zaretskii , 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Reuben Thomas writes: > ​This was still on my to-do list, but thanks very much, Thierry, for taking > over.​ You are welcome ;-) Don't hesitate to correct my poor C code, thanks. So here the final patch I could push if Eli is ok after looking the comments in previous mail; I had prefered also adding the changes to simple.el in same commit when i know how to do, basically it is just how/where to add: (setq while-no-input-ignore-events '(focus-in focus-out help iconify deiconify selection-request)) Here the last patch: 1 file changed, 22 insertions(+), 5 deletions(-) src/keyboard.c | 27 ++++++++++++++++++++++----- modified src/keyboard.c @@ -3567,14 +3567,22 @@ kbd_buffer_store_buffered_event (union buffered_input_event *event, #endif /* subprocesses */ } + Lisp_Object ignore_event = Qnil; + + switch (event->kind) + { + case FOCUS_IN_EVENT: ignore_event = Qfocus_in; break; + case FOCUS_OUT_EVENT: ignore_event = Qfocus_out; break; + case HELP_EVENT: ignore_event = Qhelp; break; + case ICONIFY_EVENT: ignore_event = Qiconify; break; + case DEICONIFY_EVENT: ignore_event = Qdeiconify; break; + case SELECTION_REQUEST_EVENT: ignore_event = Qselection_request; break; + } + /* If we're inside while-no-input, and this event qualifies as input, set quit-flag to cause an interrupt. */ if (!NILP (Vthrow_on_input) - && event->kind != FOCUS_IN_EVENT - && event->kind != FOCUS_OUT_EVENT - && event->kind != HELP_EVENT - && event->kind != ICONIFY_EVENT - && event->kind != DEICONIFY_EVENT) + && !NILP (Fmemq (ignore_event, Vwhile_no_input_ignore_events))) { Vquit_flag = Vthrow_on_input; /* If we're inside a function that wants immediate quits, @@ -11164,6 +11172,10 @@ syms_of_keyboard (void) DEFSYM (Qiconify_frame, "iconify-frame"); DEFSYM (Qmake_frame_visible, "make-frame-visible"); DEFSYM (Qselect_window, "select-window"); + DEFSYM (Qhelp, "help"); + DEFSYM (Qiconify, "iconify"); + DEFSYM (Qdeiconify, "deiconify"); + DEFSYM (Qselection_request, "selection-request"); { int i; @@ -11822,6 +11834,11 @@ signals. */); /* Create the initial keyboard. Qt means 'unset'. */ initial_kboard = allocate_kboard (Qt); + + DEFVAR_LISP ("while-no-input-ignore-events", + Vwhile_no_input_ignore_events, + doc: /* Ignored events from while-no-input. */); + Vwhile_no_input_ignore_events = Qnil; } void -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 13:40:48 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 18:40:49 +0000 Received: from localhost ([127.0.0.1]:43821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4Nc-0006zD-Lo for submit@debbugs.gnu.org; Sun, 27 Nov 2016 13:40:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4Na-0006z1-Vq for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 13:40:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cB4NU-0002d8-L0 for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 13:40:41 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB4NP-0002aZ-Pz; Sun, 27 Nov 2016 13:40:35 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1806 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cB4NM-0001DY-Rl; Sun, 27 Nov 2016 13:40:35 -0500 Date: Sun, 27 Nov 2016 20:40:15 +0200 Message-Id: <83twaszrzk.fsf@gnu.org> From: Eli Zaretskii To: Thierry Volpiatto In-reply-to: <87r35wx0qe.fsf@gmail.com> (message from Thierry Volpiatto on Sun, 27 Nov 2016 18:59:37 +0100) Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> <87r35wx0qe.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 19547 Cc: rrt@sc3d.org, 19547@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Thierry Volpiatto > Cc: npostavs@users.sourceforge.net, 19547@debbugs.gnu.org, rrt@sc3d.org > Date: Sun, 27 Nov 2016 18:59:37 +0100 > > Eli Zaretskii writes: > > > In addition to using 'break', you need to initialize ignore_event with > > some value, otherwise it will hold garbage, which could accidentally > > be one of the values you want to filter. Alternatively, add a > > 'default' case to the switch. > > Is Qnil ok as default value ? Yes, it means no events are filtered out initially. > > I'd suggest to use Flist instead, it should be closer to Lisp (if you > > want to do this from C). > > Didn't succeed with Flist: > > keyboard.c:11842:5: error: too many arguments to function ‘Flist’ > = Flist (Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, Qselection_request) > ^ My advice is to look at how a function is used elsewhere in the sources, before using it in your code. In this case, you will find stuff like this: arg = Flist (nargs - i, &arg_vector[i]); IOW, the first argument to Flist is the number of arguments, and the second argument is an array of that dimension. > >> I wondered also if instead the variable could be feeded from lisp as > >> suggested by Eli, but I don't know yet where is the good place for this > >> and how. > > > > Something like simple.el should be fine. > > I would prefer setting the variable from lisp. > ok for simple.el, but what is the recommended way for setting it (I > don't think throwing a (setq while-no-input-ignore-events [...]) > anywhere in simple.el is the way to do) ? Why not? You will see quite a few examples of such stuff there. E.g.: (setq undo-outer-limit-function 'undo-outer-limit-truncate) > Also on my laptop with gcc version 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04.3) > I have no warnings, but on an other computer with gcc version 5.4.0 > 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4), I have these warnings (but it > compiled fine): > > keyboard.c: In function ‘kbd_buffer_store_buffered_event’: > keyboard.c:3572:3: warning: enumeration value ‘NO_EVENT’ not handled in switch [-Wswitch] > switch (event->kind) > ^ > keyboard.c:3572:3: warning: enumeration value ‘ASCII_KEYSTROKE_EVENT’ not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value ‘MULTIBYTE_CHAR_KEYSTROKE_EVENT’ not handled in switch [-Wswitch] That's because you don't have a "case default". You should, as I explained earlier. > keyboard.c:3585:11: warning: ‘ignore_event’ may be used uninitialized in this function [-Wmaybe-uninitialized] > && !NILP (Fmemq (ignore_event, Vwhile_no_input_ignore_events))) > ^ > > What can I do to avoid this ? Like I said: initialize ignore_event and add a "case default". > Or should I just ignore this ? Not a good idea, at least as long as you don't feel at home with C programming. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 13:41:47 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 18:41:47 +0000 Received: from localhost ([127.0.0.1]:43825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4OZ-00070u-0w for submit@debbugs.gnu.org; Sun, 27 Nov 2016 13:41:47 -0500 Received: from mail-io0-f177.google.com ([209.85.223.177]:32933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4OW-00070h-Ve for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 13:41:45 -0500 Received: by mail-io0-f177.google.com with SMTP id j65so197097690iof.0 for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 10:41:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=WW5vHTtoKw7Dpgvv999X8IFSHi1wvlY9a+GyYPoM9ig=; b=ddKXcBa8s/c0oWbhzFD8Sq7hhuJLyXYX6rEtsjvm62WG0gprWRDE6wYHi940oWtMOr UGmzbRd/GYe1s5arkmwq1M4ZQlrxTJbrczWjWgdBSi9rhaYmm16tiDl/wK980W/5BsC4 TpzVuDHRgswt1i97YbrNlTZKidabHVF1ekSLIFetcJkvvZ6MrG+l5NbP1t/KCzc+X/OB qsOASXK6oD0SdC+50api8OS+IV1pEVu/JxVWHDyh3ddmrtEiL8xpJvM2Je0AsFhEtNqs wuDeQu2wBB5MEFgVteVEYx7lMhKRk7LQE2T6QoXFH3VnUqmJuyx+7gD676P2YQFfMixP s75w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=WW5vHTtoKw7Dpgvv999X8IFSHi1wvlY9a+GyYPoM9ig=; b=hZnTJphqitDpdBbgCyEPQq+EE744+Wj8z4j9LiBlPceTTLbhgQ3nhvwruM16t2RjrK cur9pyy3K2Nm5yyjdyHN/bYeqtMOD0wDk1pAfAcHijs0KXLdoM84ne1H9AaziPWTLdbK 9gGZPGz7IjX3j8gmA1T12BeWM21VfpegSaaAJxTvQpVOBi0jnvIVfla4Bj+vj6p2vMjE TuXZ2lwb/mhF96LBFapwrR3aYvV65aJgaDoIDgcvC0kJ1UjNa9tUHStJu1PsYFcUtna4 owcXeD2+b/iahNobCibbBuZA5FvYVK4tf80KNIUq3OH86ERalQCF6MP0rDafHPQlKOHA eD3Q== X-Gm-Message-State: AKaTC00VXafIf2zO56Ix/XZQ3Woa/G1AySBqiBUFtasJlyZwtZ/cmnRxwRDkbGQWbmK18g== X-Received: by 10.36.137.194 with SMTP id s185mr14960217itd.5.1480272099261; Sun, 27 Nov 2016 10:41:39 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id n206sm7618283itg.1.2016.11.27.10.41.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 27 Nov 2016 10:41:38 -0800 (PST) From: npostavs@users.sourceforge.net To: Thierry Volpiatto Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> <87r35wx0qe.fsf@gmail.com> Date: Sun, 27 Nov 2016 13:42:34 -0500 In-Reply-To: <87r35wx0qe.fsf@gmail.com> (Thierry Volpiatto's message of "Sun, 27 Nov 2016 18:59:37 +0100") Message-ID: <87k2boix2d.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 19547 Cc: Eli Zaretskii , rrt@sc3d.org, 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Thierry Volpiatto writes: > Eli Zaretskii writes: > >> In addition to using 'break', you need to initialize ignore_event with >> some value, otherwise it will hold garbage, which could accidentally >> be one of the values you want to filter. Alternatively, add a >> 'default' case to the switch. > > Is Qnil ok as default value ? > >> I'd suggest to use Flist instead, it should be closer to Lisp (if you >> want to do this from C). > > Didn't succeed with Flist: > > keyboard.c:11842:5: error: too many arguments to function =E2=80=98Flist= =E2=80=99 > =3D Flist (Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, Qsele= ction_request) > ^ You have to use CALLN for functions taking a non-fixed amount of arguments: CALLN (Flist, Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, Qsele= ction_request); > >>> I wondered also if instead the variable could be feeded from lisp as >>> suggested by Eli, but I don't know yet where is the good place for this >>> and how. >> >> Something like simple.el should be fine. > > I would prefer setting the variable from lisp. > ok for simple.el, but what is the recommended way for setting it (I > don't think throwing a (setq while-no-input-ignore-events [...]) > anywhere in simple.el is the way to do) ? I think that should be fine. Though maybe in subr.el next to the definition of `while-no-input' would be a better place? > > Also on my laptop with gcc version 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04.3) > I have no warnings, but on an other computer with gcc version 5.4.0 > 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4), I have these warnings (but it > compiled fine): That should be fixed by adding a default case as Eli suggested, but does it make sense to handle any of those other events? > > keyboard.c: In function =E2=80=98kbd_buffer_store_buffered_event=E2=80=99: > keyboard.c:3572:3: warning: enumeration value =E2=80=98NO_EVENT=E2=80=99 = not handled in switch [-Wswitch] > switch (event->kind) > ^ > keyboard.c:3572:3: warning: enumeration value =E2=80=98ASCII_KEYSTROKE_EV= ENT=E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98MULTIBYTE_CHAR_KEY= STROKE_EVENT=E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98NON_ASCII_KEYSTROK= E_EVENT=E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98TIMER_EVENT=E2=80= =99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98MOUSE_CLICK_EVENT= =E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98WHEEL_EVENT=E2=80= =99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98HORIZ_WHEEL_EVENT= =E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98SCROLL_BAR_CLICK_E= VENT=E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98HORIZONTAL_SCROLL_= BAR_CLICK_EVENT=E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98SELECTION_CLEAR_EV= ENT=E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98BUFFER_SWITCH_EVEN= T=E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98DELETE_WINDOW_EVEN= T=E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98MENU_BAR_EVENT=E2= =80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98MENU_BAR_ACTIVATE_= EVENT=E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98DRAG_N_DROP_EVENT= =E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98USER_SIGNAL_EVENT= =E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98TOOL_BAR_EVENT=E2= =80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98SELECT_WINDOW_EVEN= T=E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98SAVE_SESSION_EVENT= =E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98GPM_CLICK_EVENT=E2= =80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98DBUS_EVENT=E2=80= =99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98CONFIG_CHANGED_EVE= NT=E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3572:3: warning: enumeration value =E2=80=98FILE_NOTIFY_EVENT= =E2=80=99 not handled in switch [-Wswitch] > keyboard.c:3585:11: warning: =E2=80=98ignore_event=E2=80=99 may be used u= ninitialized in this function [-Wmaybe-uninitialized] > && !NILP (Fmemq (ignore_event, Vwhile_no_input_ignore_events))) > ^ > > What can I do to avoid this ? Or should I just ignore this ? > > Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 14:03:22 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 19:03:22 +0000 Received: from localhost ([127.0.0.1]:43833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4jS-0007WX-6G for submit@debbugs.gnu.org; Sun, 27 Nov 2016 14:03:22 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4jQ-0007WK-FQ for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 14:03:20 -0500 Received: by mail-wm0-f43.google.com with SMTP id g23so186911311wme.1 for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 11:03:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=B7eUKuArVkQ0bQtiz/M7Qe5KqXTn4q7G6l2QvVpKw8A=; b=lAuVgns+FL0FGvdyZGfkFL1pa8JMFAcjaACJgr0VBas9s1pu1Fpf2aQMszjnVQ7Njy 2chHifSUZ092PhsJpbo5WSU5fqKSHaszJIubo1WhR7qV2K+fZBRRYAhxzRn1vNw5520V 1L/isvUUObHxu+AdQe76OoQUY+jkD5yO0QZUcS9BvGDDHGyUudX1EH6sHrXSzO2cvSgS qeAHxVWhvgJWGj8hhxmsjaoSDBaE0z7ADf2fEGNmERwSeLWT96laXPHJzuZbniJI7mBu J/2HDlprWINQ3CEm4aUHMP6udZ/HATaiU8U6lcOHvgUMTxW3+kEmR63S1XEAzeXQGZfB 7WVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=B7eUKuArVkQ0bQtiz/M7Qe5KqXTn4q7G6l2QvVpKw8A=; b=mfFiGLKiXg9cEOWuDtMQjyXbI/BNIqXhBqVS709lvyVjVrcnXn4gpte/I68VN7S3sN mz88dPqO/WT8O63t9ewF1ipUJ2QY31iM4zn/GzW2U6dHbt3+JyJaDdkEQqIT7pcV3DTN /z72frdDKzl23FEMM6pWW/phcJCbQrmeyE0CyvyfXgm4dUj7Yx50jocGhkuWD4nVGpe6 cgLo7iPgD0e+6JStxhDU3A0TbtoooT3J08hxdUuGrcYD8sIIiS/bhAtznqxlzlqww5b1 f4eX5/0CU3t3bHzgjBPblHcYhsgJFDeKw/UaDBUbk/d44uzfmlFvwngQB4Z7c4HCDKP0 GLWA== X-Gm-Message-State: AKaTC02JUzUvnlKHhqTxtaLJwY+vTtvczoGCa+dotQ9R2Fu6xv4j3w10mQkDcPWtD8PDXA== X-Received: by 10.28.73.135 with SMTP id w129mr15116483wma.42.1480273394740; Sun, 27 Nov 2016 11:03:14 -0800 (PST) Received: from dell-14z ([37.167.8.218]) by smtp.gmail.com with ESMTPSA id d8sm24847441wmi.21.2016.11.27.11.03.12 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 27 Nov 2016 11:03:13 -0800 (PST) References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> <87r35wx0qe.fsf@gmail.com> <83twaszrzk.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Thierry Volpiatto To: Eli Zaretskii Subject: Re: bug#19547: Patch for this bug In-reply-to: <83twaszrzk.fsf@gnu.org> Date: Sun, 27 Nov 2016 20:03:10 +0100 Message-ID: <87oa10wxsh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: rrt@sc3d.org, 19547@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: > My advice is to look at how a function is used elsewhere in the > sources, before using it in your code. In this case, you will find > stuff like this: > > arg = Flist (nargs - i, &arg_vector[i]); > > IOW, the first argument to Flist is the number of arguments, and the > second argument is an array of that dimension. Ok, I understand now why there is also a warning about 2 args or something like this, great, thanks for explanations. > Why not? You will see quite a few examples of such stuff there. Ok no problem, 2 last questions: - What about like suggested by Noam to put this just above the definition of while-no-input in subr.el ? - IIRC you didn't want to add by default selection-request aka SELECTION_REQUEST_EVENT, is this always true ? >> keyboard.c: In function ‘kbd_buffer_store_buffered_event’: >> keyboard.c:3572:3: warning: enumeration value ‘NO_EVENT’ not handled in switch [-Wswitch] >> switch (event->kind) >> ^ >> keyboard.c:3572:3: warning: enumeration value ‘ASCII_KEYSTROKE_EVENT’ not handled in switch [-Wswitch] >> keyboard.c:3572:3: warning: enumeration value ‘MULTIBYTE_CHAR_KEYSTROKE_EVENT’ not handled in switch [-Wswitch] > > That's because you don't have a "case default". You should, as I > explained earlier. Ok so this should be fixed now. Thanks. -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 14:08:19 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 19:08:19 +0000 Received: from localhost ([127.0.0.1]:43839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4oE-0007dM-PM for submit@debbugs.gnu.org; Sun, 27 Nov 2016 14:08:18 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:38391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4oD-0007d9-NC for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 14:08:17 -0500 Received: by mail-wm0-f48.google.com with SMTP id f82so135927432wmf.1 for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 11:08:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=KdSrVCWLKWF2Kl8FvBzfDjlQTyjDIiQFgp/JaZbZFw0=; b=lr4kd+hIYmi98rJfrBMgyLLUDg72xQCMekuVsm2T2vxuuHoMVBQc43gBcGgVG4sSiD 4H821zjGvDNaJACa0E+QV49jR/x7aNeoyQbSMv4GSN2HymfrGy9sYWkbFo5jpxxsRyyy gxy6RtSMGQHE45+4htyKR8FbujC4LAMaOxuHoIexY5PjnJjPwdau+Vj3AK2BTVk/g5sU Xhf9t+XmX5klnlG9RyfB8E02zjbhh2tiBZ0K8iFD/eG0guWm+RPQ+dMm9cGeGX1UCUWc Cx/ZgMRiMf1In0qALulggKXBgN2GZUFsMH0R/OlGGbSLZSEuZGGf+EX9fOOBwOSzTJzw QHEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=KdSrVCWLKWF2Kl8FvBzfDjlQTyjDIiQFgp/JaZbZFw0=; b=IIvM9h0g4tOQGs1NW/QYSUk7eYmlWbwbx3uhdzXW8WOLLJcMVccMFGoOSC0z02j9Y5 f9OlEQRkp/XEpXwHKPIVmig5mlItvCXsxFgiUosi3DbAp7FgHnE8GI8J3NQuusZpgg5c ptdz2t2fcyDjoX1minZ4XQxmCofyEwF42u2JLHtZfJxITRnENrFm1iP3iNqKaGxI9UyU Dt1mwU7Q8c/sAabzXgDXFb7C2P+RSnxOeIFmtOuxsLk5N8hH8Ne2LhWBL6jXxFT804f/ 9Rj3P8jMSofCbR5BWAlgMnhq/ZrCmKrlW3Squ7BQo8r9yLzifOM+7f+czY+ZSFtbakRK zmzA== X-Gm-Message-State: AKaTC01J5EF5g3XYQL/MQwC201PM0hVGh4Y7vVrS6PrJVamVFa86hogmYAqwrxKpk74u9w== X-Received: by 10.28.40.67 with SMTP id o64mr15220232wmo.40.1480273692138; Sun, 27 Nov 2016 11:08:12 -0800 (PST) Received: from dell-14z ([37.167.8.218]) by smtp.gmail.com with ESMTPSA id l187sm24928138wml.6.2016.11.27.11.08.10 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 27 Nov 2016 11:08:11 -0800 (PST) References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> <87r35wx0qe.fsf@gmail.com> <87k2boix2d.fsf@users.sourceforge.net> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Thierry Volpiatto To: npostavs@users.sourceforge.net Subject: Re: bug#19547: Patch for this bug In-reply-to: <87k2boix2d.fsf@users.sourceforge.net> Date: Sun, 27 Nov 2016 20:08:08 +0100 Message-ID: <87mvgkwxk7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 19547 Cc: Eli Zaretskii , rrt@sc3d.org, 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) npostavs@users.sourceforge.net writes: > Thierry Volpiatto writes: > You have to use CALLN for functions taking a non-fixed amount of arguments: > > CALLN (Flist, Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, Qselection_request); Great, good to know as alternative in addition of Eli's explanation. Thanks. > I think that should be fine. Though maybe in subr.el next to the > definition of `while-no-input' would be a better place? Yes, I like this. > That should be fixed by adding a default case as Eli suggested, Yes done. > but does it make sense to handle any of those other events? Don't know why debugger mentionned those events, I never add any of them. Thanks. -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 14:39:44 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 19:39:45 +0000 Received: from localhost ([127.0.0.1]:43849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB5Ie-0008Me-NV for submit@debbugs.gnu.org; Sun, 27 Nov 2016 14:39:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB5Ic-0008MR-G2 for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 14:39:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cB5IW-0004oz-GC for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 14:39:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB5IR-0004oP-P4; Sun, 27 Nov 2016 14:39:31 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1846 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cB5IP-0001UU-9M; Sun, 27 Nov 2016 14:39:31 -0500 Date: Sun, 27 Nov 2016 21:39:18 +0200 Message-Id: <83r35wzp95.fsf@gnu.org> From: Eli Zaretskii To: Thierry Volpiatto In-reply-to: <87oa10wxsh.fsf@gmail.com> (message from Thierry Volpiatto on Sun, 27 Nov 2016 20:03:10 +0100) Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> <87r35wx0qe.fsf@gmail.com> <83twaszrzk.fsf@gnu.org> <87oa10wxsh.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 19547 Cc: rrt@sc3d.org, 19547@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Thierry Volpiatto > Cc: npostavs@users.sourceforge.net, 19547@debbugs.gnu.org, rrt@sc3d.org > Date: Sun, 27 Nov 2016 20:03:10 +0100 > > > Why not? You will see quite a few examples of such stuff there. > > Ok no problem, 2 last questions: > > - What about like suggested by Noam to put this just above the > definition of while-no-input in subr.el ? No objections here. > - IIRC you didn't want to add by default selection-request aka > SELECTION_REQUEST_EVENT, is this always true ? I had no firm opinion on that. However, since it will be so easy to add and remove events to/from the list, I see no problem in having SELECTION_REQUEST_EVENT there by default: an application that doesn't want that can easily have what it wants. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 14:54:15 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 19:54:15 +0000 Received: from localhost ([127.0.0.1]:43855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB5Wh-0000FK-2a for submit@debbugs.gnu.org; Sun, 27 Nov 2016 14:54:15 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:38287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB5Wf-0000F8-Jr for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 14:54:13 -0500 Received: by mail-wm0-f50.google.com with SMTP id f82so136564695wmf.1 for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 11:54:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=cVJP1mRyVJHBG71Z6VL88cxDj8eTvBLUWR3REKotHec=; b=bglIyv2TTHNqvDjAu9t7wisXIYQ4z7RoVzqntSKTLT35QWsuO/AdlMJsOVEPhxYP9L zO+B7lS1enIkjt+P+Bv0WYGOjBYnnqhedz4VGFJ/BlSdG7zS+APNiOgAsWZg7pCgKWJy MT929cAbD5IYZ6lpeGyubSd0m+Y/JBzx43Ax3rdwHMZRLf1RtIfMW2qWXXEWEUaja2uE hpaQVXHbmz9retkmBlTsRXKy1BZf2F0GYEwo20/R0vrOpX/5/6BDFjujV07y+XJSDGRN WaQE7FPN7kdvyFFhzRVYspoc9EnXElN6Q1e0697/AXVQKGOstEDOD8rg9WESxpLdk+Cg 5W6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=cVJP1mRyVJHBG71Z6VL88cxDj8eTvBLUWR3REKotHec=; b=b3D3tM/0z/FtxeLOO89BYPqnDJ5G6BV4r0Gh6zmJHyG+UV41vIP2TxIdsHJBrp8jos 4crznGDN1VBpxZHUrqduu4rcEBHKc25DNbSyL1Qk63I47+Tuc3wloVNF840Xc3CO/Twc dV3NT+RlxG0zy/fx0sMdKBUq2Y9tdR0xeJnVv28F4McnjUXPbNuckDmB7ikevi5bBSn5 35crpYy2VIb4vg07BtQ5mlBn+fKseqTJQ6D9IBpyESwqmZzuRs0PwuTbU2EqPh3DneiO x1Cw5QMtqUJ6QPiFhEh3itocoUrXaeI3AqAtlG7ZmQSCqsxfAExrguX+N5ZF0Da80MRJ ZK4g== X-Gm-Message-State: AKaTC00tWy0jPzwwiXJeQwwR5n/8BBjd5XEevig0SHaJpS33MMQnla5FzE/oDzEBANKKbQ== X-Received: by 10.28.170.202 with SMTP id t193mr15252229wme.10.1480276447830; Sun, 27 Nov 2016 11:54:07 -0800 (PST) Received: from dell-14z ([37.167.8.218]) by smtp.gmail.com with ESMTPSA id d10sm58556797wja.20.2016.11.27.11.54.06 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 27 Nov 2016 11:54:07 -0800 (PST) References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> <87r35wx0qe.fsf@gmail.com> <83twaszrzk.fsf@gnu.org> <87oa10wxsh.fsf@gmail.com> <83r35wzp95.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Thierry Volpiatto To: Eli Zaretskii Subject: Re: bug#19547: Patch for this bug In-reply-to: <83r35wzp95.fsf@gnu.org> Date: Sun, 27 Nov 2016 20:54:00 +0100 Message-ID: <87lgw4wvfr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: rrt@sc3d.org, 19547@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: > No objections here. > >> - IIRC you didn't want to add by default selection-request aka >> SELECTION_REQUEST_EVENT, is this always true ? > > I had no firm opinion on that. However, since it will be so easy to > add and remove events to/from the list, I see no problem in having > SELECTION_REQUEST_EVENT there by default: an application that doesn't > want that can easily have what it wants. Ok, good, can I push changes on master ? -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 15:06:36 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 20:06:36 +0000 Received: from localhost ([127.0.0.1]:43863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB5ie-0000XJ-Dz for submit@debbugs.gnu.org; Sun, 27 Nov 2016 15:06:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB5ic-0000X7-O4 for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 15:06:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cB5iW-0004up-TX for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 15:06:29 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB5iT-0004uH-1o; Sun, 27 Nov 2016 15:06:25 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1877 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cB5iR-0001oD-L8; Sun, 27 Nov 2016 15:06:24 -0500 Date: Sun, 27 Nov 2016 22:06:13 +0200 Message-Id: <83polgzo0a.fsf@gnu.org> From: Eli Zaretskii To: Thierry Volpiatto In-reply-to: <87lgw4wvfr.fsf@gmail.com> (message from Thierry Volpiatto on Sun, 27 Nov 2016 20:54:00 +0100) Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> <87r35wx0qe.fsf@gmail.com> <83twaszrzk.fsf@gnu.org> <87oa10wxsh.fsf@gmail.com> <83r35wzp95.fsf@gnu.org> <87lgw4wvfr.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 19547 Cc: rrt@sc3d.org, 19547@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Thierry Volpiatto > Cc: npostavs@users.sourceforge.net, 19547@debbugs.gnu.org, rrt@sc3d.org > Date: Sun, 27 Nov 2016 20:54:00 +0100 > > Ok, good, can I push changes on master ? I think this variable should be mentioned in the ELisp manual. And in NEWS. Other than that, yes. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 15:53:40 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 20:53:40 +0000 Received: from localhost ([127.0.0.1]:43902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB6SC-0003NY-3k for submit@debbugs.gnu.org; Sun, 27 Nov 2016 15:53:40 -0500 Received: from mail-wj0-f173.google.com ([209.85.210.173]:36649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB6S9-0003NJ-Ui for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 15:53:38 -0500 Received: by mail-wj0-f173.google.com with SMTP id qp4so99755938wjc.3 for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 12:53:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=D8DAqAGkl1eEKVEPfNJ5I2dol4xcVQVHr/LPiqxTPl8=; b=NYgcKKnu5bi/xP0SgzR2qRIzzBhwh9gs8RzwdRvX2zZ0ZaOTGFWr+V4x149tNMRqPr J7lXZ/f1sEOFseSMedcU7LIvTf5iQHc5K67YhhXD3ljUlQ+Dv79d1667Lo1d4bluSc6H 7wSFwkhMszgXuA1x0w1CU6NOD71jbfw9iDSyK0OhnlObKWeyJPND1hq6fgmphEVXnBU3 vnBavmd72Niqe7t7Js3Hfam1mWuS0E1rVlfziG79IV8skBckWgaiVb7U82Y8osqHlw8i JLrXKUf5Sqcl48A6eZmQG2IlSMWkxjnAfYmeuOpQe5mD1dBp/XxU8M7ozje84n6Fgq2F NZDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=D8DAqAGkl1eEKVEPfNJ5I2dol4xcVQVHr/LPiqxTPl8=; b=jC9jX1cosow6VDB8TWl9GYzAU7YM/vy6EBoPse9wOkxbVPfSq7dOXBthLDSJ4z0Y0G kKsMgX6N4RgwtHZPwLZn/B+WtQ/li/PNXZ12mowsGq7vBl5Xi7SVGFaILal+dgVXh31y QJK6Flu/jPEvLoDtyqzQsV7ADWDWIXCiDFAgmy7AyA9jQyRX7qg/NSdV7ZrEJq5Ja+7b 0EqyutMu9mF7hMKBXquFA7c5SpJoniRXfEVlFyxNTB/DzYP7VDj+gCtju2MaljiFBiNC 0PJIsVk+7VECkuzsx4xvLdtkYYu6Y9PFjK68ZdZvKqLp9xkYNyvPh3TXBdjCI2maAUcH B0aA== X-Gm-Message-State: AKaTC00zGlbA96Rgm9BXmAdrjHeVzFiD1XSRkp3vQH5OUKxiiqrKHPMzHu9+j+Uu7xe+Vw== X-Received: by 10.194.39.7 with SMTP id l7mr15779181wjk.182.1480280012117; Sun, 27 Nov 2016 12:53:32 -0800 (PST) Received: from dell-14z ([37.167.8.218]) by smtp.gmail.com with ESMTPSA id d10sm58773278wja.20.2016.11.27.12.53.30 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 27 Nov 2016 12:53:31 -0800 (PST) References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> <87r35wx0qe.fsf@gmail.com> <83twaszrzk.fsf@gnu.org> <87oa10wxsh.fsf@gmail.com> <83r35wzp95.fsf@gnu.org> <87lgw4wvfr.fsf@gmail.com> <83polgzo0a.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Thierry Volpiatto To: Eli Zaretskii Subject: Re: bug#19547: Patch for this bug In-reply-to: <83polgzo0a.fsf@gnu.org> Date: Sun, 27 Nov 2016 21:53:28 +0100 Message-ID: <87k2bo4pbr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: rrt@sc3d.org, 19547@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: > I think this variable should be mentioned in the ELisp manual. Done. > And in NEWS. Done. > Other than that, yes. Ok I pushed changes. Many thanks to you and Noam for your help. Let me know if something wrong or missing, I will correct. -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 16:10:34 2016 Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 21:10:34 +0000 Received: from localhost ([127.0.0.1]:43912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB6iX-0003ol-Qx for submit@debbugs.gnu.org; Sun, 27 Nov 2016 16:10:33 -0500 Received: from smtprelay-b12.telenor.se ([62.127.194.21]:54383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB6iV-0003oR-Dw for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 16:10:31 -0500 Received: from ipb4.telenor.se (ipb4.telenor.se [195.54.127.167]) by smtprelay-b12.telenor.se (Postfix) with ESMTP id 462A8EB8DE for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 22:10:25 +0100 (CET) X-SMTPAUTH-B2: [bocjoh] X-SENDER-IP: [85.229.6.57] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2CVDACESjtYEDkG5VVeGgEBAQECAQEBAQgBAQEBgzgBAQEBAR+BW4J7g3mlX48JhiECgWVEEAECAQEBAQEBAQYBAQEBAQECN0WEaQEBBCcvIxALISUPAQQNCwEMChoTiFMDGwGuXD2HKQ2ECgEBAQEBBQEBAQEjixmCSIdiBZofNY0wlAiJQIg9NYEVEwyDWByBXj00iHUBAQE X-IPAS-Result: A2CVDACESjtYEDkG5VVeGgEBAQECAQEBAQgBAQEBgzgBAQEBAR+BW4J7g3mlX48JhiECgWVEEAECAQEBAQEBAQYBAQEBAQECN0WEaQEBBCcvIxALISUPAQQNCwEMChoTiFMDGwGuXD2HKQ2ECgEBAQEBBQEBAQEjixmCSIdiBZofNY0wlAiJQIg9NYEVEwyDWByBXj00iHUBAQE X-IronPort-AV: E=Sophos;i="5.31,560,1473112800"; d="scan'208";a="618783536" Received: from c-3906e555.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.229.6.57]) by ipb4.telenor.se with ESMTP; 27 Nov 2016 22:10:24 +0100 Received: by muon.localdomain (Postfix, from userid 1000) id 47975484399; Sun, 27 Nov 2016 22:10:19 +0100 (CET) From: =?utf-8?Q?Johan_Bockg=C3=A5rd?= To: Thierry Volpiatto Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <87polgwzc2.fsf@gmail.com> Date: Sun, 27 Nov 2016 22:10:18 +0100 In-Reply-To: <87polgwzc2.fsf@gmail.com> (Thierry Volpiatto's message of "Sun, 27 Nov 2016 19:29:49 +0100") Message-ID: <87polgr5mt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Thierry Volpiatto writes: > + case FOCUS_IN_EVENT: ignore_event = Qfocus_in; break; > + case FOCUS_OUT_EVENT: ignore_event = Qfocus_out; break; > + case HELP_EVENT: ignore_event = Qhelp; break; > + case ICONIFY_EVENT: ignore_event = Qiconify; break; > + case DEICONIFY_EVENT: ignore_event = Qdeiconify; break; > + case SELECTION_REQUEST_EVENT: ignore_event = Qselection_request; break; > + } > + > /* If we're inside while-no-input, and this event qualifies > as input, set quit-flag to cause an interrupt. */ > if (!NILP (Vthrow_on_input) > - && event->kind != FOCUS_IN_EVENT > - && event->kind != FOCUS_OUT_EVENT > - && event->kind != HELP_EVENT > - && event->kind != ICONIFY_EVENT > - && event->kind != DEICONIFY_EVENT) > + && !NILP (Fmemq (ignore_event, Vwhile_no_input_ignore_events))) > { > Vquit_flag = Vthrow_on_input; > /* If we're inside a function that wants immediate quits, > @@ -11164,6 +11172,10 @@ syms_of_keyboard (void) > DEFSYM (Qiconify_frame, "iconify-frame"); > DEFSYM (Qmake_frame_visible, "make-frame-visible"); > DEFSYM (Qselect_window, "select-window"); > + DEFSYM (Qhelp, "help"); > + DEFSYM (Qiconify, "iconify"); > + DEFSYM (Qdeiconify, "deiconify"); > + DEFSYM (Qselection_request, "selection-request"); HELP_EVENT, ICONIFY_EVENT and DEICONIFY_EVENT already have the Lispy names `help-echo', `iconify-frame' and `make-frame-visible', respectively, so I think we should use those instead of inventing new symbols. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 01:01:06 2016 Received: (at 19547) by debbugs.gnu.org; 28 Nov 2016 06:01:06 +0000 Received: from localhost ([127.0.0.1]:44106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBEzy-0004QD-Av for submit@debbugs.gnu.org; Mon, 28 Nov 2016 01:01:06 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:35129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBEzw-0004Pa-FX for 19547@debbugs.gnu.org; Mon, 28 Nov 2016 01:01:04 -0500 Received: by mail-wm0-f46.google.com with SMTP id a197so194551530wmd.0 for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 22:01:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=IgmCBR6ub/dQFW4y02asG50rf2UrAW+TpjBZ6MhqCe8=; b=PCxEUJE79QZqVMmC3q9uYZuk6bcwxcwuhSjQQ9aBEmBnsXkISpkJWtYX+hF+XZ426P JR0wcnaEGcnoEvqcuxPfrt/RSYwEq1G3sRJNiCKyrKkTdmp0t9SWubcgmeEXgNwF/RVg 5ZD5N0F6sxCOB0teP8iru6LoZBhBCzzNoUwmWY3pEZTA97d4wJ7b9GRfUZq9FfP+8xQN Bx8svttjJxJpqra6Ggd/nXPzjAyC3PS8m91l4WqxnO/EmZzNaafvEFMtdG0BHOZM/RmD 2BuLssDZaBgtreDczLQEC4njZN4lBlpOYrz6O570V6PGoehKDJuGSP9pBZdYxRjt1v8z T5ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=IgmCBR6ub/dQFW4y02asG50rf2UrAW+TpjBZ6MhqCe8=; b=QqOXfrT0k9yUo1ql85iU+wbh2tb623j8LoJIVYUBxkTfgat/GFY99Ok7drZy/vilVi PdrVauJfC522Czvz0RqULr96hLQGHOvMyipGxha2Iq4WVKlMpecYfx2T5dRRp9TM1w2u SjUhx0SsIDFW27v6yX/Rv3dftsQ65fTp6hCDKN7w4F51XaZ4zhhdK9Qd7JZvrOPk6x9T ROaIZvzoXWrjiP2eJvFbBUldlZrpcTl5MEtqo5n9+LbxMFdjyl1+Z5CLwWI7U0ky5Ad9 yvlC3QRy/Rb56uP72xuRerURRRGmZnGDFlj6TDhyzh6IjKE2hCklfgDK43OBtn5d038D 9uNA== X-Gm-Message-State: AKaTC021YFse9dLeFP/Fko6WnkvfFFhfVaGYO4QYxJWW9Os6FME5fraZ9HHCxILstHKr/A== X-Received: by 10.28.165.131 with SMTP id o125mr16938751wme.9.1480312858519; Sun, 27 Nov 2016 22:00:58 -0800 (PST) Received: from dell-14z ([37.162.194.66]) by smtp.gmail.com with ESMTPSA id d64sm26992864wmh.3.2016.11.27.22.00.57 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 27 Nov 2016 22:00:57 -0800 (PST) References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <87polgwzc2.fsf@gmail.com> <87polgr5mt.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 26.0.50.5 From: Thierry Volpiatto To: Johan =?utf-8?Q?Bockg=C3=A5rd?= Subject: Re: bug#19547: Patch for this bug In-reply-to: <87polgr5mt.fsf@gnu.org> Date: Mon, 28 Nov 2016 07:00:55 +0100 Message-ID: <87y404nnxk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 19547 Cc: 19547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Johan Bockgård writes: > HELP_EVENT, ICONIFY_EVENT and DEICONIFY_EVENT already have the Lispy > names `help-echo', `iconify-frame' and `make-frame-visible', > respectively, so I think we should use those instead of inventing new > symbols. Done, thanks. -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 15:27:18 2016 Received: (at 19547) by debbugs.gnu.org; 30 Nov 2016 20:27:18 +0000 Received: from localhost ([127.0.0.1]:47804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCBTJ-00087h-UY for submit@debbugs.gnu.org; Wed, 30 Nov 2016 15:27:18 -0500 Received: from mail-wj0-f173.google.com ([209.85.210.173]:32974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCBTH-00087T-U1 for 19547@debbugs.gnu.org; Wed, 30 Nov 2016 15:27:16 -0500 Received: by mail-wj0-f173.google.com with SMTP id xy5so186192904wjc.0 for <19547@debbugs.gnu.org>; Wed, 30 Nov 2016 12:27:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=IGa7icF6hUxE8me0IHEKPy0d5ZeIWT/Uutr9dC19Rvc=; b=oeOcYcuXvuZR3d4hrvjK7rf/uXkg73njBZbeFDONWg0NPmeXv04em4EDz7c6oidFnU Y4RLcL/DsI6WErhr2V7KPXiKYa4oNyvjccC6z2u3E24SgmDoI9WPQVwN/R7CQ56u3eJv SanHzoWX96N1nEuX3t1gaVu+/wWMvuxcLl/HieDx/hHKxhaFhLvOI/iFkkJf8q1l8fNG yF4RANElaO0C5LtVcGs+HEonWvr8TiprdNJHgwQMXYYqtw1mx4Xz2AeAAXfAOhjTkcBd lxZGdJVOl1KctejzPGEN8TG/3qQ01FdwuShXgLGqOgV4Azu2vKFpS8a/DqZi+1Slvyij ixew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=IGa7icF6hUxE8me0IHEKPy0d5ZeIWT/Uutr9dC19Rvc=; b=U220dQpDvA5Kpzg5zck8/X4Wri2RElRTDbz1oX3YX/L06ECRJbV6Gt0gl56iUj1maQ ERp2xXKV9msQKnXHVCd6ddzc/BztO8QaGzZ0JzzDIyBo3kkXfJvKYscmT3n1ZPhaxYcQ G7v9Z8B0T5W8VYnA+6iv2TWl+w79G+b3qrBCT2Jgwsfx9QwS4oxxT0zNRNHFcssBM9OW RojZPnNxywXYIibSOx87m1BwTQRxrOMWE6IDYTHwrJIt69bH8IlRRYdQMEthmxkbPURm O2nKaceldMnchBz5rsiszerZbe5VAjfyVyQORzXul3fvZX4dTYSmTK417hws3OdJrgpF reUA== X-Gm-Message-State: AKaTC00TcGHTcQfCpnCtITCYmGKNQgvuQPj3c5YmxDQoREjKEzqj9vXED3I1Byga+/4jJw== X-Received: by 10.194.141.141 with SMTP id ro13mr29859248wjb.76.1480537630194; Wed, 30 Nov 2016 12:27:10 -0800 (PST) Received: from dell-14z ([37.162.239.119]) by smtp.gmail.com with ESMTPSA id t82sm9621759wmd.17.2016.11.30.12.27.07 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 30 Nov 2016 12:27:08 -0800 (PST) References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> <87r35wx0qe.fsf@gmail.com> <83twaszrzk.fsf@gnu.org> <87oa10wxsh.fsf@gmail.com> <83r35wzp95.fsf@gnu.org> <87lgw4wvfr.fsf@gmail.com> <83polgzo0a.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Thierry Volpiatto To: Eli Zaretskii Subject: Re: bug#19547: Patch for this bug In-reply-to: <83polgzo0a.fsf@gnu.org> Date: Wed, 30 Nov 2016 21:27:04 +0100 Message-ID: <877f7kyaqv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: rrt@sc3d.org, 19547@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: > Other than that, yes. Eli, I did a big mistake in this patch, I used !NILP instead of NILP. !NILP (Fmemq (ignore_event, Vwhile_no_input_ignore_events))) should be instead: NILP (Fmemq (ignore_event, Vwhile_no_input_ignore_events))) No objection to push the fix ? -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 22:28:39 2016 Received: (at 19547) by debbugs.gnu.org; 1 Dec 2016 03:28:39 +0000 Received: from localhost ([127.0.0.1]:47973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCI35-0004ds-Eo for submit@debbugs.gnu.org; Wed, 30 Nov 2016 22:28:39 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCI33-0004de-6f for 19547@debbugs.gnu.org; Wed, 30 Nov 2016 22:28:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCI2x-0007Aq-71 for 19547@debbugs.gnu.org; Wed, 30 Nov 2016 22:28:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCI2s-00079i-GB; Wed, 30 Nov 2016 22:28:26 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3121 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCI2r-00050i-FR; Wed, 30 Nov 2016 22:28:25 -0500 Date: Thu, 01 Dec 2016 05:28:31 +0200 Message-Id: <83mvggpbts.fsf@gnu.org> From: Eli Zaretskii To: Thierry Volpiatto In-reply-to: <877f7kyaqv.fsf@gmail.com> (message from Thierry Volpiatto on Wed, 30 Nov 2016 21:27:04 +0100) Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> <87r35wx0qe.fsf@gmail.com> <83twaszrzk.fsf@gnu.org> <87oa10wxsh.fsf@gmail.com> <83r35wzp95.fsf@gnu.org> <87lgw4wvfr.fsf@gmail.com> <83polgzo0a.fsf@gnu.org> <877f7kyaqv.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 19547 Cc: rrt@sc3d.org, 19547@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Thierry Volpiatto > Cc: npostavs@users.sourceforge.net, 19547@debbugs.gnu.org, rrt@sc3d.org > Date: Wed, 30 Nov 2016 21:27:04 +0100 > > !NILP (Fmemq (ignore_event, Vwhile_no_input_ignore_events))) > > should be instead: > > NILP (Fmemq (ignore_event, Vwhile_no_input_ignore_events))) > > No objection to push the fix ? How can I object to fixing a mistake? Go ahead, of course. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 11 18:01:59 2017 Received: (at 19547) by debbugs.gnu.org; 11 Jun 2017 22:01:59 +0000 Received: from localhost ([127.0.0.1]:41522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKAvn-0005xA-9r for submit@debbugs.gnu.org; Sun, 11 Jun 2017 18:01:59 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:36631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKAvl-0005ws-Ov; Sun, 11 Jun 2017 18:01:58 -0400 Received: by mail-it0-f67.google.com with SMTP id 185so7426289itv.3; Sun, 11 Jun 2017 15:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=IJjtITj7PPdJOnxP20oxM6YcLiBmd/RfS33eZAaWrrI=; b=qV1wnWioII16H4CW+dRfeus59ZwDivYSeFxma6aFZjXd50KiJB6ajT4Y2eykfU3Ayi XWBS+eIy2aeOVHEc8i1VMTtfTseI+3y+BmQVPS6YiasO8TPzSSaDgeV/19WG3id2tgun j8/F857u5fwZRzt8uo6bAN9IBQ2r/3aNTIMk3OXYN7qBycNUMJy7Dpd9l7W2DkUY4TM2 VXVg2UU8Em/vV72WCk+PoZPmAvPccaKATLNFo2EOaMywxhqacnksUV1SfnNVqXV9B4vZ 2y3oGoWy5aZTIzrCbemdVuStcL+Hqp9e1/R2DaR5SwA4Mm9bNQBgTHVJWzNHCddYnayj 88Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=IJjtITj7PPdJOnxP20oxM6YcLiBmd/RfS33eZAaWrrI=; b=tGCScP9wYe3gYKeqdojRm8b81gnj+k8X/B5RZQ/b8HL4BmrTzbHBxd93XXoKzF1IpI dy5FawslGbpqNLJl1Gvw9mexL+hV9kpGdbN+JuHJG6X6wPYNXugkhrdHes0CEUqmrGCs uZAwyGJc43D3Rp5pDblxirZt8HUWhBd7LLYoUETArefM9zN1bt0QMfoPLAk3ggT4HItw HuebJSzkVPo66OxcWuiaIr3PwehdkRu1bSWVAWDqKQy35ajpi8zIid9y0zk6R1rhD2E0 bAUMjApkwMs1hChAf5i10/EUPvs8x+7RBW8ZmzD25+3cLYnPwN3yaYzW2JU65FyxOUX2 2KAQ== X-Gm-Message-State: AODbwcBJaD1P1jil9DEs/oWpOjPh45cY5ZGYUR+KXV3HXNZzeg7tAdX8 MldJUCcSkyCXSUJ7 X-Received: by 10.36.118.11 with SMTP id z11mr9543917itb.88.1497218512035; Sun, 11 Jun 2017 15:01:52 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 66sm3689708iov.21.2017.06.11.15.01.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Jun 2017 15:01:50 -0700 (PDT) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#19547: Patch for this bug References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> <87r35wx0qe.fsf@gmail.com> <83twaszrzk.fsf@gnu.org> <87oa10wxsh.fsf@gmail.com> <83r35wzp95.fsf@gnu.org> <87lgw4wvfr.fsf@gmail.com> <83polgzo0a.fsf@gnu.org> <877f7kyaqv.fsf@gmail.com> <83mvggpbts.fsf@gnu.org> Date: Sun, 11 Jun 2017 18:03:28 -0400 In-Reply-To: <83mvggpbts.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 01 Dec 2016 05:28:31 +0200") Message-ID: <87lgoyuqq7.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 19547 Cc: rrt@sc3d.org, 19547@debbugs.gnu.org, Thierry Volpiatto X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tags 19547 fixed close 19547 26.1 quit Eli Zaretskii writes: >> From: Thierry Volpiatto >> Cc: npostavs@users.sourceforge.net, 19547@debbugs.gnu.org, rrt@sc3d.org >> Date: Wed, 30 Nov 2016 21:27:04 +0100 >> >> !NILP (Fmemq (ignore_event, Vwhile_no_input_ignore_events))) >> >> should be instead: >> >> NILP (Fmemq (ignore_event, Vwhile_no_input_ignore_events))) >> >> No objection to push the fix ? > > How can I object to fixing a mistake? Go ahead, of course. Relevant commits are [319bafc9b2], [d9dd884c7c], and [43ec6efa2b]. [d9dd884c7c]: 2016-11-27 21:48:07 +0100 Allow configuring which event throw-on-input should ignore (bug#19547). http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d9dd884c7c1940cacfcc2d86d47220b40c520bb5 [43ec6efa2b]: 2016-11-28 06:59:49 +0100 Reuse already existing lisp symbols for ignore_event (bug#19547). http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=43ec6efa2b41b43a2e55be16434f64bba644271e [319bafc9b2]: 2016-11-30 21:22:04 +0100 Fix Condition in kbd_buffer_store_buffered_event (bug#19547). http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=319bafc9b28bd5bffb92a97a8ab53b9a3b97e6fd From unknown Wed Aug 20 05:43:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 10 Jul 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator