GNU bug report logs - #19509
[PATCH] diff: treat fifos as identical

Previous Next

Package: diffutils;

Reported by: Ondřej Svoboda <ondrej <at> svobodasoft.cz>

Date: Sun, 4 Jan 2015 21:24:03 UTC

Severity: normal

Tags: notabug, patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log


Message #27 received at control <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Ondřej Svoboda <ondrej <at> svobodasoft.cz>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, Eric Blake <eblake <at> redhat.com>,
 19509 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#19509: bug#19509: bug#19509: [PATCH] diff:
 treat fifos as identical
Date: Fri, 5 May 2017 09:40:12 -0700
close 19509
tags 19509 notabug
thanks

On Wed, Feb 11, 2015 at 8:22 PM, Ondřej Svoboda <ondrej <at> svobodasoft.cz> wrote:
> Thank you, Eric!
>
> I will try it out.
>
>
> On 12.2.2015 01:25, Eric Blake wrote:
>>
>> On 02/11/2015 04:37 PM, Ondřej Svoboda wrote:
>>>
>>> I also posed this question to myself -- how can we tell two fifos apart?
>>> Do they by any chance store e.g. a file descriptor when they are being
>>> used?
>>>
>>> I am not aware of any comparison done to fifos but I may as well be
>>> wrong.
>>
>> fstat() will tell you if two fds are the same fifo - their st_dev and
>> st_ino will be equal.

As far as I can see, diff already does the right thing: If the two
fifos are the same dev/ino, it doesn't even read them and exits 0.
Otherwise, it reads each and compares, just as for other types of files.

I'm marking this auto-created issue as "done", and "notabug", but feel
free to comment here.




This bug report was last modified 8 years and 14 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.