From unknown Tue Jun 17 01:50:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19509: [PATCH] diff: treat fifos as identical Resent-From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Sun, 04 Jan 2015 21:24:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19509 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: patch To: 19509@debbugs.gnu.org X-Debbugs-Original-To: bug-diffutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14204065951791 (code B ref -1); Sun, 04 Jan 2015 21:24:03 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jan 2015 21:23:15 +0000 Received: from localhost ([127.0.0.1]:36664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7sdn-0000Sk-BB for submit@debbugs.gnu.org; Sun, 04 Jan 2015 16:23:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35549) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7sMc-0008Sp-LH for submit@debbugs.gnu.org; Sun, 04 Jan 2015 16:05:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y7sMb-0003DV-PO for submit@debbugs.gnu.org; Sun, 04 Jan 2015 16:05:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7sMb-0003DN-Ah for submit@debbugs.gnu.org; Sun, 04 Jan 2015 16:05:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7sMZ-0000B9-UW for bug-diffutils@gnu.org; Sun, 04 Jan 2015 16:05:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y7sMV-0003Cn-H2 for bug-diffutils@gnu.org; Sun, 04 Jan 2015 16:05:27 -0500 Received: from kolbaba.stable.cz ([88.86.120.103]:44373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7sMV-0003Ci-BS for bug-diffutils@gnu.org; Sun, 04 Jan 2015 16:05:23 -0500 Received: from localhost (kolbaba.miton.cz [127.0.0.1]) by kolbaba.stable.cz (Postfix) with ESMTP id BB1BE22CC3 for ; Sun, 4 Jan 2015 22:05:21 +0100 (CET) X-Virus-Scanned: amavisd-new at kolbaba.stable.cz Received: from kolbaba.stable.cz ([127.0.0.1]) by localhost (kolbaba.stable.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pmqzkzO6RpWr for ; Sun, 4 Jan 2015 22:05:18 +0100 (CET) Received: from [192.168.0.15] (155.198.broadband11.iol.cz [90.178.198.155]) by kolbaba.stable.cz (Postfix) with ESMTPSA id CB3F322BE9 for ; Sun, 4 Jan 2015 22:05:18 +0100 (CET) Message-ID: <54A9AB0D.1090900@svobodasoft.cz> Date: Sun, 04 Jan 2015 22:05:17 +0100 From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Mailman-Approved-At: Sun, 04 Jan 2015 16:23:12 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) (Continuation of the previous patch; may I ask the good people of the list to review both?) This avoids unwanted "differences" like File dev1/fifo1 is a fifo while file dev2/fifo1 is a fifo --- src/diff.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/diff.c b/src/diff.c index a3e1b6f..cf2c62a 100644 --- a/src/diff.c +++ b/src/diff.c @@ -1299,6 +1299,11 @@ compare_files (struct comparison const *parent, status = EXIT_FAILURE; } } + else if (S_ISFIFO (cmp.file[0].stat.st_mode) + && S_ISFIFO (cmp.file[0].stat.st_mode)) + { + /* Both are fifos. */ + } else { /* We have two files that are not to be compared. */ -- 2.2.1 From unknown Tue Jun 17 01:50:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19509: [bug-diffutils] bug#19509: [PATCH] diff: treat fifos as identical Resent-From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Wed, 11 Feb 2015 23:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19509 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: patch To: 19509@debbugs.gnu.org Cc: eggert@cs.ucla.edu Received: via spool by 19509-submit@debbugs.gnu.org id=B19509.142369735818757 (code B ref 19509); Wed, 11 Feb 2015 23:30:03 +0000 Received: (at 19509) by debbugs.gnu.org; 11 Feb 2015 23:29:18 +0000 Received: from localhost ([127.0.0.1]:40374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YLgib-0004sT-Oo for submit@debbugs.gnu.org; Wed, 11 Feb 2015 18:29:18 -0500 Received: from kolbaba.stable.cz ([88.86.120.103]:36596) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YLgiZ-0004sF-CI for 19509@debbugs.gnu.org; Wed, 11 Feb 2015 18:29:16 -0500 Received: from localhost (kolbaba.miton.cz [127.0.0.1]) by kolbaba.stable.cz (Postfix) with ESMTP id 3861621AB0 for <19509@debbugs.gnu.org>; Thu, 12 Feb 2015 00:29:09 +0100 (CET) X-Virus-Scanned: amavisd-new at kolbaba.stable.cz Received: from kolbaba.stable.cz ([127.0.0.1]) by localhost (kolbaba.stable.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FpD-oflirO2I for <19509@debbugs.gnu.org>; Thu, 12 Feb 2015 00:29:05 +0100 (CET) Received: from [10.0.0.8] (38.211.broadband18.iol.cz [109.81.211.38]) by kolbaba.stable.cz (Postfix) with ESMTPSA id 96BB121AF0; Thu, 12 Feb 2015 00:29:04 +0100 (CET) Message-ID: <54DBE5BF.3010009@svobodasoft.cz> Date: Thu, 12 Feb 2015 00:29:03 +0100 From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 References: <54A9AB0D.1090900@svobodasoft.cz> In-Reply-To: <54A9AB0D.1090900@svobodasoft.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Hello Paul, may I ask you to review this little patch (and its successor that I will be also bumping shortly)? Thank you! :-) Regards, Ondra Svoboda On 4.1.2015 22:05, Ondřej Svoboda wrote: > (Continuation of the previous patch; may I ask the good people of the > list to review both?) > > This avoids unwanted "differences" like > > File dev1/fifo1 is a fifo while file dev2/fifo1 is a fifo > --- > src/diff.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/diff.c b/src/diff.c > index a3e1b6f..cf2c62a 100644 > --- a/src/diff.c > +++ b/src/diff.c > @@ -1299,6 +1299,11 @@ compare_files (struct comparison const *parent, > status = EXIT_FAILURE; > } > } > + else if (S_ISFIFO (cmp.file[0].stat.st_mode) > + && S_ISFIFO (cmp.file[0].stat.st_mode)) > + { > + /* Both are fifos. */ > + } > else > { > /* We have two files that are not to be compared. */ From unknown Tue Jun 17 01:50:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19509: [bug-diffutils] bug#19509: [PATCH] diff: treat fifos as identical Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Wed, 11 Feb 2015 23:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19509 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Ond=C5=99ej?= Svoboda , 19509@debbugs.gnu.org Received: via spool by 19509-submit@debbugs.gnu.org id=B19509.142369746319005 (code B ref 19509); Wed, 11 Feb 2015 23:32:02 +0000 Received: (at 19509) by debbugs.gnu.org; 11 Feb 2015 23:31:03 +0000 Received: from localhost ([127.0.0.1]:40378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YLgkJ-0004wT-8r for submit@debbugs.gnu.org; Wed, 11 Feb 2015 18:31:03 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:58104) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YLgkG-0004vy-Sq for 19509@debbugs.gnu.org; Wed, 11 Feb 2015 18:31:01 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 4D065A600E3; Wed, 11 Feb 2015 15:30:54 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oeOeK+QtWpXd; Wed, 11 Feb 2015 15:30:54 -0800 (PST) Received: from [192.168.1.9] (pool-173-55-11-52.lsanca.fios.verizon.net [173.55.11.52]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 00FE9A600DD; Wed, 11 Feb 2015 15:30:53 -0800 (PST) Message-ID: <54DBE629.1060302@cs.ucla.edu> Date: Wed, 11 Feb 2015 15:30:49 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 References: <54A9AB0D.1090900@svobodasoft.cz> <54DBE5BF.3010009@svobodasoft.cz> In-Reply-To: <54DBE5BF.3010009@svobodasoft.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Ondřej Svoboda wrote: > } > + else if (S_ISFIFO (cmp.file[0].stat.st_mode) > + && S_ISFIFO (cmp.file[0].stat.st_mode)) > + { > + /* Both are fifos. */ > + } If they're the *same* fifo, they should compare the same (and already do, if I'm not mistaken). But if they're *different* fifos? From unknown Tue Jun 17 01:50:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19509: [bug-diffutils] bug#19509: [PATCH] diff: treat fifos as identical Resent-From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Wed, 11 Feb 2015 23:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19509 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: patch To: Paul Eggert , 19509@debbugs.gnu.org Received: via spool by 19509-submit@debbugs.gnu.org id=B19509.142369785719550 (code B ref 19509); Wed, 11 Feb 2015 23:38:02 +0000 Received: (at 19509) by debbugs.gnu.org; 11 Feb 2015 23:37:37 +0000 Received: from localhost ([127.0.0.1]:40382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YLgqf-00055G-3b for submit@debbugs.gnu.org; Wed, 11 Feb 2015 18:37:37 -0500 Received: from kolbaba.stable.cz ([88.86.120.103]:42176) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YLgqc-000551-Bi for 19509@debbugs.gnu.org; Wed, 11 Feb 2015 18:37:34 -0500 Received: from localhost (kolbaba.miton.cz [127.0.0.1]) by kolbaba.stable.cz (Postfix) with ESMTP id B559A208CB for <19509@debbugs.gnu.org>; Thu, 12 Feb 2015 00:37:28 +0100 (CET) X-Virus-Scanned: amavisd-new at kolbaba.stable.cz Received: from kolbaba.stable.cz ([127.0.0.1]) by localhost (kolbaba.stable.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 762IunxSqUGa for <19509@debbugs.gnu.org>; Thu, 12 Feb 2015 00:37:25 +0100 (CET) Received: from [10.0.0.8] (38.211.broadband18.iol.cz [109.81.211.38]) by kolbaba.stable.cz (Postfix) with ESMTPSA id CC82B204A0; Thu, 12 Feb 2015 00:37:23 +0100 (CET) Message-ID: <54DBE7B2.5010201@svobodasoft.cz> Date: Thu, 12 Feb 2015 00:37:22 +0100 From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 References: <54A9AB0D.1090900@svobodasoft.cz> <54DBE5BF.3010009@svobodasoft.cz> <54DBE629.1060302@cs.ucla.edu> In-Reply-To: <54DBE629.1060302@cs.ucla.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) I also posed this question to myself -- how can we tell two fifos apart? Do they by any chance store e.g. a file descriptor when they are being used? I am not aware of any comparison done to fifos but I may as well be wrong. On 12.2.2015 00:30, Paul Eggert wrote: > Ondřej Svoboda wrote: >> } >> + else if (S_ISFIFO (cmp.file[0].stat.st_mode) >> + && S_ISFIFO (cmp.file[0].stat.st_mode)) >> + { >> + /* Both are fifos. */ >> + } > > If they're the *same* fifo, they should compare the same (and already > do, if I'm not mistaken). But if they're *different* fifos? > From unknown Tue Jun 17 01:50:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19509: [bug-diffutils] bug#19509: bug#19509: [PATCH] diff: treat fifos as identical Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Thu, 12 Feb 2015 00:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19509 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Ond=C5=99ej?= Svoboda , Paul Eggert , 19509@debbugs.gnu.org Received: via spool by 19509-submit@debbugs.gnu.org id=B19509.142370075523868 (code B ref 19509); Thu, 12 Feb 2015 00:26:01 +0000 Received: (at 19509) by debbugs.gnu.org; 12 Feb 2015 00:25:55 +0000 Received: from localhost ([127.0.0.1]:40419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YLhbP-0006Ct-8K for submit@debbugs.gnu.org; Wed, 11 Feb 2015 19:25:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44389) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YLhbL-0006Ch-RO for 19509@debbugs.gnu.org; Wed, 11 Feb 2015 19:25:53 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1C0Phr1008625 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 11 Feb 2015 19:25:43 -0500 Received: from [10.3.113.9] ([10.3.113.9]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1C0Phrq002706; Wed, 11 Feb 2015 19:25:43 -0500 Message-ID: <54DBF306.90006@redhat.com> Date: Wed, 11 Feb 2015 17:25:42 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 References: <54A9AB0D.1090900@svobodasoft.cz> <54DBE5BF.3010009@svobodasoft.cz> <54DBE629.1060302@cs.ucla.edu> <54DBE7B2.5010201@svobodasoft.cz> In-Reply-To: <54DBE7B2.5010201@svobodasoft.cz> OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kXNnGfdoDglkUFkEb0cpuhlBM7PP1jqli" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kXNnGfdoDglkUFkEb0cpuhlBM7PP1jqli Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/11/2015 04:37 PM, Ond=C5=99ej Svoboda wrote: > I also posed this question to myself -- how can we tell two fifos apart= ? > Do they by any chance store e.g. a file descriptor when they are being > used? >=20 > I am not aware of any comparison done to fifos but I may as well be wro= ng. fstat() will tell you if two fds are the same fifo - their st_dev and st_ino will be equal. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kXNnGfdoDglkUFkEb0cpuhlBM7PP1jqli Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU2/MGAAoJEKeha0olJ0NqkzcIAKjq4Er3IWiRJYUFJm7aveiF x4DU+NCwojkbdnnAfJreL35F0shfnV+dcSSZgGI+HRu7dx2dRP9829pgR89Ow5YS XcwXJCignoadS2XVdFcJUZ4rzCo9rmMsFqN+fuXEIXIK9OnkbJ/+atfmhwbhfPKE BKGn78MIqUnR/EvIiVsWGGDifvajfH0HK1qtn6eI404/2WFDrokzgXeoof9GluGX QseaShcIz4Vsu2HNypui60f+thYS5Wnl3lNC/zqnmed4aPOOOQz0Ja/G4UioXTzx V2rgCi61QCMm+/iy77ycutUHiJmuB73DNVBgBzTnbmgeXfWrFiLIzXhnmYLog1o= =OMau -----END PGP SIGNATURE----- --kXNnGfdoDglkUFkEb0cpuhlBM7PP1jqli-- From unknown Tue Jun 17 01:50:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19509: [bug-diffutils] bug#19509: bug#19509: [PATCH] diff: treat fifos as identical Resent-From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Thu, 12 Feb 2015 04:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19509 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: patch To: Eric Blake , Paul Eggert , 19509@debbugs.gnu.org Received: via spool by 19509-submit@debbugs.gnu.org id=B19509.142371494714604 (code B ref 19509); Thu, 12 Feb 2015 04:23:02 +0000 Received: (at 19509) by debbugs.gnu.org; 12 Feb 2015 04:22:27 +0000 Received: from localhost ([127.0.0.1]:40483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YLlIJ-0003nT-0D for submit@debbugs.gnu.org; Wed, 11 Feb 2015 23:22:27 -0500 Received: from kolbaba.stable.cz ([88.86.120.103]:38128) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YLlIG-0003nF-8f for 19509@debbugs.gnu.org; Wed, 11 Feb 2015 23:22:24 -0500 Received: from localhost (kolbaba.miton.cz [127.0.0.1]) by kolbaba.stable.cz (Postfix) with ESMTP id 6764A21269 for <19509@debbugs.gnu.org>; Thu, 12 Feb 2015 05:22:18 +0100 (CET) X-Virus-Scanned: amavisd-new at kolbaba.stable.cz Received: from kolbaba.stable.cz ([127.0.0.1]) by localhost (kolbaba.stable.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jRwB6U-PbC6g for <19509@debbugs.gnu.org>; Thu, 12 Feb 2015 05:22:15 +0100 (CET) Received: from [10.0.0.8] (38.211.broadband18.iol.cz [109.81.211.38]) by kolbaba.stable.cz (Postfix) with ESMTPSA id 7EDF220565; Thu, 12 Feb 2015 05:22:12 +0100 (CET) Message-ID: <54DC2A73.9020804@svobodasoft.cz> Date: Thu, 12 Feb 2015 05:22:11 +0100 From: =?UTF-8?Q?Ond=C5=99ej?= Svoboda User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 References: <54A9AB0D.1090900@svobodasoft.cz> <54DBE5BF.3010009@svobodasoft.cz> <54DBE629.1060302@cs.ucla.edu> <54DBE7B2.5010201@svobodasoft.cz> <54DBF306.90006@redhat.com> In-Reply-To: <54DBF306.90006@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Thank you, Eric! I will try it out. On 12.2.2015 01:25, Eric Blake wrote: > On 02/11/2015 04:37 PM, Ondřej Svoboda wrote: >> I also posed this question to myself -- how can we tell two fifos apart? >> Do they by any chance store e.g. a file descriptor when they are being >> used? >> >> I am not aware of any comparison done to fifos but I may as well be wrong. > fstat() will tell you if two fds are the same fifo - their st_dev and > st_ino will be equal. > From unknown Tue Jun 17 01:50:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#19509: [bug-diffutils] bug#19509: bug#19509: bug#19509: [PATCH] diff: treat fifos as identical Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Fri, 05 May 2017 16:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19509 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Ond=C5=99ej?= Svoboda Cc: Paul Eggert , Eric Blake , 19509@debbugs.gnu.org Received: via spool by 19509-submit@debbugs.gnu.org id=B19509.14940024439745 (code B ref 19509); Fri, 05 May 2017 16:41:02 +0000 Received: (at 19509) by debbugs.gnu.org; 5 May 2017 16:40:43 +0000 Received: from localhost ([127.0.0.1]:56598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6gHa-0002X2-PI for submit@debbugs.gnu.org; Fri, 05 May 2017 12:40:42 -0400 Received: from mail-ua0-f182.google.com ([209.85.217.182]:34618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6gHW-0002We-Jt for 19509@debbugs.gnu.org; Fri, 05 May 2017 12:40:39 -0400 Received: by mail-ua0-f182.google.com with SMTP id g49so7566151uaa.1 for <19509@debbugs.gnu.org>; Fri, 05 May 2017 09:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=cHm+1o8XNT94I2FDXkGxCUtG05l7uop05PZ7dgMEyKE=; b=aMw3mtt5aedf2W37rd76D21c+xF+4wodoyZfwDC5SPgd2UbT+MtANO9st0hocxAaGf K0708nPu9pGmM0yCvX8HDQRkJW8YOvdYJLiyQEfdyiJS7WuDlFn4QNBucPOyXoZxKuyQ cyGthNZQsuoevcDXjuozJ8C3W0ZKFSZQufw0/uLvF+I1NaGTny5gAPimvwjPc0rpQoYs lb5OAJf8KKSpo3vlIEm7gPn1VnS7OcgpkzyA08NvnJYdPcNoclrermlxEsmt2Z1dzzP4 JE3Yi7jpqo2n37IPI3nzYIFzFetS0C+cTNAGL/Fel2/f1gpP07d6moql6udUGT/xXefh cmdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=cHm+1o8XNT94I2FDXkGxCUtG05l7uop05PZ7dgMEyKE=; b=LuNPCDQuecE8ZSqBvk4LSNvIOYZWB05W06j29HBMpIX38xwLCUhz/of3Pu1Oi7Foqe XUXCtZie0asTMbe3/v7g+zrN2hFcQufGaC8Eo7MQBbZUdQjAMcHipwy+XWsTNxLee74q VkR5yk85hrUbFdeb/gppu4IucEOAdpBz18wmxDAoQLDWdl2/Nm/Owiy6mY8Co90zyrsU RCB0x1voEK8rYgITNv/nUHiPHr+dRZG9KD3NyQdw2hHYcFcgB5jllZjwd0hzDBMC574Y EGP85TVozVSYJ4FI2txSYJLYbAgO1TEfCU8iD/i4j1eCe2DelHU9GhWWAFrlI0yp15Y6 6r5A== X-Gm-Message-State: AN3rC/7sY7ceyQJhU1kE24WMI7vFhiWJRgEIWSHzMbJfMJMheok6Njze +vQV59EhII8bacsgKyDjVPWsH4FC8Q== X-Received: by 10.31.48.149 with SMTP id w143mr19252676vkw.122.1494002432927; Fri, 05 May 2017 09:40:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.86.86 with HTTP; Fri, 5 May 2017 09:40:12 -0700 (PDT) In-Reply-To: <54DC2A73.9020804@svobodasoft.cz> References: <54A9AB0D.1090900@svobodasoft.cz> <54DBE5BF.3010009@svobodasoft.cz> <54DBE629.1060302@cs.ucla.edu> <54DBE7B2.5010201@svobodasoft.cz> <54DBF306.90006@redhat.com> <54DC2A73.9020804@svobodasoft.cz> From: Jim Meyering Date: Fri, 5 May 2017 09:40:12 -0700 X-Google-Sender-Auth: jV_Raf22yPgiyyeUlmnv2WP7k5s Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) close 19509 tags 19509 notabug thanks On Wed, Feb 11, 2015 at 8:22 PM, Ond=C5=99ej Svoboda wrote: > Thank you, Eric! > > I will try it out. > > > On 12.2.2015 01:25, Eric Blake wrote: >> >> On 02/11/2015 04:37 PM, Ond=C5=99ej Svoboda wrote: >>> >>> I also posed this question to myself -- how can we tell two fifos apart= ? >>> Do they by any chance store e.g. a file descriptor when they are being >>> used? >>> >>> I am not aware of any comparison done to fifos but I may as well be >>> wrong. >> >> fstat() will tell you if two fds are the same fifo - their st_dev and >> st_ino will be equal. As far as I can see, diff already does the right thing: If the two fifos are the same dev/ino, it doesn't even read them and exits 0. Otherwise, it reads each and compares, just as for other types of files. I'm marking this auto-created issue as "done", and "notabug", but feel free to comment here.