Subject: bug#19506: closed (Re: bug#19506: 25.0.50; [PATCH] Use conf-mode for VC config files)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 19 Apr 2015 01:38:02 +0000

Your bug report

#19506: 25.0.50; [PATCH] Use conf-mode for VC config files

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
19506: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19506
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#19506: 25.0.50; [PATCH] Use conf-mode for VC config files
From: Glenn Morris <[email-masked]>
To: [email-masked]
Date: Sat, 18 Apr 2015 21:37:14 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 25.1

Eduard Wiebe wrote:

> --- a/lisp/files.el
> +++ b/lisp/files.el
> @@ -2522,6 +2522,9 @@ ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|7Z\\)\\'" . archive-mode)
>       ("/config\\.\\(?:bat\\|log\\)\\'" . fundamental-mode)
>       ;; Windows candidates may be opened case sensitively on Unix
>       ("\\.\\(?:[iI][nN][iI]\\|[lL][sS][tT]\\|[rR][eE][gG]\\|[sS][yY][sS]\\)\\'" . conf-mode)
> +     ("\\(?:\\.bzrignore\\|\\.bazaar/ignore\\)\\'" . conf-mode)
> +     ("\\(?:\\.hgignore\\|\\.?hgrc\\)\\'" . conf-mode)
> +     ("\\(?:\\.git\\(ignore\\|attributes\\)\\|\\.?gitconfig\\|\\.git/info/\\(?:exclude\\|attributes\\)\\)\\'" . conf-mode)
>       ("\\.\\(?:desktop\\|la\\)\\'" . conf-unix-mode)
>       ("\\.ppd\\'" . conf-ppd-mode)
>       ("java.+\\.conf\\'" . conf-javaprop-mode)

As I see it, conf-mode is useful for things that contain
"var=value" statements.

bzrignore, bazaar/ignore, .hgignore, .gitignore, .git/info/exclude
  do not

.gitconfig and .hgrc do.
.gitattributes sort of does, maybe.
.git/info/attributes seems like overkill.

So I added just .gitconfig and .hgrc.

Subject: 25.0.50; [PATCH] Use conf-mode for VC config files
From: Eduard Wiebe <[email-masked]>
To: [email-masked]
Date: Sun, 04 Jan 2015 19:22:46 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

 Hi,

any concerns to add this tiny change?

* files.el (auto-mode-alist): Use `conf-mode' for Bzr, Git, and Hg
  config files.
---
 lisp/ChangeLog |    7 +++++++
 lisp/files.el  |    3 +++
 2 files changed, 10 insertions(+)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index f62dc07..8f27b42 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,10 @@
+2015-01-04  Eduard Wiebe  <[email-masked]>
+
+	Use conf-mode for VC config files.
+
+	* files.el (auto-mode-alist): Use `conf-mode' for Bzr, Git, and Hg
+	config files.
+
 2015-01-04  Paul Eggert  <[email-masked]>
 
 	Less 'make' chatter for lisp dir
diff --git a/lisp/files.el b/lisp/files.el
index 80b538c..44ef910 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -2522,6 +2522,9 @@ ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|7Z\\)\\'" . archive-mode)
      ("/config\\.\\(?:bat\\|log\\)\\'" . fundamental-mode)
      ;; Windows candidates may be opened case sensitively on Unix
      ("\\.\\(?:[iI][nN][iI]\\|[lL][sS][tT]\\|[rR][eE][gG]\\|[sS][yY][sS]\\)\\'" . conf-mode)
+     ("\\(?:\\.bzrignore\\|\\.bazaar/ignore\\)\\'" . conf-mode)
+     ("\\(?:\\.hgignore\\|\\.?hgrc\\)\\'" . conf-mode)
+     ("\\(?:\\.git\\(ignore\\|attributes\\)\\|\\.?gitconfig\\|\\.git/info/\\(?:exclude\\|attributes\\)\\)\\'" . conf-mode)
      ("\\.\\(?:desktop\\|la\\)\\'" . conf-unix-mode)
      ("\\.ppd\\'" . conf-ppd-mode)
      ("java.+\\.conf\\'" . conf-javaprop-mode)

--
Eduard Wiebe